aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/models/uat_model.cpp
AgeCommit message (Collapse)AuthorFilesLines
2023-01-13Qt: Fix test for appending rows to UAT tablesJohn Thacker1-2/+3
We want to return with failure when the number of entries in the row we're trying to append is greater than the number of columns, not less than the number of rows in the table. The IO Graph is the only place that uses appendEntry, and this allows adding IO Graphs past the tenth graph. Fix #18762
2022-09-14Qt6: add toInt() to QVariant == Qt::CheckedChuck Craft1-2/+2
A change in Qt6 "==" comparison for QVariant for not defined types. Closes #18336
2021-09-08Qt: IOGraph - correctly add new graphsRoland Knall1-13/+87
If a graph is added it should be a single operation, not multiple setData operations leading to a myriad of dataChanged signals to be fired, which in turn can hinder redissection.
2021-03-08Remove modelines in ui/qt.Gerald Combs1-12/+0
Remove the editor modeline blocks from most of the source files in ui/qt by running perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' ) then cleaning up the remaining files by hand. This *shouldn't* affect anyone since - All of the source files in ui/qt use 4 space indentation, which matches the default in our top-level .editorconfig - The one notable editor that's likely to be used on these files and *doesn't* support EditorConfig (Qt Creator) defaults to 4 space indentation.
2020-06-01Qt: Fix some Qt 5.15 deprecation warnings.Gerald Combs1-1/+1
Use Qt::ItemFlags() instead of 0. Use QFileDialog::Options() instead of 0. Use QComboBox::textActivated instead of QComboBox::activated. Switch to just using Qt::WindowFlags() in GeometryStateDialog. This *should* work for Qt 5.5 and earlier, but if it doesn't we can switch back. Change-Id: Iaf4e7efa1a11fc7f3325b449eef1be308cd21b45 Reviewed-on: https://code.wireshark.org/review/37349 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-17Qt: Cleanup space inside parenthesesStig Bjørlykke1-2/+2
Remove randomly used space inside parentheses to make the coding style uniform. Add space after if, for and while. Change-Id: I519f5994b6f73d8a57a5004d51ca460276c618fe Reviewed-on: https://code.wireshark.org/review/35112 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-05-15Qt: do not expose a UAT record if the update callback failsPeter Wu1-4/+4
The default chk callbacks for individual fields only catches basic errors such as invalid, too large numbers. Many dissectors perform additional validation in the update_cb which is invoked for a record as a whole. If this check fails, then the UAT must not be marked as valid or else invalid records (like NULL pointers) could be exposed. Thanks to Uli Heilmeier for noticing this. Bug: 15709 Change-Id: I1cc4c6925322011a561ad6df840fbac67796e5b2 Fixes: v2.3.0rc0-1002-g1cd22559a8 ("Qt: convert UatDialog to model/view pattern, improve UX") Reviewed-on: https://code.wireshark.org/review/33157 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29Qt: move method to apply/undo UAT changes to UatModelPeter Wu1-0/+37
UatModel could be constructed with a name instead of an epan_uat type. To allow those users to save/revert the uat, make sure to expose a method that does not require access to the underlying epan_uat type. Change-Id: I1d1a5811c1025bd9c2a2ea1722f460e6ac33b9aa Reviewed-on: https://code.wireshark.org/review/31793 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-10-05Qt: Add copy from another profile in UAT dialogsStig Bjørlykke1-0/+7
Add a new button to UAT dialogs to copy entries from another profile. Change-Id: I641ba764d8738f738466529d74d4a21ff13075a0 Reviewed-on: https://code.wireshark.org/review/30028 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke1-1/+2
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-05Qt: Remove checks for version below 5.2Roland Knall1-15/+3
This stops the main source from being buildable by Qt 4.x Change-Id: I61edbae04ac2b3bf0ae8ee8e09d335083945c176 Reviewed-on: https://code.wireshark.org/review/26756 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-18Qt: I/O graph fixes.Gerald Combs1-8/+5
Use Qt::DecorationRole when setting and getting a color and Qt::CheckStateRole when setting and getting the check state of UatModel items. Add a default role for UatModel::data. Convert between value strings and their respective values where needed. Bug: 14317 Change-Id: Idd3eb773dc9944f982f6dbd7d49f73f4a60dd5a2 Reviewed-on: https://code.wireshark.org/review/25355 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com>
2017-11-16Qt: Add UAT move up and down buttonsStig Bjørlykke1-0/+16
Add two new buttons for moving entries up and down in the list. Change-Id: I90e5c5812754391651885e2a622148cecc124099 Reviewed-on: https://code.wireshark.org/review/24413 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-21Add button in Qt UAT dialog/frame to remove all UAT entries at once.Michael Mann1-0/+14
Change-Id: If5a172cd69beeb0b9a22eb7f6b9e7cb25f350b49 Reviewed-on: https://code.wireshark.org/review/23968 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07Use UAT model for I/O graphMichael Mann1-4/+22
Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI is "just handled" within the table. Required to add support for "colors" and "protocol fields" to UAT types. Also needed to add some hacks for "custom" UAT field handlers for backwards compatibility with the existing UAT structure used. Because UAT functionality was switched completely to the model, some information in the table was "lost in translation" because the UATs themselves aren't translated to other languages. TODO: 2. Better "order of operations"? A bunch of NULL/size checks needed to be added to prevent crashing. Now with model/"view" should events/functions be reordered? Bug: 13585 Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe Reviewed-on: https://code.wireshark.org/review/22766 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-26Qt: Create models directoryRoland Knall1-0/+417
Following the move for widgets and utils directory, moving models and delegates to the utils directory. Guidelines for this directory are: - Implementation of a model - Implementation of a delegate - Utility class for data storage used by a model Note: additionally all includes affected by this move have been changed to absolute path includes, instead of relative ones. Change-Id: I3bb868af7d3570437682b722a0cd46c906628570 Reviewed-on: https://code.wireshark.org/review/22790 Reviewed-by: Roland Knall <rknall@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 04:31:19 +0000