aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/io_graph_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2021-03-08Remove modelines in ui/qt.Gerald Combs1-13/+0
Remove the editor modeline blocks from most of the source files in ui/qt by running perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' ) then cleaning up the remaining files by hand. This *shouldn't* affect anyone since - All of the source files in ui/qt use 4 space indentation, which matches the default in our top-level .editorconfig - The one notable editor that's likely to be used on these files and *doesn't* support EditorConfig (Qt Creator) defaults to 4 space indentation.
2020-12-04Initial try at y_axis_factor for I/O graphThomas Stewart1-5/+15
2020-11-14Tuning of IO Graph intervalsDeveloper Alexander1-1/+8
Improves the resolution of interval steps that can be selected in IO Graph. Selectable interval steps follow a scheme of 1 -> 2 -> 5 -> 10. Having a broad choice of different intervals is important for visualizing.
2020-10-01Qt: Use … instead of UTF8_HORIZONTAL_ELLIPSIS in translated strings.Gerald Combs1-2/+2
Run $ gsed -i -e 's/\(tr *(.*".*\)" *UTF8_HORIZONTAL_ELLIPSIS/\1…"/' $( ag -l 'tr *\(.*" *UTF8_HORIZONTAL_ELLIPSIS' ) $ gsed -i -e 's/\(tr *( *\)UTF8_HORIZONTAL_ELLIPSIS *"/\1"…/' $( ag -l 'tr *\( *UTF8_HORIZONTAL_ELLIPSIS *"' ) in ui/qt. As discussed in #16812, the UTF8_ macros were required at one time because we only allowed ASCII in our source code. However, that requirement has since been relaxed and Qt's translation framework doesn't handle concatenating strings and macros very well.
2020-08-10Qt: Add a packet diagram view.Gerald Combs1-1/+1
Add a new top-level view that shows each packet as a series of diagrams similar to what you'd find in a networking textook or an RFC. Add proto_item_set_bits_offset_len so that we can display some diagram fields correctly. Bugs / to do: - Make this a separate dialog instead of a main window view? - Handle bitfields / flags Change-Id: Iba4897a5bf1dcd73929dde6210d5483cf07f54df Reviewed-on: https://code.wireshark.org/review/37497 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-30Qt: Make our exported and saved line endings consistent.Gerald Combs1-1/+1
Make sure we set QIODevice::Text on our QTextStreams when saving and exporting text so that we get native line endings on Windows. Change-Id: I4602157d2d170eb9a2c79032254ea5be236c7589 Reviewed-on: https://code.wireshark.org/review/37336 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-30Qt: Updates for 5.15.Gerald Combs1-3/+3
Fix the following deprecation issues for Qt 5.15: Use Qt::WindowFlags() instead of 0 in Qt >= 5.6. Pass Qt::SkipEmptyParts instead of QString::SkipEmptyParts to QString::split() in Qt >= 5.15. Use QMultiMap instead of QMap where we were using QMap::uniqeKeys(). Use QCP::Interactions() instead of 0. Use '\n' instead of QTextStream::endl. Use QWheelEvent::angleDelta() instead of QWheelEvent::angle(). Change-Id: Ie2d69d3a396c0821c2c34f506ddad6f8e22f7049 Reviewed-on: https://code.wireshark.org/review/37334 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-13WSUG: Update the I/O Graphs section.Gerald Combs1-1/+1
Update the I/O Graphs section of the User's Guide. Use the name "I/O Graphs" consistently. Update the image thanks to Chuck Craft. Ping-Bug: 16359 Change-Id: I6b60fd1b79a849e4467c7ca7927279e16dd6e671 Reviewed-on: https://code.wireshark.org/review/35762 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-15Qt: Access I/O Graph settings via UAT interfaceTomasz Moń1-4/+4
All I/O Graph instances share the same configuration. The code was accessing the UAT underlying number of items variable (num_io_graphs_) directly but the actual rows were accessed indirectly via UAT interface. This could lead to UAT missynchronization and in turn an out of range index access in IOGraphDialog::createIOGraph(). Fix the issue by not using the num_io_graphs_ directly. Bug: 16373 Change-Id: Ifbc0fddb619d23f31f32aa46c4ae613954a8b780 Reviewed-on: https://code.wireshark.org/review/36106 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-25IO Graph does no return to 0 if there are no fields for yAlexander Meier1-14/+49
IO Graph used to show a value of 0 if there are no relevant fields/packets when using SUM, MAX, MIN or LOAD. This is an issue because you can not distinguish if there was a value of 0 or if there was not even a relevant field/packet. With this patch IO Graph shows no point in the interval if there is no relevant field/packet when using SUM, MAX, MIN or LOAD. Change-Id: I9b17447cb38efe6dbf9299ec67aac999cfa744a3 Reviewed-on: https://code.wireshark.org/review/35859 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-13Qt: Make sure shortcuts are visible in context menus.Gerald Combs1-0/+1
As of Qt 5.10, context menu shortcuts can be hidden: https://bugreports.qt.io/browse/QTBUG-61181 Add set_action_shortcuts_visible_in_context_menu to qt_ui_utils and call it for our context menus as needed. For Qt 5.{10,11,12} it calls QAction::setShortcutVisibleInContextMenu(true). For Qt 5.13 and later, call QStyleHints::setShowShortcutsInContextMenus(true) in WiresharkApplication. Change-Id: Ie8941951c3a9801b4642f4ce15ac217e37d1300f Reviewed-on: https://code.wireshark.org/review/35761 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-13Qt: Add a splitter to the I/O Graphs dialog.Gerald Combs1-6/+9
Add a vertical splitter, with the graph and hint label in the top part and the graph list in the bottom. Change-Id: Ib297b5c9c7da121b86bf3c5c4299985882ca5b8d Reviewed-on: https://code.wireshark.org/review/35765 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07Qt: Don't plot zero values in I/O scatter plotsGerald Combs1-6/+18
We don't currently distinguish between missing and zero values in I/O graphs. This can be problematic in scatter plots since the plot points tend to show up as chartjunk which overwhelms the X axis. In plain, non-calculated plots assume that zero values mean "missing" and omit those points. Describe this in the User's Guide, but comment the text out for now pending a full update to the I/O Graph section. Switch to title case in our default graphs. Make the TCP Errors graph red by default. Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114 Reviewed-on: https://code.wireshark.org/review/35645 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-24Additional styles for IO GraphAlexander Meier1-0/+19
This patch adds the styles Cross, Plus and Circle to IO Graph. Change-Id: I72ff0134cd34a7e9b88a3e9c6a685526a0bca1db Reviewed-on: https://code.wireshark.org/review/35555 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-11-17Qt: Cleanup space inside parenthesesStig Bjørlykke1-9/+9
Remove randomly used space inside parentheses to make the coding style uniform. Add space after if, for and while. Change-Id: I519f5994b6f73d8a57a5004d51ca460276c618fe Reviewed-on: https://code.wireshark.org/review/35112 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05Qt: IOGraph display filter graph addedRoland Knall1-1/+10
Add a graph for the currently display filter if none exists, upon opening IOGraph Change-Id: Ic25b014484898dd1917b13f2616fd519e2e8183b Reviewed-on: https://code.wireshark.org/review/34984 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-17Update to qcustomplot 2.0.1Alexis La Goutte1-16/+21
Upgrade the internal version of QCustomPlot to 2.0.1 Change-Id: I1eb372d8e6a2f6c1bbdde4c74596785bf2d405c2 Reviewed-on: https://code.wireshark.org/review/17980 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Move CopyFrom from menu to buttonRoland Knall1-9/+5
Move the CopyFromProfile implementation from a menu to a button to ease integration in existing code Change-Id: I4fb4e952e89665eda99d162e891ac6d3516a6f02 Reviewed-on: https://code.wireshark.org/review/34266 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-05Qt: do not adjust the time origin for empty graphsPeter Wu1-1/+1
If a graph does not contain any visible data (for example, "TCP Errors" in a capture without TCP packets), the start offset is bogus. Ignore it to avoid Time of Day being displayed as 01.01.1970. Bug: 15247 Change-Id: I0e0a113dac6aebd42a4b48b89bbf563e96a8807a Reviewed-on: https://code.wireshark.org/review/34129 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-27HTTPS In More Places, update some URLs.Guy Harris1-2/+2
Change-Id: Ice2e1e2e4d94f6c9da7c651866cfa1a8ac4a31d8 Reviewed-on: https://code.wireshark.org/review/34096 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-21Qt: Convert the rest of the preference dialog list buttons.Gerald Combs1-0/+12
We no longer use the old icon names, so remove their aliases from stock_icons.qrc. Ping-Bug: 15511 Change-Id: If3c5e2b95825207a401e12607fcb94cdcc8a51c8 Reviewed-on: https://code.wireshark.org/review/33689 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-06-20Use I/O Graphs instead of IO graphs everywhere.Dario Lombardo1-2/+2
Change-Id: I6ce866b03632965dd1bad6eff361d91dd210c62b Reviewed-on: https://code.wireshark.org/review/33680 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-10IO stats in 5 ms task cyclesubhav81-1/+2
Change-Id: Ia2f5c44fe56ecd6c55f704c2df5e32dea947cac4 Reviewed-on: https://code.wireshark.org/review/33534 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29Qt: move method to apply/undo UAT changes to UatModelPeter Wu1-12/+7
UatModel could be constructed with a name instead of an epan_uat type. To allow those users to save/revert the uat, make sure to expose a method that does not require access to the underlying epan_uat type. Change-Id: I1d1a5811c1025bd9c2a2ea1722f460e6ac33b9aa Reviewed-on: https://code.wireshark.org/review/31793 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-09Qt: Cleanup deletion of CopyFromProfileMenuStig Bjørlykke1-6/+4
Set the push button as parent to the profile list menu so it will be deleted when that parent is destroyed. Change-Id: Ide4a234e039a3e27d9ee4732a3800906c80be173 Reviewed-on: https://code.wireshark.org/review/31446 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-5/+5
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-08Qt: Refactor copy from profile widgetStig Bjørlykke1-5/+9
Refactor CopyFromProfile class from Button to Menu to make it usable for existing buttons, both QPushButton and QToolButton. Change-Id: I7d23b4225dbe45f961fb05e73dbb4dd51e6f8ea1 Reviewed-on: https://code.wireshark.org/review/30083 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-07Qt: Add copy from another profile for IO GraphsStig Bjørlykke1-0/+50
Add a new button to the IO Graphs dialog to copy entries from another profile. Add a clear all button to easily remove all existing entries before copying. Change-Id: I66cb27163663e5f2223d0dd3f8566f0fbebb553c Reviewed-on: https://code.wireshark.org/review/30043 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-06Qt: Call createIOGraph() when duplicating an existing IO GraphStig Bjørlykke1-3/+2
Call createIOGraph() when adding a new graph by duplicating an existing to actually create the new graph. This is a regression from g5b3e3ee5. Change-Id: If1d8e4386a44dc4867d75fbad2d9ebb2e4b22307 Reviewed-on: https://code.wireshark.org/review/30034 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-05Qt: Add copy from another profile in UAT dialogsStig Bjørlykke1-1/+1
Add a new button to UAT dialogs to copy entries from another profile. Change-Id: I641ba764d8738f738466529d74d4a21ff13075a0 Reviewed-on: https://code.wireshark.org/review/30028 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-07-21Add a tap "finish" callback, called when a listener is removed.Guy Harris1-1/+2
Change-Id: Ic6c23dbd39d1adf8f730f1c866e409f731947475 Reviewed-on: https://code.wireshark.org/review/28786 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-06Use the file *base* name for statistics graphs etc..Guy Harris1-1/+1
For example, if the file is foo.pcap, make the default name for a saved PDF of some graph be foo.pdf, as it was prior to 2.6, not foo.pcap.pdf. Change-Id: Ide99c9c7fa1f3d16f829e731f968a209fbb52b8d Reviewed-on: https://code.wireshark.org/review/28624 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-04fileTitle -> fileDisplayName.Guy Harris1-1/+1
That more closely matches the name of the file.h routine that it uses. Change-Id: Ia206fb8331f4f3ad8035da9f6137ad2428d53a49 Reviewed-on: https://code.wireshark.org/review/28589 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-03CaptureFile.fileTitle() is for display, not for file name processing.Guy Harris1-1/+1
Don't use CaptureFile.fileTitle() if you're constructing a pathname; use it only if you're constructing a window title. Change-Id: I40f225ddb07be2f7dc3ae03108dae816846f20c7 Reviewed-on: https://code.wireshark.org/review/28582 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-31sharkd: add support for io graph.Jakub Zawadzki1-146/+1
Change-Id: I8d23a2b55024e2ef8c644dcef9176c7e3050a703 Reviewed-on: https://code.wireshark.org/review/27376 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16Windows: Make sure more native dialogs handle HiDPI.Gerald Combs1-2/+2
Add a WiresharkFileDialog class, which is a thin wrapper around a few QFileDialog functions that sets per-monitor v2 DPI awareness before showing native dialogs and resets the awareness context afterward. Use it where we call QFileDialog::getXXX. Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673 Reviewed-on: https://code.wireshark.org/review/27568 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke1-1/+2
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17Qt: fix remaining CaptureEvent signal connectionsPeter Wu1-2/+2
Converted all remaining "CaptureEvent *" to "CaptureEvent" using: sed -e 's/CaptureEvent *\*/CaptureEvent/g' $(git grep -le 'CaptureEvent *\*') -i Change-Id: I328d2890ec3b5e6672fa3fab22e85063e8309574 Fixes: v2.9.0rc0-186-g57bf7e4347 ("Qt: Fix memory leak for CaptureEvent") Reviewed-on: https://code.wireshark.org/review/26985 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-04-17Qt: Fix memory leak for CaptureEventRoland Knall1-3/+3
Make the argument to the events a non-memory object Change-Id: I46d8c24415aa2bc48b2a2d3b1fccffa6956d08b5 Reviewed-on: https://code.wireshark.org/review/26671 Reviewed-by: Roland Knall <rknall@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-31IO Graph: Add some vector checks.Gerald Combs1-3/+3
Use Qvector::value in a few places instead of an array index. Change-Id: I821ef4b16df919977739c12ccaa3b9c3d53f049c Ping-bug: 14357 Reviewed-on: https://code.wireshark.org/review/25511 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-18Qt: Fixup a cast.Gerald Combs1-1/+1
Change-Id: I25dbf6c91bd3ca1f16a01c937a3830010adcd197 Reviewed-on: https://code.wireshark.org/review/25373 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-18Qt: I/O graph fixes.Gerald Combs1-31/+38
Use Qt::DecorationRole when setting and getting a color and Qt::CheckStateRole when setting and getting the check state of UatModel items. Add a default role for UatModel::data. Convert between value strings and their respective values where needed. Bug: 14317 Change-Id: Idd3eb773dc9944f982f6dbd7d49f73f4a60dd5a2 Reviewed-on: https://code.wireshark.org/review/25355 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com>
2017-12-27Apply new CaptureEvents to statistics dialogs.Michael Mann1-3/+8
Refactoring from If366d42b07dc822636404ac44ba2306ec4418b4e ignored dialogs outside of the main window. Searched for removed signals from CaptureFile class and applied new CaptureEvent handling. Change-Id: I9e0aaa0dc1c702ce04810d27c8f9273997f7ca30 Reviewed-on: https://code.wireshark.org/review/25007 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-04Put the structure of a capture_file back in cfile.h.Guy Harris1-1/+0
The split isn't necessary now that epan no longer uses the capture_file structure. Change-Id: Ia232712a2fb5db511865805518e8d03509b2167f Reviewed-on: https://code.wireshark.org/review/24693 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-12-03Use cfile.h to define the capture_file type.Guy Harris1-0/+1
Have cfile-int.h declare the structure, and use it in files that directly access the structure. Have cfile.h just incompletely declare the structure and include it rather than explicitly declaring it in source files or other header files. Never directly refer to struct _capture_file except when typedeffing capture_file. Add #includes as necessary, now that cfile.h doesn't drag in a ton of Change-Id: I7931c8039d75ff7c980b0f2a6e221f20e602a556 Reviewed-on: https://code.wireshark.org/review/24686 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-08iograph: Use default graph values if io_graphs UAT file doesn't pass validationPeter Wu1-1/+2
Change-Id: I70c8ca7b5b31d284a12220fc6ce2a764ea9fbe6b Fixes: v2.5.0rc0-631-g5b3e3ee587 ("Use UAT model for I/O graph") Reviewed-on: https://code.wireshark.org/review/23366 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-08io_graph_dialog.cpp: Remove graph_enabled_vs.Michael Mann1-7/+0
No longer necessary with model Change-Id: If1516f264013fabe1211aa04fe054b15e235b36a Reviewed-on: https://code.wireshark.org/review/23007 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07Use UAT model for I/O graphMichael Mann1-647/+396
Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI is "just handled" within the table. Required to add support for "colors" and "protocol fields" to UAT types. Also needed to add some hacks for "custom" UAT field handlers for backwards compatibility with the existing UAT structure used. Because UAT functionality was switched completely to the model, some information in the table was "lost in translation" because the UATs themselves aren't translated to other languages. TODO: 2. Better "order of operations"? A bunch of NULL/size checks needed to be added to prevent crashing. Now with model/"view" should events/functions be reordered? Bug: 13585 Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe Reviewed-on: https://code.wireshark.org/review/22766 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 13:32:11 +0000