aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/column_editor_frame.h
AgeCommit message (Collapse)AuthorFilesLines
2024-06-10Qt: Adjust stretching for Edit ColumnJohn Thacker1-0/+1
We want to use stretch factors, beccause the column definition line edit for custom columns has larger needs than the column title. However, if those two elements have stretch factors but others do not, then they will be allowed to shrink to their minimum before the other widgets that don't have the stretch factor. We don't, however, want the other widgets to stretch beyond their hinted size, which in this case is a maximum. So make the occurrenceLineEdit also have a stretch factor, but set its maximum to its size hint. Do something similar with the type combobox, except put a minimum size on it that is large enough to view most types (with the date and time formats being an exception.) For Windows (and possibly other platforms), force the pop-up view to have the full width instead of eliding the text as it does by default. (On many Linux desktops the pop-up always has the full necessary width.) The fieldsNameLineEdit is only relevant if the typeComboBox is COL_CUSTOM. The text for "Custom" is small. So when COL_CUSTOM is selected, shrink the size of the typeComboBox to what is necessary for "Custom" and give extra space to the fieldsNameLineEdit. For any other column type, do the reverse. Fix #19458
2023-11-11Qt: Update styleSheet in AccordionFrameStig Bjørlykke1-1/+0
Update all widget styleSheet in AccordionFrame instead of in each frame implementation.
2023-11-10Qt: Update styleSheet on ApplicationPaletteChange eventStig Bjørlykke1-0/+1
Update styleSheet used in AccordionFrame on ApplicationPaletteChange event received in WiresharkMainWindow to support switch between Light mode and Dark mode.
2022-06-30Qt: Add resolved button to Edit ColumnsJohn Thacker1-1/+2
Add the ability to set custom columns as resolved/unresolved via the Edit Column frame, if the column fields support it. Related to #15394.
2021-11-30Add UI header files to DoxygenMoshe Kaplan1-1/+1
Add @file markers for UI header files so that Doxygen will generate documentation for them.
2021-03-08Remove modelines in ui/qt.Gerald Combs1-13/+0
Remove the editor modeline blocks from most of the source files in ui/qt by running perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -g '\.(cpp|h)' ) then cleaning up the remaining files by hand. This *shouldn't* affect anyone since - All of the source files in ui/qt use 4 space indentation, which matches the default in our top-level .editorconfig - The one notable editor that's likely to be used on these files and *doesn't* support EditorConfig (Qt Creator) defaults to 4 space indentation.
2019-11-12Qt: Cleanup push/pop InfosRoland Knall1-1/+0
Currently push pop is propagated by a massive load of signals which partly are also propagated through parent objects. This moves the status handling to WiresharkApplication, also pathlining future moves to move status to different classes or use additional methods of status information Change-Id: Ibcb2c98688f1adf40dce1483f336596ef992bb06 Reviewed-on: https://code.wireshark.org/review/35071 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke1-1/+2
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-25Qt: AccordionFrame users keyPressEvent() fixesStig Bjørlykke1-1/+1
- Declare keyPressEvent() virtual. - Give keyPressEvent() to parent when done. Change-Id: If1c05e86a5ab71dd239c025cdb2bcfb1ef484811 Reviewed-on: https://code.wireshark.org/review/24573 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-09Qt: Give focus to Title in ColumnEditorFrameStig Bjørlykke1-0/+1
Select the title text and give focus to the title when Edit Column. Bug: 14191 Change-Id: I04fc5f6bcc830a15ef43fa2d06a1a729df52e370 Reviewed-on: https://code.wireshark.org/review/24305 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-19Qt: Add key events to accept and reject changes in ColumnEditorFrameStig Bjørlykke1-0/+4
Change-Id: I5f9ee01ee3aca5b2d75136fff3d8dc3e90ca1a4e Reviewed-on: https://code.wireshark.org/review/23585 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-18Qt: Improved ColumnEditorFrame validation checksStig Bjørlykke1-0/+1
Use common validation checks for fieldsNameLineEdit and occurrenceLineEdit. No need to check for COL_CUSTOM and empty occurrence because this will give a valid value anyway. Change-Id: I8981a15954e9a55a9a43e4a5760b34d83aa2e1ca Reviewed-on: https://code.wireshark.org/review/23584 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-20Qt: Add missing multi-field column validationMichal Labedzki1-2/+2
GTK already has it, but Qt forgot about it, so multi-field custom column works ok if previously saved in GTK-shark. Invalid validation prevent from modifying and saving multi-field custom column in Qt version. While at it, rename "custom field" to "custom fields" to ensure we think about multi-field custom column. Change-Id: I99588150ccb38be11b75f5dd5b0f6443e7055ebb Reviewed-on: https://code.wireshark.org/review/12685 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01Qt Frames: Use ButtonBox instead of buttonsRoland Knall1-2/+2
In these frames the Ok and Close buttons are implemented as standalone buttons. This leads to the scenario, that they break plattform-ui preferences on the one hand, as well as not being the same order throughout. This patch replaces all Ok/Close buttons with the Qt button box, which handles the plattform-ui internally, and additionally allways enforces the same order. Change-Id: If62b90016b222322f60c0962da04c8277589a57f Reviewed-on: https://code.wireshark.org/review/12335 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-11Qt: fixes to 'Edit Column' dialogPascal Quantin1-1/+1
- set field name and occurrence when editing a custom column - convert occurrence number to a QString - disable OK button when syntax is incorrect or empty for a custom column - update syntax state when opening the edit dialog or when switching between custom and normal column Bug: 11433 Change-Id: Ia8424474dd250c78a0b503e0e9d89c322f4f86a9 Reviewed-on: https://code.wireshark.org/review/11705 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-06Qt: Add a context menu to the packet list header.Gerald Combs1-0/+71
Don't carry over the sort items from the GTK+ UI (for now, at least). Update some names. Add a column editor frame similar to the "Go to Packet" and "Search" frames. Change-Id: I1bd3834a26994de96894d2b7512bce2c19915c77 Reviewed-on: https://code.wireshark.org/review/6277 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>