aboutsummaryrefslogtreecommitdiffstats
path: root/ui/profile.c
AgeCommit message (Collapse)AuthorFilesLines
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke1-1/+2
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0Anders1-1/+0
Change-Id: Ie95cf37f9cd283545693e290340a7489cc989c95 Reviewed-on: https://code.wireshark.org/review/26970 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02ui: use SPDX identifiers.Dario Lombardo1-14/+1
Change-Id: I6b05399395bcc35e59b73b4030ba4a05711a7b1a Reviewed-on: https://code.wireshark.org/review/25565 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-31UI: Rename profiles without deleteStig Bjørlykke1-3/+3
Do not try to delete the old profile name after renaming. In most cases it will not exist, but when using a case-insensitive file system this will delete the renamed profile if only changing capitalizations (first it's renamed and then it's deleted). Change-Id: I27d2d22d2353b09f2041d82ea1cf1bae37a1ce3d Reviewed-on: https://code.wireshark.org/review/25515 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-18Make apply_profile_changes() return a non-const pointer.Guy Harris1-3/+3
It returns a pointer to a g_mallocated string, which the caller has to free, so its return value shouldn't be a const pointer. Change-Id: I76f288379a5c1eff580c391bdc9019ab7fe8f336 Reviewed-on: https://code.wireshark.org/review/25364 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-12-05[profile.c] glist_fre_full() is 2.28, include glib-compat.hAndersBroman1-0/+1
Change-Id: I4b4e39de55a30352aa965653bcdf2429efb9e146 Reviewed-on: https://code.wireshark.org/review/24709 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-28ui: Sort profile namesStig Bjørlykke1-3/+19
Not all file systems returns a sorted list of filenames, so we need to sort the entries before using the list in the Profile popup and the Manage Profiles dialog. Change-Id: Ic1f2bfa77fb47fb8c406d891aee49b484876b4f7 Reviewed-on: https://code.wireshark.org/review/24615 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-19Clean up some memory leaks in wsutil/filesystem.cMichael Mann1-2/+4
The fixes involve functions always returning a string that needs to be freed by the caller. That way the static string pointers within the functions don't end up leaking at program end. Change-Id: I35a8dc37536c2927d88f33217887f62efafcc8ca Reviewed-on: https://code.wireshark.org/review/20175 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-08Qt: Add check for valid profile nameStig Bjørlykke1-2/+4
Add check for a valid profile name in the Profile dialog and disable the Ok button and mark the invalid profile if error. The GTK dialog does not close on errors but the Qt dialog does, so ensure the user is informed beforehand. Change-Id: If31ffe75183066cf49e2b5a082112bfe62d6c06e Reviewed-on: https://code.wireshark.org/review/19995 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-07ui: Write recent file when applying profile changesStig Bjørlykke1-1/+6
Write the recent file for the current profile before copying or renaming the profile to ensure the latest changes are not lost. Change-Id: Ib07881925b398314da0a9b2ec875da7650b84712 Reviewed-on: https://code.wireshark.org/review/19984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-21profile_name_is_valid() returns a malloced string [-Wcast-qual]João Valverde1-1/+1
Change-Id: I584cdbf6a09e818e0d14c951defdde2fc96787f3 Reviewed-on: https://code.wireshark.org/review/13440 Reviewed-by: João Valverde <j@v6e.pt>
2015-01-18Remove some apparently-unnecessary includes of emem.h.Guy Harris1-1/+1
Also update a comment to no longer speak of ep_ allocation, and add an include of <glib.h> to ui/profile.c, which was formerly relying on the include of emem.h to drag it in. Change-Id: I08926699ee96cf66672836b6ee3bbb405b507ce8 Reviewed-on: https://code.wireshark.org/review/6633 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-10Finish off emem_strbuf_t usage.Michael Mann1-8/+6
Change-Id: Ib0b911c86a7f8a7cca022e9e324c910664ce397e Reviewed-on: https://code.wireshark.org/review/6461 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-3/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
2013-09-13Include emem.hJörg Mayer1-0/+1
svn path=/trunk/; revision=51999
2013-03-20 From beroset:Bill Meier1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2012-12-30Move profile deletion code from profile_dlg.c to profile.c. Add leftGerald Combs1-0/+18
mouse and context (right mouse) signals to label stacks and use them to pop up profile menus in the status bar. Add profile actions (manage, new, edit, delete) to the profile dialog. svn path=/trunk/; revision=46863
2012-12-29Remove some duplicate code from ui/profile.c and move in more code fromGerald Combs1-18/+136
ui/gtk/profile_dialog.c. Use the correct profile list in profile_dialog.c so that deletion works. Add a profile dialog to the Qt port. For some reason it crashes when changing configuration profiles, which might be related to bug 7722. Move the Qt configuration profile initialization from main.cpp to wireshark_application.cpp. Make sure QMenuBar doesn't grab the configuration profiles action on OS X. Add more role color names to tango_colors.h. svn path=/trunk/; revision=46834
2012-12-28Fix [ 76%] Building C object ui/CMakeFiles/ui.dir/profile.c.o ui/profile.c: ↵Alexis La Goutte1-4/+4
In function ‘init_profile_list’: ui/profile.c:194:20: error: variable ‘fl_entry’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors svn path=/trunk/; revision=46824
2012-12-28Fix [76%] Building C object ui/CMakeFiles/ui.dir/profile.c.o ui/profile.c: ↵Alexis La Goutte1-2/+2
In function ‘init_profile_list’: ui/profile.c:195:20: error: variable ‘profile’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors svn path=/trunk/; revision=46823
2012-12-27Move common profile code to ui/profile.[ch].Gerald Combs1-0/+291
svn path=/trunk/; revision=46808