aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk
AgeCommit message (Collapse)AuthorFilesLines
2015-03-29Extcap: fix USBPcap capture broken by g8204578Pascal Quantin1-2/+7
g8204578 was not the right way to do things: if_type is used to identify an extcap interface Change-Id: Iead6c5e63f6874012c27ed7c1bf7152a5891ad65 Reviewed-on: https://code.wireshark.org/review/7849 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-25Generate the filter using _ws.expert.message instead of expert.messageMichael Mann1-10/+10
Bug: 11073 Change-Id: Ie98d52561b7aebe6875392cf3efeb22adb2ac499 Reviewed-on: https://code.wireshark.org/review/7813 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-25Have a #define for whether the capture buffer size can be set.Guy Harris3-57/+49
It can be set if either 1) this is Windows (where we're assumed to be using WinPcap, which includes calls to set the buffer size) or 2) we have pcap_create() (in which case we also have pcap_set_buffer_size(), at least in a normal libpcap release). Use that rather than testing "defined(_WIN32) || defined(HAVE_PCAP_CREATE)"; that makes it a bit more obvious what's being tested. Change-Id: Id9f8455019d19206b04dd6820a748cb97ae5ad12 Reviewed-on: https://code.wireshark.org/review/7816 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-25OK, this appears to be what's intended.Guy Harris1-4/+29
Include a column to describe what's intended. If that's *not* what's intended, fix the comment and the twisty little maze of #defines. Change-Id: Ic5d120c401d8aba23a19e9d042b1460621b80e0b Reviewed-on: https://code.wireshark.org/review/7815 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-25Clean up handling of buffer size.Guy Harris1-40/+40
Instead of a twisty little maze of #if, #ifdefs, and #elifs, all different, define HAVE_BUFFER_SIZE upfront iff we can set the buffer size - i.e., if this is Win32, and thus we're using WinPcap, or if we have pcap_create() and thus pcap_set_buffer_size() - and use that to govern whether to have a buffer size setting or not. Always put the buffer size setting in the right vertical box. If that doesn't work well for some configurations of available interface knobs, feel free to change the checks, but please make it less opaque what's going on (include a comment if necessary). Change-Id: I384c601982b470ae08de271431eac06d6c925332 Reviewed-on: https://code.wireshark.org/review/7814 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-24Win32: Compilation error if winpcap remote capturing disabledRoland Knall1-1/+3
If HAVE_PCAP_REMOTE is not set, this code is not defined and therefore will not be compiled correctly. Change-Id: Ie08a6f99598d46cfa38e2448ea979a8a9aa7c7fc Reviewed-on: https://code.wireshark.org/review/7803 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-23Centralize the code to set the active_dlt value for a device.Guy Harris1-3/+1
We were doing it similarly, but not the same, in several places; make a common routine for it. Have that code check to make sure the DLT_ value in question is actually supported by the device; if not, pick the first supported DLT_ value, if any; this keeps it from, for example, picking a bad DLT_ value if your defaults were set based on monitor mode being on but monitor mode actually being off, or vice versa. Change-Id: I1722bfeaf60429bc5c6f665fdea3d466052b13bd Reviewed-on: https://code.wireshark.org/review/7795 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-21Rename update_interface_list() and remove local interface code from it.Guy Harris1-25/+15
It's only used to update the remote interface list, and never updates anything else (it sets iftype_id to CAPTURE_IFREMOTE and never changes it, so all tests for whether iftype_id is == or >= CAPTURE_IFREMOTE succeed); remove the code that would be executed if, somehow, iftype_id got stomped on, and rename it to update_remote_interface_list(). Change-Id: I3bd80fb19bb14ef5bdf2c1a77a10f1f32bb62aba Reviewed-on: https://code.wireshark.org/review/7773 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Make the snapshot-length member of interface_t an int.Guy Harris1-2/+0
That matches what it is in other structures, and eliminates a compiler warning. While we're at it, remove an empty if statement revealed by that change. Change-Id: I5e8c8f92fdb3567e75800c729443737032a1bcc7 Reviewed-on: https://code.wireshark.org/review/7752 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-18Fix parsing of interface properties strings.Guy Harris2-8/+5
The first entry in the list does not have a leading comma, so a strstr() for ",{ifname}(" will not work. Instead, use g_strsplit() with a comma for all of the preferences. Have common code for all the "uncomplicated" preferences. Have a specialized handler for the one "complicated" preference. Change-Id: I2144a98ab0cb70db56eaaba88175d6e03885de2a Reviewed-on: https://code.wireshark.org/review/7741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-12Assert that the row number passed to packet_list_get_row_data() is valid.Jeff Morriss1-0/+1
Unfortunately that row number may come from a dissector/tap but allowing us to continue just causes us to die horribly later (and we can't except out of processing a tap). Change-Id: I37f03385db55dbe55f91e2ec6a03add5664857ba Ping-Bug: 10885 Reviewed-on: https://code.wireshark.org/review/7652 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-10Change a lot of http:// URLs to https://.Gerald Combs2-24/+8
Most of our sites are now HTTPS-only. Update URLs accordingly. Update other URLs while we're at it. Remove or comment out dead links. Change-Id: I7c4f323e6585d22760bb90bf28fc0faa6b893a33 Reviewed-on: https://code.wireshark.org/review/7621 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-03-07Get rid of an unused structure member.Guy Harris15-24/+0
Change-Id: I2941bb7e6dc0fce3e1256af6e5e19d2997de5801 Reviewed-on: https://code.wireshark.org/review/7573 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-03Eliminate e_uuid_t in favor of e_guid_t.Guy Harris1-33/+33
That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-02RTP player: don't crash when drawing channel graphs for very long calls.Jeff Morriss1-2/+26
X11 can't handle pixmaps more than 32k pixels wide so don't try to feed it one. This avoids crashes with the complaint "BadAlloc (insufficient resources for operation)". Instead we simply truncate the graph (and tell the user). Do this in a way that shows the user the empty portion of the graph. Hopefully the Qt port can fix this properly. Note: the bug report says that MacOS is not affected but it should be. So apply this fix for all on-Windows systems. Bug: 2630 Change-Id: I71e1bd2f9a62792db06ce887e2bbe7a96d110e0a Reviewed-on: https://code.wireshark.org/review/7464 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-23ui/gtk: use GTK+ 2 name for control keysPeter Wu1-2/+2
The GDK_KEY_* names are part of GTK+ 3, GTK+ 2 does not have the _KEY_ infix. See https://developer.gnome.org/gtk3/stable/gtk-migrating-2-to-3.html#id-1.6.3.3.6 Fixes regression from "ui/gtk: fix control combos such as ctrl-a, ctrl-c". Change-Id: I4d470212d172f978c171e54ff7377ddc211817ac Reviewed-on: https://code.wireshark.org/review/7325 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-02-20Clear the filter expression list in prefs.c.Gerald Combs2-13/+2
Move filter_expression_nuke from ui/gtk to epan and rename it to filter_expression_free. Call it in prefs_reset along with the other preference reset routines. This keeps the Qt filter toolbar from filling up with duplicate expressions when the profile changes. Change-Id: I9fae9a7b48944079ea342a126979d9e79af0d22b Reviewed-on: https://code.wireshark.org/review/7281 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-20ui/gtk: fix control combos such as ctrl-a, ctrl-cPeter Wu1-2/+10
Ignore any Ctrl combinations to allow pasting to work. Regression introduced in "gtk: fix crash on Broadway GDK backend". Change-Id: I3d53db2d224cb604b52081002ff923c8684a8d0a Reviewed-on: https://code.wireshark.org/review/7276 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2015-02-20Suppress a bunch of cast-qual warnings.Gerald Combs1-1/+4
Squelch warning: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Wcast-qual] similar to g630f54f. Change strtod to g_ascii_strtod to squelch a checkAPIs error. Change-Id: Ib2d26ef89f08827a5adc07e35eaf876cd7b8d14e Reviewed-on: https://code.wireshark.org/review/7269 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-20Just have init_progfile_dir() take a void pointer.Guy Harris1-1/+1
dladdr() takes a void * as a code pointer; have init_progfile_dir() do so, and do the casting in the calls. We don't care about the signature of the function whose address we're passing, we just want to pass a pointer to *something* in the main program. Change-Id: I9372620a97b0eb53c2bb3c0c41a238b4408f3709 Reviewed-on: https://code.wireshark.org/review/7270 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-18Eliminate some DIRTY_ file lists.Guy Harris1-4/+0
We don't want to encourage people to add to those lists, we want to encourage people to subtract *from* those lists (either by fixing warnings or, if an infelicitous API, or an infelicitous declaration of an API on some platforms, or a program generator that doesn't take sufficient care to avoid warnings - I'm looking at *you*, Flex - makes it impossible to fix without introducing other problems, using the DIAG_OFF()/DIAG_ON() macros if possible). Eliminate the empty lists, to make it harder to fill them up again. Change-Id: I298d07952c0cb1842a4ea71ba7e07c68e94a04e9 Reviewed-on: https://code.wireshark.org/review/7229 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-18Make UAT record update callbacks return a success/failure indication.Guy Harris1-3/+1
Have them return TRUE on success and FALSE on failure. Check the return value rather than whether the error string pointer is null or not. Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c Reviewed-on: https://code.wireshark.org/review/7222 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-16Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to worry about the wmem_allocator. Change-Id: If976fe7b0c3f9cd053225096c2ac05418f061af6 Reviewed-on: https://code.wireshark.org/review/7081 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-15Fix handling of invalid UAT itemsPeter Wu1-0/+2
If the UAT file failed a field check, then the user_data pointer may be empty. As a result uat_save() triggers an invalid write. (Discovered while working with a dfilter_macros file having duplicate names for bug 10957, caught by ASAN.) The second issue fixed in this patch is that the validity of an item is only calculated when a new record is added. So even if the user edits the UAT and makes the entry valid, it would not be saved. This is solved by adding a new uat_update_record() function which got wires up into GTK and Qt. Some open-coded g_array_index and UAT[_USER]_INDEX_PTR are also converted. Even after this patch, Qt has some issues with UAT handling. In particular, it saves new, but empty/invalid, items. It also it does not check individual fields when saving all fields (unlike Gtk). This patch focused on getting Gtk fixed first so ignores those existing issues. Change-Id: Ia35cfe9d2b793c65144ae7e29a1ed706b6668d99 Reviewed-on: https://code.wireshark.org/review/7120 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier99-1443/+2723
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-14Fix diagnostics macros and squelch a gcc warning.Gerald Combs3-8/+7
Both clang and gcc define __GNUC__. Make sure we account for that when defining diagnostic macros. Use DIAG_OFF + DIAG_ON to suppress gcc -pedantic warnings about frame_data. Get rid of packet_char_enc casts. Change-Id: Idbcc61bcdb35c1d20f185461c69451dcdf73bae9 Reviewed-on: https://code.wireshark.org/review/7106 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-14"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: Ic7dee275ba0a2bd4e19c06702a867417c5624c27 Reviewed-on: https://code.wireshark.org/review/7080 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-13Replace tabs by spaces when editor modelines has "expandtab"Bill Meier1-1/+1
Change-Id: If7a6f2697be732ae4f94ed8b845fd293c32510f7 Also: tabs-stops should be 8 Reviewed-on: https://code.wireshark.org/review/7100 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-12Revert ""Hide" hashether_t structure."Anders Broman1-3/+3
This reverts commit 297ef07b9b2f5b681234d0c31269996413262cbc. Change-Id: Id47f5fd221b631c95ca71e3f9315f5263bab22de Reviewed-on: https://code.wireshark.org/review/7077 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Revert "Make get_manuf_name return a const string."Anders Broman1-2/+2
This reverts commit 797ea88aefc2f45dba7e77d2dcaebe68ac1a4fac. Change-Id: I9bc2cef0051d88c6374c6f1868b0250cba3edbd4 Reviewed-on: https://code.wireshark.org/review/7076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to work about the wmem_allocator. Change-Id: I80f465ae0845290255a659ab63310ac3cc35506e Reviewed-on: https://code.wireshark.org/review/7075 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: I6d70b9bacbc0fa1898150f59c0c69779a6cd5d51 Reviewed-on: https://code.wireshark.org/review/7074 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-11capture_dlg.c: Fix (possibly valid) "Using uninitialized memory" MSVC2013 ↵Bill Meier1-4/+4
Code Analysis warning Change-Id: I849b731420d779b68ab4335eb8d06482ecd649e7 Reviewed-on: https://code.wireshark.org/review/7068 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-10Add a "Sum" column to the Service Response Time (SRT) window.Kevin Grigorenko14-14/+27
The Service Response Time (SRT) window currently provides the columns: Index, Procedure, Calls, Min SRT, Max SRT, and Avg SRT. A Sum column has been found useful in some customer situations to understand the total time spent doing a set of procedures. For example, in one case we were trying to isolate whether most time was being spent on a client thread or in the act of making outbound calls. We knew the start and end time of the client call, so with the "Sum" of time spent in that period, we could isolate a particular set of procedures driving the slow down. Additional changes made in this patch: * Add " (s)" to Min, Max, Avg, and Sum columns to make it clear that times are in seconds. * Refactor out width and height constants used in calls to gtk_window_set_default_size in most of the SRT users into #define SRT_PREFERRED_WIDTH and SRT_PREFERRED_HEIGHT. Also increase the common width of 550 to 650 to account for the additional column. Change-Id: I20f152eecbcd0bbf69f71c6c6b9f9463e8867e23 Reviewed-on: https://code.wireshark.org/review/7047 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-09(Trivial) Fix printf-related 'Mismatch on sign' warningsBill Meier2-2/+2
Found by MSVC2013 Code Analysis Change-Id: I58063946dd558e98308c87b36eeac0ddbe1a6e79 Reviewed-on: https://code.wireshark.org/review/7045 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-09Fix use-after free in RTP playerPeter Wu1-0/+1
Clicking "Decode" in the RTP player triggered an ASAN heap-use-after-free in update_progress_bar(). Explicitly set progress_bar to NULL to prevent this. Change-Id: Ice3105a11642a1cc5a54b8fbdf7dbf0ed430d965 Ping-Bug: 10714 Reviewed-on: https://code.wireshark.org/review/6999 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-08Menubar (GTK): fix warning: no previous prototype for ↵Alexis La Goutte1-0/+1
‘set_menus_capture_start_sensitivity’ [-Wmissing-prototypes] Change-Id: I11c805b285d277ecb963622385154c310f6d1c67 Reviewed-on: https://code.wireshark.org/review/7032 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-08Multicast Stream: Move mcast_stream.[ch] to uiAlexis La Goutte6-640/+48
Preparation to add Multicast Stream Dialog on Qt (Add extern C...) Change-Id: Ic8bc39a18dba607d6da116df799de7847ce8e4c8 Reviewed-on: https://code.wireshark.org/review/6984 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-07Fix RTP crash on RTP analysis attemptPeter Wu1-12/+12
The tap listener was handling rtpstream_tapinfo_t* types while other users was expecting a GList* instead. Fix this and avoid future confusion by replacing void* pointers. Ping-Bug: 10714 Change-Id: I66f62eaaed4a529714264bbf4e7ad1e72b46ce5a Reviewed-on: https://code.wireshark.org/review/6997 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-06Multicast Stream (GTK): fix crash when try to select a streamAlexis La Goutte1-1/+1
Change-Id: Iaaa9445ae99b37cfb1865251d50f38375f3eb272 Reviewed-on: https://code.wireshark.org/review/6985 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-04HTTP2: Add tap for HTTP2 dissectorAlexis La Goutte1-0/+2
Change-Id: Ib13d9391b64dad19321a4399c95b95d7fb791284 Reviewed-on: https://code.wireshark.org/review/6421 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-04Convert val_to_str -> val_to_str_wmem.Michael Mann10-67/+129
This is mostly for GUI usage, but a few dissectors needed some "non-packet scope" conversions. val_to_str officially now uses wmem_packet_scope() Change-Id: Ic9413eeb3406d7a7683222b86709f3675d628d81 Reviewed-on: https://code.wireshark.org/review/6933 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-04Qt: Add the Protocol Hierarchy statistics dialog.Gerald Combs1-1/+2
Change-Id: I6872e323daca4798c638d764873f54c4c0dc0006 Reviewed-on: https://code.wireshark.org/review/6934 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-03Convert val_to_str_ext -> val_to_str_ext_wmem for calls that don't have ↵Michael Mann5-22/+30
valid packet scope (GUI). val_to_str_ext now officially uses wmem_packet_scope(). Removed const from val_to_str[_ext]_wmem return value since it's not really constant. Created utility functions in qt_ui_utils.h to help with the new memory management for its GUI. Change-Id: Idf2ce4a4ce78d628b2269ad23a3a48fbfc9c077c Reviewed-on: https://code.wireshark.org/review/6926 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-02Fix some indent typo (after g2bf7878e)Alexis La Goutte1-1/+1
Change-Id: I44769f127f32ffd8a97b1579f371501f4aa9832a Reviewed-on: https://code.wireshark.org/review/6913 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-01Fix a typo.Guy Harris1-1/+1
Change-Id: I2724340e41572fdaa56ebf75478297090563c522 Reviewed-on: https://code.wireshark.org/review/6895 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-31No main window *to* update in the early argument list parsing.Guy Harris1-1/+1
We haven't yet popped the main window up, so, when we call capture_interface_list(), we shouldn't pass a pointer to the "update the main window" routine. Change-Id: Id3e02199479e66bb9e9aff99b435bd03af45a1af Reviewed-on: https://code.wireshark.org/review/6868 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-30Qt: Add the RTP Streams dialog.Gerald Combs7-250/+58
Add keyboard shortcuts. Note that not all of the buttons made it from GTK+. Add a "Go to setup frame" option. Move rtp_streams.c from ui/gtk to ui. Add a help URL for RTP analysis (which needs to be split into streams + analysis). Fix RTP stream packet marking. Change-Id: Ifb8192ff701a933422509233d76461a46e459f4f Reviewed-on: https://code.wireshark.org/review/6852 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-28Proto dialog (GTK) : fix indent (use 2 spaces) and add modelinesAlexis La Goutte2-55/+76
Change-Id: I36945843b8d544188a3ffe89f397e669f3944593 Reviewed-on: https://code.wireshark.org/review/6831 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27Added HPFEEDS stats_tree.Dario Lombardo1-0/+2
Change-Id: I256fd5395b062fa954ebd60598721323ea1d7ff1 Bug: 10875 Reviewed-on: https://code.wireshark.org/review/6713 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 03:38:42 +0000