aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk
AgeCommit message (Collapse)AuthorFilesLines
2014-06-21Move get_copyright_info() to wsutil.Guy Harris2-0/+2
Change-Id: I75c1c747cd2b4a9845c659636582d54b2caecf1a Reviewed-on: https://code.wireshark.org/review/2510 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20Fix build without pcap.Guy Harris1-4/+0
The files that use LONGOPT_CAPTURE_COMMON and OPTSTRING_CAPTURE_COMMON include capture_opts.h unconditionally, so there's no need to define them if we don't have pcap. In addition, we want the capture options "available" even if we don't have pcap, so we can tell the user "you're using a version of *shark without pcap, but you gave a capture option". Change-Id: I0bd3893b73d3d903610d0bc6cacb60bfb37096f4 Reviewed-on: https://code.wireshark.org/review/2503 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20Use OPTSTRING_CAPTURE_COMMON here as well.Guy Harris1-19/+3
Change-Id: If0078797a2e7b14edbd1b64863c4961c9b198168 Reviewed-on: https://code.wireshark.org/review/2494 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Changed a cast (from guint to guint64) in a call to gtk_tree_store_set(). ↵dameiss1-1/+1
The data is actually 64-bit, and was being fetched that way - but not stored that way - leading to some very strange (and large) values. Change-Id: I2235ae7f1bab7f48f99afac70109a7d8f9b38e2b Reviewed-on: https://code.wireshark.org/review/2468 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Save the size and position of the expert info dialogChris Maynard10-13/+77
Set initialize position to center on parent bug: 3817 Change-Id: Iad48aa762d892908d50f742606160c8305084f48 Reviewed-on: https://code.wireshark.org/review/2459 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-06-19Cleaned up some CLang dead assignment warnings.dameiss1-3/+2
Change-Id: Ibd2fa6c791253e4dbac9a21532e894db3327ce57 Reviewed-on: https://code.wireshark.org/review/2465 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Don't crash when closing the Summary window if the file has been closed.Jeff Morriss1-1/+1
Yes, this is a Gtk-UI fix but it's a one-liner and easy enough. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8715 Bug: 8715 Change-Id: I554b6c953e83ff3d8cb57029e844f2f481b751dd Reviewed-on: https://code.wireshark.org/review/2460 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-06-19gtk_table_new is deprecated in GTK3. Change to use grid instead, and usedameiss1-7/+9
ws_gtk_grid_attach_extended() to do the heavy lifting. Change-Id: I1c9d12556857196f53fadbce70f206a3cc41f7a5 Reviewed-on: https://code.wireshark.org/review/2433 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-19Add GTK modules for existing LBM dissectors.dameiss7-0/+1372
bug: 10204 Change-Id: Ie21cc07b0ac9a56648ec72062ce58a1ac800318e Reviewed-on: https://code.wireshark.org/review/2420 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Add the ability to dynamically add a new protocol to export PDU dialog boxPascal Quantin1-4/+4
Change-Id: I83012cc963d514982e40010e837e11a6fcf1bc3e Reviewed-on: https://code.wireshark.org/review/2423 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16More Python-bindings removal.Jeff Morriss1-9/+0
Change-Id: I4d82175781e65c73179f4c8e737a7900cb050bce Reviewed-on: https://code.wireshark.org/review/2283 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-06-16Fix indent (Use 4spaces like end of the file and modelines infoAlexis La Goutte1-92/+92
Change-Id: I80e0193240032e62c685c5b976df921ea1e6a581 Reviewed-on: https://code.wireshark.org/review/2251 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Graham Bloice <graham.bloice@trihedral.com>
2014-06-16Remove last remaining call to se_strdupEvan Huus1-5/+10
get_filter_from_packet_list_row_and_column now returns glib memory Change-Id: I24361670322ff4a936c157a842b07f32c474089e Reviewed-on: https://code.wireshark.org/review/2240 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Remove last caller of se_strdup_printfEvan Huus2-2/+4
Also remove that function as it is now unused. Fix what appeared to be a memory leak in the manual address resolution dialog while in the neighbourhood. Change-Id: I75128ab0f95e5a7673f92bfeea45191f00581c25 Reviewed-on: https://code.wireshark.org/review/2244 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-10rlc lte graph: Assigned value is garbage or undefined (clang analyzer)Alexis La Goutte1-0/+6
Change-Id: Ia371c26299aa62566a63bc1a4d4f6df827fdf5b9 Reviewed-on: https://code.wireshark.org/review/2085 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-09Add Modelines infoAlexis La Goutte1-0/+13
Change-Id: I2364104145518d484c2e5fb0ae5d5d80cce0982d Reviewed-on: https://code.wireshark.org/review/2064 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-05Add Object (file) export for files transferred over TFTP.Martin Mathieson3-1/+10
Updated following review comments. Change-Id: I56e70d8f8e332d2aea604ceec16c980ad890fa58 Reviewed-on: https://code.wireshark.org/review/1885 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-05-25Add support for dissecting non-packet records.Guy Harris7-13/+15
Add a dissector table indexed by the file type, and, for the file-type-specific records, have the frame dissector skip the usual pseudo-header processing, as the pseudo-header has a file-type-specific record subtype in it, and call the dissector for that file type's records. Change-Id: Ibe97cf6340ffb0dabc08f355891bc346391b91f9 Reviewed-on: https://code.wireshark.org/review/1782 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-24Allow wtap_read() and wtap_seek_read() to return records other than packets.Guy Harris8-37/+31
Add a "record type" field to "struct wtap_pkthdr"; currently, it can be REC_TYPE_PACKET, for a record containing a packet, or REC_TYPE_FILE_TYPE_SPECIFIC, for records containing file-type-specific data. Modify code that reads packets to be able to handle non-packet records, even if that just means ignoring them. Rename some routines to indicate that they handle more than just packets. We don't yet have any libwiretap code that supplies records other than REC_TYPE_PACKET or that supporting writing records other than REC_TYPE_PACKET, or any code to support plugins for handling REC_TYPE_FILE_TYPE_SPECIFIC records; this is just the first step for bug 8590. Change-Id: Idb40b78f17c2c3aea72031bcd252abf9bc11c813 Reviewed-on: https://code.wireshark.org/review/1773 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-23Revert "Allow wtap_read() and wtap_seek_read() to return non-packet records."Guy Harris8-28/+23
This reverts commit c0c480d08c175eed4524ea9e73ec86298f468cf4. A better way to do this is to have the record type be part of struct wtap_pkthdr; that keeps the metadata for the record together and requires fewer API changes. That is in-progress. Change-Id: Ic558f163a48e2c6d0df7f55e81a35a5e24b53bc6 Reviewed-on: https://code.wireshark.org/review/1741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-23Allow wtap_read() and wtap_seek_read() to return non-packet records.Guy Harris8-23/+28
This is the first step towards implementing the mechanisms requestd in bug 8590; currently, we don't return any records other than packet records from libwiretap, and just ignore non-packet records in the rest of Wireshark, but this at least gets the ball rolling. Change-Id: I34a45b54dd361f69fdad1a758d8ca4f42d67d574 Reviewed-on: https://code.wireshark.org/review/1736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-19Use g_ alloced memory (instead of emem) when printing fields. emem ↵Michael Mann1-2/+3
shouldn't be used for GUI functions anyway. emem was exposed because of its memory limits trying to output PDML for a very large byte field in a capture file. When converting from proto_construct_match_selected_string to fvalue_to_string_repr remember proto_construct_match_selected_string includes fieldname + value, not just value bug:10081 Change-Id: I4fc6ea7fd1f63cff410207c8b30562771af40ada Reviewed-on: https://code.wireshark.org/review/1578 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-17wiretap: remove unused code, drop number_of_interfacesPeter Wu1-1/+0
While investigating an ASAN issue (fixed in commit dcdd076ab0965c346efe90051678ba790eaf7a02), I got greatly confused by three different types having the same "interface_data" field name: * pcapng_t *pn stores an array of interface_data_t objects. * wtap *wth stores an array of wtapng_if_descr_t objects. * pcapng_dump_t should store an array of interface_data_t objects. pcapng_dump_t and friends are unused since commit c7f1a431d23e17a15777652b1252e139f182b0e6, so drop it. To fix the confusion, rename the interface_data_t type to interface_info_t type and use the local variable "iface_info" everywhere. Rename interface_data of pcapng_t to "interfaces" and add a comment what this exactly means (interfaces listed in the capture file). Drop the number_of_interfaces field for interfaces as the array length is already available from GArray. Now interface_data is always initialized for wth (which also gets copied to idb). s/int/guint/g and replace cast at some places. There are no regressions for the in-tree test suite. Change-Id: I2d5985c9f1e43f8230dbb4a73bd1e243c4858170 Reviewed-on: https://code.wireshark.org/review/1656 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-05-11Identify client/server by their IP address and port number in follow streams ↵Pascal Quantin3-6/+14
dialog box This allows to properly identify hosts that use the same port number Change-Id: I93bf5b53e4df1d339fb06b372b90f88fce6785a0 Reviewed-on: https://code.wireshark.org/review/1588 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-05-11Fix display of unidirectional follow TCP/UDP streamsPascal Quantin2-7/+7
It was broken since 48285bb16b0a5655a47a8a59c34bc98e6bf4cb75 While we are at it, display the streams in the same order as Qt version Change-Id: I12df1c033dd51b7a162adca3fd36b31af5c074a1 Reviewed-on: https://code.wireshark.org/review/1587 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-11Small fixes to Follow Streams dialog box:Pascal Quantin2-2/+2
- get the right IPv6 client address - display the right client to server string for UDP/SSL in Qt port Change-Id: I399cc38b8a32321198deccdd8e2ecd05b54e14db Reviewed-on: https://code.wireshark.org/review/1586 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-09Revert "Use g_ alloced memory (instead of emem) when printing fields. emem ↵Evan Huus1-3/+2
shouldn't be used for GUI functions." It's causing a few different test failures - I've tracked down at least one of them, but the others are weirder and will require more digging. This reverts commit 9edba650d11776fa1d5aefe4820890898380c1c2. Change-Id: I897f8cf1cfbb2a189b2054e5002f59757befa47f Reviewed-on: https://code.wireshark.org/review/1575 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-09Revert "Refactor Wiretap"Guy Harris8-14/+14
This reverts commit 1abeb277f5e6bd27fbaebfecc8184e37ba9d008a. This isn't building, and looks as if it requires significant work to fix. Change-Id: I622b1bb243e353e874883a302ab419532b7601f2 Reviewed-on: https://code.wireshark.org/review/1568 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-09Use g_ alloced memory (instead of emem) when printing fields. emem ↵Michael Mann1-2/+3
shouldn't be used for GUI functions. emem was exposed because of its memory limits trying to output PDML for a very large byte field in a capture file. bug:10081 Change-Id: I6346dfdfb5f6381e16761a99291c4be7851185d9 Reviewed-on: https://code.wireshark.org/review/1566 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-09Refactor WiretapMichael Mann8-14/+14
Start of refactoring Wiretap and breaking structures down into "generally useful fields for dissection" and "capture specific". Since this in intended as a "base" for Wiretap and Filetap, the "wft" prefix is used for "common" functionality. The "architectural" changes can be found in cfile.h, wtap.h, wtap-int.h and (new file) wftap-int.h. Most of the other (painstaking) changes were really just the result of compiling those new architecture changes. bug:9607 Change-Id: Ife858a61760d7a8a03be073546c0e7e582cab2ae Reviewed-on: https://code.wireshark.org/review/1485 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-05-01Fix -Wunreachable-code found by ClangAlexis La Goutte1-23/+0
Change-Id: I895194655ff674fff5e84fa93b3f9a00a0f70e27 Reviewed-on: https://code.wireshark.org/review/1457 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-01Unreachable code in ui/gtk/main.cAlexis La Goutte1-4/+4
Unreachable code due to conflicting defines: checking for GTKOSXAPPLICATION inside _WIN32 Found by Edwin Closed-bug: 10065 Change-Id: I074fa14069e859b3fc4b7f50c443a67e7f0e954b Reviewed-on: https://code.wireshark.org/review/1456 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-29prefs: spelling fix, simplify codePeter Wu1-19/+10
Found spelling error "a another". All those dynamic allocations and magic numbers are horrible and unnecessary. Simplify the gtk code rewording the message and merging strings. Simplify the version code by using fscanf to take care of matching the first line of a preference file. Change-Id: I1e75803aacaa494ba5005791bcbd023e0807aaaa Reviewed-on: https://code.wireshark.org/review/1424 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-29gtk: fix glib assert for dialogs without cancelPeter Wu1-1/+1
Dialogs with only "Save" and "Don't save" buttons do not have a default cancel action. Check for the existence of an OK button before registering one. This fixes three warnings when trying to trying to overwrite preferences with unknown keys. Change-Id: Ie583c40d3db8405d94b8d77710a7fb6556eac89d Reviewed-on: https://code.wireshark.org/review/1423 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-25Move the XXX-to-UTF-8 loops to routines in epan/charsets.c.Guy Harris1-0/+1
This moves a bunch of character set knowledge into epan/charsets.c. Change-Id: Ieb79dcaac9753c77703af756b666ad2ca9385d9e Reviewed-on: https://code.wireshark.org/review/1339 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-25Support out-of-source checkapiStig Bjørlykke1-2/+4
Always call $(top_srcdir)/tools/checkAPIs.pl with -sourcedir=$(srcdir) from Makefile.am to allow out-of-source 'make checkapi'. Change-Id: I60d7e0079984a8ededdacf4517a0738486fa7973 Reviewed-on: https://code.wireshark.org/review/1294 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-23Fix typo in comment (parameterts => parameter)Alexis La Goutte1-1/+1
Change-Id: Ie1fefc27d249929f0f5108b0757768e7e23a9dbe Reviewed-on: https://code.wireshark.org/review/1310 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-23CaptureDialog: Fix IF type for user created pipeRoland Knall1-0/+1
- If a user adds a pipe via "Capture Options"->"Manage Interfaces" ->"Pipes" the device.if_type.type is either not filled out (in the case if no other interfaces exist), or will be set to the last set if_type of the device queried by the iteration in line 3537. - One could argue, that this is just a fixup, as still the issue remains, that the device structure will not be resetted, after the search for an already existing pipe element. Maybe a separate variable should be used for searching as it is used for adding the pipe Change-Id: Ia727bf3ce270a62d065e8c524a13768af389c346 Reviewed-on: https://code.wireshark.org/review/1296 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-04-21Fix gcc "warning: no previous prototype ... [-Wmissing-prototypes]"; Do some ↵Bill Meier2-0/+4
whitespace changes Change-Id: I8c2e8694223270f1810aa6b13d955f0d08001d30 Reviewed-on: https://code.wireshark.org/review/1239 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-04-21Replace linked list of proto fields with arrayEvan Huus3-9/+10
This is substantially more memory-efficient, shaving another ~1.5MB off our base usage. It also lets us remove the annoying extra "last_field" pointer and simplify proto_register_field_common(). It also accidentally fixed what may have been a memory leak in proto_unregister_field(). It unfortunately complicates proto_get_next_protocol_field() to require refetching the protocol each time, but that is itself just an array-lookup under the covers (and isn't much used), so I don't expect the performance hit to be noticable. Change-Id: I8e1006b2326d6563fc3b710b827cc99b54440df1 Reviewed-on: https://code.wireshark.org/review/1225 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-19More name changes.Guy Harris5-15/+15
Add ep_ to routines that may return ephemeral strings. Change "get_XXX" to "XXX_to_display" if the routine returns a formatted string if it can't get a name. Change-Id: Ia0e82784349752cf4285bf82788316c9588fdd88 Reviewed-on: https://code.wireshark.org/review/1217 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-19Some routine name changes.Guy Harris11-52/+52
"get_addr_name()" -> "ep_address_to_display()", to 1) indicate that it returns a string with ephemeral scope and 2) indicate that it maps an address to a "displayable" form - a name if possible, an address string if not. "se_get_addr_name()" -> "get_addr_name()", to indicate that its strings have the same scope as "get_ether_name()", "get_hostname()", and "get_hostname6()". Change-Id: If2ab776395c7a4a163fef031d92b7757b5d23838 Reviewed-on: https://code.wireshark.org/review/1216 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-15ui/gtk/voip_calls: Fix minor memleakPeter Wu1-6/+2
Return values from g_strsplit must be always be freed. Also remove a useless return statement and set a saner maximum split. Change-Id: I680e20d40fe86103b0dcba210ef41aa5769f4f86 Reviewed-on: https://code.wireshark.org/review/1155 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-14Fix Argument with 'nonnull' attribute passed null found by ClangAlexis La Goutte1-4/+6
Change-Id: I9b8a6c37e4ed589ac3066ec9cbb1b63a9f30a12b Reviewed-on: https://code.wireshark.org/review/1097 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-14Fix warning when generate documentation (doxygen)Alexis La Goutte1-2/+12
ui/gtk/gui_stat_menu.h:42: Warning: The following parameters of register_menu_bar_menu_items(const char *gui_path, const char *name, const gchar *stock_id, const char *label, const char *accelerator, const gchar *tooltip, gpointer callback, gpointer callback_data, gboolean enabled, gboolean(*selected_packet_enabled)(frame_data *, struct epan_dissect *, gpointer callback_data), gboolean(*selected_tree_row_enabled)(field_info *, gpointer callback_data)) are not documented: parameter 'gui_path' parameter 'label' parameter 'accelerator' parameter 'tooltip' parameter 'enabled' Change-Id: I422d767741b29b8722c85a4ef97186d599d802c3 Reviewed-on: https://code.wireshark.org/review/1137 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-14Fix warning when generate documentation (doxygen)Alexis La Goutte1-1/+3
ui/gtk/gui_utils.h:277: Warning: argument 'parent' of command @param is not found in the argument list of pixbuf_to_widget(const guint8 *pb_data) ui/gtk/gui_utils.h:277: Warning: argument 'xpm' of command @param is not found in the argument list of pixbuf_to_widget(const guint8 *pb_data) Change-Id: I9182a6f8c85b69bd8b0bab7e03af441dee31fc1d Reviewed-on: https://code.wireshark.org/review/1136 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-12Get rid of more tvb_get_nstringz* calls.Guy Harris4-2/+8
Add an FT_STRINGZPAD type, for null-padded strings (typically fixed-length fields, where the string can be up to the length of the field, and is null-padded if it's shorter than that), and use it. Use IS_FT_STRING() in more cases, so that less code needs to know what types are string types. Add a tvb_get_stringzpad() routine, which gets null-padded strings. Currently, it does the same thing that tvb_get_string_enc() does, but that might change if we don't store string values as null-terminated strings. Change-Id: I46f56e130de8f419a19b56ded914e24cc7518a66 Reviewed-on: https://code.wireshark.org/review/1082 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-07Add a Qt I/O Graph dialog.Gerald Combs1-324/+39
For each graph you can set: - Its visibility - A name - A display filter - Color, from a fixed list - Plot style: Line, Impulse, Bar, Stacked Bar, Dot, Square, Diamond - Basic Y Axes (packets/s, bytes/s, bits/s) - Computed Y Axes (SUM, MIN, AVG, MAX) - Smoothing You can pan and zoom using the mouse and keyboard. Clicking on a graph selects the last packet for that interval. If all graphs have the same Y axis a single label is shown, otherwise a legend is shown. The time scale (X axis) can be toggled between relative seconds and the time of day. Graphs can be saved as PDF, PNG, BMP, and JPEG. Settings are "sticky" via the io_graphs UAT. To do: - Minimize graph drawing delays. - Figure out why smoothing differs from GTK+ - Everything else at the top of io_graph_dialog.cpp - Fix empty resets. A fair amount of code was copied from TCPStreamDialog. We might want to subclass QCustomPlot and place the shared code there. Move common syntax checking to SyntaxLineEdit. Move some common code from ui/gtk/io_stat.c to ui/io_graph_item.[ch] and use it in both GTK+ and Qt. Make the io_graph_item_t array allocation in io_stat.c static. The behavior should be identical and this gives us additional compile-time checks. Change-Id: I9a3d544469b7048f0761fdbf7bcf20f44ae76577 Reviewed-on: https://code.wireshark.org/review/435 Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org>
2014-04-03Remove garbage character inadvertantly introduced in the previous commit.Bill Meier1-1/+1
Change-Id: I6338fdb4506973ea5ed991512bbefa6b855640e9 Reviewed-on: https://code.wireshark.org/review/944 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-04-03(Pedantic): set editor modelines tab-width & etc to 8; Also: fix some ↵Bill Meier1-4/+4
indentation in packet-sip.c Change-Id: I623fc5e4c1247dbe5e15f0f33270f4f0994268ab Reviewed-on: https://code.wireshark.org/review/943 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>