aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/voip_calls.c
AgeCommit message (Collapse)AuthorFilesLines
2014-11-18voip_calls: Move to ui.Gerald Combs1-4080/+0
Move voip_calls.[ch] to ui. Add callbacks to voip_calls_tapinfo_t. Remove unused function definitions. Change-Id: Ib12db7053d53afa81ef2a66dc0cfe681bc624dd2 Reviewed-on: https://code.wireshark.org/review/5379 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-17voip_calls: Get rid of global variables.Gerald Combs1-226/+253
Move the members of voip_rtp_tapinfo_t to voip_calls_tapinfo_t. Move a bunch of formerly static variables there as well. Note that we might want to make them private again at some point. Remove launch_count. It appeared to be unused. Wrap the individual registration routines in voip_calls_init_all_taps. Wrap the removal routines in voip_calls_remove_all_tap_listeners. Move voip_calls_get_info() to voip_calls_dlg.c. Make it static. Change-Id: I58f9d91f55cfb5e4b0c048a5a1d5d4b947f4641b Reviewed-on: https://code.wireshark.org/review/5372 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Fixup whitespace.Gerald Combs1-3026/+3023
Set modelines and reindent to match the files in the top-level ui directory. Change-Id: I7ea221e76a4b0ad3b6bcf7a3c8b4645c16aecbba Reviewed-on: https://code.wireshark.org/review/5325 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Start separating common and GTK+-dependent code.Gerald Combs1-68/+73
Remove more calls to voip_calls_get_info. Get rid of the global cfile. Lowercase more function names. Change-Id: Ieda779779cce9f05e07c54314bceab4a18bae22f Reviewed-on: https://code.wireshark.org/review/5324 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Use our tap offsets.Gerald Combs1-103/+115
Add convenience functions to convert between tap IDs and tapinfo pointers. Use them to get rid of some calls to voip_calls_get_info(). Lowercase function names. Remove more exit()s. Change-Id: I187fdc505bc22cc05edafed9e97ede8279ea53f9 Reviewed-on: https://code.wireshark.org/review/5321 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Clean up tap registration and removal.Gerald Combs1-529/+331
Start moving away from a global voip_calls_tapinfo_t. Pass the voip_calls_tapinfo_t struct address to each registration and removal routine. All of the tap registration and removal routines are called at the same time. Replace the individual registration tracking booleans with a central one. Calling exit() from the GUI is rude. Don't do that. Change-Id: I9535002e2905a45a8cfc9643590b5d2d360ffc24 Reviewed-on: https://code.wireshark.org/review/5318 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls tap ID cleanup.Gerald Combs1-45/+70
Remove all of the public dummy members from voip_calls_tapinfo_t. Use pointer arithmetic to generate private, unique IDs instead. We weren't removing the SUA listener. Do so. Use the correct M3UA ID. Change-Id: I8e8cdb6addbc4868aebc004be20a2f57b4acf75b Reviewed-on: https://code.wireshark.org/review/5315 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-22Refactor pinfo->circuit_id behavior for ISUP dissectorMichael Mann1-4/+4
Change-Id: Idf6e68c53a0a2126f3906bbfa16166821735fc1b Reviewed-on: https://code.wireshark.org/review/4904 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-15Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-9/+12
Change-Id: I3e84e987ad26019d7536baf4d90d6b0c684f6ec1 Reviewed-on: https://code.wireshark.org/review/3054 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-07-11Strip some trailing whitespace; Fix some indentation; Add editor-modelines ↵Bill Meier1-22/+22
as needed. Change-Id: I943153e28f468070d86535abad7be032e1386118 Reviewed-on: https://code.wireshark.org/review/2994 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-08Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-25/+34
after change of ga67b7f5b5 Change-Id: I03155b46dc35274915f7a7c16fad81f97e0dc5bf Reviewed-on: https://code.wireshark.org/review/2911 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-27Use GQueue for generating statisticsBalint Reczey1-120/+122
This makes reversing the list back and forth to keep adding data at O(n) complexity obsolete. Bug: 9696 Change-Id: Ice77328b8f6c5bf72bbfcfd82e08d09d4f986d3f Reviewed-on: https://code.wireshark.org/review/2571 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-06-25fix_bug_10199: enhancement Telephony VoIP Call add ability to show all SIP ↵James Coleman1-10/+59
Flows. Add SIP Flows menu option beside VoIP Calls. Flow for all SIP message types (which have a call-id) is shown in SIP Flow. Add useful info(original flow method, response code, cseq) to comment field in conversation and flow dialogs. Change-Id: I4801a633ed9b6594b2d89629c9d6fec6352da150 Reviewed-on: https://code.wireshark.org/review/2479 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: James Coleman <gaoithe@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-15ui/gtk/voip_calls: Fix minor memleakPeter Wu1-6/+2
Return values from g_strsplit must be always be freed. Also remove a useless return statement and set a saner maximum split. Change-Id: I680e20d40fe86103b0dcba210ef41aa5769f4f86 Reviewed-on: https://code.wireshark.org/review/1155 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-03Fix Bug 9920 Buildbot crash due to SDP/RTP mismatchHadriel Kaplan1-4/+3
For details see comments in Bug 9920. The executive summary: Bug 9920 is a crash caused by a couple of issues: 1) The memory ownership model for the rtp_dyn_payload hashtable is split: SDP creates the rtp_dyn_payload hashtable, but RTP can free it. Since there isn't *one* pointer to the hashtable, RTP freeing it means SDP has a dangling pointer. 2) Either the SDP dissector shouldn't be creating two separate, unique hashtables for multiple media channels of the same addr:port, or RTP shouldn't be free'ing the previous one. Change-Id: I436e67de6882f84aa82dcbdfe60bf313fe4fd99c Reviewed-on: https://code.wireshark.org/review/918 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-03Create/use an extended value-string; Move value-string array from .h file; ↵Bill Meier1-2/+2
Do other misc. - Value string arrrays should never be defined in a .h file (especially one included in multiple .c files). So: a. The value_string array (and associated #defines) was moved from the .h file to packet-rtp_events.c b. A public extended value_string was created in packet-rtp_events.c and declared as external in packet-rtp_events.h - Other: Remove a few unneeded initializers; Add editor modelines. Change-Id: Ib580c3e50ab5ce79484c9c6af57f62ca604b57d1 Reviewed-on: https://code.wireshark.org/review/468 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-25Remove trailing whitespaceBill Meier1-1/+1
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0 Reviewed-on: https://code.wireshark.org/review/385 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2013-12-23From Ville Skyttä: Spelling FixesBill Meier1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9591 svn path=/trunk/; revision=54387
2013-12-15Fix some const/ not const warnings.Jakub Zawadzki1-8/+8
svn path=/trunk/; revision=54114
2013-12-14Create/use several extended value-strings;Bill Meier1-6/+29
(Sort & remove dups from underlying value_string arrays); Reformat a few long lines; Add editor modelines; svn path=/trunk/; revision=54103
2013-12-03When including <epan/prefs.h> don't force inclusion of <epan/uat.h>Jakub Zawadzki1-0/+2
svn path=/trunk/; revision=53769
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-1/+1
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-09Fix crash when displaying VoIP call flow (introduced in r52824)Pascal Quantin1-0/+13
svn path=/trunk/; revision=53204
2013-10-24Initial and woefully incomplete flow graph support.Gerald Combs1-26/+26
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch] to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in places. svn path=/trunk/; revision=52824
2013-07-21Replace relative timestamp with reference frame number. Saves 16B per frame.Jakub Zawadzki1-5/+44
svn path=/trunk/; revision=50772
2013-07-15Fix warnings: format '%blah' expects argument of type 'foo', but argument ↵Chris Maynard1-5/+5
'i' has type 'bar' [-Wformat]. svn path=/trunk/; revision=50639
2013-07-01Consistently maintain the callState member of an iax2_info_t structureGuy Harris1-45/+2
as a voip_call_state value; don't have it sometimes a voip_call_state and sometimes a frame subtype. This should squelch some complaints from newer versions of Clang about unnecessary array-bounds checks - the array-bounds checks are done on frame subtypes, where they *are* necessary (nothing prevents an untrustworthy IAX2 implementation or an untrustworthy capture file writer from putting an arbitrary value in the packets), not on voip_call_state values (where it was only necessary because the value wasn't, in that case, a voip_call_state value, it was a frame subtype cast to a voip_call_state). svn path=/trunk/; revision=50277
2013-06-27get main_window_update out of the way... pass an update_cb to the ↵Luis Ontanon1-1/+8
capture_sync stuff ... as per the XXX comment removed from tshark.c this was a mess to keep the linker happy... I couldn't! I did this without even understanding whether calling main_window_update was realy necessary in most cases. I guess nothing or more specific update cbs would be best. svn path=/trunk/; revision=50188
2013-06-06From report of IgorVK via ↵Alexis La Goutte1-0/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8736 Crash analyzing VoIP Calls Wireshark crashes when analyzing Telephony->VoIP Calls from the pcap file attached. From me : Some packets is detect to be T38 and ->stop_fd is not initialize #Backport 1.10 and 1.8 svn path=/trunk/; revision=49804
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-1/+1
svn path=/trunk/; revision=49259
2013-04-05From Tim Ringenbach:Anders Broman1-2/+2
makes the TDMoE dissector call the LAPD bitstream dissector on the D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup and tear down, instead of just a hex dump. It adds a preference for which channel the D-Channel is. It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who isn't expecting it), to register the lapd-bitstream dissector, and to mark packets with aborts or resets. also storing more data on the lapd_byte_state_t. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8374 svn path=/trunk/; revision=48743
2013-03-21From beroset:Bill Meier1-78/+78
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c svn path=/trunk/; revision=48448
2013-03-21From beroset:Bill Meier1-31/+31
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP' didn't compile and needed a few additional patches. svn path=/trunk/; revision=48447
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-2/+2
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-25it's ==> its & its ==> it's as needed.Bill Meier1-1/+1
In a few cases: Fix spelling; Clean up whitespace and formatting style. svn path=/trunk/; revision=47889
2012-12-26Fix a bunch of warnings.Guy Harris1-4/+1
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-28protect_thread_critical_region, unprotect_thread_critical_region are no-ops, ↵Jakub Zawadzki1-38/+0
cleanup code by removing them. svn path=/trunk/; revision=45201
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-09-17callsinfo->stop_fd not set in all branches for UNISTIM.Anders Broman1-5/+7
svn path=/trunk/; revision=44940
2012-09-04- Replace packet_list_recreate_visible_rows -> ↵Jörg Mayer1-1/+1
packet_list_recreate_visible_rows_list - Replace new_packet_list_ -> packet_list_ svn path=/trunk/; revision=44765
2012-09-01Clean up mgcpDialedDigits and add modelines.Evan Huus1-8/+29
Build the digit string directly in heap memory. This removes the (arbitrary?) length limit and saves us the cost of a g_strdup. Also does away with a cppcheck warning. svn path=/trunk/; revision=44734
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-02From Evan Huus Memory leak in voip_calls.c ↵Anders Broman1-1/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7320 svn path=/trunk/; revision=42997
2012-04-09Add missing const attribute to some char *Jakub Zawadzki1-1/+1
Fix some "assignment discards qualifiers from pointer target type", etc svn path=/trunk/; revision=41993
2012-04-04Fix CID 614: callsinfo can't be NULL here so don't check for it being NULL.Jeff Morriss1-101/+98
svn path=/trunk/; revision=41934
2012-04-04Fix CID 615: strinfo can't be NULL here so don't check for it being NULL.Jeff Morriss1-145/+143
svn path=/trunk/; revision=41933
2012-04-04Fix CID 616: callsinfo can't be NULL here so don't check for it being NULL.Jeff Morriss1-13/+11
svn path=/trunk/; revision=41932
2012-03-14Fix:Jörg Mayer1-11/+11
work/wireshark/svn/trunk/ui/gtk/voip_calls.c:599:9: error: variable ‘voip_calls_graph_list’ set but not used [-Werror=unused-but-set-variable] svn path=/trunk/; revision=41548
2012-03-14voip_calls.c Use the hastable instead, we should do away with the list.Anders Broman1-2/+65
graph_analysis.h Doxygen changes. svn path=/trunk/; revision=41545
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 02:36:02 +0000