aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/tcp_graph.c
AgeCommit message (Collapse)AuthorFilesLines
2017-04-05A bunch of "{Mac} OS X" -> "macOS" changes.Guy Harris1-1/+1
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X 10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS X" from 10.8 to 10.11. Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3 Reviewed-on: https://code.wireshark.org/review/20933 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-23tcp_graph (Gtk) Fix Dereference of null pointerAlexis La Goutte1-2/+2
Change-Id: Ie07ed9f2bcf719340ea607d679620916aa93ba72 Reviewed-on: https://code.wireshark.org/review/19736 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-20Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixesKevin Hogan1-16/+39
Modifications to RTT graph: - change x-axis to time (s) rather than sequence number [ avoids sequence number wraparound ambiguity, plus easier to correlate RTT changes to tcptrace graph ] - change RTT computation to properly handle acks to GSO packets - change RTT computation to take SACK blocks into account Bug fixes: - eliminate potential memory leak if some packets are unacked - ensure RTT graph is shown if TCPGraph window is opened to it directly Change-Id: I2bdcab97399ebde0f15c78fa19c882529a814580 Reviewed-on: https://code.wireshark.org/review/19662 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-27Fix compile errors in GTK buildMichael Mann1-1/+1
Change-Id: Ib28c63e0ead6950b3b11b7c87adc543f80c070ed Reviewed-on: https://code.wireshark.org/review/18498 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-26Gtk: remove atoi calls and use ws_strtoi functions.Dario Lombardo1-2/+4
Change-Id: Ie38bdd27d9e3810e3a64b985dfd5621a3aa6d073 Reviewed-on: https://code.wireshark.org/review/18445 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-24Pacify GTK checkAPIs.pl warnings.Michael Mann1-3/+3
Add "Wireshark" macros to old-gtk-compat.h for GTK APIs that have been deprecated. The macros are setup by version number to limit their proliferation (not that I suspect much development will really be done there since GTK is deprecated). Just want to make buildbots happy for the time being. Change-Id: I095f850065166a0bc2e2456fb2e886ab64fdd97d Reviewed-on: https://code.wireshark.org/review/16635 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-06Qt: add initializers (CID 1162824).Dario Lombardo1-0/+2
Change-Id: Ib570d3531bfdd35404b75d49dbd7dd43db4c30d9 Reviewed-on: https://code.wireshark.org/review/16310 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-07GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast]João Valverde1-32/+36
Change-Id: I4714ba6cfbd18847d99650f5c5cdc60dd2e7af26 Reviewed-on: https://code.wireshark.org/review/13808 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2015-10-22Use address functions instead of ADDRESS macros in ui.Gerald Combs1-2/+2
Replace CMP_ADDRESS, COPY_ADDRESS, et al with their lower-case equivalents in the ui directory. Change-Id: I10e95e66c8da5b880133452ebc484c53046e87ba Reviewed-on: https://code.wireshark.org/review/11199 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-05Move utf8_entities.h to wsutilJoão Valverde1-1/+1
Change-Id: I6298b3de5f0a1cb988014ff16082eaf8c2a3c3c0 Reviewed-on: https://code.wireshark.org/review/10786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-27ui/gtk: fix weird check for axis orientationPeter Wu1-7/+4
There is only one meaning for the flags parameter, namely axis orientation (x or y). Replace the bitmap by a bool instead. Clang 3.7.0 reported this warning: ui/gtk/tcp_graph.c:1652:29: warning: shifting a negative signed value is undefined [-Wshift-negative-value] g->y_axis->flags &= ~AXIS_ORIENTATION; ~^~~~~~~~~~~~~~~~ ui/gtk/tcp_graph.c:140:28: note: expanded from macro 'AXIS_ORIENTATION' #define AXIS_ORIENTATION 1 << 0 ^ 1 warning generated. This (~1 << 0) happened to work because nothing is actually shifted. Change-Id: I406235148b7826649d35647f5d0702cd72a925a5 Reviewed-on: https://code.wireshark.org/review/10658 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-02The official #define for 32-bit and 64-bit Windows is _WIN32.Guy Harris1-1/+1
It's _WIN32, with a leading underscore, not WIN32. See, for example: https://sourceforge.net/p/predef/wiki/OperatingSystems/ and https://msdn.microsoft.com/en-us/library/b0084kay.aspx *Some* environments may also define WIN32, but we shouldn't depend on that. Replace all-caps "WIN32" referring to Windows in comments and other text with "Windows" or "Win32". (The two are pretty much equivalent, these days; nobody much cares about Win16, not that we ever ran on it, and 64-bit Windows is just a 64-bitified Win32.) Change-Id: Id327bcd4b1e9baa4f27055eff08c2d9e594d6f70 Reviewed-on: https://code.wireshark.org/review/10367 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier1-0/+13
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-09(Trivial) Fix printf-related 'Mismatch on sign' warningsBill Meier1-1/+1
Found by MSVC2013 Code Analysis Change-Id: I58063946dd558e98308c87b36eeac0ddbe1a6e79 Reviewed-on: https://code.wireshark.org/review/7045 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-06Replace ep_address_to_str with address_to_str.Michael Mann1-2/+7
Change-Id: I4f1078b20f41800f72a751612703ad0d4c2ae87b Reviewed-on: https://code.wireshark.org/review/6323 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-1/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-07-03Rename and move ui/stat_menu.h to epan/stat_groups.h.Guy Harris1-1/+1
The groups are, technically, independent of the notion of a menu, and, if we have mechanisms by which taps that are not only GUI toolkit-independent but independent of the *existence* of a GUI can be registered, they might want to register themselves in a group just in case they're running in a program that has a GUI. Also, this might fix the Debian package build. Change-Id: I29435681e79748fd4f2e0c5ac872cd11f831d172 Reviewed-on: https://code.wireshark.org/review/2830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-30Move stat_menu.h to libui.Guy Harris1-1/+1
Change-Id: I7bed7f7931845bc41035535cc62e1fe17c71047d Reviewed-on: https://code.wireshark.org/review/2726 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-05Make launching TCP graphs from conversations window work again, by supplying ↵Martin Mathieson1-1/+4
stream and direction when graph is first created svn path=/trunk/; revision=53797
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-26From robionekenobi via ↵Pascal Quantin1-3/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9328 : Suppress some VS2013 warnings when compiling gtk ui svn path=/trunk/; revision=52880
2013-09-08Add the TCP RTT graph.Gerald Combs1-70/+0
Show the time values in ms instead of s. Add a button and keyboard shortcut to switch the connection direction. Move more code to tap-tcp-stream.c. Update our axis labels. svn path=/trunk/; revision=51832
2013-09-04Throughput graph updates.Gerald Combs1-60/+20
GTK+: Fix what appears to be an off-by-one error in the MA period (21 segments instead of 20). Throw away our initial segment length instead of subtracting it from the moving sum, which skews the sum. Qt: Add the througput graph. Use bits/s for the throughput y axis. Let the user switch between graph types. The dialog hangs when doing this. I haven't been able to track down the cause. Remove some unused code. Both: Tell the user that we're using a 20 segment moving average. Move more routines to tap-tcp-stream.[ch]. svn path=/trunk/; revision=51759
2013-08-30Add an item tracer to the TCP stream graph. Enable packet selection.Gerald Combs1-3/+4
QCustomPlot data sets are made up of keys (x axis by default) and values (y axis). It looks like we can have multiple values for a given key (i.e. we can show multiple sequence numbers for a given timestamp) but QCPItemTracers can only be positioned by a key and not a key+value pair. This makes our graph selection behavior a bit different compared to the GTK+ version. We can only select one segment for a give timestamp but our selection targets are much larger (the height of the graph). Add a map for segment data so we don't have to iterate to find them. Use UTF8_RIGHTWARDS_ARROW where appropriate. Set a window title. Tell the user what will happen if he or she clicks. Disable graph selection. svn path=/trunk/; revision=51604
2013-08-27Try to fix error: enum conversion in assignment is invalid in C++ ↵Pascal Quantin1-3/+3
[-Werror=c++-compat] svn path=/trunk/; revision=51545
2013-08-27Add TCP sequence number (Stevens-style) graphs.Gerald Combs1-574/+268
Add the QCustomPlot widget. Thanks to Emanuel Eichhammer for granting a license change. Move some common code from ui/gtk/tcp_graph.c to ui/tap-tcp-stream.[ch]. Get rid of tcp_graph_selected_packet_enabled(). It was only used in the menu code and didn't match what we were doing elsewhere. Still quite a bit of work to do but it's a promising start. svn path=/trunk/; revision=51538
2013-07-21Replace relative timestamp with reference frame number. Saves 16B per frame.Jakub Zawadzki1-4/+6
svn path=/trunk/; revision=50772
2013-07-21Some work on multi file dissectionJakub Zawadzki1-1/+1
- make init_dissection/cleanup_dissection private for libwireshark - implement epan_new(), epan_free() - pass epan_t to epan_dissect* svn path=/trunk/; revision=50761
2013-07-11packet dissection now takes pointer to tvb instead of guint8 dataJakub Zawadzki1-1/+3
implement frame_tvbuff, right now almost a copy of 'real' tvb. svn path=/trunk/; revision=50497
2013-06-16Have the seek-read routines take a Buffer rather than a guint8 pointerGuy Harris1-1/+1
as the "where to put the packet data" argument. This lets more of the libwiretap code be common between the read and seek-read code paths, and also allows for more flexibility in the "fill in the data" path - we can expand the buffer as needed in both cases. svn path=/trunk/; revision=49949
2013-06-05As of r49659, StatisticsMenu is now just Statistics.Chris Maynard1-5/+5
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8770 svn path=/trunk/; revision=49788
2013-03-28Follow up on bug 8416.Jaap Keuter1-25/+25
Remove C++ incompatibilities in GTK+ 3 code. svn path=/trunk/; revision=48606
2013-03-21From beroset:Bill Meier1-2/+2
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c svn path=/trunk/; revision=48448
2013-03-06Use explicit casts.Anders Broman1-17/+17
svn path=/trunk/; revision=48144
2013-03-06Get rid of xor_gc altogether, I think it's a remnant from the "old" ↵Anders Broman1-27/+0
cross-hair code. svn path=/trunk/; revision=48140
2013-01-16Remove redundant call to gtk_box_set_child_packing().Bill Meier1-1/+0
svn path=/trunk/; revision=47128
2013-01-16Use gdk_cairo_set_source_rgba() and GdkRGBA.Bill Meier1-31/+31
svn path=/trunk/; revision=47121
2013-01-14Cleanup: Whitespace, formatting-style, long-lines & etc.Bill Meier1-4166/+4180
Use "4 space" indentation. Add an XXX comment about better formating needed for the text in the Help window (so the text columns line up and so the Help text looks better). Comment out a "does-noting" for loop; svn path=/trunk/; revision=47059
2013-01-14Replace gtk_table...() with ws_gtk_grid...();Bill Meier1-67/+68
Also: Minor changes so that window resizing is handled identically in Gtk2 & Gtk3. svn path=/trunk/; revision=47058
2013-01-04replace "unsigned" datatype with "guint". Some mpeg files needed "unsigned ↵Michael Mann1-1/+1
int" instead. bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825) svn path=/trunk/; revision=46928
2012-12-24The inverse of GINT_TO_POINTER() is GPOINTER_TO_INT(); use it. ThatGuy Harris1-5/+5
squelches some warnings. svn path=/trunk/; revision=46729
2012-12-16Don't cast away constness of passed-in tap structs.Martin Mathieson1-4/+4
svn path=/trunk/; revision=46552
2012-12-12From Edwin Groothuis via ↵Pascal Quantin1-5/+9
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8083 : Abstract some constants by defines in tcp_graph.c svn path=/trunk/; revision=46524
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-8/+8
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-11-26From Jim Young:Anders Broman1-1/+1
Refactoring committed in Revision 460001 of tcp_graph.c introduced a copy&pasteo to wscale_make_elmtlist() such that compare_headers() would always return false. Consequently no elements would get added to the list of elements to be plotted. The attached patch corrects wscale_make_elmtlist() so that the Windows Scaling graph will plot elements. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8018 svn path=/trunk/; revision=46200
2012-11-25 Fix a [-Wshadow] warning;Bill Meier1-26/+26
svn path=/trunk/; revision=46188
2012-11-25Set line width 1 for the cairo context used to draw all lines (bugMartin Mathieson1-0/+3
8017). Do it outside of the loop. svn path=/trunk/; revision=46176
2012-11-25Needed to match up correct element lists for data + control for tcptraceMartin Mathieson1-21/+13
graphs. Should really make clearer the way lists of elements are allocated and the final next is assigned to NULL... svn path=/trunk/; revision=46174
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 10:43:19 +0000