aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/mac_lte_stat_dlg.c
AgeCommit message (Collapse)AuthorFilesLines
2017-12-08Have the frame_tvbuff.c routines not use the global cfile.Guy Harris1-0/+2
Have the routines that create them take a pointer to a struct packet_provider_data, store that in the tvbuff data, and use it to get the wtap from which packets are being read. While we're at it, don't include globals.h in any header files, and include it in source files iff the source file actually uses cfile. Add whatever includes that requires. Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229 Reviewed-on: https://code.wireshark.org/review/24733 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-15Remove superfluous null-checks before strdup/freeAhmad Fatoum1-6/+1
NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-09-01gtk: fix compilation with GTK+ before 2.18Peter Wu1-0/+1
Removed in v1.99.2rc0-399-g43f09e6, but some includes are still needed. Basically I looked for the functions defined in the ui/gtk/old-gtk-compat.h header file that were in files below ui/gtk/. Then I matched it against the removed part in the above commit and added the header back at its old place. In two other cases, the header was only needed for Windows. If the above commit did not reference the file, I checked which function was in use and added the header on top, removing redundant conditionals. Reported and tested by a user of GTK+ 2.12.12 on top of v2.0.5. Change-Id: I649eec1e5531070f88c99d893c4920306f56d849 Reviewed-on: https://code.wireshark.org/review/17371 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-07-24Replace strlen with NULL checks to pacify checkAPIs.plMichael Mann1-2/+2
Change-Id: I5db39cbd531c228da73447bf8899599f82e1889d Reviewed-on: https://code.wireshark.org/review/16624 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-19Revert "tap: change glib functions to wmem."Pascal Quantin1-3/+3
This reverts commit 2e9f3c5d366eaa7139fc877b5301392166b3f985. It breaks the registration of codec, dissector and libwiretap plugins. Change-Id: I4ef91dd192f765adf87ea9fe9f3693e25dbd24de Reviewed-on: https://code.wireshark.org/review/16012 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-17tap: change glib functions to wmem.Dario Lombardo1-3/+3
Change-Id: I878ae6b121a669f9b7f4e1e57bc079f0cb44c0bf Reviewed-on: https://code.wireshark.org/review/15270 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-11lte/ui: fix 'time' var name.Dario Lombardo1-4/+4
As pointed out by checkAPI.pl. Change-Id: Ibab9b2720f3ef666b06b2b61ffc54aa23cbb01fc Reviewed-on: https://code.wireshark.org/review/10469 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-07-03Create very basic "generic" stat tap API to create a "GUI" independent table.Michael Mann1-1/+2
A few sample tap/dissectors (ANSI/A, ANSI MAP) are also included to test the API. The "GUI output" is a bit raw and could use some "prettying up", but all the basic hooks are there. Telephony "stat grouping" needs to be better alphabetized to properly populate menu (on GTK, probably Qt) Change-Id: I98514171f69c4ab3a304dccb26c71d629703c9ab Reviewed-on: https://code.wireshark.org/review/9110 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier1-0/+13
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-3/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-11-14Add a name field to tap_param, for use in error messages.Guy Harris1-1/+1
Change-Id: Ia4317b61ff30e269eba0ee2ea2c46f1668544b1b Reviewed-on: https://code.wireshark.org/review/5309 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Add an optional flag and a type for UUID parameters for stat taps.Guy Harris1-1/+1
For future use, with common code to parse the -z argument. Change-Id: Ib2a11bd5c91b5ac48ced2cd2d112b97c301ff72a Reviewed-on: https://code.wireshark.org/review/5307 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-03Rename and move ui/stat_menu.h to epan/stat_groups.h.Guy Harris1-1/+1
The groups are, technically, independent of the notion of a menu, and, if we have mechanisms by which taps that are not only GUI toolkit-independent but independent of the *existence* of a GUI can be registered, they might want to register themselves in a group just in case they're running in a program that has a GUI. Also, this might fix the Debian package build. Change-Id: I29435681e79748fd4f2e0c5ac872cd11f831d172 Reviewed-on: https://code.wireshark.org/review/2830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-30Move stat_menu.h to libui.Guy Harris1-1/+1
Change-Id: I7bed7f7931845bc41035535cc62e1fe17c71047d Reviewed-on: https://code.wireshark.org/review/2726 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Save the size and position of the expert info dialogChris Maynard1-1/+1
Set initialize position to center on parent bug: 3817 Change-Id: Iad48aa762d892908d50f742606160c8305084f48 Reviewed-on: https://code.wireshark.org/review/2459 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-17Fix [-Wmissing-prototypes]Anders Broman1-0/+2
svn path=/trunk/; revision=54833
2013-08-08Improve stats of broadcast messagesMartin Mathieson1-18/+40
svn path=/trunk/; revision=51219
2013-07-06Count SDUs even when dumping only the MAC headerPascal Quantin1-6/+2
svn path=/trunk/; revision=50420
2013-05-31Neither gtk_mac_lte_stat_init() nor gtk_rlc_lte_stat_init() are referredGuy Harris1-1/+1
to outside the files that define them; make them static. svn path=/trunk/; revision=49664
2013-05-31Add a REGISTER_STAT_GROUP_TELEPHONY_LTE for the Telephony/LTE menu, andGuy Harris1-7/+1
use it o register the MAC and RLC statistics dialogues. Get rid of the explicit menu items for them, as they now show up in the menu as a result of the tap registering itself. svn path=/trunk/; revision=49658
2013-05-24A long-overdue rename of register_dfilter_stat() toGuy Harris1-1/+1
register_param_stat() to reflect that it's for arbitrary statistics tap parameters, not just a display filter. svn path=/trunk/; revision=49549
2013-04-15Allow MAC and RLC stats dialogs to be launched other than by menu/filterMartin Mathieson1-2/+1
dialogs. svn path=/trunk/; revision=48855
2013-03-21From beroset:Bill Meier1-4/+4
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c svn path=/trunk/; revision=48448
2013-01-17Minor cleanup:Bill Meier1-97/+98
- Whitespace; - Long lines. svn path=/trunk/; revision=47138
2013-01-17Use gtk_box_pack_start() instead of gtk_container_add()Bill Meier1-17/+18
when packing into a [v|h]box so that Gtk2 & Gtk3 behavior is the same. Also: Add an XXX comment: "progess" rendering doesn't seem to work for Gtk3 ?? svn path=/trunk/; revision=47134
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-16Don't cast away constness of passed-in tap structs.Martin Mathieson1-2/+2
svn path=/trunk/; revision=46552
2012-12-06Fix [-Wshadow] warnings.Bill Meier1-3/+3
svn path=/trunk/; revision=46426
2012-11-27Add %DL padding to LTE MAC stats.Martin Mathieson1-3/+16
svn path=/trunk/; revision=46215
2012-09-28protect_thread_critical_region, unprotect_thread_critical_region are no-ops, ↵Jakub Zawadzki1-2/+0
cleanup code by removing them. svn path=/trunk/; revision=45201
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45016
2012-07-06Take yet more care not to be dividing by zero when calculating the bitMartin Mathieson1-1/+7
rate of the channel/UE. Times four... svn path=/trunk/; revision=43578
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-03g_filename_display_basename() returns a g_mallocated string, so itsGuy Harris1-3/+12
callers either need to free it or their callers need to free it or.... This means that cf_get_display_name() must always return a g_mallocated string and its callers or... must free it. For some of those callers, create a new set_window_title() routine to do the work - they're all using the same pattern. svn path=/trunk/; revision=43047
2012-05-05AFAICT '#include sys/types.h' is not needed for these files.Bill Meier1-4/+0
svn path=/trunk/; revision=42443
2012-04-21Replace gtk_vbox_new() and gtk_hbox_new() with ws_gtk_box_new().Anders Broman1-8/+8
svn path=/trunk/; revision=42176
2012-04-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+1
svn path=/trunk/; revision=42086
2012-04-05Fix test to avoid dividing by 0.0 (was displaying as "-nan" rather thanMartin Mathieson1-1/+1
crashing). svn path=/trunk/; revision=41948
2012-03-30Fix the flag used in a test.Martin Mathieson1-1/+1
svn path=/trunk/; revision=41835
2012-03-12Add checkboxes to filter for RACH attempts and SRs.Martin Mathieson1-14/+65
svn path=/trunk/; revision=41500
2012-01-25Delete a TODO comment (now that there is an equivalent tshark tap).Martin Mathieson1-4/+0
svn path=/trunk/; revision=40713
2012-01-16Move some headers for UI stuff, and the alert_box.c UI-specific file, toGuy Harris1-1/+1
the ui directory. (Perhaps some other files that would be used by all flavors of Wireshark, for any GUI toolkit or for someting such as ncurses, and not for any command-line tool such as TShark, should be moved there as well.) Shuffle some #includes to put the "ui/XXX.h" includes together. svn path=/trunk/; revision=40529
2012-01-15Move gtk to ui/gtk.Jörg Mayer1-0/+1346
This looses the last checkin to gtk, will add this manually back. svn path=/trunk/; revision=40518
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 01:01:25 +0000