aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/gtp_stat.c
AgeCommit message (Collapse)AuthorFilesLines
2015-06-21Further refactor SRT stats.Michael Mann1-237/+0
Create "common" SRT tap data collection intended for all GUIs. Refactor/merge functionality of existing dissectors that have SRT support (AFP, DCERPC, Diameter, FC, GTP, LDAP, NCP, RPC, SCIS, SMB, and SMB2) for both TShark and GTK. SMB and DCERPC "tap packet filtering" were different between TShark and GTK, so I went with GTK filter logic. CAMEL "tap packet filtering" was different between TShark and GTK, so GTK filtering logic was pushed to the dissector and the TShark tap was left alone. Change-Id: I7d6eaad0673fe628ef337f9165d7ed94f4a5e1cc Reviewed-on: https://code.wireshark.org/review/8894 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier1-0/+13
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-10Add a "Sum" column to the Service Response Time (SRT) window.Kevin Grigorenko1-1/+1
The Service Response Time (SRT) window currently provides the columns: Index, Procedure, Calls, Min SRT, Max SRT, and Avg SRT. A Sum column has been found useful in some customer situations to understand the total time spent doing a set of procedures. For example, in one case we were trying to isolate whether most time was being spent on a client thread or in the act of making outbound calls. We knew the start and end time of the client call, so with the "Sum" of time spent in that period, we could isolate a particular set of procedures driving the slow down. Additional changes made in this patch: * Add " (s)" to Min, Max, Avg, and Sum columns to make it clear that times are in seconds. * Refactor out width and height constants used in calls to gtk_window_set_default_size in most of the SRT users into #define SRT_PREFERRED_WIDTH and SRT_PREFERRED_HEIGHT. Also increase the common width of 550 to 650 to account for the additional column. Change-Id: I20f152eecbcd0bbf69f71c6c6b9f9463e8867e23 Reviewed-on: https://code.wireshark.org/review/7047 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-5/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-11-14Add a name field to tap_param, for use in error messages.Guy Harris1-1/+1
Change-Id: Ia4317b61ff30e269eba0ee2ea2c46f1668544b1b Reviewed-on: https://code.wireshark.org/review/5309 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Add an optional flag and a type for UUID parameters for stat taps.Guy Harris1-1/+1
For future use, with common code to parse the -z argument. Change-Id: Ib2a11bd5c91b5ac48ced2cd2d112b97c301ff72a Reviewed-on: https://code.wireshark.org/review/5307 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-03Rename and move ui/stat_menu.h to epan/stat_groups.h.Guy Harris1-1/+1
The groups are, technically, independent of the notion of a menu, and, if we have mechanisms by which taps that are not only GUI toolkit-independent but independent of the *existence* of a GUI can be registered, they might want to register themselves in a group just in case they're running in a program that has a GUI. Also, this might fix the Debian package build. Change-Id: I29435681e79748fd4f2e0c5ac872cd11f831d172 Reviewed-on: https://code.wireshark.org/review/2830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-30Move stat_menu.h to libui.Guy Harris1-1/+1
Change-Id: I7bed7f7931845bc41035535cc62e1fe17c71047d Reviewed-on: https://code.wireshark.org/review/2726 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-17Fix [-Wmissing-prototypes]Anders Broman1-0/+2
svn path=/trunk/; revision=54833
2013-12-08Fix some warnings: cast discards `__attribute__((const))' qualifier from ↵Jakub Zawadzki1-1/+1
pointer target type svn path=/trunk/; revision=53875
2013-06-25Move a couple of time-related modules into wsutil.Jeff Morriss1-1/+0
A bunch of files didn't really need to include these header files so remove the include line rather than changing it. svn path=/trunk/; revision=50154
2013-05-24Have register_param_stat() add menu items, rather than having the menuGuy Harris1-6/+0
items hardcoded into ui/gtk/main_menubar.c Get rid of more stuff implying that the code for adding menu items is used only by Lua, as it's also used by register_param_stat(). Add the items to the menu list sorted by the menu item name shown to the user. Get rid of some const declarations that are lies. Use the label given for a menu item as the label in the menu, rather than parsing it from a token. svn path=/trunk/; revision=49552
2013-05-24A long-overdue rename of register_dfilter_stat() toGuy Harris1-1/+1
register_param_stat() to reflect that it's for arbitrary statistics tap parameters, not just a display filter. svn path=/trunk/; revision=49549
2013-03-21From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10408 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c svn path=/trunk/; revision=48448
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-3/+3
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-09-28protect_thread_critical_region, unprotect_thread_critical_region are no-ops, ↵Jakub Zawadzki1-2/+0
cleanup code by removing them. svn path=/trunk/; revision=45201
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-03g_filename_display_basename() returns a g_mallocated string, so itsGuy Harris1-6/+1
callers either need to free it or their callers need to free it or.... This means that cf_get_display_name() must always return a g_mallocated string and its callers or... must free it. For some of those callers, create a new set_window_title() routine to do the work - they're all using the same pattern. svn path=/trunk/; revision=43047
2012-05-05AFAICT '#include sys/types.h' is not needed for these files.Bill Meier1-4/+0
svn path=/trunk/; revision=42443
2012-04-21Replace gtk_vbox_new() and gtk_hbox_new() with ws_gtk_box_new().Anders Broman1-1/+1
svn path=/trunk/; revision=42176
2012-01-16Move some headers for UI stuff, and the alert_box.c UI-specific file, toGuy Harris1-1/+1
the ui directory. (Perhaps some other files that would be used by all flavors of Wireshark, for any GUI toolkit or for someting such as ncurses, and not for any command-line tool such as TShark, should be moved there as well.) Shuffle some #includes to put the "ui/XXX.h" includes together. svn path=/trunk/; revision=40529
2012-01-15Move gtk to ui/gtk.Jörg Mayer1-0/+249
This looses the last checkin to gtk, will add this manually back. svn path=/trunk/; revision=40518