aboutsummaryrefslogtreecommitdiffstats
path: root/ui/gtk/addr_resolution_dlg.c
AgeCommit message (Collapse)AuthorFilesLines
2017-12-08Have the frame_tvbuff.c routines not use the global cfile.Guy Harris1-0/+2
Have the routines that create them take a pointer to a struct packet_provider_data, store that in the tvbuff data, and use it to get the wtap from which packets are being read. While we're at it, don't include globals.h in any header files, and include it in source files iff the source file actually uses cfile. Add whatever includes that requires. Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229 Reviewed-on: https://code.wireshark.org/review/24733 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-29Get rid of unused #defines.Guy Harris1-2/+0
Change-Id: I6d4f56cddbe4378a3a7d4feb5ac16933675ac83b Reviewed-on: https://code.wireshark.org/review/24175 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-19Attempt to clean up addr_resolv flags by removing DUMMY_ADDRESS_ENTRYAnthony Coddington1-2/+2
Replace with easier to understand and already present NAME_RESOLVED given dummy address is always filled. Change-Id: If8464f89e88722aac70689749fe0d4a31c119db2 Bug: 13798 Reviewed-on: https://code.wireshark.org/review/22110 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-14addr_resolv: change g_hash to wmem_map.Dario Lombardo1-22/+21
Change-Id: Ice7533fbeac700dae0a46766838818a32b0d5736 Reviewed-on: https://code.wireshark.org/review/15051 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-13Fix misaligned read and buffer overrunPeter Wu1-14/+6
Ethernet addresses are only 6 bytes in size, reading it as a 64-bit integer is invalid. Use unsigned 8-bit integers instead. Caught by UBSAN and Address Sanitizer. Trigger via the Statistics menu Resolved Addresses (Qt) or Show address resolution (GTK). Change-Id: I628ff7cce0ea4f4e378c7968cd79a0ae34cdd20b Reviewed-on: https://code.wireshark.org/review/10443 Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-02-16Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to worry about the wmem_allocator. Change-Id: If976fe7b0c3f9cd053225096c2ac05418f061af6 Reviewed-on: https://code.wireshark.org/review/7081 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-14"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: Ic7dee275ba0a2bd4e19c06702a867417c5624c27 Reviewed-on: https://code.wireshark.org/review/7080 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-12Revert ""Hide" hashether_t structure."Anders Broman1-3/+3
This reverts commit 297ef07b9b2f5b681234d0c31269996413262cbc. Change-Id: Id47f5fd221b631c95ca71e3f9315f5263bab22de Reviewed-on: https://code.wireshark.org/review/7077 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Revert "Make get_manuf_name return a const string."Anders Broman1-2/+2
This reverts commit 797ea88aefc2f45dba7e77d2dcaebe68ac1a4fac. Change-Id: I9bc2cef0051d88c6374c6f1868b0250cba3edbd4 Reviewed-on: https://code.wireshark.org/review/7076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12Make get_manuf_name return a const string.Michael Mann1-2/+2
Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table. This will make name resolution of addresses perform a little better because it doesn't have to work about the wmem_allocator. Change-Id: I80f465ae0845290255a659ab63310ac3cc35506e Reviewed-on: https://code.wireshark.org/review/7075 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-12"Hide" hashether_t structure.Michael Mann1-3/+3
One use in a GUI function isn't really enough to justify making the structure public. Change-Id: I6d70b9bacbc0fa1898150f59c0c69779a6cd5d51 Reviewed-on: https://code.wireshark.org/review/7074 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-9/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-08-05Fix whitespace/indentation to match editor modelines.Bill Meier1-155/+155
Change-Id: I3445ae22f10584582d465bf632942e016f5f70ca Reviewed-on: https://code.wireshark.org/review/3452 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-31addr_resolution_dlg.c: "OK" button should *do* something: treat as cxl.Bill Meier1-1/+1
Also: remove vestigial line of commented-out code. Change-Id: Ieb41a0e39a4e0ec14031b1dbd38fc0d7ad47a635 Reviewed-on: https://code.wireshark.org/review/3278 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-31addr_resolution_dlg.c: Fix crash when 'Statistics ! Show address resolution' ↵Bill Meier1-1/+1
is invoked. (Introduced when the ipv4_hash_table key format was changed in 5d98ab67) Change-Id: Ie5d1314f7c7cc8bc71dca8a2db05e34a0a7776d7 Reviewed-on: https://code.wireshark.org/review/3277 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
2013-10-10Flag the addresses used in the trace which has been resolved and only add ↵Anders Broman1-2/+2
those to the list used to create the NRB. svn path=/trunk/; revision=52504
2013-09-11remove unused variable, mark unused parameterMartin Kaiser1-2/+1
svn path=/trunk/; revision=51954
2013-09-11Get rid of some users the addrinfo_list.Anders Broman1-80/+47
svn path=/trunk/; revision=51953
2013-08-29Revert revision=51577.Anders Broman1-2/+4
Ref https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9082 Since this commit the IP (source and destination) address in the GUI will be replaced with some date after I click on the entry, reverting this commit fixes the problem. This looks like a memory corruption. I imported an older pcap file. svn path=/trunk/; revision=51581
2013-08-29Don't store address in the hastable when name resolution is off.Anders Broman1-4/+2
svn path=/trunk/; revision=51577
2013-08-18addr_resolution_dlg.c: In function 'ipv6_hash_table_to_texbuff':Anders Broman1-1/+1
addr_resolution_dlg.c:185: warning: unused parameter 'key' svn path=/trunk/; revision=51416
2013-08-18Use g_hastable() for IPv6 name reslution.Anders Broman1-1/+25
svn path=/trunk/; revision=51415
2013-08-11Use g_hashtable for IPv4 name resolution.Anders Broman1-72/+30
svn path=/trunk/; revision=51301
2013-08-05Use a hastable for port resolution. Currently one table for the 4 protocols ↵Anders Broman1-0/+31
with resolution. SCTP and DCCP should perhaps be splited out to their own tables. svn path=/trunk/; revision=51153
2013-08-02Add some casts.Jeff Morriss1-18/+18
svn path=/trunk/; revision=51122
2013-08-02- Use a hashtable for eth lookup.Anders Broman1-0/+88
Currently broken get_ether_addr(). - Show hastable content in address dlg.(temp solution). svn path=/trunk/; revision=51119
2013-07-26gtk_widget_modify_font() has been renamed to gtk_widget_override_font() in GTK3Bill Meier1-0/+4
svn path=/trunk/; revision=50915
2013-05-22Include ui/gtk/addr_resolution_dlg.h so that functions defined here areGuy Harris1-1/+2
checked against their declarations. Fix a tpo. svn path=/trunk/; revision=49536
2013-05-13Eliminate some includes of ui/simple_dialog.h by files that don't useGuy Harris1-1/+0
anything from it. svn path=/trunk/; revision=49277
2013-04-07Use a monospace font for the address resolution dialog so that tabGerald Combs1-99/+114
alignment will work. Add modelines and reindent. svn path=/trunk/; revision=48777
2013-03-21From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP' didn't compile and needed a few additional patches. svn path=/trunk/; revision=48447
2013-03-06Actually add IPv6 addresses to the display.Jeff Morriss1-0/+1
svn path=/trunk/; revision=48128
2012-12-22Remove unneeded initializations, and one redundant if condition.Evan Huus1-1/+1
svn path=/trunk/; revision=46702
2012-11-30Add a menu to view the current address resolution.Anders Broman1-0/+277
Future enhancments(?) to save as new hosts file. svn path=/trunk/; revision=46307