aboutsummaryrefslogtreecommitdiffstats
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2016-06-15Remove Nmake build systemPascal Quantin10-329/+2
Change-Id: I3bd474f3cda9667dec66426b5729449953df3e61 Reviewed-on: https://code.wireshark.org/review/15777 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-06-15Win: convert atkversion.h to UTF-8Pascal Quantin1-4/+4
Change-Id: I7bfa9be11596cc9a3e1b0226c6865edf47e96782 Reviewed-on: https://code.wireshark.org/review/15931 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-15win-setup.ps1: stop downloading user-guide; with CMake it is generated from ↵Pascal Quantin1-2/+0
source code Change-Id: I3b015594bd6a6b0c41938ba17d5690c08e04f490 Reviewed-on: https://code.wireshark.org/review/15917 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13Indent register.c and other cosmetic changesJoão Valverde1-13/+31
Change-Id: I06e863e0b87118047f4c3b7618df02b9c7384a34 Reviewed-on: https://code.wireshark.org/review/15836 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12Have MemoryCheck() directly incorporate the error message and exit.Guy Harris1-13/+3
Manually inline memory_error() in MemoryCheck(), so that static analyzers know that, if MemoryCheck() sees a null pointer, it exists, and the null pointer isn't subsequently used. Use MemoryCheck() instead of the one place where we manually checked for a null pointer and called memory_error(). Change-Id: Id6b0328cfd17cb14ec9d1e461420896a31573c71 Reviewed-on: https://code.wireshark.org/review/15851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Add more memory checks, and use MemoryCheck() for some existing checks.Guy Harris1-31/+14
Always check for malloc() and realloc() failing. Use MemoryCheck() for most of the checks - it's a bit cleaner and makes the error message the same for those checks. Change-Id: I533153c697b37b85adfa0259c1352efece0b0486 Reviewed-on: https://code.wireshark.org/review/15849 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-06Add support in checkhf.pl for expert info.Michael Mann1-5/+158
Basically a copy/paste of the existing hf_ functionality, but looking for ei_ variables instead. Change-Id: Ic9a34f6bd5dee895fc858bb9631c00271a86486b Reviewed-on: https://code.wireshark.org/review/15717 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-03Remove an ellipsis UTF-8 character in gsignal.hPascal Quantin1-2/+2
Change-Id: Ic31dab513fc2ff5f2f182ae98c1b665ea4b8916b Reviewed-on: https://code.wireshark.org/review/15713 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-30Add nghttp2 folder to ignore pre-commit checkAlexis La Goutte1-0/+1
Change-Id: I6b76b55325db494f16488decfe94ff4129d0ac40 Reviewed-on: https://code.wireshark.org/review/15616 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-21[skinny] Fix StartMediaTransmissionMessage and OpenReceiveChannelMessage ↵Diederik de Groot1-3/+3
protocol version 20 - StartMediaTransmissionMessage is variable length - latentCapsInfo moved to protocol version 21-22 Change-Id: I4136c7007a8f9d6a8a3370d45faab62bbe983524 Reviewed-on: https://code.wireshark.org/review/15512 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-17[skinny] Update message definitionsDiederik de Groot1-6/+16
- Deal with short EnblocCallMessage coming from 7936 - SubscriptionStatReqMessage is shorter than previously known - Use buttonType enum in FeatureStatV2Message and FeatureStatMessage Change-Id: I0c4db5a0199ebb95bf807c858971d763faeef016 Reviewed-on: https://code.wireshark.org/review/15427 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-13Move the Valgrind size check after the capinfos check of the file.Jeff Morriss1-5/+5
That way if we pass a file that doesn't exist to the fuzz-test script we won't get errors from 'ls' complaining that the file doesn't exist. Change-Id: I33f4bd692775e6d3f990adaaa37b7530d343fe52 Reviewed-on: https://code.wireshark.org/review/15410 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-11Upgrade c-ares Windows library from 1.9.1 to 1.11.0Pascal Quantin1-4/+5
Bug: 12412 Change-Id: I5e5f8f86293e391ec425a6e3e314573711947bce Reviewed-on: https://code.wireshark.org/review/15345 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-02Revert "PIDL: Remove _U_ and remove unused-parameter via pragma"Guy Harris1-14/+11
This reverts commit db4f7fcdeac833f24807994b372d1e42479754bf. That doesn't work with the compiler being used on the OS X buildbot; that compiler is probably some version of llvm-gcc, which might be based on an older version of GCC without support for that pragma, or might not support it properly courtesy of the GCC front end and the LLVM back end not quite fitting together Change-Id: I6cd5f1322b4872ef0c4eb5695f021cec00ba85b7 Reviewed-on: https://code.wireshark.org/review/15246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-02Add checkAPI calls to CMake.Graham Bloice1-3/+19
This generates a top level target, checkAPI, that is excluded from the ALL build target, so must be run separately. On Windows using a Visual Studio generator, call msbuild /p:Configuration=RelWithDebInfo checkAPI.vcxproj Change-Id: I44a57c564dcfc75499463b942436f4b920a82478 Reviewed-on: https://code.wireshark.org/review/14873 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2016-05-02PIDL: Remove _U_ and remove unused-parameter via pragmaAlexis La Goutte1-11/+14
Change-Id: Ic40f86850dc94338a8c2205e04679793f368672f Reviewed-on: https://code.wireshark.org/review/14967 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-04-25Compile sshdump and ciscodump for WindowsPascal Quantin1-0/+3
Use libSSH 0.7.2 compiled with MinGW(32|64) and linked with zlib and gcrypt support Change-Id: I7c17d1ba3dd1890e2f83c119f5ea851834807e43 Reviewed-on: https://code.wireshark.org/review/12117 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-12Add more files to the pre-commit ignore list.Gerald Combs1-0/+3
checkAPIs.pl will otherwise fail for the following files and functions: epan/wmem/wmem_strbuf.c: strcpy epan/wmem/wmem_strutil.c: vsprintf wsutil/file_util.h: mkdir Change-Id: I186730c8974499959233bd21f9b428c5d896a2b5 Reviewed-on: https://code.wireshark.org/review/14893 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-04-12checkAPIs: Add links to banned functions.Gerald Combs1-1/+9
Add links to Microsoft's "Security Development Lifecycle (SDL) Banned Function Calls" and "Deprecated CRT Functions". Change-Id: I6f1ffca8158b942fccb982868c6760c2c6e2d97c Reviewed-on: https://code.wireshark.org/review/14881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-09Update USBPcap installer packaged in our Windows installer and add a warningPascal Quantin1-4/+4
The newer version creates a system restore point during installation Also add an explicit note in Wireshark installer explaining that USBPcap is experimental and some hints on how to recover in case of issue Bug: 12316 Change-Id: Ifb15ee98bf9db843debe5878f3df8c78f846d8d0 Reviewed-on: https://code.wireshark.org/review/14854 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-08Minor lemon Makefile.am fixupJoão Valverde1-1/+2
Change-Id: I80108d565e40835e9bf3fa58b1999735a45d77f0 Reviewed-on: https://code.wireshark.org/review/14860 Reviewed-by: João Valverde <j@v6e.pt>
2016-04-07Don't build lemon using -WerrorJoão Valverde1-1/+1
Change-Id: I0b7d691616578e8d5897b60fc31a469c9ab81607 Reviewed-on: https://code.wireshark.org/review/14850 Reviewed-by: João Valverde <j@v6e.pt>
2016-04-07autotools: Use AC_SUBST to set -Werror flagJoão Valverde1-5/+1
Change-Id: I34a90155ab613ca97bf58b72f56ec08eff87d3ab Reviewed-on: https://code.wireshark.org/review/14849 Reviewed-by: João Valverde <j@v6e.pt>
2016-04-05Expand a comment.Guy Harris1-2/+3
Change-Id: I13732bb2877a41b5f5d018128e05ebd4bfb6a1bf Reviewed-on: https://code.wireshark.org/review/14825 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-04-05Fix VPATH buildJoão Valverde1-1/+1
Fixup for ecb4dc396ef71feb67aeda7603e09b0cea0bc920. Change-Id: I3230e0ca203deb15dde8f22806307d59d70e05dd Reviewed-on: https://code.wireshark.org/review/14812 Reviewed-by: João Valverde <j@v6e.pt>
2016-04-04Use AC_REPLACE_FUNCS and LTLIBOBJSJoão Valverde1-0/+2
Change-Id: I0f46167fe900c39d678560809cd5391c2a9bc4d2 Reviewed-on: https://code.wireshark.org/review/14809 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-04-03Make the Flex scanners and YACC parser in libraries reentrant.Guy Harris1-53/+38
master-branch libpcap now generates a reentrant Flex scanner and Bison/Berkeley YACC parser for capture filter expressions, so it requires versions of Flex and Bison/Berkeley YACC that support that. We might as well do the same. For libwiretap, it means we could actually have multiple K12 text or Ascend/Lucent text files open at the same time. For libwireshark, it might not be as useful, as we only read configuration files at startup (which should only happen once, in one thread) or on demand (in which case, if we ever support multiple threads running libwireshark, we'd need a mutex to ensure that only one file reads it), but it's still the right thing to do. We also require a version of Flex that can write out a header file, so we change the runlex script to generate the header file ourselves. This means we require a version of Flex new enough to support --header-file. Clean up some other stuff encountered in the process. Change-Id: Id23078c6acea549a52fc687779bb55d715b55c16 Reviewed-on: https://code.wireshark.org/review/14719 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-28Fix out-of-tree "gen-authors" targetPeter Wu1-3/+3
Change directory to the source tree before invoking `git shortlog`, otherwise it fails on build directories outside the source tree. Alexis suggested to move the git invocation to the perl script, this is done now and also avoids writing AUTHORS.git in the source tree. Change-Id: I5905ebf40d8d32a586c88671b52f28c542ca33ba Reviewed-on: https://code.wireshark.org/review/14660 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-28tools/generate_authors.pl: avoid duplicatesPeter Wu1-7/+7
Officially, the local part of an email address is case sensitive, but in practice this is ignored. Ensure that duplicate email addresses are not listed. While at it, detect duplicates using `grep -Po '<\K[^>]+' AUTHORS | tr '[:upper:]' '[:lower:]' | sort | uniq -cd` and resolve them. Change-Id: Ie1e853d6253758c8454d9583f0a11f317c8390cb Reviewed-on: https://code.wireshark.org/review/14659 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-24Add basic PIDL MakefileJoão Valverde1-0/+1
Change-Id: I8f4c8e312df73b70f3cacd0df768375b46197ae6 Reviewed-on: https://code.wireshark.org/review/14507 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-24Portably remove CRs from Python output.Guy Harris1-7/+10
The GNU sed manual says the only C-style backslash escapes that can be used in regular expressions in portable sed scripts are \n and \\. The Single UNIX Specification says that \r is one of the C-style backslash escapes that can be used in tr, so use tr -d instead. Change-Id: I40d97ee9b89dfce3d67f062ec8839d3aba998ff3 Reviewed-on: https://code.wireshark.org/review/14606 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-24Add files by folder to distribution tarball (EXTRA_DIST)João Valverde1-102/+6
This takes away much of the pain (and merge conflicts) of micro-managing every sub-folder file. Change-Id: I7d7bb1173511ec9312ca4a97c6a59a26b0b194f4 Reviewed-on: https://code.wireshark.org/review/14595 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-23That's not specific to OS X.Guy Harris1-2/+5
OS X's sed appears to be a *BSD sed, so the same problem might exist on *BSD, or at least some *BSDs, and it might, in fact, be a problem with everything except for GNU sed. Change-Id: I267d9d7eb077c8ec39135bac7eff2c765af3efcf Reviewed-on: https://code.wireshark.org/review/14601 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-23Fix a problem that prevented checkins of all filenames containing theJoerg Mayer1-1/+3
character 'r' on MacOS with an active pre-commit hook. Change-Id: If26fb22d5057794ec0de0def4055310b78a05f89 Reviewed-on: https://code.wireshark.org/review/14600 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-23Make runlex.sh quieterJoão Valverde1-6/+6
Change-Id: I5a20493d1cca57ecb2487c443e9c0e20120fd711 Reviewed-on: https://code.wireshark.org/review/14575 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-21AUTHORS: More column alignment improvementsJoão Valverde1-4/+8
Change-Id: I29d08ca213df44c1d6d437135c45a3d6e45efa7d Reviewed-on: https://code.wireshark.org/review/14386 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-14Parallelize fuzz-test.shGerald Combs1-2/+14
Run each "argument" test (e.g. "-nVxr" and "-nr") simultaneously in the background. This should speed up our tests without reducing the amount of fuzzing that we do. Change-Id: I737d1dc09b31e07910d56632bec62da0f35fe222 Reviewed-on: https://code.wireshark.org/review/14432 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-03-13Move /asn1 to /epan/dissectorsJoão Valverde2-5/+4
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9 Reviewed-on: https://code.wireshark.org/review/14388 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-10Add the pass number to the fuzz failure report.Gerald Combs1-0/+1
When adjusting MAX_PASSES it'd be nice to know how many passes it normally takes to fail. Change-Id: I335c26a1e6847371706da880b83773d142797da9 Reviewed-on: https://code.wireshark.org/review/14389 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-10Use AX_PROG_CC_FOR_BUILD macro to identify compiler targeting the build host.Eric Anderson1-12/+8
(When cross-compiling, this is *not* the compiler used to build wireshark itself). Macro ax_prog_cc_for_build.m4 retrieved from http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git Change-Id: I035059d9315e0081dcf1ffbafd9ce6d7ad46700c Reviewed-on: https://code.wireshark.org/review/4503 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Eric Anderson <andersoe@cs.cmu.edu> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-08AUTHORS: Use LF line endings and remove BOMJoão Valverde1-6/+1
Change-Id: I03c582baa03238ac82916d8bf865a3bf25f04cd5 Reviewed-on: https://code.wireshark.org/review/14384 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-08AUTHORS: Add <...> to git log email addressesJoão Valverde1-1/+1
Change-Id: I936e4a25833906cac75d4d5b7359b5629d14b33d Reviewed-on: https://code.wireshark.org/review/14382 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-08generate_authors.pl: Use literal regex expressionJoão Valverde1-3/+1
Change-Id: I6828dc5f71930ce4121ab7ad24db5b0428cea7f3 Reviewed-on: https://code.wireshark.org/review/14383 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-07generate_authors: Align git log email columnJoão Valverde1-10/+18
Change-Id: Ic08b23e80a982805f4b512a410a1a4414afc3a8c Reviewed-on: https://code.wireshark.org/review/14354 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-06PIDL (NDR): fix missing $name when regenerate MAPI dissectorAlexis La Goutte1-3/+6
Issue coming from ge41f08858b Change-Id: Ibff382b7cbf9a89904eb87d7f3e8f56b5782a0f6 Reviewed-on: https://code.wireshark.org/review/14351 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-06CMake: Avoid pipes and the `cut` command.Gerald Combs1-1/+3
Dump the output of `git shortlog` directly to AUTHORS.git instead of piping it through `cut`. Depending on our toolchain, cmake COMMANDs might not support pipes. This appears to be the case for MSBuild. Removing the `cut` command has the added benefit of reducing our dependency on Cygwin. Pass HEAD to `git shortlog`, otherwise it doesn't return anything when run under MSBuild. Change-Id: I23e9436c007d76a700bbbc45c2772c8aba6d5749 Reviewed-on: https://code.wireshark.org/review/14349 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-05Check source files for broken (read: not set to 8) tabstop settings.Jeff Morriss1-0/+15
Change-Id: I60e77a67189e7446f8c5ffd0add803cca10b4b57 Reviewed-on: https://code.wireshark.org/review/14345 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-03Make sure our shell, Perl, & Python tools are executable.Gerald Combs5-0/+0
Change-Id: Ie58978473c4af7a0eaccf3e664c2f44bed2ef202 Reviewed-on: https://code.wireshark.org/review/14331 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-03-03Create perl script to append existing AUTHORS file with information from git ↵Michael Mann1-0/+197
log. new AUTHORS file can be created with "gen-authors" build parameter The "original" AUTHORS file has been fixed up to be kind to parsers (so no one gets excluded) and renamed to AUTHORS.src. This preserves the features authors worked on. For authors that didn't list features, they may be converted to just getting information from git. Change-Id: I9a4c4091e229f7f5e1c46d864527a98c1278e451 Reviewed-on: https://code.wireshark.org/review/14231 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-01debian-setup: need libtool-bin for building.Alexis La Goutte1-1/+1
Change-Id: I761babced3eb49b8a8cea4996b7ccd6f748a6200 Reviewed-on: https://code.wireshark.org/review/13829 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Dario Lombardo <lomato@gmail.com>