aboutsummaryrefslogtreecommitdiffstats
path: root/tools
AgeCommit message (Collapse)AuthorFilesLines
2020-07-08cppcheck: Fixup some comparisons.Gerald Combs1-3/+3
Change-Id: I6901c31cdea7399bc18dbf968c14c477f71a90dd Reviewed-on: https://code.wireshark.org/review/37777 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-07-07cppcheck: Bail if "-l <n>" or "-o" don't find any files.Gerald Combs1-3/+18
If we've been passed "-l <n>" and the last <n> commits don't match any C or C++ files or we've been passed "-o" and no files have been changed, simply exit instead of testing the entire code base. We use "cppcheck.sh -l <n>" in our CI system and the former behavior is much more useful (and faster) than the latter. Change-Id: I1127eabefa854d68f80b0a2dfd05e6895658abc0 Reviewed-on: https://code.wireshark.org/review/37773 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-07-01Add internalAstError to suppressed errors from cppcheck.Martin Mathieson1-0/+2
cppcheck seems to get confused by the VALS() macro. Change-Id: Iba59a4886a0461cea9797a09a10e67420b09af19 Reviewed-on: https://code.wireshark.org/review/37639 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-06-30cppcheck: add a -o option to check modified or staged changesMartin Mathieson1-1/+9
Change-Id: I336400441302549967db048bedc70980b04c5030 Reviewed-on: https://code.wireshark.org/review/37613 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-28cppcheck: add more include folders to look in.Martin Mathieson1-0/+2
Without this (particularly '.'), for some files it macro definitions cannot be found the whole file is basically skipped. Will make overall scan take quite a bit longer. Change-Id: I7498b23ad9b27edd3a815c7fc51ef8501fa5a56a Reviewed-on: https://code.wireshark.org/review/37567 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-06-22sysdig-event: fix the type of elements of an array of pointers to hf_ values.Guy Harris1-1/+2
"int * const a[]" means "array of const pointers to (non-const) int". so the array elements are all const; "const int *a[]" means "array of (non-const) pointrs to const int". Change-Id: I0571fde7704570b60c9cbd5d94826365ff35abe0 Reviewed-on: https://code.wireshark.org/review/37546 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-06-21tools/generate-sysdig-event.py: fail if the URL fetch fails.Guy Harris1-4/+4
Call exit_msg(), not just print(). Change-Id: I3ca59b262285222e5f54045244b6eeaa31fa363e Reviewed-on: https://code.wireshark.org/review/37530 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-06-21generate-sysdig-event.py: improve error reporting.Guy Harris1-1/+7
Catch particular exceptions and print a more detailed error. Change-Id: Ied98c6d0bc0410eb8b9cb2a98f7264e980c2bb28 Reviewed-on: https://code.wireshark.org/review/37529 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris3-4/+4
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-13Windows: upgrade Npcap to 0.9994Pascal Quantin1-4/+4
Change-Id: I96475046236312701bfa8e9b36dc55b2a72755c4 Reviewed-on: https://code.wireshark.org/review/37470 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-06-13macos-setup: Add iLBC.Gerald Combs1-0/+53
Change-Id: Ibdea3918a24b4c248fd5f3d524b8546e917e4ea0 Reviewed-on: https://code.wireshark.org/review/37356 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-06-13macos-setup.sh: Update GNUTLS, NETTLE and GMP versionsJoerg Mayer1-5/+5
Fix patch location for non-default build directory Change-Id: I8454e77de1cec53609bd7ab7f565b06b1ad79923 Reviewed-on: https://code.wireshark.org/review/37325 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-06-11cppcheck.sh: Add support for xml output with '-x'Moshe Kaplan1-2/+9
Add an option of '-x' to tools/cppcheck.sh to support XML output. Change-Id: I2921d7cd57ee9c925419247a0238b572f637c854 Reviewed-on: https://code.wireshark.org/review/37424 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-06-10checklicenses: Add a --list-allowed option.Gerald Combs1-7/+10
Add an option to list our allowed licenses. Remove a couple of GTK+ entries while we're here. Change-Id: I1c8cf3314cff369766f1ba25438f16c69f42a1ba Reviewed-on: https://code.wireshark.org/review/37409 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-06-08Windows: upgrade Npcap to 0.9993Pascal Quantin1-4/+4
Change-Id: Ibea3abb6e3938676ecaffa8279db22c9f78b81f8 Reviewed-on: https://code.wireshark.org/review/37408 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-06-08Tools: Use better terminology.Gerald Combs2-18/+18
"Allowed" is a perfectly fine, non-biased word for designating things that are allowed. Change-Id: Ia1e0642a073210f0475fba3d437eac654ec36cb5 Reviewed-on: https://code.wireshark.org/review/37397 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-22Windows: upgrade USBPcap to 1.5.4.0Pascal Quantin1-4/+4
Change-Id: I1414b2f0550a8e498fbf8d688119ffc42837c0ee Reviewed-on: https://code.wireshark.org/review/37281 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com> Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-05-06IDL: Clean up IDL based dissector generationJaap Keuter2-25/+8
Clean up the generators and generated dissectors a bit by updating the header, removing unwanted includes and completing the modelines block. Change-Id: I8ff80b05bb598c3fa5a5f91a24d5caba87eb712e Reviewed-on: https://code.wireshark.org/review/37154 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-05IDL: make code generation reproducibleJaap Keuter1-9/+10
The current state of generated code from the IDL specification is not reproducible with the current omniidl backend. This change brings the backend in line with the currently committed generated source code. The exception to this is that the exceptions (no pun intended) were collected in a dictionary of unspecified ordering, therefore inherently non-reproducible. These thus differ from the previously committed source code (packet-parlay.c), but do contain the same lines. Also this rolls back commit 443df9389661901e8347f33864e2cd7539dbda9f because the committed generated source files were not created with the backend with this change, nor do they fail to build, as claimed in that commit. Special thanks to Luke Mewburn for working on the dictionary problem. Change-Id: I7707746d263c7556eb06883c877f70f0e9b357c5 Reviewed-on: https://code.wireshark.org/review/37153 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-05Windows: upgrade Npcap to 0.9991Pascal Quantin1-4/+4
Change-Id: I5c664a26ede1a5904d4f02a38c43af6c15dce5f9 Reviewed-on: https://code.wireshark.org/review/37152 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-04-19travis: remove Windows supportPeter Wu5-317/+0
The Windows builds have been stuck for a while because the Qt project changed their installers which prevented the installers from finishing. Remove support because 1) the Qt installer will most likely continue to break over time as it did in the past, several times, 2) Travis CI uses Bash which is a non-standard environment on Windows, and 3) other CI platforms such as GitHub Actions started providing Windows support. Remove Windows from the Travis CI builds and all related supporting files as well. They can be restored once the Qt automation is fixed. Bug: 16501 Change-Id: I911491587a23f339aa6d6ffcfb6faffe234e5e91 Reviewed-on: https://code.wireshark.org/review/36887 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-04-13Standardise IETF RFC and Draft URLs in dissectors.Martin Mathieson1-0/+199
Prefer: - html (rather than txt) - https Also includes the script check_dissector_urls.py, that can be used to find links in code and test them. Change-Id: Iafd8bb8948674a38ad5232bf5b5432ffb2b1251b Reviewed-on: https://code.wireshark.org/review/36821 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-04-06Windows: upgrade Npcap to 0.9990Pascal Quantin1-4/+4
Change-Id: I41fb7e78b688f6be0c3f93dafe3a651a41728288 Reviewed-on: https://code.wireshark.org/review/36727 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-19Windows: upgrade Npcap to 0.9989Pascal Quantin1-4/+4
Change-Id: I33b58029d2017cda090a55960089b048de7f9224 Reviewed-on: https://code.wireshark.org/review/36508 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-16tools: do not install doxygenPeter Wu5-5/+1
Most people will never generate API documentation by running the 'wsar_html' target and will not notice any feature degradation. On Ubuntu 18.04, doxygen depends on libclang1-6.0 (and indirectly libllvm6.0), 108M can be saved by not installing these. Change-Id: I51b58f4106696b5475c48afcdaed256f9a97cc81 Reviewed-on: https://code.wireshark.org/review/36416 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-08tools: add additional params to macos-setup-brew.sh.Dario Lombardo1-1/+1
Change-Id: If43fe1344003d0a2d66cd30bcc701ea92054f9b7 Reviewed-on: https://code.wireshark.org/review/36267 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2020-03-07Windows: upgrade Npcap to 0.9988Pascal Quantin1-4/+4
Bug: 16329 Change-Id: I3348049369c55bf84380d90fc699c8d1d8604c58 Reviewed-on: https://code.wireshark.org/review/36323 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-02-26tools: add missing packages to macos-setup-brew.Dario Lombardo1-7/+6
Change-Id: Ie3068a3f6fa64319d8a4d84e6f57b06e6fac3408 Reviewed-on: https://code.wireshark.org/review/36174 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-02-24rpm-setup: Get rid of unary operator expected warning.Anders Broman1-0/+1
Change-Id: Id43f39c4d662d69a292ac433ee48fab72256a156 Reviewed-on: https://code.wireshark.org/review/36168 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-18macos-setup: Update Gcrypt to 1.8.5.Gerald Combs1-2/+2
This is required for WireGuard decryption. Change-Id: I8d27ac198a8bac161c1675e87c3685c8d73c9246 Reviewed-on: https://code.wireshark.org/review/36129 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-02-09RPM: fix missing qt5-linguist dependency, simplify installed packagesPeter Wu1-15/+10
Remove unnecessary Qt5SVG build dependency. Do not install Qt4 qt-devel. qt5-qtbase-devel is big, try to avoid pulling unnecessary deps. Change-Id: Id289bea10ea89de6b7a3ea77996d861ff7354560 Reviewed-on: https://code.wireshark.org/review/36058 Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-04Windows: upgrade Npcap to 0.9987Pascal Quantin1-4/+4
Change-Id: I6f1fcbb49b0002a4273fea449cd7346f4f0f1f58 Reviewed-on: https://code.wireshark.org/review/36031 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-02-02tools: add lua to bsd-setup.sh.Dario Lombardo1-0/+1
Change-Id: I16a5aefa11f3c73ebdd69d972136980b630892e1 Reviewed-on: https://code.wireshark.org/review/36011 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-29tls: update list of known CT logs to 2019-12-23Peter Wu1-6/+15
The old URL was gone and the JSON scheme has changed, so update the generator accordingly. Change-Id: I52ae27c7fc7dc0100e8abaa7b95b1769a7413bc6 Reviewed-on: https://code.wireshark.org/review/35983 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-26tools: add missing package to bsd-setup.Dario Lombardo1-0/+3
Change-Id: I80da65063bdabc99a3ca0dd722df710be34f1285 Reviewed-on: https://code.wireshark.org/review/35955 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-23tools: fix check in bsd-setup.Dario Lombardo1-1/+1
Change-Id: I3ad5793d6aeca54fc84c82b226311c0e6777c1df Reviewed-on: https://code.wireshark.org/review/35922 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-21Windows: fix win32 libilbc packagePascal Quantin1-2/+2
Change-Id: Ia59556092bce0694ba74a25fb10fdca4ee540a57 Reviewed-on: https://code.wireshark.org/review/35893 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-21tools: minor changes in bsd-setup script.Dario Lombardo1-4/+4
Changes: - use bash - fix list checks Change-Id: Idb933155035091974460d6957a9f6a223f6680dc Reviewed-on: https://code.wireshark.org/review/35872 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-20toold: add libilbc to bsd-setup.Dario Lombardo1-0/+4
Change-Id: I471b6936cef3df0ed9aaf6cc4421ac9fa47ad27c Reviewed-on: https://code.wireshark.org/review/35873 Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Jirka Novak <j.novak@netsystem.cz> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-20RTP: decode iLBC payloadJirka Novak3-2/+12
It is possible to decode iLBC payload. It uses libilbc library (https://github.com/TimothyGu/libilbc). Bug: 16314 Change-Id: Id4cad7ae32305a0e94ef32beb24e07733d7f834e Reviewed-on: https://code.wireshark.org/review/35686 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-17macos-setup.sh: Add SpeexDSP setup and installJoerg Mayer1-1/+54
Change-Id: I3558d398970d919b8e12992ad4c97789aac79129 Reviewed-on: https://code.wireshark.org/review/35785 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-17pfcp: Update to 3GPP TS 29.244 V16.2.0 part3Joakim Karlsson1-0/+1
Change-Id: Id6c50426a586405db9f15bf16bc6b6d503b9848e Reviewed-on: https://code.wireshark.org/review/35844 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-13Gen-bugnote: Another encoding fix.Gerald Combs1-3/+7
Change-Id: Icf9fe7cd392cce2dac8ba45854c9f4c00a80dd38 Reviewed-on: https://code.wireshark.org/review/35791 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-13Gen-bugnote: Fix an encoding issue.Gerald Combs1-1/+4
Change-Id: I0b193bc2dfa68de98d53b2443773d121801271e8 Reviewed-on: https://code.wireshark.org/review/35786 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-11ber: display x509af.utcTime year in 4 digitsAndre Luyer1-1/+1
Because: - the 2-digit year can only be in the range 1950..2049 according to https://tools.ietf.org/html/rfc5280#section-4.1.2.5.1 - to avoid confusion, interpreting the year/month/day in a different order may still represent a valid date. - now both utcTime and GeneralizedTime are displayed in exactly the same way. - some tools, like Perl, apply a different date range when converting 2-digit years. In packet-ber.c two parameters are added to the function dissect_ber_UTCTime: datestrptr: if not NULL return datetime string instead of adding to tree or NULL when packet is malformed tvblen: if not NULL return consumed packet bytes Also the memory allocation for outstr is now done using the recommended method as described in the README.developer document. The calling function in x509af/x509sat uses this to prepend the century. Added generated files. Change-Id: I714c2e8e7f899211caaa1f4136ca0d27cb1aba4a Reviewed-on: https://code.wireshark.org/review/35414 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-07AUTHORS: remove newlines.Dario Lombardo1-20/+8
The text is used in a Qt widget that handles the newlines itself. The change makes the text appear with a better look in the about dialog. Change-Id: I1dc9fdd1f401384f4ce2d6c2c0764adaa810a654 Reviewed-on: https://code.wireshark.org/review/35662 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-05tools: Make compress-pngs a standard utility.Gerald Combs1-16/+15
Switch from using `find` to find PNGs to simply accepting a list of files as arguments. Pass long arguments to some compressors. Change-Id: I37884049026fea714d0dd30b08496744c6272379 Reviewed-on: https://code.wireshark.org/review/35646 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-02make-manuf.py: Add "of" to the general terms list.Gerald Combs1-0/+1
Add "of" to the list of general terms to remove when shortening. Change-Id: Idbfea2d502a89d668ba2f170bf3450cfcbb91fe5 Reviewed-on: https://code.wireshark.org/review/35627 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-31LPP: upgrade dissector to 37.355 v15.0.0Pascal Quantin1-2/+2
3GPP decided to transfer the specification from 36.355 to 37.355 now that it covers NR also. 37.355 v15.0.0 is equivalent to 36.355 v15.5.0. Change-Id: I63aba21f55861ffd8a5c0adbd307b0453482baaa Reviewed-on: https://code.wireshark.org/review/35613 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-29make-manuf.py: Fix a shortening error.Gerald Combs1-1/+8
Handle cases where we might shorten a name (e.g. "ZAO") down to nothing. Change-Id: I5ecb9592d2ecd8225d0ed459ef16885214af5da4 Reviewed-on: https://code.wireshark.org/review/35584 Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 07:09:59 +0000