aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2012-12-13General cleanup:Bill Meier9-1887/+2424
- Localize some variables; remove unneeded initializers; - Reformat some hf[] entries; - Whitespace; style; long lines. svn path=/trunk/; revision=46529
2012-12-13Remove some commented out code as per Wido Kelling:Bill Meier2-15/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8002#c9 svn path=/trunk/; revision=46527
2012-12-12General cleanup:Bill Meier4-2631/+2892
- Don't call expert...() under 'if (tree)'; - Make some functions static; - Localize some variables; remove some uneeded initializers; - Reformat some hf[] entries; - Do whitespace fixes (including "4 space tabs"). svn path=/trunk/; revision=46523
2012-12-12From Wido Kelling: [Profinet] Updated disecction regarding the IEC 61158Bill Meier7-264/+1177
(with a few minor fixes by me). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8002 major change: reassembling of PNIO fragments (only works if OpenSafty dissector is disabled) minor changes: improved handling of DFP Frames added / updated MRP Block decoding ARServerBlock ARVendorBlock PDInterfaceDataReal PDInterfaceAdjust PDPortStatistic SubdirFrameData corrected display and subblocks added PDIRGlobalData complete dissection decoding of FrameDataProperties and ARTypes updated to conform the STD removed now usuported RTC2 ranges svn path=/trunk/; revision=46522
2012-12-10General cleanup:Bill Meier1-142/+137
- Use/create extended value strings as appropriate; - Reformat hf[] entries; - Do whitespace, & etc changes to use a consistent formatting style; - Reformat some long lines; - Localize some variables; remove some unneeded initializers; - expert...() shouldnt be called under 'if (tree)' (packet-wimaxasncp); - Move proto_register...() & etc to the end of the file (packet-ieee80211); - Misc. svn path=/trunk/; revision=46489
2012-12-07Bump revission.Anders Broman1-1/+1
svn path=/trunk/; revision=46447
2012-12-07From hannes:Anders Broman1-1/+4
'Fix for displaying the payload of the first chunk correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068 svn path=/trunk/; revision=46445
2012-12-07From hannes:Anders Broman3-15/+230
Enable the plugin to detect and reassemble chunked UA messages for displaying them correctly. From me: - Partly applied by hand. - move hf and ett asignments inseide the register routine as per convention. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068 svn path=/trunk/; revision=46436
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier6-45/+45
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-11-29Add a checkapi target.Jeff Morriss1-3/+6
svn path=/trunk/; revision=46296
2012-11-29Fix several [-Wshadow] warnings.Bill Meier2-14/+12
svn path=/trunk/; revision=46287
2012-11-28Fix [-Wshadow] warning;Bill Meier1-626/+632
Also: - remove some uneeded variable initializers; - reformat some long lines; - do some whitespace and formatting changes to use a consistent style. svn path=/trunk/; revision=46272
2012-11-28Fix :Alexis La Goutte1-1/+2
CMake Warning (dev) at CMakeLists.txt:476 (add_subdirectory): The source directory /home/wireshark/plugins/wimaxmacphy does not contain a CMakeLists.txt file. CMake does not support this case but it used to work accidentally and is being allowed for compatibility. Policy CMP0014 is not set: Input directories must have CMakeLists.txt. Run "cmake --help-policy CMP0014" for policy details. Use the cmake_policy command to set the policy and suppress this warning. This warning is for project developers. Use -Wno-dev to suppress it. svn path=/trunk/; revision=46267
2012-11-22Revert http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46140Anders Broman6-1218/+205
looks like the worong variables may be used in the for loops. ../../../plugins/profinet/packet-dcerpc-pn-io.c: In function 'dissect_PDInterfaceMrpDataAdjust_block': ../../../plugins/profinet/packet-dcerpc-pn-io.c:4420:12: warning: variable 'u8MrpInstance' set but not used [-Wunused-but-set-variable] ../../../plugins/profinet/packet-dcerpc-pn-io.c: In function 'dissect_PDInterfaceMrpDataReal_block': ../../../plugins/profinet/packet-dcerpc-pn-io.c:4542:5: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] ../../../plugins/profinet/packet-dcerpc-pn-io.c:4491:12: warning: variable 'u8MrpInstance' set but not used [-Wunused-but-set-variable] ../../../plugins/profinet/packet-dcerpc-pn-io.c: In function 'dissect_PDInterfaceMrpDataCheck_block': ../../../plugins/profinet/packet-dcerpc-pn-io.c:4570:12: warning: variable 'u8MrpInstance' set but not used [-Wunused-but-set-variable] ../../../plugins/profinet/packet-dcerpc-pn-io.c: In function 'dissect_MrpInstanceDataCheck_block': ../../../plugins/profinet/packet-dcerpc-pn-io.c:5426:160: error: unused parameter 'u16BodyLength' [-Werror=unused-parameter] ../../../plugins/profinet/packet-dcerpc-pn-io.c: In function 'dissect_ARBlockReq_block': ../../../plugins/profinet/packet-dcerpc-pn-io.c:6873:9: error: format '%x' expects a matching 'unsigned int' argument [-Werror=format] ../../../plugins/profinet/packet-dcerpc-pn-io.c:6811:13: warning: variable 'u16ARDevAccess' set but not used [-Wunused-but-set-variable] ../../../plugins/profinet/packet-dcerpc-pn-io.c: At top level: ../../../plugins/profinet/packet-dcerpc-pn-io.c:7628:1: error: 'dissect_IRTFrameBlock_block' defined but not used [-Werror=unused-function] cc1: all warnings being treated as errors svn path=/trunk/; revision=46142
2012-11-22From Wido Kelling:Anders Broman7-207/+1220
Updates to conform IEC 61158. major change: reassembling of PNIO fragments (only works if OpenSafty dissector is disabled) see Bug 7997 minor changes: improved handling of DFP Frames added / updated MRP Block decoding ARServerBlock ARVendorBlock PDInterfaceDataReal PDInterfaceAdjust PDPortStatistic SubdirFrameData corrected display and subblocks added PDIRGlobalData complete dissection decoding of FrameDataProperties and ARTypes updated to conform the STD removed now usuported RTC2 ranges https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8002 svn path=/trunk/; revision=46140
2012-10-31Add CRC verification to Modbus RTU dissector. CRC algorithm is the same as ↵Michael Mann1-2/+2
the "crc16-plain" with a different initial CRC (0xFFFF instead of 0). Created crc16_plain_tvb_offset_seed to "replace" crc16_plain_tvb_offset, but didn't remove crc16_plain_tvb_offset for backwards compatibility worries. Updated only dissector that used crc16_plain_tvb_offset (profinet/packet-pn-rt.c) to use crc16_plain_tvb_offset_seed(..., 0) svn path=/trunk/; revision=45854
2012-10-26Create SET_ADDRESS_HF that takes an additional hf_ value that can beEvan Huus1-1/+1
used to override the filter generated from the address column. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728 (again). svn path=/trunk/; revision=45792
2012-10-26Revert revision 44921.Evan Huus1-1/+1
See discussion on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728 svn path=/trunk/; revision=45791
2012-10-10Based on patch from Bill Parker, check for ws_fopen() failing.Guy Harris1-6/+10
The rest of the code already checks for namelist being null, so it's OK to call build_tree_view() - and it may be necessary to do so, as the code below might assume that's worked. However, we should not call fclose() on namelist if it's null; the C89 standard, at least, does *not* assert that fclose(NULL) is a no-op. Clean up indentation a little bit. Last part of fix for bug 7824. svn path=/trunk/; revision=45455
2012-09-30Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=45219
2012-09-30From Yu Zhang via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7769Alexis La Goutte1-1/+22
Add Dissector for SuboptionDeviceInstance under DevicePropertiesOption in PROFINET DCP In PROFINET DCP dissector, current build didn't have SuboptionDeviceInstance (0x07) under DevicePropertiesOption (0x02). This patch add the support of SuboptionDeviceInstance svn path=/trunk/; revision=45218
2012-09-26replace unnecessary decode_numeric_bitfield callsMichael Mann1-18/+9
svn path=/trunk/; revision=45154
2012-09-25Implement and document the Custom plugin system. Create relevant example ↵Jaap Keuter4-18/+23
files and add them to the distribution. Rewrite README.plugins to describe how to use this system. svn path=/trunk/; revision=45142
2012-09-23Store pointers to previously displayed and captured packet, not nstime_t deltas.Jakub Zawadzki1-2/+0
This commit reduces size (from 144B to 128B on AMD64) of frame_data structure. Part of bug 5821: Reduce per-packet memory requirements. svn path=/trunk/; revision=45071
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss131-308/+46
svn path=/trunk/; revision=45015
2012-09-15From Pontus Fuchs via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728Evan Huus1-1/+1
Make right-click + apply-as-filter work in the packet list for non-ethernet frames (such as ieee 802.11 frames). svn path=/trunk/; revision=44921
2012-09-11Add data parameter to dissector_try_heuristicJakub Zawadzki3-5/+5
svn path=/trunk/; revision=44871
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki12-22/+22
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-24Fix a trivial typo.Bill Meier1-2/+2
svn path=/trunk/; revision=44660
2012-08-23Remove commented out rulesJörg Mayer1-1/+0
Whitespace fixes svn path=/trunk/; revision=44629
2012-07-30Fix Coverity CID's 712344-712345: Unused pointer value.Chris Maynard1-2/+2
svn path=/trunk/; revision=44135
2012-07-27Fix two "set but unused variable" warnings turning errors:Jörg Mayer1-1/+2
- Comment out hdrbits, it's retrieved but not used (slightly different approach to overwritten patch) - Change two instances of pt to tree as this *may* have been the intention svn path=/trunk/; revision=44061
2012-07-27Remove unused variable, use the created subtree. Found by buildbot.Anders Broman1-4/+3
svn path=/trunk/; revision=44059
2012-07-26You can't (well, shouldn't) reference and modify a given variable multipleJeff Morriss1-27/+22
times in one C statement: the order of references and modifications is undefined. Anyway I don't think the modification is intentional: just divide instead of divide-and-assign. Also remove what looks to be some test code (only executed for frame number 11). svn path=/trunk/; revision=44056
2012-07-26Converted many proto_tree_add_text -> proto_tree_add_item (or at least ↵Michael Mann1-833/+1355
something that's filterable). since Gryphon is used as the flagship example for plugins, I don't want developers to get the impression proto_tree_add_text is the way to add fields in Wireshark. Hopefully this will reduce the number of dissectors submitted with too many proto_tree_add_text()s. svn path=/trunk/; revision=44055
2012-07-25- Call dissector_add-handle() so protocol isBill Meier1-0/+16
available under UDP 'decode as'; - Back out use of extended value strings (added in SVN #43942); 'tshark -G values' on Windows gives a warning as to 'Invalid value_string_ext ptr'. Issue: On Windows, value_string_ext validation code always fails for extended value strings in plugins. (Something todo with the linkage mechanism). svn path=/trunk/; revision=44011
2012-07-23Cleanup:Bill Meier1-432/+434
- don't call col_...() and expert...() fcns under 'if (tree)'; - create/use extended value strings in a few cases; - use val_to_str_ext_const(); - Don't increment offset if not used afterwards [set but unused]; - do whitespace cleanup (indentation, trailing, ...). svn path=/trunk/; revision=43942
2012-07-20Fix a bit too much copy pasteJörg Mayer1-4/+0
svn path=/trunk/; revision=43853
2012-07-20Add missing CMakeLists.txtJörg Mayer1-0/+69
svn path=/trunk/; revision=43851
2012-07-20Add SVN eol-style and keywords propertiesPascal Quantin6-6032/+6032
svn path=/trunk/; revision=43848
2012-07-20Fix some misplaced tree items, as caught by cppcheck (as unused variables).Evan Huus1-10/+10
svn path=/trunk/; revision=43845
2012-07-20WiMAX OFDMA PHY SAP dissector plugin ↵Michael Mann13-2/+6228
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2695) svn path=/trunk/; revision=43844
2012-07-16Fix compilation error seen with gcc on Unix:Stephen Fisher1-1/+1
pinfo_stats_tree.c:234:2: error: no newline at end of file svn path=/trunk/; revision=43755
2012-07-15From Wonil Kim: Enable statistics menu register for the tap plug-in. Fixes ↵Anders Broman1-5/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7466 svn path=/trunk/; revision=43726
2012-07-09From Evan Huus:Anders Broman1-6/+0
Grab-bag of unused variables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452 svn path=/trunk/; revision=43616
2012-07-08UATs could be put into "categories". The categories were defined onlyGuy Harris1-1/+1
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. svn path=/trunk/; revision=43603
2012-07-07From Michael Mann:Guy Harris1-2/+99
Add a preference for the packet length statistics. Fixes bug 3239. svn path=/trunk/; revision=43597
2012-07-05From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7439 :Pascal Quantin1-4/+5
Add support for DOCSIS 3.0 AES keys svn path=/trunk/; revision=43573
2012-06-28Update FSF address - part II.Jakub Zawadzki75-87/+87
svn path=/trunk/; revision=43538
2012-06-28Update Free Software Foundation address.Jakub Zawadzki131-131/+131
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536