aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2017-10-15autotools: make maintainer-clean should allow rerunning 'configure'João Valverde15-39/+0
Change-Id: Iedae94ffefe27b13b1967d69cacb757b5aa4576d Reviewed-on: https://code.wireshark.org/review/23928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Remove superfluous null-checks before strdup/freeAhmad Fatoum1-1/+1
NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-13docsis: fix ↵Alexis La Goutte1-6/+6
'docsis_vsif.gex.sav.spr.static_prefix_address/.gex.imja.imja_ssr_source_prefix_address/.imja.imja_ssr_group_prefix_address' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 Change-Id: I7c978870eb3cc54e718fe3c810f7b4e7f6ea67c9 Reviewed-on: https://code.wireshark.org/review/23897 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-13docsis: fixAlexis La Goutte1-1/+1
'docsis_vsif.gex.extended_cmts_mic_hmac_type' exists multiple times with NOT compatible types: FT_BYTES and FT_UINT8 Change-Id: Ic3a0f7f6edf5a28ffde6703276d4747d138081c7 Reviewed-on: https://code.wireshark.org/review/23896 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-13WiMAX ASN CP: Leak less memory.Gerald Combs2-59/+52
Replace some g_new()s, g_strdup()s and GArrays used in prefix registration with their epan_scoped wmem equivalents. This reduces the amount of memory we leak so that we come in below the Valgrind fuzzer's current threshold (102400). Bug: 14106 Change-Id: I7308ac89465316c06773552253dabc876b6c2425 Reviewed-on: https://code.wireshark.org/review/23891 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-06DOCSIS: added vsif general extension dissectionBruno Verstuyft1-5/+614
Change-Id: Ic61815b967fac412fb1a324c470ff5171b97acbb Reviewed-on: https://code.wireshark.org/review/23840 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-04DOCSIS: added dissection of IPv6 classifier TLVBruno Verstuyft2-1/+221
Change-Id: I49a920c2d93dbbc0ae9f8152922485a14225ea9e Reviewed-on: https://code.wireshark.org/review/23822 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-03wimax(-int.h): no newline at end of file [-Wnewline-eof]Alexis La Goutte1-1/+1
Change-Id: I863fe195f314301e2ecd92638e42a0f11dd2af9b Reviewed-on: https://code.wireshark.org/review/23826 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-03Add version check for plugin compatibilityJoão Valverde1-1/+2
Only plugins built for the same feature release (X.Y) are assured binary compatibility. Make sure we don't try to run unsuitable code and, if so, warn the user. This might happen for example if the user manually copies a binary plugin to the wrong folder, intentionally or by accident. I'm using "release version" to loosely mean not a patch release (i.e: a feature release). Change-Id: I896e9cbbd2d3843623fff6af8ef51002ec06f1f8 Reviewed-on: https://code.wireshark.org/review/23807 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-02PROFINET: Fix undecoded signal value in DCP Set Request.Birol Capa1-1/+13
According to specification, when suboption is CONTROL, signal value is FLASH_ONCE. Change-Id: I942579cdf3d642e636d02b778ffaad99022678e3 Reviewed-on: https://code.wireshark.org/review/23812 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-01Unsplit "m2m" plugin (wimax mac-to-mac encapsulation)João Valverde15-796/+8
... not to be confused with "machine-to-machine". M2M seems to be a simple Wimax encapsulation protocol developed by Intel. It's not documented publicly anywhere that I can find. The boilerplate to code ratio is huge and it even includes a complete source file from the Wimax dissector (yuck). Put it in the Wimax plugin instead. Minor version number bump for wimax plugin. Change-Id: I2694339dfe89be334093b257a5b34d1577f4dc20 Reviewed-on: https://code.wireshark.org/review/23790 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-30Fix make distcheckJoão Valverde1-1/+2
Change-Id: I6fc298c5c320fcdbc117ff2ec261e6fe335e178c Reviewed-on: https://code.wireshark.org/review/23792 Reviewed-by: João Valverde <j@v6e.pt>
2017-09-30WiMAX: Fix possible crash during protocol registrationJoão Valverde15-37/+84
proto_register_wimax() cannot be assumed to run before all other dissectors that depend on the global proto_wimax variable. It happens to work now but registration order is never guaranteed and cannot be relied upon. Wireshark will crash with a null pointer dereference if proto_register_wimax() is not run first. Have proto_register_wimax() call the registration routine for the other dissectors that depend on proto_wimax to impose the hard-coded order. Change-Id: I3e9a9ea742f3feeb5b802ad79cfc9ed916264d2f Reviewed-on: https://code.wireshark.org/review/23788 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-28Remove TPG plugin and dependenciesJoão Valverde4-510/+0
It doesn't build with autotools and CMake. Under-documented and unmaintained. Seems to be a work-in-progress that stalled. Introduces spurious CMake dependency on yapp. Change-Id: I0dca1ccbdfd683586c05765437d4b7804ab5cc70 Reviewed-on: https://code.wireshark.org/review/23758 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-26Remove "easy_codec" sourceJoão Valverde11-565/+0
It's dead, unmaintained and unfinished. Not in a good enough state to live in the tree. Change-Id: I6a5c391503b5237638f8362fb9f0492c4cf36223 Reviewed-on: https://code.wireshark.org/review/23745 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-26DOCSIS: Adding Attribute masks to Service FlowBruno Verstuyft2-0/+58
Change-Id: I626b8a1d85e3062c58f9e3bd7bd6c6123c4b8272 Reviewed-on: https://code.wireshark.org/review/23749 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-09-25Docsis: fix an infinite loopPascal Quantin1-0/+14
Add missing decrement of concatlen based on master-2.2 version. Bug: 14080 Change-Id: I00f7e34f8e599718316a4ce8916d91b780ec7c14 Reviewed-on: https://code.wireshark.org/review/23663 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-19Disable flex-generated [-Wsign-compare] warningsJoão Valverde2-0/+8
Change-Id: Iace0462e6bb50573f3e4603f7a19e4b7ee1f9733 Reviewed-on: https://code.wireshark.org/review/23541 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-16_U_ is wrong in c++, as is Q_UNUSED (in most cases).Joerg Mayer1-2/+1
The correct way is to not name the variable. Change-Id: Ic016f1b9161db6b4cc3f6534c853a1f50e31aa2b Reviewed-on: https://code.wireshark.org/review/23569 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-15epan: Fix misuse of comma operatorStig Bjørlykke1-1/+1
Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c Reviewed-on: https://code.wireshark.org/review/23558 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15Qt: Use Q_UNUSED macro for unused argumentsStig Bjørlykke1-1/+2
Change-Id: I4bf7fe4ba3e3e6575e6537a8ec2b6024c253e776 Reviewed-on: https://code.wireshark.org/review/23559 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-09packet-dcerpc-pn-io.c: Fix potential resource leakshqking1-0/+6
Bug: 13826 Change-Id: I01674d5a31281508686bc06e222d6a87926d1c83 Reviewed-on: https://code.wireshark.org/review/23436 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-08DOCSIS: Fix compiler warning on macOS.Michael Mann1-1/+1
Previous functionality presumed cat = 0, so initialize cat to it. Change-Id: Ic0fdccc8222dfb435178416911d35bac105c6c03 Reviewed-on: https://code.wireshark.org/review/23434 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-08DOCSIS: Ensure docsis_ucd has a registered dissection functionMichael Mann1-1/+3
Bug: 14038 Change-Id: I36fbaa591a7ebf5da7d2e7be837e8fcca30c7f98 Reviewed-on: https://code.wireshark.org/review/23432 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-07DOCSIS: Added support for version 5 MAPs (dissect_map_v5)Bruno Verstuyft1-27/+188
Change-Id: Icc43fdc341a8f263af5d7b9e1bc14e13b5361dd0 Reviewed-on: https://code.wireshark.org/review/23392 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-06CMake: Make plugin installation path use PLUGIN_INSTALL_LIBDIRJoão Valverde16-48/+48
Change-Id: I47f248f6ef56aba400054fa3ade2bf4d29eeb895 Reviewed-on: https://code.wireshark.org/review/23411 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-05Fix memory leak in wimaxasncpAhmad Fatoum1-2/+2
Remove unnecessary null-check before free as well. Change-Id: Ic54459149b40fd8c8f58c643bbd6cfc81ee8b923 Reviewed-on: https://code.wireshark.org/review/23398 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-04Extra decodings for DOCSIS MDD messageBruno Verstuyft1-0/+189
Change-Id: I8765c96717d80f2b340428eb025e0a1e52a6e495 Reviewed-on: https://code.wireshark.org/review/23353 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-03Extra decodings for DOCSIS RNGRSPBruno Verstuyft1-5/+217
Change-Id: I27ad1143dc5c568a3c7cced4f61c11e45485c7f4 Reviewed-on: https://code.wireshark.org/review/23354 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-08-28transum: clear the list of wanted hfids in file cleanup routinePeter Wu1-6/+9
Be sure to disable the wanted hfids list when the transum dissector is cleaned up, otherwise it will leak memory when reloading a file while the transum dissector is enabled. Change-Id: I2af8edab89da8b3cfb65e19726e1d2546a1dc8d4 Reviewed-on: https://code.wireshark.org/review/23261 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-28PNIO: Fix another potential OOB write.Gerald Combs1-2/+3
Bug: 13847 Change-Id: I62bb519b8e37112a59a7d209b39780f034dbcd0c Reviewed-on: https://code.wireshark.org/review/23267 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-23Fix potential oob write crashesUlf1-6/+6
Bug: 13847 Change-Id: I3a706db25204fe4c1fd1b7be3b17b8c55365dccf Reviewed-on: https://code.wireshark.org/review/23169 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-18TRANSUM fails with DCE-RPC request Packet Type 0Paul Offord2-4/+4
TRANSUM fails to calculate RTE figures for DCE-RPC where request Packet Type is zero Bug: 13988 Change-Id: I1dd7aee0283042703530a6d72fff063279e6147e Reviewed-on: https://code.wireshark.org/review/23115 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-31IrCOMM: check string length before appending it to itemPascal Quantin1-2/+8
Bug: 13929 Change-Id: I33f3fec77014949fcc15df72c42ffcb25158562f Reviewed-on: https://code.wireshark.org/review/22887 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-19dcerpc-pn-io (profinet): fix typo for pn_io.iops display filterAlexis La Goutte1-1/+1
Change-Id: I8422005703c9e0a04d067dfe5ba501fe7417ff8a Reviewed-on: https://code.wireshark.org/review/22718 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-09Don't use uint_to_str_back when you need guint32_to_str_buf.Michael Mann1-4/+2
It will end up eventually crashing column buffers because memory behind the address is trounced. Change-Id: Id6b5a42effc503e4b8bf5e1deb2135241e2893f3 Reviewed-on: https://code.wireshark.org/review/22563 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-03mate_grammar(lemon): fix this statement may fall through ↵Alexis La Goutte1-1/+2
[-Werror=implicit-fallthrough] found by gcc7 Change-Id: Id26c1c0d1678613a90ff7707265ec062cd30cf83 Reviewed-on: https://code.wireshark.org/review/22501 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-26Parse enterprise-numbers at run timeJoão Valverde1-1/+1
"enterprise-numbers" is converted to tab-separated values and renamed "enterprises". Unused fields are stripped. PENs are stored in a hash table loaded at run-time. User "enterprises" file is loaded from the personal config dir. Misc make-sminmpec.pl improvements and fixes. Note: names of type "Entity (formerly ...)" have the formerly part commented out for a cleaner output. Change-Id: I60c533afbe3e399077fbf432088064471ad3e1e2 Reviewed-on: https://code.wireshark.org/review/22246 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2017-06-19PROFINET IO: define an arbitrary recursion depth limitPascal Quantin1-3/+12
Bug: 13811 Change-Id: I52bffd4a79dcdad9da23f33e1fc6a868472390bf Reviewed-on: https://code.wireshark.org/review/22232 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14DOCSIS: Prevent infinite loop from unknown FCParm.Michael Mann1-0/+4
concatlen was not updated if FCParm was unknown, leading to an infinite loop. Bug: 13797 Change-Id: I1b64d757a369183a711f01b0b5cd1ba7aa0787bc Reviewed-on: https://code.wireshark.org/review/22120 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-07profinet: use proto_tree_add_item_ret_(u)int directlyMartin Kaiser5-43/+26
Profinet defined functions to add 32bit integers to the tree and get their value. This is equivalent to proto_tree_add_item_ret_(u)int. Call those functions directly and remove the now obsolete Profinet functions. In some cases, the returned 32bit value is discarded. Use proto_tree_add_item then. Change-Id: I7744fab2f27b8ae8e681a36e4e96eb2f8be87bd6 Reviewed-on: https://code.wireshark.org/review/21989 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-06profinet: use proto_tree_add_item_ret_(u)intMartin Kaiser1-12/+4
profinet has a number of internal functions that add an item to the tree and read its value. For 32bit integers, this is exactly what proto_tree_add_item_ret_(u)int do. Just call those functions. (We could do the same for 8 and 16bit values. We'd need a temporary value then and the code wouldn't be much easier than it is now.) Change-Id: I98fc70ced2dc5a552235a476d40a4275f3b3bd38 Reviewed-on: https://code.wireshark.org/review/21965 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-06-04profinet dcp: simplify dissect_PNDCP_Suboption_Manuf()Martin Kaiser1-9/+4
There's not much point in having a switch-case block with only a default statement ;-) Change-Id: Iaacd87bb2995783b98e5395b3654a1c8f32c473a Reviewed-on: https://code.wireshark.org/review/21938 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-04profinet dcp: don't THROW() an exception from a dissectorMartin Kaiser1-1/+5
In this case, we can simply replace the exception with an expert info and exit the loop. Change-Id: I232e554af299140d7123b5e21d78372a35a7923b Reviewed-on: https://code.wireshark.org/review/21936 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-04profinet: remove unnecessary if(tree) checksMartin Kaiser1-32/+15
Change-Id: I0c4346386846c03a67b83bebfce6da6323379180 Reviewed-on: https://code.wireshark.org/review/21937 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-31opcua: fix no previous prototype for ↵Alexis La Goutte2-2/+2
‘parseNodeClassMask/parseResultMask’ [-Wmissing-prototypes] Change-Id: If57183bcea978b766fc53f691a35c4ddf98ca2dd Reviewed-on: https://code.wireshark.org/review/21849 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-20If we don't have an ARUUID, don't use it as if we do.Guy Harris1-8/+14
Don't use random on-the-stack data as a UUID. Change-Id: I77961e1404ad73a484a7fc865bc54219dc239b4d Reviewed-on: https://code.wireshark.org/review/21721 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-12DOCSIS: Simplify all MAC Management into a single file.Michael Mann49-14305/+7781
Removes a bunch of duplication set up because commands were all in different files. Change-Id: I950bc70da0edcdef7aaf21a43328cf69267f79af Reviewed-on: https://code.wireshark.org/review/21613 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12OPC UA: Added details for BrowseDescription NodeClassMask and ResultMaskCamille Guérin7-33/+133
Display the details for the NodeClassMask and ResultMask values in a BrowseRequest's BrowseDescription. As described in OPC UA 1.03 Specification, the value 0 for the NodeClassMask and the value 63 (0x003F) for ResultMask should results in returning all the fields in the BrowseResponse. Display 'All' when those fields have those values Display a detailled bit tree mask when values are different Code Change: Added parseNodeClass and parseResultMask Use them in parseBrowseDescription instead of parseUInt32 Removed not needed anymore hf_opcua_NodeClassMask, hf_opcua_ResultMask and their related entries in registerFieldTypes Change-Id: Ic3ed8630825b5456f91156f06b2203ebfa422155 Reviewed-on: https://code.wireshark.org/review/21446 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-10Define YYMALLOCARGTYPE appropriately.Guy Harris1-2/+3
Define it, so the generated parser knows what argument type the function passed to MateParserAlloc() takes. Use it when declaring MateParserAlloc(). Change-Id: Ice18fd6b5fdbdb31f527e5d6eb06e78594d4565b Reviewed-on: https://code.wireshark.org/review/21588 Reviewed-by: Guy Harris <guy@alum.mit.edu>