aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2013-10-13Add CMake properties to targets so that they are logically organised when ↵Graham Bloice15-0/+15
using a Visual Studio solution. Add CMake properties to group the source files in epan into logical blocks when using a Visual Studio solution. svn path=/trunk/; revision=52580
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=52290
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+3
svn path=/trunk/; revision=52289
2013-09-30Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=52288
2013-09-28Fix various warnings in (hopefully) the right ways.Evan Huus7-12/+5
svn path=/trunk/; revision=52236
2013-09-281. Remove PITEM_FINFO from add_tlv_subtree and add_protocol_subtree (as well ↵Michael Mann16-2017/+1427
as some other minor cleanup) and adjust the calling functions accordingly. 2. Converted several add_protocol_subtree calls to add_tlv_subtree to get true filterability. Many of the add_protocol_subtree are effectively being (ab)used as proto_tree_add_text with different highlighting. 3. Convert tvb_new_subset into tvb_new_subset_length. Still looks like some of the remaining "protocols" need more specific filters, and should just be regular FT_BYTES fields. svn path=/trunk/; revision=52235
2013-09-24Prevent crashing as a result of tree removal in r52208. Tree removal + this ↵Michael Mann1-2/+2
patch should be the "quick" fix to bug 5349 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5349). I knew the tree check was preventing some dissection/column data/etc, but from the comments in bug 5349, the tree check was also protecting this (and maybe other) crashes (due to missed NULL checking). I want to follow up with some massive cleanup (remove PITEM_FINFO calls), but this with r52208 should be good enough to backport to 1.8 and 1.10 to fix bug 5349. Cleanup shouldn't need to be backported. svn path=/trunk/; revision=52209
2013-09-24You are in a twisty little maze of code paths, all different. Get ridGuy Harris1-416/+407
of the if (tree) tests in dissect_mac_header_generic_decoder(), as some of the stuff done inside there should be done even if we're not building a protocol tree, e.g. CRC stuff and calling subdissectors. Get rid of a gratuitous pair of curly braces, and fix the indentation of one line, while we're at it. svn path=/trunk/; revision=52208
2013-09-24Stuff used when checking the CRC needs to be done regardless of whetherGuy Harris1-9/+14
we're building a protocol tree or not. svn path=/trunk/; revision=52207
2013-09-24Get rid of unused variable.Guy Harris1-3/+0
svn path=/trunk/; revision=52206
2013-09-24Fix copy-and-pasteo(?).Guy Harris1-2/+2
svn path=/trunk/; revision=52205
2013-09-24One advantage of making as many things as possible static is that, ifGuy Harris1-1/+4
they're not being used, the compiler can be made to warn about that. In this case, Broadcast_Control_Pointer_IE() was used because of a missing case in a switch statement; put that case in. svn path=/trunk/; revision=52204
2013-09-24Wimax dissector improvements:Michael Mann29-1193/+467
1. Remove message type field from all MAC Management "sub"dissectors and place it in Mac Management subdissector itself. This may cause backwards-compatibility issues (malformed packets) with third-party subdissectors of the MAC Management dissector, but it didn't make sense to have so many filters for a single enumerated value, especially when the various "protocol" filters covers many of them. 2. Removed some if(tree) checks as column info and calling other dissectors are sometimes executed underneath. Some of this is in preparation for addressing bug 5349. 3. Make all dissector functions (and a few others) static, and use register_dissector() when necessary. 4. Convert generic decoder CRC errors into expert info, rather than have it be a "protocol" filter (it just looks funny that way) In general, these dissectors seem "over-protocolized". I understand the need for all of the dissectors, but I don't know if they all need "protocol" status. svn path=/trunk/; revision=52203
2013-09-22More emem -> wmem conversion:Pascal Quantin1-1/+1
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-22emem -> wmem conversion:Pascal Quantin3-3/+3
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-22Don't declare proto_mac_mgmt_msg_ucd_decoder twice.Jeff Morriss1-1/+0
svn path=/trunk/; revision=52168
2013-09-22Make dissectors register for their MAC Management Message Type and use ↵Michael Mann31-902/+603
dissector_try_uint to do any dissection. Many "outside" (third-party) message types appear to exist. Have the makefiles do all the work setting up proto_register_<dissector> and proto_reg_handoff_<dissector>, rather than sprinkled throughout the dissectors with extern declarations. More is coming to make more functions static (because of current makefile fixes) and cleanup MAC Management dissectors to remove unnecessary/duplicative code, but I wanted to get the build issues squared away. svn path=/trunk/; revision=52167
2013-09-20Enhance DOCSIS dissector with new fields. Bug 9149 ↵Michael Mann1-5/+86
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9149) From Jerry Negele svn path=/trunk/; revision=52158
2013-09-17emem -> wmemPascal Quantin11-72/+77
svn path=/trunk/; revision=52130
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann6-130/+130
svn path=/trunk/; revision=51850
2013-09-08Convert profinet dissector to use filterable expert info.Michael Mann3-153/+197
NOTE: Some of the expert group values may need to be checked, PI_UNDECODED doesn't always seem like the right choice. I thought PI_PROTOCOL should be used more. This concludes the conversion expert_add_info_format for all dissectors (where the function isn't commented or #defined out). Onto the "internal" (epan/lua) uses of the call. svn path=/trunk/; revision=51841
2013-09-02Fix Function call argument is an uninitialized value Warning found by ClangAlexis La Goutte1-1/+1
packet-dcerpc-pn-io.c:9101:29: warning: Function call argument is an uninitialized value tvbuff_t *new_tvb = tvb_new_subset(tvb, offset, u32RecDataLen, u32RecDataLen); ^ ~~~~~~~~~~~~~ svn path=/trunk/; revision=51687
2013-09-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+0
svn path=/trunk/; revision=51680
2013-09-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=51679
2013-09-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
svn path=/trunk/; revision=51678
2013-08-27Enhance Profinet MRP (Merge LinkUp and LinkDown)Alexis La Goutte1-74/+23
svn path=/trunk/; revision=51548
2013-08-16packet-dcerpc-pn-io.c: In function 'dissect_PNIO_C_SDU':Anders Broman1-1/+1
packet-dcerpc-pn-io.c:9220: warning: unused parameter 'drep' svn path=/trunk/; revision=51390
2013-08-16From Wido Kelling:Anders Broman1-1/+2
wrong interpretation of first byte in userdata of profinet data. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9039 svn path=/trunk/; revision=51389
2013-08-15As suggested by Volcke Mario, fixingEvan Huus1-1/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9036 Don't change the length *and* the offset when adjusting for the ethercat header, just the offset is enough (the length is then right). svn path=/trunk/; revision=51360
2013-08-13Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9035 :Pascal Quantin1-5/+11
Indicate the right direction in info column svn path=/trunk/; revision=51333
2013-08-06Replace hfinfo pointer to same_name_prev, with same_name_prev_id.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=51175
2013-08-06Remove hfinfo->bitshift member, add hfinfo_bitshift() to get it.Jakub Zawadzki2-2/+2
svn path=/trunk/; revision=51174
2013-07-22Revert removed line in r50774, we can update pinfo->rel_ts not sure if it ↵Jakub Zawadzki1-0/+1
makes sense, but why not? svn path=/trunk/; revision=50795
2013-07-21Update plugins/ with recent change.Jakub Zawadzki2-2/+1
svn path=/trunk/; revision=50774
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki4-5/+5
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-16Bail in the profinet heuristics if we don't have source and destination macEvan Huus1-1/+7
addresses. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8904 svn path=/trunk/; revision=50651
2013-07-15Fix warning: ISO C does not allow extra ';' outside of a function.Chris Maynard1-2/+3
svn path=/trunk/; revision=50638
2013-07-15Move report_err.{h,c} from epan into wsutil: there's nothing epan-specific ↵Jeff Morriss3-4/+7
there and moving it avoids having to recompile the file for use in editcap and capinfos (which don't link against libwireshark). svn path=/trunk/; revision=50598
2013-07-14Use tvb_new_chain with the tvbuffs from a reassembly.Guy Harris3-6/+6
svn path=/trunk/; revision=50585
2013-07-14A fragment_data structure now contains a pointer to a tvbuff to theGuy Harris3-14/+12
fragment or reassembled data, not a pointer to the data itself; instead of having to construct a tvbuffs for the reassembled data, we can now just use the existing tvbuff. Spell out "fragment" and "fragmentation" in comments while we're at it. svn path=/trunk/; revision=50584
2013-07-06Add our license header to plugin moduleinfo.h files. Cleans up a batch ofEvan Huus12-0/+276
licensecheck warnings. svn path=/trunk/; revision=50407
2013-07-03WS_DLL_PUBLIC is now always WS_DLL_PUBLIC_NOEXTERN with "extern" added;Guy Harris3-7/+7
just define WS_DLL_PUBLIC_NOEXTERN inside the ifdefs, and define WS_DLL_PUBLIC as WS_DLL_PUBLIC_NOEXTERN followed by "extern". Then rename WS_DLL_PUBLIC_NOEXTERN to WS_DLL_PUBLIC_DEF, to clarify that it's what should be used for definitions; at least on Windows, you *have* to use it when declaring arrays without a size, and, whilst you might be able to use WS_DLL_PUBLIC for definitions of functions and perhaps data definitions other than no-size arrays, it might be clearer to rename WS_DLL_PUBLIC to WS_DLL_PUBLIC_DECL and use it only for declarations. svn path=/trunk/; revision=50334
2013-07-01Fix Coverity CID 280618 (Dereference before null check).Chris Maynard1-2/+2
#BACKPORT(1.10,1.8) svn path=/trunk/; revision=50305
2013-07-01Fix Coverity CID 1035326 (Improper use of negative value) by guarding ↵Chris Maynard1-0/+2
against tvb_reported_length_remaining() possibly returning -1. #BACKPORT(1.10,1.8) svn path=/trunk/; revision=50301
2013-07-01Define certain 'const char *...' arrays as static.Bill Meier2-4/+4
(That is: Don't create the array on the stack each time the function is called). Reduces code memory usage and execution time. (See SVN #50271) svn path=/trunk/; revision=50296
2013-06-30Add a question about whether hf_pn_rt_frag_data should be FT_STRING or FT_BYTES.Jeff Morriss1-0/+2
svn path=/trunk/; revision=50261
2013-06-25Link this plugin with libwsutil too (in order to pick up time symbols).Jeff Morriss1-1/+1
svn path=/trunk/; revision=50155
2013-06-25makefile.nmake -> Makefile.nmake and minor whitespace (spaces -> tabs) changes.Chris Maynard2-2/+2
svn path=/trunk/; revision=50140
2013-06-17More PDU export work:Pascal Quantin1-17/+1
- add automatic export of port type when exporting a source / destination port - add export of SCTP PPID (usefulness to be checked) - fix some field size svn path=/trunk/; revision=49989
2013-05-29Batch (some of) the plugins to filterable expert infos. The Profinet plugin ↵Michael Mann7-18/+93
started to get a bit complex in determining filter names (especially the DCOM stuff), so I'll leave that to someone more familiar with the protocol. svn path=/trunk/; revision=49624
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 17:47:07 +0000