aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2013-05-29Batch (some of) the plugins to filterable expert infos. The Profinet plugin ↵Michael Mann7-18/+93
started to get a bit complex in determining filter names (especially the DCOM stuff), so I'll leave that to someone more familiar with the protocol. svn path=/trunk/; revision=49624
2013-04-22Add a "hidden" array of UAT entry data to allow separation between UAT file ↵Michael Mann1-1/+1
syntax errors and "syntactically correct, but invalid field". Now UAT files load all entries into the "hidden" array (raw_data), but only adds valid ones to the user_data, which is used by the dissectors. This is a start to fixing bug 7471 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7471) and is being committed to get the new ABI/API in before the 1.10 release. What remains is the "GUI portion" (GTK+qt) to indicate to users which UAT entries are invalid. svn path=/trunk/; revision=48960
2013-04-18Fix FSF address.Guy Harris1-2/+2
svn path=/trunk/; revision=48907
2013-04-17Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-17/+12
svn path=/trunk/; revision=48898
2013-04-16Fix another dozen or so files with bad FSF addresses as caught by licensecheck.Evan Huus4-4/+4
svn path=/trunk/; revision=48869
2013-04-10Coverity CID 280337 Unchecked return valueMartin Kaiser1-4/+6
check the return value of fstat() svn path=/trunk/; revision=48809
2013-04-09Coverity CID 751101: Logically Dead CodeMartin Kaiser1-1/+1
my assumption is that this was a typo check should be for u8BlockVersionLow>2 there's code to handle u8BlockVersionLow 0, 1 and 2 svn path=/trunk/; revision=48805
2013-04-09fix indentingMartin Kaiser1-36/+36
svn path=/trunk/; revision=48804
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus2-2/+2
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris4-21/+25
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-21From beroset:Bill Meier1-28/+28
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachments #10423,#10424 svn path=/trunk/; revision=48450
2013-03-21From beroset:Bill Meier6-88/+88
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10409 svn path=/trunk/; revision=48449
2013-03-20[-Wmissing-prototypes]Anders Broman1-7/+7
Use explicit casts. svn path=/trunk/; revision=48439
2013-03-20 From beroset:Bill Meier7-25/+25
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2013-03-19From Michal Labedzki:Anders Broman1-1/+1
Fix some compilation errors in dumpcap/plugins https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304 svn path=/trunk/; revision=48413
2013-03-18From beroset:Anders Broman1-9/+9
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48400
2013-03-18From beroset:Anders Broman1-12/+12
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48399
2013-03-15Build easy codec plugin as a DLLBalint Reczey1-0/+4
This fixes compilation on Windows. From Gisle Vanem <gvanem@broadpark.no> with a minor change by me. svn path=/trunk/; revision=48314
2013-03-12From David Arnold:Jaap Keuter15-15/+15
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools. svn path=/trunk/; revision=48261
2013-03-09From Thomas Wiens via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8455Evan Huus1-1/+1
Don't add an extra 16 to offset, we've been updating it as we go. Fixes cases where valid AMS packets were marked as malformed. svn path=/trunk/; revision=48215
2013-03-03ENC_BIG_ENDIAN -> ENC_NA (as found by fix-encoding-args.pl)Pascal Quantin1-1/+1
svn path=/trunk/; revision=48040
2013-03-03From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :Pascal Quantin6-82/+82
Remove C++ incompatibilities from profinet plugin svn path=/trunk/; revision=48039
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey20-23/+28
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-03-01From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :Pascal Quantin1-78/+78
Remove C++ incompatibilities from packet-asn1.c svn path=/trunk/; revision=47984
2013-03-01From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :Pascal Quantin3-84/+84
Remove C++ incompatibilities from WiMAX plugins svn path=/trunk/; revision=47978
2013-02-27Move show_exception() and show_reported_bounds_error() toGuy Harris1-3/+0
epan/show_exception.c, as it's used outside epan/dissectors/packet-frame.c. Update their callers to include <epan/show_exception.h> to get their declaration. Add a CATCH_NONFATAL_ERRORS macro that catches all exceptions that, if there's more stuff in the packet to dissect after the dissector call that threw the exception, doesn't mean you shouldn't go ahead and dissect that stuff. Use it in all those cases, including ones where BoundsError was inappropriately being caught (you want those passed up to the top level, so that the packet is reported as having been cut short in the capture process). Add a CATCH_BOUNDS_ERRORS macro that catches all exceptions that correspond to running past the end of the data for a tvbuff; use it rather than explicitly catching those exceptions individually, and rather than just catching all exceptions (the only place that DissectorError should be caught, for example, is at the top level, so dissector bugs show up in the protocol tree). Don't catch and then immediately rethrow exceptions without doing anything else; just let the exceptions go up to the final catcher. Use show_exception() to report non-fatal errors, rather than doing it yourself. If a dissector is called from Lua, catch all non-fatal errors and use show_exception() to report them rather than catching only ReportedBoundsError and adding a proto_malformed item. Don't catch exceptions when constructing a trailer tvbuff in packet-ieee8023.c - just construct it after the payload has been dissected, and let whatever exceptions that throws be handled at the top level. Avoid some TRY/CATCH/ENDTRY cases by using checks such as tvb_bytes_exist() before even looking in the tvbuff. svn path=/trunk/; revision=47924
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-1/+1
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-26it's ==> its & its == > it's as needed.Bill Meier4-15/+15
svn path=/trunk/; revision=47893
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris2-5/+2
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2013-02-15Get rid of an extra blank line.Guy Harris1-1/+0
svn path=/trunk/; revision=47677
2013-02-15From Hannes Mezger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8327Evan Huus13-795/+1412
Updates to the OPCUA plugin so that subtrees of the dissector select the appropriate number of bytes. Also fix dissection of the array dimensions field for matrix values and the highlighting for empty string fields. svn path=/trunk/; revision=47673
2013-02-12Fix the grammar.h/grammar.c/grammar.lemon dependency so thatGilbert Ramirez1-2/+2
grammar.h is not always out of date. Use the same pattern as in the Makefile.nmake files svn path=/trunk/; revision=47643
2013-02-10Comment out numerous unused hf_.... instances found by checkhf.Bill Meier33-114/+272
svn path=/trunk/; revision=47617
2013-02-10Add %option noinput to some Flex files, as we aren't using the input()Guy Harris1-0/+5
routine and thus don't need to have it generated - and as it produces warnings of a routine defined but not used, we don't want to have it generated. svn path=/trunk/; revision=47616
2013-02-10Fix a (benign) ERROR: NO ARRAY: opcua/opcua.c, hf_opcua_reassembled_dataBill Meier1-2/+1
svn path=/trunk/; revision=47614
2013-02-10Add %option noinput to a bunch of Flex files, as we aren't using theGuy Harris1-0/+5
input() routine and thus don't need to have it generated - and as it produces warnings of a routine defined but not used, we don't want to have it generated. Squelch a casting-const-away warning. svn path=/trunk/; revision=47613
2013-02-10Comment out various unused hf_... instances found by checkhf.Bill Meier4-222/+314
svn path=/trunk/; revision=47607
2013-02-10Fix ERROR: NO ARRAY: packet-tlv.c, hf_docsis_rcv_mod_enc_ctr_freq_asgnBill Meier1-0/+5
##Backport 1.6, 1.8 svn path=/trunk/; revision=47605
2013-02-09We *did* fix the APIs used.Guy Harris1-1/+0
svn path=/trunk/; revision=47597
2013-02-09Pull the definition of NODIST_HEADER_FILES up intoGuy Harris5-12/+6
plugins/Makefile.common.inc. svn path=/trunk/; revision=47596
2013-02-09"make maintainer-clean" should nuke all generated files.Guy Harris1-0/+2
svn path=/trunk/; revision=47594
2013-02-09Get rid of trailing tabs, make comments more similar.Guy Harris2-3/+3
svn path=/trunk/; revision=47593
2013-02-09Define GENERATED_HEADER_FILES in plugins/Makefile.common.inc.Guy Harris2-4/+7
svn path=/trunk/; revision=47592
2013-02-09plugins/Makefile.common.inc defines NODIST_SRC_FILES, andGuy Harris1-4/+0
plugins/mate/Makefile.common includes it, so there's no need to define it in plugins/mate/Makefile.common. svn path=/trunk/; revision=47591
2013-02-09Define FLEX_GENERATED_SRC_FILES and LEMON_GENERATED_SRC_FILES inGuy Harris2-4/+16
plugins/Makefile.common.inc, and use it in plugins/mate/Makefile.nmake. svn path=/trunk/; revision=47590
2013-02-09plugins/Makefile.common.inc should already be definingGuy Harris1-4/+0
GENERATED_SRC_FILES, and plugins/mate/Makefile.common includes it, so it shouldn't need to define GENERATED_SRC_FILES itself. svn path=/trunk/; revision=47589
2013-02-09The type of the second argument to g_snprintf() is gulong. (It *should*Guy Harris1-2/+2
have been size_t, just as with Boring Old Snprintf; what were they thinking?) svn path=/trunk/; revision=47588
2013-02-09Add casts to make it build on win64.Anders Broman1-2/+2
svn path=/trunk/; revision=47587
2013-02-09Try to fix the makefiles to be able to build mate after distclean.Anders Broman2-3/+15
svn path=/trunk/; revision=47586
2013-02-09Get rid of a '- i' that appears to have been accidentally inserted in r47581.Evan Huus1-1/+1
i is definitely not initialized at that point (GCC was complaining), and there seems to be no need to subtract anything from the value in question in the first place. svn path=/trunk/; revision=47582