aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/wimax/mac_hd_generic_decoder.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-281. Remove PITEM_FINFO from add_tlv_subtree and add_protocol_subtree (as well ↵Michael Mann1-8/+8
as some other minor cleanup) and adjust the calling functions accordingly. 2. Converted several add_protocol_subtree calls to add_tlv_subtree to get true filterability. Many of the add_protocol_subtree are effectively being (ab)used as proto_tree_add_text with different highlighting. 3. Convert tvb_new_subset into tvb_new_subset_length. Still looks like some of the remaining "protocols" need more specific filters, and should just be regular FT_BYTES fields. svn path=/trunk/; revision=52235
2013-09-24You are in a twisty little maze of code paths, all different. Get ridGuy Harris1-416/+407
of the if (tree) tests in dissect_mac_header_generic_decoder(), as some of the stuff done inside there should be done even if we're not building a protocol tree, e.g. CRC stuff and calling subdissectors. Get rid of a gratuitous pair of curly braces, and fix the indentation of one line, while we're at it. svn path=/trunk/; revision=52208
2013-09-24Stuff used when checking the CRC needs to be done regardless of whetherGuy Harris1-9/+14
we're building a protocol tree or not. svn path=/trunk/; revision=52207
2013-09-24Wimax dissector improvements:Michael Mann1-37/+53
1. Remove message type field from all MAC Management "sub"dissectors and place it in Mac Management subdissector itself. This may cause backwards-compatibility issues (malformed packets) with third-party subdissectors of the MAC Management dissector, but it didn't make sense to have so many filters for a single enumerated value, especially when the various "protocol" filters covers many of them. 2. Removed some if(tree) checks as column info and calling other dissectors are sometimes executed underneath. Some of this is in preparation for addressing bug 5349. 3. Make all dissector functions (and a few others) static, and use register_dissector() when necessary. 4. Convert generic decoder CRC errors into expert info, rather than have it be a "protocol" filter (it just looks funny that way) In general, these dissectors seem "over-protocolized". I understand the need for all of the dissectors, but I don't know if they all need "protocol" status. svn path=/trunk/; revision=52203
2013-09-22Make dissectors register for their MAC Management Message Type and use ↵Michael Mann1-5/+9
dissector_try_uint to do any dissection. Many "outside" (third-party) message types appear to exist. Have the makefiles do all the work setting up proto_register_<dissector> and proto_reg_handoff_<dissector>, rather than sprinkled throughout the dissectors with extern declarations. More is coming to make more functions static (because of current makefile fixes) and cleanup MAC Management dissectors to remove unnecessary/duplicative code, but I wanted to get the build issues squared away. svn path=/trunk/; revision=52167
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-14Use tvb_new_chain with the tvbuffs from a reassembly.Guy Harris1-2/+2
svn path=/trunk/; revision=50585
2013-07-14A fragment_data structure now contains a pointer to a tvbuff to theGuy Harris1-5/+5
fragment or reassembled data, not a pointer to the data itself; instead of having to construct a tvbuffs for the reassembled data, we can now just use the existing tvbuff. Spell out "fragment" and "fragmentation" in comments while we're at it. svn path=/trunk/; revision=50584
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-3/+4
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-20 From beroset:Bill Meier1-8/+8
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2012-12-26Fix a bunch of warnings.Guy Harris1-11/+11
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45015
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-10Better fixes for the last commit.Gerald Combs1-5/+3
svn path=/trunk/; revision=42529
2012-05-09Fix a few scan-build warnings.Gerald Combs1-6/+6
svn path=/trunk/; revision=42528
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-92/+92
plugin dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39292
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-6/+6
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39262
2011-07-21Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-3/+3
svn path=/trunk/; revision=38150
2011-07-04From Kluchnikov Ivan:Anders Broman1-3/+3
Wireshark cannot decode wimax compressed DL-MAP without FCH burst. Function is_down_link use the base station address (bs_address), which is set in function dissect_wimax_fch_decoder. Changed function is_down_link, it use packet_info->p2p_dir for check if packet is downlink. packet_info->p2p_dir set in GSMTAP. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6066 svn path=/trunk/; revision=37889
2010-04-08Get rid of check_col().Anders Broman1-44/+12
svn path=/trunk/; revision=32426
2009-10-04Constify wimax_mac_calc_crc32()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=30309
2009-10-04Move prototype to wimax_utils.hKovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=30307
2009-08-04Minor changes:Bill Meier1-789/+786
- Move proto_register...() to the end of the file as per convention; - Move ett[] to be local to proto_register...(); - "if (...==-1)" not req'd in proto_register...(); - #include <moduleinfo.h> not req'd; - Remove unneeded forward declarations. svn path=/trunk/; revision=29296
2009-06-22From Kovarththanan Rajaratnam:Stig Bjørlykke1-88/+88
More header field info cleanup in plugins/* and epan/dissectors/* svn path=/trunk/; revision=28811
2009-06-22From Kovarththanan Rajaratnam:Stig Bjørlykke1-736/+736
Move header field info declarations into function scope. This is the first step. Another patch will be submitted which actually scrubs the header field info declarations (remove empty blurbs, etc.) svn path=/trunk/; revision=28797
2009-05-13Apply some of the patches from:Anders Broman1-3/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28355
2008-08-29#include <prefs.h> not requiredBill Meier1-1/+0
svn path=/trunk/; revision=26103
2008-06-20Fix wimax encoding err when packing subheader present.Martin Mathieson1-3/+3
From Frank Wang, fixes bug 2570. svn path=/trunk/; revision=25494
2008-01-24Fixed some more malloc -> g_malloc, free -> g_free, strdup -> g_strdup.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=24180
2007-12-14Warning fixes: function declaration isn’t a prototypeJörg Mayer1-1/+1
svn path=/trunk/; revision=23862
2007-11-28Change each filter prefix to match the protocol name ("wmx"). Add aGerald Combs1-89/+89
"wmx" prefix to each sub-protocol. "wmx"-ize the preferences and dissector registration. svn path=/trunk/; revision=23660
2007-07-25Initialize a couple of variables to prevent a couple (false, I think) "could ↵Jeff Morriss1-2/+4
be used uninitialized" warnings from GCC svn path=/trunk/; revision=22401
2007-05-27Use tvb_reported_length() to get the amount of data we should look at;Guy Harris1-5/+5
the number of bytes in the packet or subset of the packet is the reported length, tvb_length() just gives you the amount of that data that was actually captured. Include <glib.h>, not <gmodule.h>, even in plugins. Fix the version numbers in the rc files. svn path=/trunk/; revision=21960
2007-05-25From Mike Harvey: Support for WiMAX and the WiMAX M2M encapsulation protocol.Gerald Combs1-0/+2298
Add support for WiMAX and M2M to various makefiles and installer files. Add basic support for M2M to randpkt. svn path=/trunk/; revision=21945
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 10:49:13 +0000