aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/opcua
AgeCommit message (Collapse)AuthorFilesLines
2014-01-14More prototype cleanup.Guy Harris5-1/+25
svn path=/trunk/; revision=54752
2014-01-13dispatchService() is imported from other code; declare it inGuy Harris2-3/+1
opcua_transport_layer.h, not opcua_transport_layer.c. svn path=/trunk/; revision=54730
2014-01-01Fix [-Wmissing-prototypes]Anders Broman2-2/+3
svn path=/trunk/; revision=54528
2013-12-23Avoid using ephemeral memory in register routines.Evan Huus1-1/+4
svn path=/trunk/; revision=54423
2013-11-15Try to fix [-Wmissing-prototypes]Anders Broman7-1/+9
svn path=/trunk/; revision=53337
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-15/+15
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-10-23Fix (using '#if 0') a few more [-Wunused-const-variable] warningsBill Meier1-3/+5
svn path=/trunk/; revision=52799
2013-10-13Add CMake properties to targets so that they are logically organised when ↵Graham Bloice1-0/+1
using a Visual Studio solution. Add CMake properties to group the source files in epan into logical blocks when using a Visual Studio solution. svn path=/trunk/; revision=52580
2013-09-17emem -> wmemPascal Quantin2-4/+5
svn path=/trunk/; revision=52130
2013-09-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=51679
2013-08-06Remove hfinfo->bitshift member, add hfinfo_bitshift() to get it.Jakub Zawadzki2-2/+2
svn path=/trunk/; revision=51174
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-06Add our license header to plugin moduleinfo.h files. Cleans up a batch ofEvan Huus1-0/+23
licensecheck warnings. svn path=/trunk/; revision=50407
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-11/+11
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-12From David Arnold:Jaap Keuter1-1/+1
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools. svn path=/trunk/; revision=48261
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-1/+1
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2013-02-15From Hannes Mezger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8327Evan Huus13-795/+1412
Updates to the OPCUA plugin so that subtrees of the dissector select the appropriate number of bytes. Also fix dissection of the array dimensions field for matrix values and the highlighting for empty string fields. svn path=/trunk/; revision=47673
2013-02-10Comment out numerous unused hf_.... instances found by checkhf.Bill Meier1-6/+8
svn path=/trunk/; revision=47617
2013-02-10Fix a (benign) ERROR: NO ARRAY: opcua/opcua.c, hf_opcua_reassembled_dataBill Meier1-2/+1
svn path=/trunk/; revision=47614
2013-02-09Make the other plugin makefiles use the new style introduced in the MATEGuy Harris3-37/+46
makefiles. svn path=/trunk/; revision=47579
2012-12-26Fix a bunch of warnings.Guy Harris2-5/+5
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-07Bump revission.Anders Broman1-1/+1
svn path=/trunk/; revision=46447
2012-12-07From hannes:Anders Broman1-1/+4
'Fix for displaying the payload of the first chunk correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068 svn path=/trunk/; revision=46445
2012-12-07From hannes:Anders Broman3-15/+230
Enable the plugin to detect and reassemble chunked UA messages for displaying them correctly. From me: - Partly applied by hand. - move hf and ett asignments inseide the register routine as per convention. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8068 svn path=/trunk/; revision=46436
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier3-18/+18
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss11-33/+11
svn path=/trunk/; revision=45015
2012-06-28Update FSF address - part II.Jakub Zawadzki1-2/+2
svn path=/trunk/; revision=43538
2012-06-28Update Free Software Foundation address.Jakub Zawadzki3-3/+3
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-01Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if ↵Bill Meier1-1/+1
Makefile.common is changed svn path=/trunk/; revision=42972
2012-06-01Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt ↵Bill Meier1-2/+2
if Makefile.common is changed ToDo: ditto for Makefile.am ? svn path=/trunk/; revision=42971
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris2-22/+22
proto_tree_add_item() calls. Clean up indentation. svn path=/trunk/; revision=42586
2012-05-05From Nhi Nguyen:pascal1-2/+2
OPC UA bytestring node id decoding is wrong https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7226 svn path=/trunk/; revision=42437
2012-04-09Add missing consts in opcua plugin.Jakub Zawadzki5-274/+274
svn path=/trunk/; revision=42000
2012-04-04Add a "-build" argument to checkAPIs.pl. Use that argument when buildingJeff Morriss2-2/+2
from makefiles (and thus from the buildbot). The intention is to be able to tell when a human is running the tool so we can provide more code-review guidance. As a starter, enable the "too many proto_tree_add_text() calls" check when a human is running the tool. svn path=/trunk/; revision=41943
2012-01-29Add *.sbr files to the clean target.Anders Broman1-1/+1
svn path=/trunk/; revision=40761
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-10/+10
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-18Do some more conversions of proto_tree_add_item() 'encoding' argBill Meier1-6/+6
(previously missed). svn path=/trunk/; revision=39450
2011-10-15Convert plugin files proto_tree_add_item() 'encoding' arg for field types ↵Bill Meier1-6/+6
FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39429
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-16/+16
plugins/*: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in an earlier SVN) svn path=/trunk/; revision=39329
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier5-77/+77
plugin dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39292
2011-03-23Removed unused parameter to parseServiceNodeId.Stig Bjørlykke3-6/+4
Coverity 596. svn path=/trunk/; revision=36283
2011-02-02A bit of Windows makefiles rework and cleanup:Bill Meier1-2/+3
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile; a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS; b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake) (This allows disabling "Warnings as Errors" by just changing config.nmake) c. CVARSDLL definitions (not usage) have been removed from the various makefiles. XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since: -DWIN32 and -DNULL=0 do not appear to be needed (any more); -D_MT and _D_DLL are not needed since /MP causes these definitions. d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled. E.G., 4295: array is too small to include a terminating null character - config.nmake: reformat some long lines for readability; - plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile); - dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ... svn path=/trunk/; revision=35747
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-11Added opcua_extensionobjecttable.c from revision 34906.Stig Bjørlykke1-0/+1
svn path=/trunk/; revision=35177
2010-12-04From Gerhard Gappmeier via ↵Jeff Morriss3-15/+40
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5429 : Until now the info column only shows the OPC UA transport protocol type (Hello, Ack, Secure Conversion message). After connections establishment has finished this column shows only Secure Conversion message, because every service is sent over the secure channel. This patch adds the useful support of displaying the service type in the info column. This makes it easier to find specific service calls in huge capture files. svn path=/trunk/; revision=35119
2010-12-04From Gerhard Gappmeier via ↵Jeff Morriss2-4/+336
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5427 : This patch adds support for dissecting all Extension Objects types defined by the OPC Foundation. svn path=/trunk/; revision=35118
2010-12-02From Gerhard Gappmeier:Anders Broman1-12/+12
Fix mapping of datatype strings in opcua plugin https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5428 svn path=/trunk/; revision=35105
2010-11-16From Gerhard Gappmeier via ↵Jeff Morriss6-1/+158
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5410 : This patch adds support for displaying OPC UA ExtensionObjects. An ExtensionObject is a mechanism to transport user defined structures as serialized blobs. Some types of ExtensionObjects are already defined by the OPC Foundation's OPC UA Specifications. These types can be implemented by this dissector, because they are well-known. Real user-defined or vendor-defined types are unlikely to be implemented by a passive dissector, because this would require browsing of the UA server's address space to retrieve the type information. Currently only the following types are supported: * DataChangeNotification * EventNotification Others OPC defined types will follow. From me: fix warnings: "format not a string literal and no format arguments" svn path=/trunk/; revision=34906
2010-11-16From Gerhard Gappmeier via ↵Jeff Morriss1-8/+29
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5409 : This patch fixes displaying OPCUA Strings and ByteStrings. From me: fix warnings: "format not a string literal and no format arguments" svn path=/trunk/; revision=34905