aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/ethercat
AgeCommit message (Collapse)AuthorFilesLines
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte5-10/+0
(Using sed : sed -i '/^\# \$Id\$/,+1 d') (start with dash) Change-Id: Ia4b5a6c2302f6a531f6a86c1ec3a2f8205c8c2dd Reviewed-on: https://code.wireshark.org/review/881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte13-26/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespaceBill Meier4-13/+13
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0 Reviewed-on: https://code.wireshark.org/review/385 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2013-12-20#if 0 a group of unused #defines;Bill Meier1-8/+23
Remove some trailing whitespace; Add editor modelines. svn path=/trunk/; revision=54307
2013-12-20fixMartin Kaiser1-0/+1
CC packet-ecatmb.lo packet-ecatmb.c: In function 'dissect_ecat_mailbox': packet-ecatmb.c:877:64: error: 'info.anSdoInfoUnion.Entry.ValueInfo' may be used uninitialized in this function [-Werror=uninitialized] packet-ecatmb.c:796:38: note: 'info.anSdoInfoUnion.Entry.ValueInfo' was declared here packet-ecatmb.c:884:34: error: 'info.anSdoInfoUnion.Entry.Res.BitLen' may be used uninitialized in this function [-Werror=uninitialized] packet-ecatmb.c:796:38: note: 'info.anSdoInfoUnion.Entry.Res.BitLen' was declared here svn path=/trunk/; revision=54286
2013-12-20Fix [-Wmissing-prototypes]Anders Broman2-6/+12
svn path=/trunk/; revision=54280
2013-11-21Create separate dissector function for TCP functionality so ↵Michael Mann1-12/+17
packet_info->ethertype doesn't need to be used. svn path=/trunk/; revision=53478
2013-11-19Fix [-Wmissing-prototypes]Anders Broman5-2/+16
svn path=/trunk/; revision=53425
2013-11-05Remove setting of pinfo->private_data to ETHERCAT_MBOX_HEADER structure as ↵Michael Mann1-1/+0
it's not used anywhere in the Wireshark source. If it's used by a third-party plugin, please submit a patch that passes the ETHERCAT_MBOX_HEADER structure through the data parameter of the "new" style dissector function. svn path=/trunk/; revision=53094
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-4/+1
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-13Add CMake properties to targets so that they are logically organised when ↵Graham Bloice1-0/+1
using a Visual Studio solution. Add CMake properties to group the source files in epan into logical blocks when using a Visual Studio solution. svn path=/trunk/; revision=52580
2013-08-15As suggested by Volcke Mario, fixingEvan Huus1-1/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9036 Don't change the length *and* the offset when adjusting for the ethercat header, just the offset is enough (the length is then right). svn path=/trunk/; revision=51360
2013-07-22Revert removed line in r50774, we can update pinfo->rel_ts not sure if it ↵Jakub Zawadzki1-0/+1
makes sense, but why not? svn path=/trunk/; revision=50795
2013-07-21Update plugins/ with recent change.Jakub Zawadzki1-1/+0
svn path=/trunk/; revision=50774
2013-07-06Add our license header to plugin moduleinfo.h files. Cleans up a batch ofEvan Huus1-0/+23
licensecheck warnings. svn path=/trunk/; revision=50407
2013-06-25Link this plugin with libwsutil too (in order to pick up time symbols).Jeff Morriss1-1/+1
svn path=/trunk/; revision=50155
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-12From David Arnold:Jaap Keuter1-1/+1
Replace use of INCLUDES with AM_CPPFLAGS in all Makefiles to placate recent autotools. svn path=/trunk/; revision=48261
2013-03-09From Thomas Wiens via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8455Evan Huus1-1/+1
Don't add an extra 16 to offset, we've been updating it as we go. Fixes cases where valid AMS packets were marked as malformed. svn path=/trunk/; revision=48215
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-1/+1
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-02-10Comment out numerous unused hf_.... instances found by checkhf.Bill Meier5-16/+34
svn path=/trunk/; revision=47617
2013-02-09Make the other plugin makefiles use the new style introduced in the MATEGuy Harris3-26/+38
makefiles. svn path=/trunk/; revision=47579
2012-12-26Fix a bunch of warnings.Guy Harris8-150/+150
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-23Store pointers to previously displayed and captured packet, not nstime_t deltas.Jakub Zawadzki1-2/+0
This commit reduces size (from 144B to 128B on AMD64) of frame_data structure. Part of bug 5821: Reduce per-packet memory requirements. svn path=/trunk/; revision=45071
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss7-14/+0
svn path=/trunk/; revision=45015
2012-09-11Add data parameter to dissector_try_heuristicJakub Zawadzki1-3/+3
svn path=/trunk/; revision=44871
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki2-2/+2
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-06-28Update FSF address - part II.Jakub Zawadzki1-4/+4
svn path=/trunk/; revision=43538
2012-06-28Update Free Software Foundation address.Jakub Zawadzki16-16/+16
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-07Attempt to fix display of "eoe macfilter header".Bill Meier1-7/+19
Among other things: fix incorrect 'display' value in several hf[] entries. (See XXX coments in source for further details). Attempt to fix use of incorrect value in hf[] entry 'display' fields svn path=/trunk/; revision=43149
2012-06-01Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if ↵Bill Meier1-1/+1
Makefile.common is changed svn path=/trunk/; revision=42972
2012-06-01Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt ↵Bill Meier1-2/+2
if Makefile.common is changed ToDo: ditto for Makefile.am ? svn path=/trunk/; revision=42971
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-9/+9
proto_tree_add_item() calls. svn path=/trunk/; revision=42584
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-2/+2
proto_tree_add_item() calls. svn path=/trunk/; revision=42583
2012-04-27Fix Malformed packet AMS for Read Device Info Read State Request.Anders Broman1-3/+25
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6710 check if data exists. svn path=/trunk/; revision=42292
2012-04-04Add a "-build" argument to checkAPIs.pl. Use that argument when buildingJeff Morriss2-2/+2
from makefiles (and thus from the buildbot). The intention is to be able to tell when a human is running the tool so we can provide more code-review guidance. As a starter, enable the "too many proto_tree_add_text() calls" check when a human is running the tool. svn path=/trunk/; revision=41943
2012-01-29Add *.sbr files to the clean target.Anders Broman1-1/+1
svn path=/trunk/; revision=40761
2012-01-13Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-5/+5
svn path=/trunk/; revision=40475
2012-01-13Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=40474
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier7-37/+37
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier1-1/+1
svn path=/trunk/; revision=39490
2011-10-18Do some more conversions of proto_tree_add_item() 'encoding' argBill Meier1-1/+1
(previously missed). svn path=/trunk/; revision=39450
2011-10-15Convert plugin files proto_tree_add_item() 'encoding' arg for field types ↵Bill Meier2-6/+6
FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39429
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier4-77/+77
plugins/*: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in an earlier SVN) svn path=/trunk/; revision=39329
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier6-152/+152
plugin dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39292
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier5-61/+61
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39262
2011-04-22Use the return value of proto_item_add_subtree(): put the filter masks in ↵Jeff Morriss1-2/+4
their own subtree (as it appears was intended). svn path=/trunk/; revision=36811
2011-03-29Add a missing break.Anders Broman1-0/+1
CID 487 svn path=/trunk/; revision=36403
2011-03-24Don't assign to a proto_item* if the value won't be used: Coverity 1155-1156;Bill Meier1-86/+86
Also: - Fix a few cases of SET_HIDDEN on the wrong item. (The SET_HIDDEN was being done on an already hidden item). - Minor indentation cleanup; svn path=/trunk/; revision=36315
2011-03-24Don't assign to a proto_item* if the value won't be used: Coverity 1151-1154;Bill Meier1-95/+95
svn path=/trunk/; revision=36312