aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-08-29Gryphon: Prevent endless loopMichael Mann1-1/+5
Bug: 16020 Change-Id: I59c24d3bdb3f3a85f6e498683594ee12db9642a8 Reviewed-on: https://code.wireshark.org/review/34392 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-27HTTPS In More Places, update some URLs.Guy Harris7-7/+15
Change-Id: Ice2e1e2e4d94f6c9da7c651866cfa1a8ac4a31d8 Reviewed-on: https://code.wireshark.org/review/34096 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26HTTPS (almost) everywhere.Guy Harris97-97/+97
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26Initialize newly-allocated iap_conversation_t before fetching packet data.Guy Harris1-4/+6
If we do it after trying to fetch packet data, the attempt to fetch might throw an exception, and the structure won't be fully initialized. Bug: 15934 Change-Id: If50a8c18232d934c1e33512cddb40a011a4eaef7 Reviewed-on: https://code.wireshark.org/review/34087 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-18Don't just grab raw string data with tvb_memcpy().Guy Harris1-17/+71
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column, and just use proto_tree_add_item() if we don't need the string's value. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and, if necessary, are formatted for display. Add comments asking about encodings. Change-Id: I32dbdf17c90e77cc080d6132c740c8c5d19ef4c5 Reviewed-on: https://code.wireshark.org/review/33997 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Clean up comments.Guy Harris1-9/+1
VisibleString does, in fact, mean ASCII in PROFINET. Put a space after a comma. Change-Id: I0b9da9599ddd5429736dff598e5c37e9cac88bc6 Reviewed-on: https://code.wireshark.org/review/33996 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-125/+58
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column, and just use proto_tree_add_item() if we don't need the string's value. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and, if necessary, are formatted for display. Add comments about fields that have type VisibleString, asking whether that means "ASCII" or "just the "Basic" part of ISO 646", where the latter is ENC_ISO_646_BASIC. Add a comment about fields using "The definition of IETF RFC 5890" - that means "Punycode", but I don't think we map Punycode to Unicode; perhaps we should. Also ask whether that also implies RFC 1035's encoding of domain names as sequences of counted strings. Change-Id: Ie8d5bc18d2846f8d723019b22f69a50ce55f9a9b Reviewed-on: https://code.wireshark.org/review/33986 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Fix signedness warnings.Guy Harris1-4/+4
Change-Id: I2a0d6f6e73c56eb3b531d6e805c9db435ceb72e7 Reviewed-on: https://code.wireshark.org/review/33983 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Clean up string handling.Guy Harris1-42/+116
Use tvb_get_string_enc() routines to fetch strings; all strings must have an encoding value, to properly map to UTF-8. Use format_text() when displaying string values in columns. Show the interpretation of "character set" values. Choose the encoding value based on the "character set" value. While we're at it, use the XDLC_S_U_MASK #define, rather than a raw hex value, when testing for S frames vs. U frames. Change-Id: Idf9d6302473bbffdfa67341c381575aa525a6d84 Reviewed-on: https://code.wireshark.org/review/33982 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-15Clean up indentation.Guy Harris1-78/+78
Change-Id: I072ae41e48583ed52679cc58fb3b65e7654bf3ab Reviewed-on: https://code.wireshark.org/review/33947 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-11Doxygen: Fix some warnings.Anders Broman1-1/+1
Change-Id: I0344d44d08d2e159c895d693500403c067039a44 Reviewed-on: https://code.wireshark.org/review/33894 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10doxygen: Try to fix warnings.Anders Broman1-2/+0
Change-Id: I1517c968f05e7d9c6b561c0f5a7c6a059462d175 Reviewed-on: https://code.wireshark.org/review/33889 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-09ethercat: add new hf item for sdo abort code.Richard Kuemmel2-3/+8
Add new hf item for sdo abort code and display abort code instead of index. Added check of APWR and FPRW to decide if an EtherCAT command is a mailbox command. Change-Id: I42877c26cb70c7567dc2d1b703e84aad8a3f7ac8 Reviewed-on: https://code.wireshark.org/review/33405 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-05-29Use the HTTPS URL for our main site in a few places.Gerald Combs1-1/+1
Fixup the encoding of plugins/plugin.rc.in while we're here. Change-Id: I21b56ce68bc3d84298a846a991c72bf710b9ae8a Reviewed-on: https://code.wireshark.org/review/33414 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-05-20PN-DCP: Add headerfield for DHCP Option-CodeThomas Wiens1-2/+9
Change-Id: Id00a531355fd5e32c5b3d98388fc43a5ad71aa12 Reviewed-on: https://code.wireshark.org/review/33260 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-14PROFINET DCP: fix dissection of an empty DHCP optionPascal Quantin1-14/+15
Bug: 15774 Change-Id: Ief2588e5d6f43da708ef071a4490f5f881268820 Reviewed-on: https://code.wireshark.org/review/33186 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Mehmet Oguz Sakaoglu <mehmet.oguz.mnz@gmail.com> Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-05-06wimax: fix copy&paste error.Dario Lombardo1-1/+1
Fix suggested by Mark Hermeling. Bug: 15750 Change-Id: I0d5e29e549acf797b234175f27aa6e49a5a45436 Reviewed-on: https://code.wireshark.org/review/33080 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-21Revert "ProfiNet: Fix order in AssetManagment"Başak Kalfa1-4/+4
This reverts commit 1e98cee5e1797839b515703f6a48cc0efedbbdb7. According to Profinet specification, DeviceSubId, DeviceId, VendorId, Organization must be in reverse order. Change-Id: I3db3d7d83813239784557286479b37448f70db55 Reviewed-on: https://code.wireshark.org/review/32683 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs7-104/+104
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-18Get rid of extra declaration.Guy Harris1-3/+0
Change-Id: Ia08374136ee3a9770cd7bba2d6bf433590061337 Reviewed-on: https://code.wireshark.org/review/32468 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-25mate: Memory leak in mate_grammar.lemon's recolonize function.Anders Broman1-1/+2
Bug: 15525 Change-Id: I42728bc7b029618d8012cbbbec470b48a8fb2d92 Reviewed-on: https://code.wireshark.org/review/32188 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-21profinet: fix unused hrefAlexis La Goutte1-1/+1
Unused href entry: plugins/epan/profinet/packet-pn-dcp.c: hf_pn_dcp_blockqualifier Change-Id: I3bf53a4fa27043b8398cd2a4d7efbec848e7bca6 Reviewed-on: https://code.wireshark.org/review/32136 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Mehmet Oguz Sakaoglu <mehmet.oguz.mnz@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-21profinet: fix Control flow issues (DEADCODE)Alexis La Goutte1-1/+2
CID 1442818 & 1442815 Change-Id: I8e7201795a780f10923ff6fb0af6b78adc56b75d Reviewed-on: https://code.wireshark.org/review/32135 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Mehmet Oguz Sakaoglu <mehmet.oguz.mnz@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-18PROFINET: Additional DCP features are added.moguz1-23/+187
Missing DCP features are implemented. Minor bugs are fixed as well. Change-Id: I2deb00ca61a09cc290a692eadaea4eaa1a52fb85 Reviewed-on: https://code.wireshark.org/review/32030 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-19diam_dict.l,wimaxasncp_dict.l: fix -Werror=stringop-truncationPeter Wu1-3/+2
The given "len" is the size of the string in "txt" excluding the NUL terminator. GCC 8.2.1+20181127-1 rightfully complains that strncpy will not terminate the destination buffer. Change-Id: I592c7c218cf07c13697de4e60f454326a93d1124 Reviewed-on: https://code.wireshark.org/review/31600 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-20/+23
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-28Allow floating point values for stats_treeMichael Mann1-6/+6
Bug: 4234 Change-Id: Ibd59809b2dd9890a7851eb57ef7af384e280a74b Reviewed-on: https://code.wireshark.org/review/31222 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris3-14/+14
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-13opcua: show invalid OPC UA messages when 'opcua' filter is setHannes Mezger1-0/+8
Change-Id: Ia9d14c14c20ef35aefbb0e6b3853450074b4c0a3 Reviewed-on: https://code.wireshark.org/review/31020 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-12opcua: fix typo, use the commonly used 'Endpoint' instead of 'EndPoint'Hannes Mezger1-1/+1
Change-Id: I403673962987e4da0711896e8ae3e60af34acb4e Reviewed-on: https://code.wireshark.org/review/31019 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-12opcua: add support for new reverse hello messageHannes Mezger3-0/+20
The reverse hello message type was added in OPC UA specification 1.04. Change-Id: I00095e35049b8f38ab183ded1b96af51d788d986 Reviewed-on: https://code.wireshark.org/review/31018 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06PROFINET: PDPortDataReal_block dissection is changed.Ba?ak Kalfa1-8/+52
According to specification, PortState is renamed and dissected as "LinkState.Link" and "LinkState.Port" which are both 8 bits. Change-Id: I1eff258f48d6fd76286ae08a7d2d80793ea23f12 Reviewed-on: https://code.wireshark.org/review/30913 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-30PROFINET: fix dissection of IO conversasion directionnakarlsson2-11/+44
Bug: 15313 Change-Id: I5255f8b03f9d86cd7da8be34a71f0a3932bfca5c Reviewed-on: https://code.wireshark.org/review/30821 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-30Fix pluginifdemo with DISABLE_WERRORMichał Łabędzki1-1/+1
Change-Id: I19853157ea2cbe3a28c06493a32b73913c1aad84 Reviewed-on: https://code.wireshark.org/review/30429 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-21opcua: add missing opcua_nested_count decrementJiří Engelthaler1-3/+15
Nest testing was added in I5f6da3a3e269f6db1b690b77470ddf60045bcedd as a reaction to CVE-2018-12086. In this changed there was only nest increment without decrement. Bug: 15226 Change-Id: I178fad4be1106c8da23351220c95c85274bddc30 Reviewed-on: https://code.wireshark.org/review/30285 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-20Updated OPC UA 1.0.4 enumerationcacamille31-0/+5
Change-Id: I55bd26abde59442280833973f6a6b52ba1d7b337 Reviewed-on: https://code.wireshark.org/review/30262 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-20Include transport protocols' hfids in the list of wanted hfids.Guy Harris2-1/+8
We need to get the fields corresponding to those protocols, so we know the range within the packet that those protocols cover. Improve a debugging message while we're at it. Bug: 15208 Change-Id: Idc329079584e8d035622b148503a2ec1a295ccaa Reviewed-on: https://code.wireshark.org/review/30280 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-10-17added new OPC UA 1.04 AttributesIdcacamille31-0/+5
Change-Id: I35963ca61792d41cf72895277e61c9fce3870200 Reviewed-on: https://code.wireshark.org/review/30234 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-03PROFINET: ARServerblock is correctly dissected.moguz1-5/+5
ARServerBlock function causes MalformedPacket error. Padding in the function is fixed. Change-Id: I498b1f15abcaab2a0be19096939fae5402747b68 Reviewed-on: https://code.wireshark.org/review/29899 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com> (cherry picked from commit c3b0bcaed51b80faaed1bdfbfae111ef162f9672) Reviewed-on: https://code.wireshark.org/review/29993
2018-10-03PROFINET: Decoding of DCP SetResBlockbasakkal1-4/+4
At SetResBlock, the field "Response" should be "Option" according to specification. It is corrected. Moreover, hf and display filter are changed. Change-Id: Ieae38616b130efc118673814f9fcee4241e75f05 Reviewed-on: https://code.wireshark.org/review/29988 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-27PROFINET: DynamicFramePacking subframes are decoded.basakkal1-1/+1
Last version of Wireshark can not decode DynamicFramePacking subframes. Changes are implemented to decode subframes. Change-Id: Ifba011418a5211d9599c48d37597a16733dfafa8 Reviewed-on: https://code.wireshark.org/review/29882 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-21ProfiNet: Fix order in AssetManagmentRoland Knall1-4/+4
According to the current Profinet specification in regard to the coding of the AM_DeviceIdentification field, the dissection order of DeviceId and VendorId is in the wrong order. Bug: 15140 Change-Id: I9954619a938db382967104de91e2b905677cc171 Reviewed-on: https://code.wireshark.org/review/29780 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-09-20checkAPIs: Add a max termout count for TRANSUM.Gerald Combs1-1/+2
Change-Id: I241da2d1c2e46947c31743f9527faa5884767ed9 Reviewed-on: https://code.wireshark.org/review/29763 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-19Try to discourage the use of APIs via counting.Gerald Combs4-6/+6
Add the ability to specify maximum function counts for each group to checkAPIs. Add maximum counts for the "termoutput" and "abort" groups where needed. Show summaries in various checkAPI targets. Switch uses of ws_g_warning back to plain g_warning. Change-Id: I5cbddc8c671729e424eed8551f69116d16491976 Reviewed-on: https://code.wireshark.org/review/29721 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-18TRANSUM: fix crash with current top of treePascal Quantin2-3/+7
ssl filters were renamed to tls. Also protect against not found fields to avoid a crash in the future. Change-Id: I181a252557b8261fa134b1331c31096a6205635f Reviewed-on: https://code.wireshark.org/review/29715 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-18PROFINET: AM_Reserved is added on AM_FirmwareOnlyInformationbasakkal1-0/+12
block According to specification, AM_FirmwareOnlyInformation is extended with AM_Reserved. Dissection of I&M3 was only for read response. Dissection is also added for write request. Change-Id: I281efa2324416b0f98d22ee4e50f2c8f711e2913 Reviewed-on: https://code.wireshark.org/review/29693 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-14opcua: prevent opcua dissector crash by limiting nesting depthHannes Mezger2-1/+37
The OPC UA types DiagnosticInfo, Variant and ExtensionObject can be nested, which can lead to stack overflows when parsing specially crafted packets. This is fixed by storing the current nesting depth as expert info. The corresponding CVE is https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-12086 The corresponding security bulletin of the OPC Foundation is https://opcfoundation-onlineapplications.org/faq/SecurityBulletins/OPC_Foundation_Security_Bulletin_CVE-2018-12086.pdf Change-Id: I5f6da3a3e269f6db1b690b77470ddf60045bcedd Reviewed-on: https://code.wireshark.org/review/29645 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21plugins: Minor interface improvementJoão Valverde1-1/+2
Change the plugin compatibility check to make it more convenient to define and check the major.minor Wireshark version. Change-Id: I2a6d2a746682c29504311cce5c457e0a852c3daf Reviewed-on: https://code.wireshark.org/review/29224 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-07-21Add a tap "finish" callback, called when a listener is removed.Guy Harris1-1/+1
Change-Id: Ic6c23dbd39d1adf8f730f1c866e409f731947475 Reviewed-on: https://code.wireshark.org/review/28786 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-14PROFINET: Refactoringgizem.yurdagul3-1070/+1080
According to the prediction, some new features will be added in the future. I'm working on the implementation of these new features. dissect_PNIO_status is updated as "extern" and transferred to the packet-pn.c. Because upcoming feature will have own c file and it will use this dissection. Thus, dependence between classes will be decreased and duplicated code lines will be prevented. So that future changes will be easier. Change-Id: I067d9582dcc8b9909e5a9bc3ab5f30d3c879b226 Reviewed-on: https://code.wireshark.org/review/28677 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-20 22:08:35 +0000