aboutsummaryrefslogtreecommitdiffstats
path: root/packet-snmp.c
AgeCommit message (Collapse)AuthorFilesLines
2004-01-23"sprint_realloc_value()" takes a "u_char **" as an argument - pass itGuy Harris1-3/+3
one. svn path=/trunk/; revision=9806
2004-01-23signed/unsigned warning fixesJörg Mayer1-18/+18
svn path=/trunk/; revision=9790
2004-01-17splitted some of the preferences texts into more than one line,Ulf Lamping1-2/+2
to reduce the size of the preferences dialog. This becoming necessary, as some of the texts were huge svn path=/trunk/; revision=9693
2003-11-16Export "protocol_t" as an opaque type.Guy Harris1-2/+2
Make "proto_is_protocol_enabled()" and "proto_get_protocol_short_name()" take a "protocol_t *" as an argument, so they don't have to look up the "protocol_t" - this will probably speed them up considerably, and they're called on almost every dissector handoff. Get rid of a number of "proto_is_protocol_enabled()" calls that aren't necessary (dissectors called through handles, including those called through dissector tables, or called as heuristic dissectors, aren't even called if their protocol isn't enabled). Change some direct dissector calls to go through handles. svn path=/trunk/; revision=8979
2003-11-02From Gisle Vanem:Gerald Combs1-1/+15
* Added a new function get_file_in_temp() to epan/filesystem.c. This because of asn1.dll plugin which had code to write to a log-file "c:\temp\ethereal.log". I feel this patch makes this safer; I don't even have a c:\temp dir. * Patched packet-asn1.c to use get_file_in_temp(). * Added some #undef to packet-snmp.c to silence gcc. * Changed "%u" -> "%lu" formats in util.c Rename get_file_in_temp() to get_tempfile_path() to match other function names. svn path=/trunk/; revision=8859
2003-10-29Plug that leak with a cleanup handler, so we don't leak the variable OIDGuy Harris1-3/+15
if we throw an exception fetching the variable value. svn path=/trunk/; revision=8818
2003-10-29...and there's one leak we missed.Guy Harris1-1/+2
svn path=/trunk/; revision=8817
2003-10-29Another leak that isn't.Guy Harris1-2/+1
svn path=/trunk/; revision=8816
2003-10-29Actually, one of those *isn't* a leak; don't free something we haven'tGuy Harris1-2/+1
allocated yet. svn path=/trunk/; revision=8815
2003-10-29Fix some memory leaks found by Steve Ford.Guy Harris1-1/+4
svn path=/trunk/; revision=8814
2003-09-08There is no such thing as a preference that's not set - stringGuy Harris1-28/+20
preferences are set to a null string if their value is null - so just initialize "mib_modules" to DEF_MIB_MODULES and then, in the register routine, override that with the setting of MIBS if it's set. svn path=/trunk/; revision=8417
2003-09-08Don't unload the MIBs unless we've loaded them.Guy Harris1-6/+10
svn path=/trunk/; revision=8416
2003-09-08From Kari Tiirikainen: have a preference setting giving the MIB moduleGuy Harris1-6/+83
list, and use that when loading MIBs. svn path=/trunk/; revision=8415
2003-09-06Handle SNMP-over-TCP.Guy Harris1-38/+184
svn path=/trunk/; revision=8401
2003-09-04Back out the previous change - sometimes the newlines should be mappedGuy Harris1-13/+1
to "\n", and other control characters should be, as the strings are text, not binary. We really need our own routines to do the formatting of SNMP variable values ourselves.... svn path=/trunk/; revision=8366
2003-08-04UCD SNMP sometimes puts newlines into the printable form of an SNMPGuy Harris1-1/+13
value; turn those newlines into spaces, as the text for a protocol tree item shouldn't contain newlines (or tabs, or any other non-printable characters). svn path=/trunk/; revision=8124
2003-06-19make snmp request id a filterable field instead of just a text entryRonnie Sahlberg1-3/+7
svn path=/trunk/; revision=7902
2003-05-03SNMP dissector enhancements:Laurent Deniel1-18/+116
- display OID in info column - preference added to disable such a display - add new function new_format_oid to retrieve both decoded and non decoded OID strings - add OID display filter for both decoded and non decoded strings - add Error Status display filter svn path=/trunk/; revision=7637
2003-04-27Replace some unchecked malloc calls by g_malloc.Laurent Deniel1-6/+6
svn path=/trunk/; revision=7584
2003-04-19Run strings through "format_text()" before putting them into items inGuy Harris1-44/+68
the protocol tree. Give SMUX filterable fields for the version and PDU type. svn path=/trunk/; revision=7499
2003-04-19Squelch a compiler warning.Guy Harris1-7/+8
svn path=/trunk/; revision=7497
2003-04-18From Thierry Andry: more filterable fields in SNMP.Guy Harris1-23/+59
svn path=/trunk/; revision=7495
2003-03-02From Jochen Friedrich: add support for:Guy Harris1-1/+3
HP extended 802.2 LLC HP-UX remote management over HP extended 802.2 LLC SNMP over HP extended 802.2 LLC. svn path=/trunk/; revision=7253
2003-01-28* Fix compilation errors with some installation of NET-SNMPLaurent Deniel1-7/+61
* Fix some compilation warnings (conservative changes here) svn path=/trunk/; revision=7028
2002-11-11"#ifdef" doesn't take Boolean expressions as arguments; use "#ifGuy Harris1-2/+2
defined(A) && defined(B)" to check whether both A and B are defined. svn path=/trunk/; revision=6613
2002-11-10Add tethereal's tap objects to Makefile.nmake's "clean" target.Gerald Combs1-2/+26
Instead of setting MIBDIRS in tethereal.c and gtk/main.c, set it in packet-snmp.c. svn path=/trunk/; revision=6606
2002-10-24Don't include the header file to get the SNMP version unless we'reGuy Harris1-5/+6
building with an SNMP library. If we have Net-SNMP, include <net-snmp/version.h>, not <ucd-snmp/version.h>. Don't include any of the SNMP headers unless HAVE_SOME_SNMP is defined. Include <net-snmp/config_api.h> if we have Net-SNMP, to declare "read_premib_configs()" and "read_configs()". Supply the include directories for Net-SNMP in the Makefile.nmake for GTK 1.2 and GTK 2. svn path=/trunk/; revision=6493
2002-10-24This helps packet-snmp.c compile if you don't HAVE_NET_SNMP or HAVE_UCD_SNMP.Tim Potter1-2/+2
svn path=/trunk/; revision=6492
2002-10-23From Wes Hardaker:Guy Harris1-4/+5
Define HAVE_SOME_SNMP if either HAVE_UCD_SNMP or HAVE_NET_SNMP is defined, and use HAVE_SOME_SNMP, rather than HAVE_UCD_SNMP, in most places when testing whether we have an SNMP library or not. Be more selective when including Net-SNMP header files. Fix up {gtk,gtk2}/main.c to do the same SNMP stuff that tethereal.c does - including the MIB stuff that gtk/main.c was doing but gtk2/main.c wasn't doing. Fix the copyright date in gtk/main.c. svn path=/trunk/; revision=6483
2002-10-22Wes Hardaker: Support NET-SNMP in addition to UCD-SNMPJörg Mayer1-29/+43
svn path=/trunk/; revision=6475
2002-08-28Removed trailing whitespaces from .h and .c files using theJörg Mayer1-45/+45
winapi_cleanup tool written by Patrik Stridvall for the wine project. svn path=/trunk/; revision=6117
2002-08-21Moved the generic true_false_string saying "Set", "Not set" intoTim Potter1-6/+1
epan/packet.c It was cut and pasted into seven other dissectors! svn path=/trunk/; revision=6052
2002-08-02Replace the types from sys/types.h and netinet/in.h by their glib.hJörg Mayer1-14/+6
equivalents for the toplevel directory. The removal of winsock2.h will hopefully not cause any problems under MSVC++, as those files using struct timeval still include wtap.h, which still includes winsock2.h. svn path=/trunk/; revision=5932
2002-05-30Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourthGuy Harris1-2/+3
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to run to the end of the parent tvbuff. svn path=/trunk/; revision=5597
2002-04-08If variables are used only if "HAVE_UCD_SNMP" is undefined, declare themGuy Harris1-2/+3
only if "HAVE_UCD_SNMP" is undefined. svn path=/trunk/; revision=5117
2002-04-01From Kikuchi Ayamura: include <ucd-snmp/ucd-snmp-config.h> to fix IRIXGuy Harris1-1/+2
compilation problems. svn path=/trunk/; revision=5073
2002-03-31(Conditionally) mark unused variables as such.Guy Harris1-3/+13
svn path=/trunk/; revision=5063
2002-03-26Make the UCD SNMP library read its configuration files, so that, forGuy Harris1-2/+15
example, you can configure it to read in MIB files other than the default ones. svn path=/trunk/; revision=5022
2002-03-12Get rid of the "--enable-snmp" option; instead, use "--with-ucdsnmp".Guy Harris1-26/+22
Make the directory option to "--with-ucdsnmp" optional. Handle "--with-ucdsnmp" similar to the way "--with-pcap" is handled. Get rid of unnecessary #defines in "packet-cops.c". Get rid of no-longer-necessary include of "dlfcn.h" in "packet-snmp.c". svn path=/trunk/; revision=4930
2002-03-11"format_var()" returns a "malloc()"ed string, not a "g_malloc()"edGuy Harris1-5/+6
string; free it with "free()", not "g_free()". svn path=/trunk/; revision=4925
2002-03-11If we're linking with the UCD SNMP library, make "format_oid()" append aGuy Harris1-45/+35
display of the symbolic form of the OID. Remove code that used to do that outside of "format_oid()". Export "format_oid()" from "packet-snmp.c" and use it in "packet-cops.c". Remove support for CMU SNMP and older versions of UCD SNMP from "packet-cops.c", as it has been removed from the rest of Ethereal. svn path=/trunk/; revision=4924
2002-03-11The "val_len" member of a "struct variable_list" should be set to theGuy Harris1-7/+6
length of the variable's value, in bytes, not the length of the BER encoding of that variable's value. The latter setting means it won't be correct for object IDs. svn path=/trunk/; revision=4922
2002-03-10Use "ds_set_int()", not "snmp_set_suffix_only()", to set the "printGuy Harris1-2/+2
suffixes only" setting. svn path=/trunk/; revision=4916
2002-03-10Use the "sprint_realloc_" routines in UCD SNMP 4.2.2 and later, ratherGuy Harris1-419/+128
than the "sprint_" routines in UCD and CMU SNMP; the latter routines have no bounds checking, and if you use them you cannot protect against buffer overflows. As we now require UCD SNMP 4.2.2 or later: 1) we no longer need code to support CMU SNMP; 2) we no longer need code to work around problems with UCD SNMP 4.1.1; and, as we no longer use the "sprint_" routines, we no longer need code to work around the changed API and ABI of those routines in some nonstandard versions of the UCD SNMP library. svn path=/trunk/; revision=4914
2002-03-06Check to make sure SNMP_IPADDR items are 4 bytes long and SNMP_COUNTER64Guy Harris1-3/+38
items are 8 bytes long. svn path=/trunk/; revision=4882
2002-03-01Add a routine to "asn1.c" to translate ASN1_ERR_ values to strings. UseGuy Harris1-29/+5
that in the SNMP dissector. Check the return values of ASN.1 routines in the LDAP dissector, and have all the subroutines in that disesctor that can return error indications return ASN1_ERR_ values. Have the routines that can supply a pointer to a newly-created protocol-tree item use the right type for items ("proto_item *", not "proto_tree *", even though they are, at least currently, typedefs for the same type), and use "proto_item" for the type of the item a pointer to which is passed to those routines. Before calling those routines, set the item pointer to null, in case the routine fails. Don't check the return value of "parse_filter_strings()" against -1 - that routine can't return -1. svn path=/trunk/; revision=4833
2002-02-19From Andrew Hood: translate enterprise OIDs in SNMP traps to strings ifGuy Harris1-1/+13
possible. svn path=/trunk/; revision=4758
2002-01-24Replace a bunch of "tvb_length()" and "tvb_length_remaining()" calls inGuy Harris1-5/+3
arguments to "proto_tree_add_text()", and to "proto_tree_add_XXX()" calls that add FT_NONE or FT_PROTO items to the protocol tree, with -1. Replace some calls to "tvb_length()" or "tvb_length_remaining()" with calls to "tvb_reported_length()" and "tvb_reported_length_remaining()", as those give the actual length of the data in the packet, not just the data that happened to be captured. svn path=/trunk/; revision=4605
2002-01-21Include files from the "epan" directory and subdirectories thereof withGuy Harris1-4/+4
"epan/..." pathnames, so as to avoid collisions with header files in any of the directories in which we look (e.g., "proto.h", as some other package has its own "proto.h" file which it installs in the top-level include directory). Don't add "-I" flags to search "epan", as that's no longer necessary (and we want includes of "epan" headers to fail if the "epan/" is left out, so that we don't re-introduce includes lacking "epan/"). svn path=/trunk/; revision=4586
2001-12-12Work around changes made to recent Red Hat ucd-snmp packages. SeeGerald Combs1-1/+17
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57421 for details. svn path=/trunk/; revision=4387