aboutsummaryrefslogtreecommitdiffstats
path: root/packet-ncp2222.inc
AgeCommit message (Collapse)AuthorFilesLines
2003-04-09Clean up the handling of the completion code.Guy Harris1-7/+8
svn path=/trunk/; revision=7424
2003-04-08From Greg Morris: update the introductory comment, fix the handlingGuy Harris1-6/+9
of the completion code, and tweak the description of continuation fragments. svn path=/trunk/; revision=7416
2003-02-25From Greg Morris: don't delete the EID hash table after the first pass,Guy Harris1-29/+20
as it's needed whenever a packet is dissected. svn path=/trunk/; revision=7200
2003-02-19Updates from Greg Morris:Guy Harris1-10/+270
1. Added a number of NCP Error return values. 2. Added ability to pass byte strings to summary window. 3. Modified file NCP's to reflect file handle in summary window. 4. Changed all NCP's using QueueID from big endian to little endian. This is different from Novell's NCP documentation but matches same information obtained from NDS dissector. 5. Added over 50 more NDS error return values. 6. Partially fixed NDS Request verb 6 (Search Entries) svn path=/trunk/; revision=7172
2003-02-08The hour and minute fields of times go from 0 to 23 and 0 to 59, soGuy Harris1-3/+3
adding 1 to them is incorrect (and cannot possibly be correct, as that'd rule out 0 as valid values, meaning nothing can ever happen in the first hour after midnight or in the first minute after the hour). svn path=/trunk/; revision=7099
2003-01-22Keep track of and display the time between Call and Reply in NCP packets.Ronnie Sahlberg1-1/+18
svn path=/trunk/; revision=6968
2003-01-06Fix up the display of the "ncp.nds_time_filter" field.Guy Harris1-2/+2
svn path=/trunk/; revision=6852
2002-12-02Don't cast away constness, and fix variable and structure memberGuy Harris1-14/+14
qualifiers as necessary to ensure that we don't have to. "strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't test their results as if they did. Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes. Update Michael Tuexen's e-mail address. svn path=/trunk/; revision=6726
2002-10-22Put in a note about the completion code not appearing to be present inGuy Harris1-1/+7
replies to continuation messages (or, at least, not present in the obvious place). svn path=/trunk/; revision=6470
2002-10-21From Greg Morris:Guy Harris1-155/+665
Various NDS dissector enhancements including NDS verb 0x07, and proper ping flags for NDS ping version 10 request. Updated error codes for several NCP reply packets. NDPS enhancements. svn path=/trunk/; revision=6463
2002-10-19Get rid of all places where "vstring" is set to point to a null stringGuy Harris1-161/+17
constant, as that won't work with "get_string()" (it'll try to overwrite the constant, and either crash, trash memory, or both). svn path=/trunk/; revision=6460
2002-10-19From Greg Morris: put a buffer into "nw_uni_t", and make "get_string()"Guy Harris1-25/+10
fill that in. svn path=/trunk/; revision=6456
2002-10-16Clean up white space.Guy Harris1-32/+50
Clean up the stuff to handle MVTYPE_PROC_ENTRY_SPECIFIERS a bit, and put in comments explaining what's going on for that and MVTYPE_ATTR_REQUEST. svn path=/trunk/; revision=6439
2002-10-16Use #defines for multivalue types.Guy Harris1-69/+84
svn path=/trunk/; revision=6438
2002-10-16Make some counters 32-bit, as the upper limit on the loop in whichGuy Harris1-86/+86
they're used is 32-bit. Use "%u" rather than "%d" to print unsigned values. svn path=/trunk/; revision=6437
2002-10-16Use #defines for vtype values, rather than numbers.Guy Harris1-262/+272
svn path=/trunk/; revision=6436
2002-10-16Make arrays of "nds_val" structures rather than declaring a bunch ofGuy Harris1-2765/+2130
individual structures, and initialize them, and put them into the protocol tree, in a loop. svn path=/trunk/; revision=6435
2002-10-15Fully initialize an ncp_req_hash_value after allocating it.Guy Harris1-1/+4
svn path=/trunk/; revision=6431
2002-10-15We'll be building a protocol tree for all NDS Ping packets, so we canGuy Harris1-39/+35
just wrap the entire dissection in an "if", as was done before. (Actually, we can just skip the "if" entirely, I guess....) svn path=/trunk/; revision=6429
2002-10-15Set the "req_nds_flags" field for an NDS Ping request regardless ofGuy Harris1-100/+90
whether we're building a protocol tree or not. Set the separator if we put "Revision" into the summary. Check for a remaining length >= 8, not > 8, to check for an NDS version 10 or later ping, and check the reported length, not the captued length. svn path=/trunk/; revision=6428
2002-10-14Create the temporary tree if we're *not* building a protocol treeGuy Harris1-2/+2
already, not if we *are*. svn path=/trunk/; revision=6414
2002-10-11Make the flag buffer in "dissect_ping_req()" large enough to hold theGuy Harris1-8/+7
longest possible flag string. Don't create a temporary protocol tree unless we're not filling in a protocol tree. The NDS version isn't present in NDS pings prior to version 10; dissect it only if it's present. svn path=/trunk/; revision=6412
2002-10-11Note that "dissect_ping_req()" duplicates a bunch of stuff inGuy Harris1-6/+10
"dissect_ncp_request()". Fix "dissect_ping_req()" to properly put the NDS version in a ping request into the tree (although that field isn't present in the ping requests I've seen, so perhaps it's only in NDS version 10 and later), as big-endian (change FALSE to TRUE if it's little-endian). Get rid of the unused "ncp_nds_verb" variable (set, but not used) in "dissect_ncp_common()". Call "dissect_ping_req()" from "dissect_ncp_common()" again. svn path=/trunk/; revision=6411
2002-10-10Fix some spelling errors.Guy Harris1-50/+50
svn path=/trunk/; revision=6410
2002-10-10Rename "ncp.nds_string" to "ncp.nds_tree_name", as it's not a genericGuy Harris1-15/+10
string, it's a tree name (as the field's display name suggests). Get rid of the unused "ncp.nds_string_value" field. Fix up the names of some fields, and use "proto_tree_add_uint()" rather than "proto_tree_add_uint_format()" to add them to the protocol tree. svn path=/trunk/; revision=6408
2002-10-10Fix up the handling of bitfields in NDS messages - get rid of extraGuy Harris1-78/+74
blanks, and don't put the list of flag values in if no bits are set. svn path=/trunk/; revision=6407
2002-10-10"proto_tree_add_string_format()" requires that the string value beGuy Harris1-13/+16
passed as an argument before the format string; fix some calls to do so. svn path=/trunk/; revision=6405
2002-10-10When deciding whether to put "NDS" into the protocol field in the packetGuy Harris1-15/+17
list, check whether the protocol field is enabled, not whether the info field is enabled. Update the protocol field before trying to look at the packet, so it gets updated even for short packets. Only parse service reply packets as NDS packets; don't parse positive ack packets that way. svn path=/trunk/; revision=6404
2002-10-10Don't attach the string for an NDS error to the completion code - attachGuy Harris1-30/+8
the string for the completion code. Do put the string for the NDS error into the summary line, however. Don't clear the NDS error code if we can't translate it to a string. svn path=/trunk/; revision=6400
2002-10-10"#if 0" out the code in "get_string()", as it will probably causeGuy Harris1-3/+15
crashes on many platforms, and other random behavior on others. Don't create a temporary tree with an NCP tree underneath it if we already have an NCP tree; we don't want the results of a dissection to be stuck in an invisible temporary tree if we're supposed to be generating a protocol tree. svn path=/trunk/; revision=6399
2002-10-08From cjs 2895: get rid of C++ comments, so IBM's Visual Age C compilerGuy Harris1-3/+3
can compile the code. Note that Bill Fumerola rewrote the Cisco NetFlow dissector. Update a bunch of addresses in the Ethereal man page, and put some missing addresses in. svn path=/trunk/; revision=6380
2002-10-08Make some variables unsigned to remove some compiler warnings.Guy Harris1-3/+3
svn path=/trunk/; revision=6377
2002-09-26Warning fixes for the ncp code by Greg Morris and J�rg Mayer.Jörg Mayer1-25/+12
svn path=/trunk/; revision=6338
2002-09-25Greg Morris:Jörg Mayer1-49/+81
This update adds NCP 87/66. Also add additional error codes, added hf_definition for super class (NDS). Cleaned up some unused variables (Warnings when building Ethereal). Fixed NCP type 0x9999 (server busy packets to echo information to summary information), Added subtree format to NDS dissector to cleanup display. svn path=/trunk/; revision=6331
2002-09-22Fix some (but not all) compiler warnings.Gerald Combs1-10/+10
svn path=/trunk/; revision=6317
2002-09-22From Greg Morris: More NDS decodes.Gerald Combs1-112/+7267
Fix a typo in get_string(). svn path=/trunk/; revision=6313
2002-08-25NDS fragment handles are 32 bits, according to Greg Morris.Guy Harris1-7/+6
svn path=/trunk/; revision=6084
2002-08-23Give the NDS Verb field a value_string table, so you can filter on itGuy Harris1-302/+65
without having to know the numerical values for the verbs. Use that table to convert the verb value to a verb name. Fix indentation. svn path=/trunk/; revision=6075
2002-08-23Note to the person who checked in the previous change: that's "alreadyGuy Harris1-2/+2
have", not "don't have". :-) svn path=/trunk/; revision=6074
2002-08-23In "dissect_nds_request()", if we already have a tree into which to putGuy Harris1-3/+2
items, don't create the temporary tree. svn path=/trunk/; revision=6073
2002-08-23From Greg Morris:Gilbert Ramirez1-37/+504
1. Secret Store Services (NCP 94) (ncp2222.py) 2. NMAS (NCP 92) (ncp2222.py) 3. NDS information in summary screen (packet-ncp.c & packet-ncp2222.inc) 4. Sever broadcast packets (NCP type 0xbbbb) to notify workstation to clear op-lock (packet-ncp.c) 5. Large Internet Packets (LIP) (packet-ncp.c) 6. Unicode Support. (unicode_to_string function in packet-ncp2222.inc & ncp2222.py) svn path=/trunk/; revision=6069
2002-05-16Move the #defines for NCP packet types to "packet-ncp-int.h", and useGuy Harris1-7/+23
them in "packet-ncp2222.inc". The page at http://www.odyssea.com/whats_new/tcpipnet/tcpipnet.html indicates that a positive ACK (0x9999) NCP packet has the same completion code and connection status fields as a reply (0x3333) packet (but nothing after them); hand "dissect_ncp_reply()" the packet type as one of its arguments, and have it handle positive ACK packets as well as reply packets. It also indicates that bit 4 of the connection status indicates that the server is unavailable, and the page at http://www.unm.edu/~network/presentations/course/appendix/appendix_f/tsld088.htm speaks of that and of the significance of other bits; put a comment in "ncp2222.py", before the "hf_ncp_connection_status" field, about that. From looking at a capture, it appears that a "destroy service connection" (0x5555) packet should be treated like a "create service connection" (0x1111) packet and be handed to "dissect_ncp_request()". Note that perhaps watchdog packets should be handled by "dissect_ncp_reply()" as well. svn path=/trunk/; revision=5489
2002-05-16For response packets, add a field showing the number of the frameGilbert Ramirez1-1/+9
containing the request packet. svn path=/trunk/; revision=5485
2002-05-11Put in a note about date and time formats.Guy Harris1-1/+17
svn path=/trunk/; revision=5451
2002-05-09Merge the work in Novell_NCP_branch into the mainline code.Gilbert Ramirez1-55/+625
A little work still needs to be done on the new NCP dissector -- make some of the COL_INFO texts more useful, handle a Unicode issue, and modify some of the cases that use "request conditions". But the NCP dissector as it stands is very usable now. Note: I didn't merge in the PROTO_LENGTH_UNTIL_END macro... I wanted to think about the various possible macros and review an email conversation I had with Guy on the subject. svn path=/trunk/; revision=5432
2002-04-04Remove unused variable.Gilbert Ramirez1-2/+1
svn path=/trunk/; revision=5094
2002-01-10Allow NCP types to define bitfields. In order to implementGilbert Ramirez1-3/+49
sub-trees, I added new functions to ptvcursor: ptvcursor_add_no_advance() ptvcursor_tvbuff() ptvcursor_current_offset() Note that no NCP type that actually uses bitfields has been checked in yet. svn path=/trunk/; revision=4509
2002-01-05Long NCP traces can easily have many packets whose "uniqueness"Gilbert Ramirez1-13/+21
variables wrap-around. Since the request/reply packets are related via a hash based on these uniqueness variables, long NCP traces can have mis-matches reqeust/reply records. Thus, only do the hash-lookup for the reply packet during the first sequential scan of the trace file. Once the pertinent info is found, store it in the packet's private data area. Since the memory allocated for the hash and for the structures that make up the keys are no longer needed after the first sequential run through the trace file, arrange to free that memory after the first sequential run. Similar to the register_init_routine() that allows dissectors to register callbacks for calling *before* a capture file is loaded, set up a register_postseq_cleanup_routine() function that allows dissectors to register callbacks for calling *after* the first sequential run-through of the trace file is made. This is not a *final* cleanup callback, since Ethereal will still have that trace file open for random-access reading. I didn't have tethereal call postseq_cleanup_all_protocols() since tethereal doesn't keep the trace file open for random-access reading. I could easily be swayed to make tethereal call that function, however. svn path=/trunk/; revision=4484
2001-12-10Move the pointer to the "column_info" structure in the "frame_data"Guy Harris1-7/+7
structure to the "packet_info" structure; only stuff that's permanently stored with each frame should be in the "frame_data" structure, and the "column_info" structure is not guaranteed to hold the column values for that frame at all times - it was only in the "frame_data" structure so that it could be passed to dissectors, and, as all dissectors are now passed a pointer to a "packet_info" structure, it could just as well be put in the "packet_info" structure. That saves memory, by shrinking the "frame_data" structure (there's one of those per frame), and also lets us clean up the code a bit. svn path=/trunk/; revision=4370
2001-11-13Hopefully the last time I have to change my e-mail address.Gilbert Ramirez1-2/+2
svn path=/trunk/; revision=4199
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 10:12:25 +0000