Age | Commit message (Collapse) | Author | Files | Lines |
|
length of the IU must be at least 2 bytes in order to dissect the
contents.
Just use "proto_tree_add_item()" to add the value of the private
extension, and do so only if it's not zero-length.
svn path=/trunk/; revision=10518
|
|
svn path=/trunk/; revision=10248
|
|
"tvb_memcpy()"ing to it, and putting in a null terminator;
"tvb_get_string()" will check whether all bytes of the string are
present before allocating the buffer, so that you don't leak memory if
the copy throws an exception, and don't crash if the length is absurdly
large.
Use "tvb_memdup()" instead of allocating a buffer and "tvb_memcpy()"ing
to it, so that an exception is thrown before you try to allocate the
buffer (for the same reasons as listed above).
Before allocating a buffer used when processing a chunk of data from a
packet, get a pointer to the chunk with "tvb_get_ptr()", or check that
the data is all there with "tvb_ensure_bytes_exist()", so that an
exception is thrown before you try to allocate the buffer (for the same
reasons as listed above).
Fix up the lengths of the tvbuff used when dissecting ONC RPC opaque data
with a particular dissector.
svn path=/trunk/; revision=10236
|
|
make it a "guint", not just a "guint8".
svn path=/trunk/; revision=9569
|
|
svn path=/trunk/; revision=9561
|
|
svn path=/trunk/; revision=9115
|
|
svn path=/trunk/; revision=8749
|
|
merge gtpv0 and gtpv1 dissectors into one;
fix up XXX_to_str routines.
svn path=/trunk/; revision=8715
|
|
svn path=/trunk/; revision=8714
|
|
1) not to rely on their static buffers being initialized;
2) not to bother checking whether a BCD digit is a valid digit
or not (index into a 16-element array, instead);
3) to work correctly, in the case of "id_to_str()".
svn path=/trunk/; revision=8705
|
|
svn path=/trunk/; revision=8665
|
|
svn path=/trunk/; revision=8509
|
|
variable.
svn path=/trunk/; revision=8504
|
|
svn path=/trunk/; revision=8492
|
|
msisdn_to_str().
Do the same for imsi_to_str().
svn path=/trunk/; revision=8491
|
|
signed-vs-unsigned-comparison complaint in one case, and it's a
generally good habit.
svn path=/trunk/; revision=8469
|
|
in it, imsi_to_str(), and id_to_str() a bit.
svn path=/trunk/; revision=8468
|
|
svn path=/trunk/; revision=8467
|
|
Extract the FCS decoding section of the PPP_HDLC dissector to
allow the CHDLC dissector to use the same routine.
The ppp_options used for preferences has been renamed to
fcs_options and exported via packet-ppp.h so CHDLC gets a
separate (but identical) FCS preference.
This means prefs.h has to be included before packet-ppp.h so a
couple of ppp related files (packet-{gtp,null,raw,vj}.c) had
their includes slightly re-arranged.
From me: make the PPP/CHDLC FCS code use "crc32()" to check the 32-bit
FCS.
svn path=/trunk/; revision=8266
|
|
"mm_sec_modep[]" to decode the security type.
svn path=/trunk/; revision=8005
|
|
have other dissectors that use them fetch them with
"find_dissector_table()".
svn path=/trunk/; revision=7601
|
|
Comparing It Against An 8-bit Or Longer Length To Make Sure It Doesn't
Go Past The Length, because if the length is 255, it can't ever go past
it as it'll overflow if it does.
svn path=/trunk/; revision=7093
|
|
svn path=/trunk/; revision=7066
|
|
belongs, as that's redundant.
Fix a bunch of cases where that was done, and map the old name to the
new name.
Instead of marking "mtp3.mtp3_standard" as obsolete, map it to
"mtp3.standard".
svn path=/trunk/; revision=7030
|
|
messages, as recommended by recent 3GPP recommendations.
svn path=/trunk/; revision=6836
|
|
mobile network code greater than 9.
svn path=/trunk/; revision=6775
|
|
gtpv0 decoder.
svn path=/trunk/; revision=6749
|
|
- more typos corrected
- changed "Teardown indication" to "Teardown Indicator"
The official name is Teardown Ind, but 3GPP TS 29.060 also
refers to it as Teardown Indicator
- bugfix: I had moved the call to col_append_str_gtp() one bracket
too far resulting in display of "GTP <GTP>" or "GTP-U <GTP-C>".
svn path=/trunk/; revision=6619
|
|
item to look more-or-less like a PPP packet, just dissect it in place
and hand off to the appropriate subdissector using the PPP dissector's
handoff table (which we export, along with its value_string table for
protocol IDs, which we use to report the protocol ID symbolically).
This means there's no point in having a configurable option to control
whether to do that tweaking; make it an obsolete option.
Bring "col_get_writable()" back from the dead, and have the GTP
dissector save the current "writable" flag for columns, mark the columns
non-writable before calling the subdissector for the PPP configuration
protocol, and restore the state of the writable flag, rather than
putting the columns back after the PPP configuration protocol's
dissector is done.
Fix some more typos in comments.
Don't register the IP dissector in the "ppp.protocol" table in the GTP
dissector's handoff registration routine - it's already being done in
the IP dissector's handoff routine.
Fix the name for CHAP to match what RFC 1994 calls it (if the name
changed, it should be changed in all places, but, at least according to
this message, a while ago, from Bob Sutterfield, "since the RFC defines
the protocol, the RFC defines the name":
http://mail-index.netbsd.org/netbsd-help/1996/05/16/0011.html
and the RFC defines the name as "PPP Challenge Handshake Authentication
Protocol (CHAP)").
svn path=/trunk/; revision=6617
|
|
- correct typos in comments
- remove obsoleted definition of GTP_PPP_0x00, ...
- remove distinction between GTP and PPP for col_append_str_gtp(),
because this layer is GTP (or GTP-U), but never PPP
svn path=/trunk/; revision=6614
|
|
Replace the handling of PPP packets over GTPv1 and also
establish the handling of PPP packet over GTPv0. Additionally
IPv6 packets are handled in GTPv0 and GTPv1.
Explanation:
- old solution: examining the known PPP protocols is a tough
task, because there might be more in the future -> the list
must be extended more and more (the octet 0x00 has already
been added for PPP network layer protocols, but for protocol
field compression a lot of protocols must be inserted for
IPv4(0x21), IPv6(0x57), maybe IPX (0x2b) or AppleTalk (0x29),
...)
- new solution: It is easier the other way: the most significant
nibble of the first octet must be 4 for IPv4 and 6 for IPv6.
All other values are assumed to be PPP packets, including
packets beginning with values 0x40-0x44 (header too short for
IPv4 packet) and value 0x4f (PPP protocol type (IPv6 header
compression protocol) taking precedence over IPv4 packets with
header length of 60 octets).
svn path=/trunk/; revision=6568
|
|
svn path=/trunk/; revision=6565
|
|
svn path=/trunk/; revision=6537
|
|
one byte, so fetch it with "tvb_get_guint8()", not "tvb_get_ntohl()".
Put in the location in the GPRS standard where that's defined, while
we're at it.
svn path=/trunk/; revision=6533
|
|
svn path=/trunk/; revision=6512
|
|
what they are - well, bit strings, really, but...). Doing so also fixes
a bug, as "decode_gtp_auth_tri()" was copying 16 bytes to an array that
was 8 bytes long....
Do the same for byte-string elements of a quintuplet - and show as byte
strings some elements that weren't being shown at all.
svn path=/trunk/; revision=6511
|
|
svn path=/trunk/; revision=6143
|
|
Windows that cause compiler warnings.
svn path=/trunk/; revision=6129
|
|
winapi_cleanup tool written by Patrik Stridvall for the wine
project.
svn path=/trunk/; revision=6117
|
|
svn path=/trunk/; revision=6091
|
|
Merge all the cases for handling PPP together.
svn path=/trunk/; revision=6078
|
|
rate in GTP v1 (they were swapped).
svn path=/trunk/; revision=6070
|
|
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.
svn path=/trunk/; revision=5932
|
|
dftest.c:
Remove #if-0-ed includes
packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
packet-wtp.c, ethereal_gen.py:
Remove redundant include varargs (already in snprintf.h,
and required only for snprintf.h)
Remove unused include of snprintf.h from files not using
"snprintf()".
svn path=/trunk/; revision=5889
|
|
Fixed TFT decoding and processing PPP payload inside of GTP
protocol conf options
That change also put all GTP preferences under a "gtp" heading; put in
another hack so that your old "gtpv0" and "gtpv1" settings are recognized.
svn path=/trunk/; revision=5588
|
|
svn path=/trunk/; revision=5586
|
|
static, and add a new "packet-data.h" to declare "proto_data".
Display escape sequences in octal in the IAPP dissector, as is now done
in the RADIUS dissector.
svn path=/trunk/; revision=5441
|
|
svn path=/trunk/; revision=5361
|
|
functions, from David Frascone.
svn path=/trunk/; revision=5288
|
|
svn path=/trunk/; revision=5131
|