aboutsummaryrefslogtreecommitdiffstats
path: root/packet-diameter.c
AgeCommit message (Collapse)AuthorFilesLines
2003-10-29From Steve Ford: "prefs_register_string_preference()" makes a copy ofGuy Harris1-5/+17
any string pointed to by the preference variable - as the value we set it to is allocated, we should free it after registering the preference. The register routine is called only once - don't worry about whether "gbl_diameterDictionary" is null or not. Get rid of a duplicate credit entry in the man page. svn path=/trunk/; revision=8813
2003-07-09Removed duplicate definitions of flags_set_truth.Tim Potter1-6/+1
svn path=/trunk/; revision=8001
2003-05-15From Richard Urwin:Guy Harris1-7/+3
add support for a system-wide color filter file; fix a bug where "read_filters()" didn't close the file handle. Use the "get_datafile_path()" routine he added to construct the pathname of the Diameter directory, the global preferences file, and the manuf file. svn path=/trunk/; revision=7677
2003-04-12Fix a typo.Guy Harris1-2/+2
svn path=/trunk/; revision=7441
2003-04-10From David Frascone: use a string constant rather than a global variableGuy Harris1-6/+2
for the full name of the Diameter protocol. svn path=/trunk/; revision=7434
2002-12-02Don't cast away constness, and fix variable and structure memberGuy Harris1-15/+13
qualifiers as necessary to ensure that we don't have to. "strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't test their results as if they did. Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes. Update Michael Tuexen's e-mail address. svn path=/trunk/; revision=6726
2002-08-28Removed trailing whitespaces from .h and .c files using theJörg Mayer1-68/+68
winapi_cleanup tool written by Patrik Stridvall for the wine project. svn path=/trunk/; revision=6117
2002-08-02Replace the types from sys/types.h and netinet/in.h by their glib.hJörg Mayer1-17/+9
equivalents for the toplevel directory. The removal of winsock2.h will hopefully not cause any problems under MSVC++, as those files using struct timeval still include wtap.h, which still includes winsock2.h. svn path=/trunk/; revision=5932
2002-05-10From Joerg Mayer: make a pile of stuff not used outside one source fileGuy Harris1-2/+2
static, and add a new "packet-data.h" to declare "proto_data". Display escape sequences in octal in the IAPP dissector, as is now done in the RADIUS dissector. svn path=/trunk/; revision=5441
2002-05-02From Joerg Mayer: get rid of unused arguments.Guy Harris1-12/+12
svn path=/trunk/; revision=5364
2002-04-29Removal (or, at least, #ifdeffing out) of unused variables andGuy Harris1-3/+1
functions, from David Frascone. svn path=/trunk/; revision=5288
2002-03-05From David Frascone: fix pathname of Diameter directory file.Guy Harris1-3/+2
svn path=/trunk/; revision=4869
2002-01-31Don't copy the AVP data to a buffer from the tvbuff and then extractGuy Harris1-93/+131
stuff from the buffer - extract what you need directly from the tvbuff. (And definitely don't extract stuff from the buffer if you haven't copied stuff to it.) For integral AVP items, check the length of the item before processing it. Put time items into the protocol tree as times, not as byte arrays. svn path=/trunk/; revision=4645
2002-01-30Include <string.h> to declare various string functions.Guy Harris1-9/+14
Include "snprintf.h", when needed, to declare "snprintf()" on platforms that don't have it. Fix some formats and arguments to various printing routines. Fix "diameter_time_to_string()" to properly fetch the time value from the data buffer handed to it. svn path=/trunk/; revision=4639
2002-01-21Convert some "col_add_str()" calls to "col_set_str()".Guy Harris1-2/+2
svn path=/trunk/; revision=4592
2002-01-21Include files from the "epan" directory and subdirectories thereof withGuy Harris1-4/+4
"epan/..." pathnames, so as to avoid collisions with header files in any of the directories in which we look (e.g., "proto.h", as some other package has its own "proto.h" file which it installs in the top-level include directory). Don't add "-I" flags to search "epan", as that's no longer necessary (and we want includes of "epan" headers to fail if the "epan/" is left out, so that we don't re-introduce includes lacking "epan/"). svn path=/trunk/; revision=4586
2002-01-15Fix some preferences to eliminate the extra copy of the protocol name atGuy Harris1-2/+2
the beginning, and to use underscores rather than periods where the preference's name really isn't part of a hierarchical namespace. Use "%u" rather than "%d" to print unsigned quantities. svn path=/trunk/; revision=4543
2002-01-08Use "%u", not "%d", to print unsigned quantities.Guy Harris1-5/+5
svn path=/trunk/; revision=4496
2002-01-07Vendor ID lookup fix, from David Frascone.Guy Harris1-54/+141
svn path=/trunk/; revision=4494
2001-12-10Move the pointer to the "column_info" structure in the "frame_data"Guy Harris1-10/+10
structure to the "packet_info" structure; only stuff that's permanently stored with each frame should be in the "frame_data" structure, and the "column_info" structure is not guaranteed to hold the column values for that frame at all times - it was only in the "frame_data" structure so that it could be passed to dissectors, and, as all dissectors are now passed a pointer to a "packet_info" structure, it could just as well be put in the "packet_info" structure. That saves memory, by shrinking the "frame_data" structure (there's one of those per frame), and also lets us clean up the code a bit. svn path=/trunk/; revision=4370
2001-12-03Make "dissector_add()", "dissector_delete()", and "dissector_change()"Guy Harris1-10/+14
take a dissector handle as an argument, rather than a pointer to a dissector function and a protocol ID. Associate dissector handles with dissector table entries. svn path=/trunk/; revision=4308
2001-11-27Thou shalt not use C++-style comments in C code, for they upset some CGuy Harris1-2/+2
compilers. svn path=/trunk/; revision=4284
2001-11-21Get rid of some unused variables.Guy Harris1-6/+1
svn path=/trunk/; revision=4241
2001-11-04Allow a dissector to register preferences that it no longer supports asGuy Harris1-1/+6
obsolete; we silently ignore attempts to set those in a preferences file, so that we don't spam the user with error messages caused by them having saved preferences in an earlier release that contained those preferences. Make the Diameter and iSCSI dissectors register obsolete preferences. Crash if some code tries to register a preferences module with a name that contains something other than lower-case ASCII letters, numbers, or underscores, or that has already been registered, or if some code tries to register a preference with a name that contains something other than lower-case ASCII letters, numbers, underscores, or periods, or that has already been registered, so that we don't put code like that in a release and have to shovel code into "prefs.c" to fix it up later. (The problem with multiple modules or preferences with the same name should be obvious; the problem with names with blanks, or upper-case letters, or punctuation, is that they're a pain to type on the command line.) svn path=/trunk/; revision=4148
2001-11-03Clean up the Info column, by leaving the ": " that separates badGuy Harris1-2/+5
packet/flag information from the PDU type if there's no bad packet or flag informatin. svn path=/trunk/; revision=4144
2001-11-03Support for desegmentation of Diameter-over-TCP, from David Frascone.Guy Harris1-11/+77
svn path=/trunk/; revision=4141
2001-11-03In "addStaticAVP()", add the new entry to the list of AVP types afterGuy Harris1-1/+5
it's filled in. svn path=/trunk/; revision=4137
2001-11-02Add support for 64-bit signed integers in "int-64bit.[ch]", add anGuy Harris1-10/+4
FT_INT64 type, and make the Diameter dissector use it. Handle the 64-bit integer types in the display filter semantics checks. svn path=/trunk/; revision=4125
2001-11-01From David Frascone: duUpdate to Diameter dissector to load theGuy Harris1-101/+867
dictionary as an XML file rather than building it in, and various Diameter updates. svn path=/trunk/; revision=4122
2001-10-29From Ronnie Sahlberg: FT_UINT64 support, code to handle 64-bit integersGuy Harris1-10/+3
without requiring compiler support for them, and updates to the Diameter, L2TP, NFS, and NLM dissectors to use it and to the ONC RPC dissector to allow ONC RPC subdissectors to use it. svn path=/trunk/; revision=4099
2001-08-04Don't cast "data" to "unsigned long long"; "long long" - or whateverGuy Harris1-2/+2
data type "gint64" really is - should be sufficiient for a %llx format, and not all compilers that support 64-bit data types have "long long". svn path=/trunk/; revision=3820
2001-07-30From David Frascone: update to the DIAMETER dissector forGuy Harris1-603/+699
draft-ietf-aaa-diameter-07. His changenotes: Changes: o Flags are now done properly. (I changed it to dissect them like packet-tcp.c does) o Completely re-did the dictionary. I think it is much more maintainable now. And, it is no longer dynamically generated. o Added some lookup routines to work with new dictionary. o Removed lots of old lookup stuff that had been cloned from packet-radius.c. It's much cleaner now. svn path=/trunk/; revision=3799
2001-07-15Fixes, from Scott Renfro, for some calls to "localtime()" that didn'tGuy Harris1-5/+9
check whether the call succeeded (it doesn't always do so on Windows, for example). svn path=/trunk/; revision=3722
2001-06-18From Joerg Mayer: explicitly fill in all members of aGuy Harris1-23/+23
"header_field_info" structure, including the ones that are later set by the routines to register fields. svn path=/trunk/; revision=3561
2001-05-27Fix the copyright notice to reflect the fact that Gerald holds theGuy Harris1-3/+4
copyright on Ethereal as a whole. svn path=/trunk/; revision=3473
2001-04-10Updates from David Frascone.Guy Harris1-12/+34
svn path=/trunk/; revision=3287
2001-02-23Updates from David Frascone: includes DIAMETER-over-SCTP support.Guy Harris1-25/+35
svn path=/trunk/; revision=3073
2001-02-20In the DIAMETER dissector, clear the Info column before fetchingGuy Harris1-1/+3
anything from the packet, so that if we throw an exception before setting the Info column, it doesn't have stuff left over from the previous dissector. Tvbuffify the RADIUS dissector. svn path=/trunk/; revision=3055
2001-02-20Don't do anything with 64-bit integral types if G_HAVE_GINT64 isn'tGuy Harris1-10/+16
defined. Use "gint64" and "guint64", not "long long int", for 64-bit integral types, so that this code works with compilers (such as Microsoft Visual C++) that have 64-bit integral types but that don't call them "long long". Use "pntohll()" to extract 64-bit integral types from a field. Put a "break;" into a "default:" clause - MSVC++ doesn't like switch (XXX) { ... default: } svn path=/trunk/; revision=3051
2001-02-19As "dissect_diameter()" is now static to "packet-diameter.c", there's noGuy Harris1-2/+1
need to declare it in "packet-diameter.h" - and no need for "packet-diameter.h". svn path=/trunk/; revision=3050
2001-02-19New tvbuffified DIAMETER dissector, from David Frascone.Guy Harris1-522/+567
It doesn't do DIAMETER-over-UDP, so the RADIUS dissector no longer checks for DIAMETER packets and calls the DIAMETER dissector if it finds one. svn path=/trunk/; revision=3049
2001-02-163rd time's a charm.Gilbert Ramirez1-4/+6
Check against the *correct* buffer size. svn path=/trunk/; revision=3046
2001-02-16Off-by-a-little-bit in adjusting the offset.Gilbert Ramirez1-3/+3
svn path=/trunk/; revision=3045
2001-02-16Don't trust avp_length, which is taken directly from the packet data.Gilbert Ramirez1-6/+23
svn path=/trunk/; revision=3044
2001-02-05Fix up some MSVC complaints about (narrowing) type conversions byGuy Harris1-2/+2
widening formal arguments or narrowing variables passed as actual arguments. svn path=/trunk/; revision=2993
2001-01-09Add an additional "protocol index" argument to "{old_}dissector_add()",Guy Harris1-5/+9
"{old_}heur_dissector_add()", "{old_}conv_dissector_add()", and "register_dissector()", so that an entry in those tables has associated with it the protocol index of the protocol the dissector handles (or -1, if there is no protocol index for it). This is for future use in a number of places. (Arguably, "proto_register_protocol()" should take a dissector pointer as an argument, but 1) it'd have to handle both regular and heuristic dissectors; 2) making it take either a "dissector_t" or a union of that and a "heur_dissector_t" introduces some painful header-file interdependencies so I'm punting on that for now. As with other Ethereal internal APIs, these APIs are subject to change in the future, at least until Ethereal 1.0 comes out....) svn path=/trunk/; revision=2849
2001-01-03Add a new "prefs_register_protocol()" routine, which is likeGuy Harris1-2/+2
"prefs_register_module()" except that it takes a protocol index as returned by "proto_register_protocol()" as its first argument, rather than taking two character strings as arguments as its first two arguments, and uses the protocol's abbreviation as the name to use for preferences in the preferences file and the "-o" flag and uses the protocol's short name as the name to use in the tabs in the "Edit->Preferences" window. svn path=/trunk/; revision=2812
2001-01-03Have "proto_register_protocol()" build a list of data structures forGuy Harris1-7/+8
protocols, in addition to adding structures to the list of filterable fields. Give it an extra argument that specifies a "short name" for the protocol, for use in such places as pinfo->current_proto; the dialog box for constructing filters; the preferences tab for the protocol; and so on (although we're not yet using it in all those places). Make the preference name that appears in the preferences file and the command line for the DIAMETER protocol "diameter", not "Diameter"; the convention is that the name in question be all-lower-case. Make some routines and variables that aren't exported static. Update a comment in the ICP dissector to make it clear that the dissector won't see fragments other than the first fragment of a fragmented datagram. svn path=/trunk/; revision=2810
2000-11-19For each column, have both a buffer into which strings for that columnGuy Harris1-2/+2
can be put, and a pointer to the string for the column, which might or might not point to that buffer. Add a routine "col_set_str()", which sets the string for the column to the string passed to it as an argument; it should only be handed a static string (a string constant would be ideal). It doesn't do any copying, so it's faster than "col_add_str()". Make the routines that append to columns check whether the pointer to the string for the column points to the buffer for the column and, if not, copy the string for the column to the buffer for the column so that you can append to it (so you can use "col_set_str()" and then use "col_append_str()" or "col_append_fstr()"). Convert a bunch of "col_add_str()" calls that take a string constant as an argument to "col_set_str()" calls. Convert some "col_add_fstr()" calls that take a string constant as the only argument - i.e., the format string doesn't have any "%" slots into which to put strings for subsequent arguments to "col_set_str()" calls (those calls are just like "col_add_str()" calls). Replace an END_OF_FRAME reference in a tvbuffified dissector with a "tvb_length(tvb)" call. svn path=/trunk/; revision=2670
2000-11-17Add #include <string.h>, to get prototypes for mem* and str* functions.Gilbert Ramirez1-1/+2
svn path=/trunk/; revision=2654