aboutsummaryrefslogtreecommitdiffstats
path: root/packet-dcerpc-spoolss.c
AgeCommit message (Collapse)AuthorFilesLines
2004-03-30Add the mask for an NT ACL ACE to the summary list for each ACE. Thissharpe1-4/+4
means we don't have to expand the ACE to see what the permission mask is. There are a couple of other places where this could be used, but I have not done anything about them. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10515 f5534014-38df-0310-8fa8-9805f1628bb7
2004-01-19char *drep -> guint8 *drepjmayer1-126/+126
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9735 f5534014-38df-0310-8fa8-9805f1628bb7
2003-10-15We got rid of the wrong hf_devmode_driver_extra; bring the wrong oneguy1-5/+5
back, and get rid of the one that shouldn't be kept around. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8702 f5534014-38df-0310-8fa8-9805f1628bb7
2003-10-06From packet steve: get rid of some duplicate field definitions (someguy1-5/+1
aren't exactly duplicates, but they both set the same hf_ variable). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8621 f5534014-38df-0310-8fa8-9805f1628bb7
2003-08-04Guy suggested that the dcerpc opnum value_string code could be simplifiedtpot1-8/+1
somewhat. Now the dynamic initialisation of the value_string is contained in the value_string_from_subdissectors() function instead of being distributed amongst the dcerpc dissectors. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8123 f5534014-38df-0310-8fa8-9805f1628bb7
2003-07-14Fix misdissection of spoolss enumprinterdataex replies:tpot1-11/+29
- skip dissection of value if value length is zero - add placeholder for REG_MULTI_SZ value proto item - rename local variable start to start_offset for consistency git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8019 f5534014-38df-0310-8fa8-9805f1628bb7
2003-06-26Dynamically create DCERPC opnum value_strings from the subdissectortpot1-89/+10
list rather than duplicating this information in the dissector. Some of the opnum strings were starting to get out of date as developers forgot to update the information in both places. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7936 f5534014-38df-0310-8fa8-9805f1628bb7
2003-06-17Remove silly dcerpc_smb_check_long_frame() function and all calls to it.tpot1-154/+1
A much better place to do this is after the subdissector function has been called in dcercp_try_handoff(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7895 f5534014-38df-0310-8fa8-9805f1628bb7
2003-06-05In the policy handle hashing, handle more than one policy handle havingguy1-73/+146
the same value, as an open might return handle XXX, handle XXX might then be closed, and a subsequent handle might return handle XXX, and we want to keep the two handles distinct to avoid, for example, displaying handles closed before they're opened. In policy handle open replies, store the handle name only if the operation succeeded. We can now do that without parsing the packet twice. Have "dissect_nt_policy_hnd()" optionally return, through a pointer, the protocol tree item for the handle, so that its caller can decorate the item with the name of the handle - that's done on opens, where we do that only if the operation succeeds. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7787 f5534014-38df-0310-8fa8-9805f1628bb7
2003-05-27Get rid of a debugging message.guy1-3/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7749 f5534014-38df-0310-8fa8-9805f1628bb7
2003-05-15More work on dissecting generic and standard mappings for NT access masks.tpot1-16/+76
Also, it turns out that there are three types of specific access permissions for printing - printer, print server and job specific bits. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7669 f5534014-38df-0310-8fa8-9805f1628bb7
2003-04-28Move the specific rights dissection function and name into a structuretpot1-7/+11
instead of passing them around as separate parameters. This is a prelude to adding generic and standard mapping to the access mask dissection. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7591 f5534014-38df-0310-8fa8-9805f1628bb7
2003-04-27Not all strings in MS interfaces are unicode.sahlberg1-2/+2
Rename cb_str_postprocess which handles unicode strings to cb_wstr_postprocess. Add cb_str_postprocess which handles ASCII strings git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7572 f5534014-38df-0310-8fa8-9805f1628bb7
2003-04-15When dissecting a SYSTEM_TIME, include the milliseconds in the top-levelguy1-5/+6
summary item. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7461 f5534014-38df-0310-8fa8-9805f1628bb7
2003-04-10Some COL_INFO goodies for SpoolssWritePrinter.tpot1-2/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7435 f5534014-38df-0310-8fa8-9805f1628bb7
2003-04-03When dissecting specific rights, pass a name string down so thetpot1-6/+7
proto item says "foo specific rights" instead of just "specific rights". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7401 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-25Don't append text in cb_notify_str_postprocess() if text is the empty string.tpot1-40/+67
Cleaned up some all caps proto items to more friendly looking text. Append number of notifies within a notify option structure to the proto_item. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7195 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-24Change SPOOLSS policy handle string names to be consistent withtpot1-3/+3
the SAMR ones. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7188 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-24Rename "fake_unicode()" to "tvb_fake_unicode()" as it works on a tvbuff,guy1-6/+6
give it a byte-order argument, and move it to "epan/tvbuff.c". Use it to handle UCS-2 strings in version 1 of the Service Location Protocol. In SRVLOC V1, use registered fields that are already there for SRVLOC V2, and add some as needed. Fix some field names. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7186 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-14More cleanups - nearly done!tpot1-1040/+986
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7150 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-11More cleanups.tpot1-434/+507
Added name parameter and add_subtree boolean to dissect_SYSTEM_TIME() Decorate COL_INFO with changeid and notify information for print notify RPCs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7121 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-10Deleted dissect_unistr2() function - call dissect_ndr_cvstring() instead.tpot1-493/+692
Hooray - I think that's the last of the spoolss specific string routines cleaned up. Cleanup of print notify dissections: - rename hf variable names - added 'job total bytes' and 'job bytes printed' filter fields - fixed bug dissecting job notify data introduced when converting to NDR routines - add hidden values for notify data so that filtering on (say) printer name brings up notify data that references it - decorate some higher level print notify proto_items to make things look pretty Add printer name to ReplyOpenPrinter policy handle name. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7113 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-10Cleanup of printer forms dissection:tpot1-151/+154
- display more data in COL_INFO - replaced per-RPC level fields with generic spoolss.form.level one - put the form type value string into the hf initialisation instead of displaying it by hand using proto_tree_add_text - added hidden field for all forms RPCs (filter on spoolss.form to get all form related RPCs) - removed useless dissect_form_name() function git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7111 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-07Rename "dissect_ndr_char_string()" and "dissect_ndr_wchar_string()" toguy1-3/+3
"dissect_ndr_char_cvstring()" and "dissect_ndr_wchar_cvstring()", to indicate that they're for conformant varying strings. Rename "dissect_ndr_character_array()" to "dissect_ndr_cvstring()", to indicate that it's for conformant varying strings. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7096 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-07Rename "dissect_ndr_char_array" and "disect_ndr_wchar_array" toguy1-2/+2
"dissect_ndr_char_string" and "dissect_ndr_wchar_string", to make it clearer what it does. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7095 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-07Fix a typo in the multiple-include protection in "packet-dcerpc-nt.h".guy1-20/+4
Rename "dissect_ndr_element_array()" to "dissect_ndr_character_array()", move it out of "packet-dcerpc-nt.c" to "packet-dcerpc.c", and have it use the standard DCE RPC array max count/offset/count fields rather than their own private versions of those fields. Give it an option to create a subtree, and an argument to specify the field to use for the actual data buffer, and export it. Move the routines for handling arrays of "char" and "wchar" as strings out of "packet-dcerpc-nt.c" to "packet-dcerpc.c". Add a routine to handle an array of "char" as an opaque blob of bytes. Use "dissect_ndr_character_array()" to dissect character strings in MAPI (the strings in question are ASCII, not Unicode), and use the routine to handle an array of "char" as an opaque blob of bytes to dissect encrypted data (again, it's bytes, not 16-bit quantities). Show them as encrypted data, not unknown data. Use "dissect_ndr_character_array()" to dissect a form name in "dissect_form_name()" in the SPOOLSS dissector. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7091 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-07Fix callers to dissect_nt_sec_desc() to use new function interface.tpot1-7/+12
Dissection of security descriptors in SPOOLSS RPC calls now display the correct meaning of the specific access mask bits. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7087 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-05Cleaned up print job filterable fields.tpot1-213/+370
Set item len for devicemode dissector. Fixed dissection of relative strings so that the actual value of the string is assigned to the hf item instead of the empty string. Dissect JOB_INFO_2 structure. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7078 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-05Deleted RPC request/response proto items from the spoolss dissector astpot1-449/+1
it's done better in the dcerpc dissector. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7075 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-05Fixed bug in dissect_printerdata_data()tpot1-7/+9
Display something useful in COL_INFO when dissecting REG_BINARY printerdata. Display the value needed field in value subtree. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7073 f5534014-38df-0310-8fa8-9805f1628bb7
2003-02-03Convert to new DCERPC string handling functions. There are still sometpot1-2/+2
cosmetic bugs to work out though. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7069 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-30Fixed memory leak in dissect_unistr2().tpot1-14/+12
Fixed double free bug in GetPrinterData occuring when applying a filter. Cleaned up same bit of code in OpenPrinterEx. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7051 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-30Generalize "cb_str_postprocess()" to allow the string to be appended toguy1-14/+14
items N levels up from the item being processed, and use that to decorate the tree as it was decorated before. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7043 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-30Clean up the handling of null buffers in getprinter, getform,tpot1-99/+93
getjob and getprinterdriver2. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7037 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-28Cleanup of filterable fields for printer data and devicemodes.tpot1-374/+860
Added a stack of value_strings for devicemode fields that didn't have them already. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7027 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-28Convert dissector to callback based version of dissect_ndr_pointer().tpot1-94/+68
This fixes a bunch of neat stuff that was broken after the conversion to the dissect_ndr_* functions like printer handle tracking by name and many COL_INFO things. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7018 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-16Change name of proto item for UINT16UNI.tpot1-5/+5
Use dissect_ndr_uint32 instead of dissect_doserror() to peek at the RPC error in SpoolssOpenPrinterEx_r. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6935 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-11Finish converting remaining RPCs to ndr routines.tpot1-358/+125
Deleted all the old crufy ndr pointer dissection. Hooray! Next on the hit list is some refactoring of the ndr string routines... git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6899 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-11Converted some more RPCs to ndr routines.tpot1-240/+22
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6897 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-10Converted enumprinters and enumprinterkey rpc to ndr routines.tpot1-20/+34
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6892 f5534014-38df-0310-8fa8-9805f1628bb7
2003-01-10Convert enumprinterdataex rpc to ndr format calls.tpot1-43/+177
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6891 f5534014-38df-0310-8fa8-9805f1628bb7
2002-12-13More conversions to NDR routines. This commit does most of the printerdatatpot1-36/+53
routines except for the enumprinterdata values. Note the display of strings inside the protocol tree is broken due to lack of a unicode string frametype. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6784 f5534014-38df-0310-8fa8-9805f1628bb7
2002-12-13Guy has pointed out that this dissection looks wrong. In the etherealtpot1-1/+6
output for a USER_LEVEL_1 it looks like the info level and container pointer are transposed. I'm not even sure this structure is a container git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6783 f5534014-38df-0310-8fa8-9805f1628bb7
2002-12-12When dissecting a buffer, use the tvbuff for the buffer, as the offsetguy1-22/+22
we're using is relative to the beginning of that tvbuff, not relative to the beginning of the containing tvbuff; that also lets us use -1 when in "proto_tree_add_text()" calls when we mean "to the end of the buffer. Fix the comment for one field. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6781 f5534014-38df-0310-8fa8-9805f1628bb7
2002-12-04Decode getprinter level 7.tpot1-1/+51
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6742 f5534014-38df-0310-8fa8-9805f1628bb7
2002-11-28Get rid of the "pdata" argument to "dissect_dcerpc_uint16s()" andguy1-3/+3
"dissect_ndr_uint16s()"; "dissect_ndr_uint16s()" is always passed a null pointer, "dissect_dcerpc_uint16s()" is only called by "dissect_ndr_uint16s()", and the pointer returned through "pdata" is *NOT* guaranteed to be aligned on a 16-bit boundary so we don't want to tempt people to blithely dereference that pointer. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6699 f5534014-38df-0310-8fa8-9805f1628bb7
2002-11-28Make the pointer passed by reference as the last argument ofguy1-2/+2
"dissect_ndr_uint8s()" a const pointer, as that's what "dissect_ndr_uint8s()" expects. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6690 f5534014-38df-0310-8fa8-9805f1628bb7
2002-11-23Make "dissect_spoolss_uint16uni()" take an extra argument giving theguy1-7/+23
name of the field being dissected, and, if it's not null, use it instead of "UINT16UNI". Pass the appropriate argument in some calls. In "SpoolssOpenPrinterEx_q()", put in some #if 0'ed out code to note what should be done with the printer name when we can get it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6670 f5534014-38df-0310-8fa8-9805f1628bb7
2002-11-19Some more spoolss ndr conversions. OpenPrinterEx now decodes it'stpot1-109/+254
arguments correctly. There's a string datatype, a devicemode container with a possibly null devicemode, and a "user level" structure, whatever that is. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6659 f5534014-38df-0310-8fa8-9805f1628bb7
2002-11-19Fix dissection of printer info levels 0-3 which has been broken for atpot1-73/+405
while. Also convert to dissect_ndr_* functions instead of old-style prs_* functions. Converted devicemode dissection to ndr functions as well. There are still a bunch of value_strings that can be written to decode some of the constants here. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@6658 f5534014-38df-0310-8fa8-9805f1628bb7