aboutsummaryrefslogtreecommitdiffstats
path: root/packet-bpdu.c
AgeCommit message (Collapse)AuthorFilesLines
2004-01-08Update the comment about the length issue to reflect mail from somebodyGuy Harris1-5/+12
on the stds-802-1@ieee.org list. svn path=/trunk/; revision=9599
2004-01-07From Alex Rozin: cope with what appears to be an ambiguity in the 802.1sGuy Harris1-4/+34
spec, where different implementations take different interpretations. svn path=/trunk/; revision=9595
2004-01-05From Alex Rozin: fix handling of MST messages.Guy Harris1-4/+6
Fix his e-mail address. svn path=/trunk/; revision=9556
2003-09-21Remove a bunch of duplicate semicolons.Gerald Combs1-2/+2
svn path=/trunk/; revision=8509
2003-04-30From Kaloian Stoilov: add a subtree for the MSTI flags.Guy Harris1-2/+17
svn path=/trunk/; revision=7610
2003-01-11Add a new "chdlctypes.h" file for Cisco HDLC type values that aren'tGuy Harris1-2/+3
just Ethernet type values. Move the type value for ISO network-layer protocols there, and put the type value for IEEE spanning tree there as well, use that value in the BPDU dissector, and add an item to the CHDLC dissector for it. svn path=/trunk/; revision=6915
2003-01-110x4242 is the Cisco HDLC type value for the spanning tree protocol.Guy Harris1-1/+2
svn path=/trunk/; revision=6913
2002-12-22The field 2 bytes into a BPDU is always a version identifier, regardlessGuy Harris1-3/+4
of the type of the packet; always fetch it. svn path=/trunk/; revision=6815
2002-11-26The command says 0x20-0x2F: Adjust mask accordinglyJörg Mayer1-2/+2
svn path=/trunk/; revision=6673
2002-10-08From cjs 2895: get rid of C++ comments, so IBM's Visual Age C compilerGuy Harris1-4/+4
can compile the code. Note that Bill Fumerola rewrote the Cisco NetFlow dissector. Update a bunch of addresses in the Ethereal man page, and put some missing addresses in. svn path=/trunk/; revision=6380
2002-09-25Complete the implementation of 802.1s by Clive A StubbingsJörg Mayer1-7/+124
svn path=/trunk/; revision=6333
2002-09-23From Clive A Stubbings:Gerald Combs1-13/+134
Add support for the static portion of 802.1s MSTP. svn path=/trunk/; revision=6319
2002-08-28Removed trailing whitespaces from .h and .c files using theJörg Mayer1-30/+30
winapi_cleanup tool written by Patrik Stridvall for the wine project. svn path=/trunk/; revision=6117
2002-08-02Replace the types from sys/types.h and netinet/in.h by their glib.hJörg Mayer1-9/+1
equivalents for the toplevel directory. The removal of winsock2.h will hopefully not cause any problems under MSVC++, as those files using struct timeval still include wtap.h, which still includes winsock2.h. svn path=/trunk/; revision=5932
2002-05-30Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourthGuy Harris1-2/+4
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to run to the end of the parent tvbuff. svn path=/trunk/; revision=5597
2002-03-31Get rid of an unused variable.Guy Harris1-2/+1
svn path=/trunk/; revision=5055
2002-03-19Set the length for topology change BPDUs to 4, and leave the length ofGuy Harris1-5/+18
unknown BPDU types alone. Use the tvbuff's length in as the length of the top-level protocol tree item. svn path=/trunk/; revision=4978
2002-03-19Give all the items in the packet filterable fields, including theGuy Harris1-72/+193
bitfields in the flags field. Put a summary of the flags in the protocol tree item for the flags field. Give the Protocol Identifier and BPDU Type fields value_string tables. Don't bother with "proto_tree_add_uint_format()" for fields with value_string tables - use the default format. Put the "Version 1 Length" field into Rapid Spanning Tree packets. Don't fetch items until you put them into the protocol tree. Make the length of the top-level item be the correct length of the packet, including the "Version 1 Length" field in RST packets. (XXX - should it be really short for Topology Change Notification packets?) For packets with unknown BPDU types, put the value of the type into the Info column. svn path=/trunk/; revision=4976
2002-02-27Support for IEEE 802.1w RST BPDUs, from Alex Ruzin.Guy Harris1-8/+57
svn path=/trunk/; revision=4825
2002-01-21Include files from the "epan" directory and subdirectories thereof withGuy Harris1-3/+3
"epan/..." pathnames, so as to avoid collisions with header files in any of the directories in which we look (e.g., "proto.h", as some other package has its own "proto.h" file which it installs in the top-level include directory). Don't add "-I" flags to search "epan", as that's no longer necessary (and we want includes of "epan" headers to fail if the "epan/" is left out, so that we don't re-introduce includes lacking "epan/"). svn path=/trunk/; revision=4586
2001-12-10Move the pointer to the "column_info" structure in the "frame_data"Guy Harris1-12/+12
structure to the "packet_info" structure; only stuff that's permanently stored with each frame should be in the "frame_data" structure, and the "column_info" structure is not guaranteed to hold the column values for that frame at all times - it was only in the "frame_data" structure so that it could be passed to dissectors, and, as all dissectors are now passed a pointer to a "packet_info" structure, it could just as well be put in the "packet_info" structure. That saves memory, by shrinking the "frame_data" structure (there's one of those per frame), and also lets us clean up the code a bit. svn path=/trunk/; revision=4370
2001-12-03Make "dissector_add()", "dissector_delete()", and "dissector_change()"Guy Harris1-4/+6
take a dissector handle as an argument, rather than a pointer to a dissector function and a protocol ID. Associate dissector handles with dissector table entries. svn path=/trunk/; revision=4308
2001-11-26Moved from using dissect_data() to using call_dissector()Ed Warnicke1-2/+4
svn path=/trunk/; revision=4269
2001-07-23GMRP dissector, from Markus Seehofer.Guy Harris1-3/+10
Throw a very small caltrop in the way of spam-harvesters, by replacing "@" in e-mail addresses in the AUTHORS file and Ethereal man page with "[AT]" (although I wouldn't be surprised to find that some of those harvesters already know about that trick and "fix" those addresses so you, too, can receive Valuable Information about Viagra, can-fail Internet investment opportunities and stuff-envelopes-at-home jobs, and cable descramblers). Add a couple of items from the AUTHORS file to the Ethereal man page. svn path=/trunk/; revision=3781
2001-06-18From Joerg Mayer: explicitly fill in all members of aGuy Harris1-13/+13
"header_field_info" structure, including the ones that are later set by the routines to register fields. svn path=/trunk/; revision=3561
2001-05-27Call the GVRP dissector through a handle.Guy Harris1-6/+10
Update Gerald's e-mail address. svn path=/trunk/; revision=3459
2001-03-13Make tvb_get_ptr() return 'const guint8*', and clean up all theGilbert Ramirez1-3/+3
usages of tvb_get_ptr(). packet-ieee80211.c still has one bad usage, in which it *does* modify the tvbuff's data. svn path=/trunk/; revision=3128
2001-02-08Don't fetch any of the fields past the BPDU type if the BPDU type isn'tGuy Harris1-7/+18
0; topology change notification frames don't *have* anything past the BPDU type to fetch. svn path=/trunk/; revision=3003
2001-02-08Set the Protocol column, and clear the Info column, before we startGuy Harris1-8/+11
fetching anything from the packet, so that if an exception is thrown those columns don't show something from the previous protocol. Don't fetch the protocol identifier or protocol version identifier before you use them. svn path=/trunk/; revision=3000
2001-01-22Remove more "CHECK_DISPLAY_AS_DATA()" calls and "pinfo->current_proto ="Guy Harris1-5/+1
statements. Move the setting of the Protocol column in the Appletalk ARP and IPX dissectors before anything is fetched from the packet, and also clear the Info column at that point in those and some other dissectors, so that if an exception is thrown, the columns don't reflect the previous protocol. Fix the registration of the IPX RIP dissector to use the right protocol ID. svn path=/trunk/; revision=2928
2001-01-14Add the PPP types for the DEC LANBridge100 Spanning Tree protocol andGuy Harris1-1/+3
for "Bridging PDU"s (which I'm assuming are 802.1d Spanning Tree BPDUs), and have the STP and LANBridge100 STP dissectors register them with the "ppp.protocol" dissector table. Fix the value for the PPP type for MPLS Multicast (it's 0x0283, not 0x0281). svn path=/trunk/; revision=2896
2001-01-09Add an additional "protocol index" argument to "{old_}dissector_add()",Guy Harris1-3/+3
"{old_}heur_dissector_add()", "{old_}conv_dissector_add()", and "register_dissector()", so that an entry in those tables has associated with it the protocol index of the protocol the dissector handles (or -1, if there is no protocol index for it). This is for future use in a number of places. (Arguably, "proto_register_protocol()" should take a dissector pointer as an argument, but 1) it'd have to handle both regular and heuristic dissectors; 2) making it take either a "dissector_t" or a union of that and a "heur_dissector_t" introduces some painful header-file interdependencies so I'm punting on that for now. As with other Ethereal internal APIs, these APIs are subject to change in the future, at least until Ethereal 1.0 comes out....) svn path=/trunk/; revision=2849
2001-01-03Have "proto_register_protocol()" build a list of data structures forGuy Harris1-2/+2
protocols, in addition to adding structures to the list of filterable fields. Give it an extra argument that specifies a "short name" for the protocol, for use in such places as pinfo->current_proto; the dialog box for constructing filters; the preferences tab for the protocol; and so on (although we're not yet using it in all those places). Make the preference name that appears in the preferences file and the command line for the DIAMETER protocol "diameter", not "Diameter"; the convention is that the name in question be all-lower-case. Make some routines and variables that aren't exported static. Update a comment in the ICP dissector to make it clear that the dissector won't see fragments other than the first fragment of a fragmented datagram. svn path=/trunk/; revision=2810
2000-12-23Add support for the DLT_LINUX_SLL capture type in the current CVSGuy Harris1-3/+8
version of libpcap; that's used on Linux for captures on the "any" device (which captures from all interfaces simultaneously) and for captures on devices whose link-layer type libpcap doesn't (yet) support natively. The spanning tree code, when checking for GV{M,R,...}P packets, must first check whether the link-layer destination address is, in fact, an Ethernet-style address; on Linux cooked captures, there *is* no destination address, so it's of type AT_NONE, not AT_ETHER. svn path=/trunk/; revision=2772
2000-11-30GVRP dissector, from Kevin Shi.Guy Harris1-2/+46
svn path=/trunk/; revision=2721
2000-11-19For each column, have both a buffer into which strings for that columnGuy Harris1-2/+2
can be put, and a pointer to the string for the column, which might or might not point to that buffer. Add a routine "col_set_str()", which sets the string for the column to the string passed to it as an argument; it should only be handed a static string (a string constant would be ideal). It doesn't do any copying, so it's faster than "col_add_str()". Make the routines that append to columns check whether the pointer to the string for the column points to the buffer for the column and, if not, copy the string for the column to the buffer for the column so that you can append to it (so you can use "col_set_str()" and then use "col_append_str()" or "col_append_fstr()"). Convert a bunch of "col_add_str()" calls that take a string constant as an argument to "col_set_str()" calls. Convert some "col_add_fstr()" calls that take a string constant as the only argument - i.e., the format string doesn't have any "%" slots into which to put strings for subsequent arguments to "col_set_str()" calls (those calls are just like "col_add_str()" calls). Replace an END_OF_FRAME reference in a tvbuffified dissector with a "tvb_length(tvb)" call. svn path=/trunk/; revision=2670
2000-11-16Tvbuffify the STP dissector, have it register itself and have the LLCGuy Harris1-65/+72
dissector call it through a handle, and make it static. Give "dissect_data()" an "offset" argument, so dissectors can use it to dissect part of the packet without having to cook up a new tvbuff. Go back to using "dissect_data()" to dissect the data in an IPP request. svn path=/trunk/; revision=2651
2000-08-13Add the "Edit:Protocols..." feature which currently only implementsLaurent Deniel1-1/+3
the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267
2000-08-07Allow either old-style (pre-tvbuff) or new-style (tvbuffified)Guy Harris1-3/+3
dissectors to be registered as dissectors for particular ports, registered as heuristic dissectors, and registered as dissectors for conversations, and have routines to be used both by old-style and new-style dissectors to call registered dissectors. Have the code that calls those dissectors translate the arguments as necessary. (For conversation dissectors, replace "find_conversation_dissector()", which just returns a pointer to the dissector, with "old_try_conversation_dissector()" and "try_conversation_dissector()", which actually call the dissector, so that there's a single place at which we can do that translation. Also make "dissector_lookup()" static and, instead of calling it and, if it returns a non-null pointer, calling that dissector, just use "old_dissector_try_port()" or "dissector_try_port()", for the same reason.) This allows some dissectors that took old-style arguments and immediately translated them to new-style arguments to just take new-style arguments; make them do so. It also allows some new-style dissectors not to have to translate arguments before calling routines to look up and call dissectors; make them not do so. Get rid of checks for too-short frames in new-style dissectors - the tvbuff code does those checks for you. Give the routines to register old-style dissectors, and to call dissectors from old-style dissectors, names beginning with "old_", with the routines for new-style dissectors not having the "old_". Update the dissectors that use those routines appropriately. Rename "dissect_data()" to "old_dissect_data()", and "dissect_data_tvb()" to "dissect_data()". svn path=/trunk/; revision=2218
2000-05-31Add routines for adding items to a protocol tree that take arguments ofGuy Harris1-11/+11
a particular type, rather than taking a varargs list, along the lines of the "proto_tree_add_XXX_format()" routines. Replace most calls to "proto_tree_add_item()" and "proto_tree_add_item_hidden()" with calls to those routines. Rename "proto_tree_add_item()" and "proto_tree_add_item_hidden()" to "proto_tree_add_item_old()" and "proto_tree_add_item_hidden_old()", and add new "proto_tree_add_item()" and "proto_tree_add_item_hidden()" routines that don't take the item to be added as an argument - instead, they fetch the argument from the packet whose tvbuff was handed to them, from the offset handed to them. svn path=/trunk/; revision=2031
2000-05-11Add tvbuff class.Gilbert Ramirez1-19/+19
Add exceptions routines. Convert proto_tree_add_*() routines to require tvbuff_t* argument. Convert all dissectors to pass NULL argument ("NullTVB" macro == NULL) as the tvbuff_t* argument to proto_tree_add_*() routines. dissect_packet() creates a tvbuff_t, wraps the next dissect call in a TRY block, will print "Short Frame" on the proto_tree if a BoundsError exception is caught. The FDDI dissector is converted to use tvbuff's. svn path=/trunk/; revision=1939
2000-04-17Register a "llc.dsap" dissector table for 802.2 LLC, and have dissectorsGuy Harris1-1/+8
for protocols that run inside 802.2 LLC register themselves with it using "dissector_add()". Make various dissectors static if they can be, and remove from header files declarations of those dissectors. svn path=/trunk/; revision=1872
2000-03-12Break proto_tree_add_item_format() into multiple functions:Gilbert Ramirez1-4/+5
proto_tree_add_protocol_format() proto_tree_add_uint_format() proto_tree_add_ipxnet_format() proto_tree_add_ipv4_format() proto_tree_add_ipv6_format() proto_tree_add_bytes_format() proto_tree_add_string_format() proto_tree_add_ether_format() proto_tree_add_time_format() proto_tree_add_double_format() proto_tree_add_boolean_format() If using GCC 2.x, we can check the print-format against the variable args passed in. Regardless of compiler, we can now check at run-time that the field type passed into the function corresponds to what that function expects (FT_UINT, FT_BOOLEAN, etc.) Note that proto_tree_add_protocol_format() does not require a value field, since the value of a protocol is always NULL. It's more intuitive w/o the vestigial argument. Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*) Checked in Guy's fix for the function declearation for proto_tree_add_text() and proto_tree_add_notext(). svn path=/trunk/; revision=1713
2000-01-16Get rid of the include of "util.h" that some dissectors do - it's notGuy Harris1-2/+1
necessary. svn path=/trunk/; revision=1496
1999-11-16Replace the ETT_ "enum" members, declared in "packet.h", withGuy Harris1-3/+8
dynamically-assigned "ett_" integer values, assigned by "proto_register_subtree_array()"; this: obviates the need to update "packet.h" whenever you add a new subtree type - you only have to add a call to "proto_register_subtree_array()" to a "register" routine and an array of pointers to "ett_", if they're not already there, and add a pointer to the new "ett_" variable to the array, if they are there; would allow run-time-loaded dissectors to allocate subtree types when they're loaded. svn path=/trunk/; revision=1043
1999-10-16Replace proto_tree_add_item_format by proto_tree_add_item.Laurent Deniel1-26/+30
svn path=/trunk/; revision=854
1999-10-12New proto_tree header_field_info stuff. Header_field_infos now containGilbert Ramirez1-13/+25
the base for numbers to be displayed in, bitmasks for bitfields, and blurbs (which are one or two sentences describing the field). proto_tree_add*() routines now automatically handle bitfields. You tell it which header field you are adding, and just pass it the value of the entire field, and the proto_tree routines will do the masking and shifting for you. This means that bitfields are more naturally filtered via dfilter now. Added Phil Techau's support for signed integers in dfilters/proto_tree. Added the beginning of the SNA dissector. It's not complete, but I'm committing it now because it has example after example of how to use bitfields with the new header_field_info struct and proto_tree routines. It was the impetus to change how header_field_info works. svn path=/trunk/; revision=815
1999-10-09- dissect data if type unknownLaurent Deniel1-22/+105
- add display filters svn path=/trunk/; revision=793
1999-10-08The abbreviation for a protocol is generally all-lower-case, as it'sGuy Harris1-2/+2
used as a display filter to match all packets that contain data for that protocol. svn path=/trunk/; revision=791
1999-10-08Christophe Tronche's BPDU dissector.Guy Harris1-0/+160
svn path=/trunk/; revision=790