aboutsummaryrefslogtreecommitdiffstats
path: root/gtk
AgeCommit message (Collapse)AuthorFilesLines
2005-02-04remove #include "globals.h" from summary.c, as it's a bad idea for multiple ↵Ulf Lamping3-3/+9
capture files. If a summary user would like to get a summary, it should know the file of *which* it needs the summary. svn path=/trunk/; revision=13291
2005-02-04huge cleanup of capture file API (functions in file.c/file.h).Ulf Lamping40-117/+121
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions. Hopefully, I didn't introduced any new bugs, as I had to change a lot of files... svn path=/trunk/; revision=13289
2005-02-04(some) redesign of capture data structures.Ulf Lamping3-3/+4
don't use global cfile at all but only an untpyed handle to call the cf_... functions in file.c move the save_file member from capture_file to capture_opts, as it's only used while capturing and while preparing it svn path=/trunk/; revision=13276
2005-02-03move capture_file_fd field from capture_file to capture_opts type, as this ↵Ulf Lamping1-2/+3
is the place where it should be svn path=/trunk/; revision=13268
2005-02-03From Francisco Alcoba:Anders Broman1-0/+46
Patch for graphing ISUP calls. It shows the type of message, in the first one the calling and called numbers, and in the second the SPs and CIC; in releases it shows the cause value. svn path=/trunk/; revision=13262
2005-02-03add tooltips to the dialogs radio buttonsUlf Lamping1-1/+7
svn path=/trunk/; revision=13259
2005-02-02Writing the raw data of a TCP stream to a file isn't printing it, soGuy Harris1-36/+81
don't use the print mechanism for that - do the writing directly in the "follow stream" code. Use "size_t" for character counts. Make the "hexchars" array static and const, as it's not written to, and there's probably no point in copying it to the stack (unless that improves cache locality). There's no need to explain why we're subtracting the number of bytes actually read, rather than the number of bytes asked for, from the data length. Note an issue with printing lines. svn path=/trunk/; revision=13240
2005-02-02Get rid of an unused typedef.Guy Harris4-9/+0
svn path=/trunk/; revision=13239
2005-02-02Use C89 syntax, not C++ syntax, for functions that take no arguments.Guy Harris4-6/+6
svn path=/trunk/; revision=13238
2005-02-02Don't assume that the only blank filter expression is empty - check forGuy Harris1-28/+30
an all-space-character string. Don't use "filter_string" both for the (unfreeable, unmodifiable) value fetched from the text entry and the new filter expression; use it only for the former, and make it a "const" pointer to avoid compiler warnings. Use a GString to construct the stuff to be added to the new filter expression - the old code, when appending stuff to the filter expression in a loop, would leak the pre-append value. svn path=/trunk/; revision=13237
2005-02-02from chris eagleRonnie Sahlberg1-56/+94
add radiobutton to allow saving raw tcpstreams these radiobuttons should, by someone that uses, this feature be changed into a menu instead. svn path=/trunk/; revision=13236
2005-02-02Make sure "comment" is set.Guy Harris1-7/+5
Get rid of an unused variable. svn path=/trunk/; revision=13235
2005-02-02Clean up white space.Guy Harris1-11/+7
Get rid of an unused variable and two #includes that aren't needed. svn path=/trunk/; revision=13234
2005-02-02"filter_string_fwd" is assigned a "const" pointer, so make it a "const"Guy Harris1-1/+1
pointer. svn path=/trunk/; revision=13233
2005-02-02for VoIP Call Analysis:Lars Roland6-116/+143
- make VoIP Call Analysis work if, called from command line - should also work now while capturing with packet list updated in "real time" (to be tested) - give each tap listener a unique identifier, so ethereal won't mix them up - various cleanups - compile by default Todo: - add support for "tap display filter" - reimplement function to add rtp streams to the call flow. svn path=/trunk/; revision=13232
2005-02-01add packet-sdp.hLars Roland1-1/+1
and from Julien Leproust: fix graph_analysis.c svn path=/trunk/; revision=13226
2005-02-01From Alejandro Vaquero:Lars Roland8-0/+3427
h323 taps support up to 5 messages per packet now. VoIP call analysis: - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info: - Start and Stop time of the call - Init svn path=/trunk/; revision=13225
2005-01-29Mark unused arguments as such.Guy Harris1-1/+1
svn path=/trunk/; revision=13197
2005-01-29Add a new menu item "View/Resize Columns" to, well, resize columns. As this ↵Ulf Lamping3-2/+83
might take a long time, I've provided a progress bar with the option to cancel the operation. I might later add something like "View/Auto Resize Columns" with a checkbox menu item, so this is done everytime a capture file finished loading. However, I don't know how well this will work together with "Update list of packets in real time" while doing a capture. svn path=/trunk/; revision=13192
2005-01-27We use the range utilities regardless of whether we're built withGuy Harris1-1/+1
libpcap or not. svn path=/trunk/; revision=13182
2005-01-27Fix a problem with building with libpcap disabled.Guy Harris1-3/+5
svn path=/trunk/; revision=13181
2005-01-24if context menu item "Print" is clicked from the packet list context menu, ↵Ulf Lamping3-3/+25
it should use the selected range setting as default. As we currently have only one packet selectable, this will print only this one. If we would allow selecting multiple packets in the packet list in the future, this option would print all selected packets. svn path=/trunk/; revision=13169
2005-01-22first proposal: try to rearrange context menus to be more context relevantUlf Lamping1-49/+49
svn path=/trunk/; revision=13161
2005-01-20add some more online help functionality and help buttons at various dialog ↵Ulf Lamping19-143/+365
boxes, if a help page *is* available. However, the new help system needs a lot more work before completed. svn path=/trunk/; revision=13152
2005-01-19while I'm at it, add another packet details context menu item, which will ↵Ulf Lamping3-0/+37
link to the specific display filter reference page (just try it out :-) svn path=/trunk/; revision=13117
2005-01-18added the "Online Protocol Info" to the packet details context menu with a ↵Ulf Lamping2-7/+50
simple_dialog doing some explanation. svn path=/trunk/; revision=13115
2005-01-17Squelch compiler warnings about unused parameters.Guy Harris1-1/+1
svn path=/trunk/; revision=13096
2005-01-17add first implementation of context relevant calls to the protocol specific ↵Ulf Lamping3-4/+43
wiki pages. I've commented out the items in menu.c, so this (hopefully) won't break the current release run. We might think about further steps after the release is out. However, if someone (already) want's to try out right now, you simply have to remove the comments in menu.c around line 430 svn path=/trunk/; revision=13091
2005-01-16Rename capture_combo_utils.{c,h} to capture_ui_utils.{c,h}, as the codeGuy Harris3-3/+3
in there is for UI functions including, but not limited to, the combo box in capture dialogs. svn path=/trunk/; revision=13061
2005-01-16Use a more descriptive name, if available, for the network interface inGuy Harris1-37/+17
window titles even on UN*X, and if the user's specified a description for an interface, use that rather than the description supplied by libpcap. Put the interface name into the main window title when doing a live capture. svn path=/trunk/; revision=13060
2005-01-15Recently the capture interface name was added to the title of the capture ↵Ulf Lamping1-1/+35
info dialog. On WIN32, this interface name is in a somehwat unreadable format "\Device\NPF_{242423...", display the interface description on win32 systems instead "Realtek RTL ..." svn path=/trunk/; revision=13048
2005-01-14From Laurent Rabret: handle the cases where there's no capture file, orGuy Harris7-20/+39
there is but it has no packets. svn path=/trunk/; revision=13041
2005-01-13Add a missing case.Guy Harris1-0/+1
svn path=/trunk/; revision=13020
2005-01-03Make the version and library information in the about box copy-and-paste-ableGerald Combs1-9/+10
under GTK+ 2.x. svn path=/trunk/; revision=12943
2005-01-02Cast the values passed to the <ctype.h> macros so as to avoidGuy Harris1-1/+1
sign-extending 8-bit characters. svn path=/trunk/; revision=12922
2005-01-01Add casts of OBJECT_SET_DATA() arguments in cases where that'sGuy Harris2-20/+22
appropriate. Use %u, not %d, to convert unsigned values to strings. svn path=/trunk/; revision=12921
2005-01-01Don't explicitly cast the last argument to OBJECT_SET_DATA() toGuy Harris1-2/+2
"gpointer" - callers should do that if appropriate (or perhaps change the call to pass a different argument if that's more appropriate), and even if casting it were the right thing to do, the argument needs to be surrounded with parentheses so the correct value is cast. svn path=/trunk/; revision=12919
2005-01-01Cast away the constness of the geom_name argument toGuy Harris1-2/+2
"window_new_with_geom()" - there's no way to tell the compiler that we're not going to be modifying it, but we aren't. The right way to check whether a pointer is null and get a Boolean is to test it against null, not to cast it to a Boolean type - as Boolean types in C89/C90, at least, are just integral types, that cast might just throw away the upper 32 bits; that probably yields the results you want, but the compiler might well justifiably warn about that on an LP64 platform. svn path=/trunk/; revision=12918
2005-01-01The right way to check whether a pointer is null and get a Boolean is toGuy Harris3-11/+11
test it against null, not to cast it to a Boolean type - as Boolean types in C89/C90, at least, are just integral types, that cast might just throw away the upper 32 bits; that probably yields the results you want, but the compiler might well justifiably warn about that on an LP64 platform. svn path=/trunk/; revision=12915
2005-01-01Make the signatures of functions passed to "register_tap_listener()"Guy Harris27-173/+197
match what "register_tap_listener()" expects (rather than squelching warnings about the differences by casting function pointers to "void *"). Make static some functions not used outside the module in which they're defined. svn path=/trunk/; revision=12913
2005-01-01Throw in a cast to squelch an (unavoidable, and probably harmless -Guy Harris1-1/+1
GTK+'s function signatures aren't necessarily what they should be) warning. svn path=/trunk/; revision=12912
2005-01-01As we've made the tap_specific_data field of a tap_packet_t structure aGuy Harris22-168/+145
const pointer (so that we don't get complaints when we make the tap-specific data argument to "tap_queue_packet()" a const pointer, allowing dissectors to hand const data to a tap without a complaint), we should make the tap per-packet function take a const pointer as an argument as well. Do so. In some taps, use _U_, or actually use the argument, rather than sticking in dummy "X = X" assignments to fake use of parameters. (This means that the tap functions in question no longer have the notion that they act on a particular static structure wired in.) svn path=/trunk/; revision=12910
2004-12-31In column sort routines, make the row pointers "const" pointers, as theGuy Harris8-16/+16
arguments passed in corresponding to those pointers are gconstpointers. svn path=/trunk/; revision=12884
2004-12-31"gtk_entry_get_text()" returns a "const char *" - assign the result toGuy Harris10-43/+43
one. "get_basename()" doesn't modify its argument, and its callers don't modify the substring pointed to by the result, so make it take a "const char *" as an argument and return a "const char *". "find_last_pathname_separator()" doesn't modify its argument, so make it a "const char *" - but some of its callers pass a non-"const" "char *" and modify the result, so don't make its return value a "const char *". And, as none of its callers are outside "filesystem.c", make it static. In "about_folders_page_new()", have separate variables for pathnames returned as "const char *" (which are cached by the routine that returns them, so you can't modify them - and can't free them, so get rid of the commented-out "g_free()" calls for them) and pathnames returned as "char *" (which are allocated anew for each call, and can be modified, but have to be freed). Clean up white space. svn path=/trunk/; revision=12881
2004-12-31Make the "col_data" field in a "column_info" structure a pointer to anGuy Harris1-1/+1
array of "const char *" rather than to an array of "char *", and make the second argument of "col_set_str()" a "const char *" - there's no guarantee that "col_data" points to something you're allowed to modify. svn path=/trunk/; revision=12880
2004-12-30Make the "col_data" field in a "column_info" structure a pointer to anGuy Harris1-1/+1
array of "const char *" rather than to an array of "char *", and make the second argument of "col_set_str()" a "const char *" - there's no guarantee that "col_data" points to something you're allowed to modify. svn path=/trunk/; revision=12875
2004-12-30Change a function name in preparation for genereating H.245 and H.225 ↵Anders Broman1-1/+1
dissectors with asn2etrh svn path=/trunk/; revision=12871
2004-12-30Fix some cut-and-pasteos.Guy Harris1-2/+2
svn path=/trunk/; revision=12866
2004-12-30Add a "get_addr_name()" routine that takes an "address *" and attemptsGuy Harris2-36/+19
to resolve it to a name. Fix up some const-pointer-to-non-const-pointer, and function-pointer-to-void-*, conversions. Fix some comments. svn path=/trunk/; revision=12863
2004-12-29From Albert Chin: not all compilers support a comma after the last valueGuy Harris1-1/+2
in an enum. svn path=/trunk/; revision=12862