aboutsummaryrefslogtreecommitdiffstats
path: root/gtk/tcp_graph.c
AgeCommit message (Collapse)AuthorFilesLines
2009-06-28From Sean Walberg:Anders Broman1-2/+1
The title in the TCP sequence graphs is too short. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3556 svn path=/trunk/; revision=28873
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-3/+3
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-03-19As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a ↵Bill Meier1-11/+10
numeric constant in various places; svn path=/trunk/; revision=27800
2008-12-01Fix a few more problems found by checkAPIs.plStephen Fisher1-1/+1
svn path=/trunk/; revision=26887
2008-12-01Remove call to deprecated perror() and a check to see if g_malloc() failedStephen Fisher1-3/+0
since g_malloc will terminate the program if it cannot allocate memory instead of returning NULL. svn path=/trunk/; revision=26886
2008-10-31Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=26641
2008-08-26#include <emem.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26094
2008-06-29Fix some simple cases of GTK2 deprecated API usage by using a renamed or ↵Bill Meier1-13/+13
equivalent API gtk_container_border_width() ==> gtk_container_set_border_width() gtk_container_children() ==> gtk_container_get_children() gtk_entry_new_with_max_length() ==> gtk_entry_new(); gtk_entry_set_max_length() gtk_menu_append() ==> gtk_menu_shell_append() gtk_menu_prepend() ==> gtk_menu_shell_prepend() gtk_notebook_set_page() ==> gtk_notebook_set_current_page() gtk_paned_gutter_size() ==> gtk_paned_set_gutter_size() gtk_radio_button_group() ==> gtk_radio_button_get_group() gtk_signal_connect() ==> g_signal_connect() gtk_signal_disconnect() ==> g_signal_handler_disconnect() gtk_signal_emit_by_name() ==> g_signal_emit_by_name() gtk_signal_handler_block_by_data() ==> g_signal_handlers_block_matched() gtk_signal_handler_block_by_func() ==> g_signal_handlers_block_by_func() gtk_signal_handler_unblock_by_data() ==> g_signal-handlers_unblock_matched() gtk_signal_handler_unblock_by_func() ==> g_signal-handlers_unblock_by_func() gtk_spin_button_get_value_as_float() ==> gtk_spin_button_get_value() gtk_toggle_button_set_state() ==> gtk_toggle_button_set_active() svn path=/trunk/; revision=25634
2008-06-04Sun C warns about an integer overflow for 1 << 31, presumably because 1Guy Harris1-4/+4
is signed; make the flags field in "struct magnify" unsigned, and make the flags unsigned, so we shift 1U rather than 1. svn path=/trunk/; revision=25421
2008-04-17rename REGISTER_xxx_GROUP_NONE to REGISTER_xxx_GROUP_UNSORTED, as NONE seems ↵Ulf Lamping1-4/+4
a bit misleading svn path=/trunk/; revision=25086
2008-04-13sort #includes by directoriesUlf Lamping1-10/+14
svn path=/trunk/; revision=24969
2008-04-12where it's not necessary, remove #include "compat_macros.h"Ulf Lamping1-1/+0
svn path=/trunk/; revision=24922
2008-04-11last round to replace SIGNAL_CONNECT with g_signal_connectUlf Lamping1-44/+44
svn path=/trunk/; revision=24918
2008-04-11replace WIDGET_SET_SIZE with gtk_widget_set_size_requestUlf Lamping1-1/+1
svn path=/trunk/; revision=24910
2008-04-11OBECT_..._DATA --> g_object_..._dataBill Meier1-31/+31
svn path=/trunk/; revision=24893
2008-04-11Replace FONT_TYPE macro with PangoFontDescription.Stephen Fisher1-1/+1
svn path=/trunk/; revision=24889
2008-04-07remove GTK1 codeUlf Lamping1-94/+0
svn path=/trunk/; revision=24824
2008-02-07Removed some more "statement not reached" warnings.Stig Bjørlykke1-4/+0
svn path=/trunk/; revision=24283
2007-08-16experimental feature: dissector filtersUlf Lamping1-1/+1
add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI svn path=/trunk/; revision=22530
2007-07-18Make debugging static.Michael Tüxen1-1/+1
svn path=/trunk/; revision=22347
2007-05-29From David Howells :Sebastien Tandel1-5/+5
Fix compilation failures when building wireshark-0.99.6-SVN-21916 on an x86_64-unknown-linux-gnu target with gcc version 4.1.2 20070403 (Red Hat 4.1.2-8). The failures fall into two categories: (1) Casts between pointers and 32-bit integers without an intermediary cast via 'long' or 'unsigned long'. This results in a compiler warning complaining about casts between a pointer and an integer of a different size. (2) Passing values to "%lld" or similar printf-style format options that the compiler thinks are a different size. Such values need to be cast to 'long long' or 'unsigned long long'. svn path=/trunk/; revision=21975
2007-03-21fix all warnings in gtk dir & set the "treat all warnings as errors" MSVC flagUlf Lamping1-4/+4
svn path=/trunk/; revision=21080
2007-02-19Squelch a couple (false) uninitialized variable warningsJeff Morriss1-2/+2
svn path=/trunk/; revision=20858
2006-12-12gtkglobals.h not neededUlf Lamping1-1/+0
svn path=/trunk/; revision=20127
2006-05-28Ethereal->WiresharkAnders Broman1-2/+2
svn path=/trunk/; revision=18232
2006-05-22Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUIGuy Harris1-4/+4
strings, and function names. svn path=/trunk/; revision=18205
2006-05-21name changeRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18197
2006-03-20waste a couple of bytes per tcp conversation and make the tree for ↵Ronnie Sahlberg1-0/+1
acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global. while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite tcp analysis might actually work and work well even for tcp over tcp tunnelling. this also means that if you include packet-tcp.h you also need to include emem.h . svn path=/trunk/; revision=17681
2006-03-19Get rid of a declaration of a non-existent function.Guy Harris1-1/+0
svn path=/trunk/; revision=17673
2006-03-09There is a one-to-one mapping between each graph and its "toplevel" andGerald Combs1-85/+18
drawing_area widgets. Instead of canoodling around with a global list of graphs, simply associate a graph to its widgets using OBJECT_SET_DATA. This should take care of Coverity CIDs 50 - 59. Clean up whitespace. svn path=/trunk/; revision=17554
2006-03-08Make calculation of TCP Graph bounds more robust. The calculation might have ↵Lars Roland1-13/+17
failed in unusual conditions. This bug was discovered while looking at defects #130 and #131 discovered by coverity. This patch also fixes these non-severe defects. svn path=/trunk/; revision=17531
2005-12-22From Bill Meier:Gerald Combs1-102/+131
After investigating the time-sequence graphs (Stevens and tcptrace) produced using an FTP capture file supplied by Eduardo Segura (see http://www.ethereal.com/lists/ethereal-users/200512/msg00153.html ) I've identified several problems in tcp_trace.c. The problems mostly involve incorrect determination of the lower/upper sequence number bounds (for the Y axis) in certain cases (e.g. having to do with 'partial' conversations). I've reworked the '...get_bounds' code to handle cases such as: 1. out of order data segments (e.g.: the first segment in a captured conversation has a higher sequence number than a later segment); 2. 'ack' sequence numbers for initial ack segments in a conversation lower than the sequence numbers of the initial data segments; 3. maximum 'ack + win' sequence number in a conversation greater than the max data sequence number; 4. Stevens graph: only use data segment sequence numbers when determining bounds; 5. TCP RST packet without 'ack' flag: do not try to use the 'ack' seq num from the packet in this case. (This was the specific cause of the originally reported problem). I've also reworked the tcptrace display code slightly to properly handle the initial ack packet of a sequence; As an example of the some of the fixes the Ethereal tcptrace style graph of the following conversation fragment will now be similar to the graph produced by Tcptrace. data: seq 10000 len 100 data: seq 10100 len 200 ack: ack 5000 win 6000 ack: ack 5400 win 5600 svn path=/trunk/; revision=16874
2005-09-17Move a pile of protocol-related headers from the top-level sourceGuy Harris1-2/+2
directory to the epan directory. Some of them should perhaps ultimately be moved to epan/dissectors, if they pertain only to stuff exported by a particular dissector. Fix Gerald's e-mail address in files we're moving. svn path=/trunk/; revision=15844
2005-09-14Have cf_retap_packets() take an argument that indicates whether toGuy Harris1-1/+1
generate columns; use cf_retap_packets instead of cf_redissect_packets() when running taps (the general flow graph stat uses the Info column). svn path=/trunk/; revision=15793
2005-08-24EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry! Ulf Lamping1-8/+8
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ... What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere. As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon. Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way... As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number... svn path=/trunk/; revision=15520
2005-08-21As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], soGuy Harris1-1/+1
that it doesn't appear to be part of GTK+. svn path=/trunk/; revision=15501
2005-08-21Add a "register_dfilter_stat()", to register stats that take a displayGuy Harris1-4/+5
filter as an argument on the command line and have a dialog box to enter the display filter through the GUI. Use it for all stats using "gtk_tap_dfilter_dlg_cb()". Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E" for the benefit of the declaration of "register_dfilter_stat()" in the top-level "tap_dfilter_dlg.h". Rename the "stat_menu.h" in the gtk directory to "gtk_stat_menu.h", so as not to have two headers with the same name. Get rid of headers not declaring any functions not being used in the module. svn path=/trunk/; revision=15493
2005-08-20- Declare some functions staticJörg Mayer1-2/+2
- Add plugins_dlg.h - Include .h files in their respective .c files - Include .h and remove extern declarations in .c files - set eol-style and keywords on gui_utils.[hc] svn path=/trunk/; revision=15471
2005-08-20renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical ↵Ulf Lamping1-1/+1
named ui_util.h in / dir svn path=/trunk/; revision=15465
2005-08-19Move the APIs for registering and processing "-z" command-line argumentsGuy Harris1-5/+5
and "Statistics" menu items into "stat.h" and "stat.c", to separate them from the core tapping APIs. A tap could conceivably not register as a "-z" command-line argument or "Statistics" menu item, and a stat could conceivably not be implemented as a tap, and dissectors that implement tapping points don't need the UI-related stuff from "stat.h", they just want the tap-related stuff in <epan/tap.h>. svn path=/trunk/; revision=15427
2005-08-08fix some MSVC const warningsUlf Lamping1-2/+2
svn path=/trunk/; revision=15263
2005-08-06Last set of char -> const char trivial warning fixes.Jörg Mayer1-15/+15
svn path=/trunk/; revision=15244
2005-08-05replace malloc and alike calls by their GLib pendants -> g_mallocUlf Lamping1-40/+40
svn path=/trunk/; revision=15232
2005-07-10Just pass &cfile to select_tcpip_session(); we don't need to passGuy Harris1-17/+16
cfile.current_frame to it separately. Note that we shouldn't ever get a "Selected packet isn't a TCP segment" error any more; we can now handle all link layers. Give a little more detail in the message shown if there's *more than one* TCP header in the packet. svn path=/trunk/; revision=14895
2005-07-10Fix some comment typos.Guy Harris1-2/+2
Don't regenerate the packet list when generating the TCP stream graph - it won't be changing; just redissect and run the tap. svn path=/trunk/; revision=14894
2005-07-10Get rid of an unused argument.Guy Harris1-5/+5
svn path=/trunk/; revision=14892
2005-07-10It works reasonably well with extensive testing so here goes :Ronnie Sahlberg1-249/+304
tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file. This makes tcp graph work for any type of capture and for any transport. In the future someone with access to captures with TCP over something over TCP to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph. svn path=/trunk/; revision=14889
2005-02-04huge cleanup of capture file API (functions in file.c/file.h).Ulf Lamping1-2/+2
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions. Hopefully, I didn't introduced any new bugs, as I had to change a lot of files... svn path=/trunk/; revision=13289
2004-12-29Make the tone of the error messages a bit less formal, by usingGuy Harris1-1/+1
contractions. (Safari does, at least when you're trying to open a file to which you don't have read access.) svn path=/trunk/; revision=12852
2004-09-29Move various tables into the epan directory.Guy Harris1-1/+1
svn path=/trunk/; revision=12130
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 02:02:08 +0000