aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2020-01-09TPNCP: Update from downstreamOrgad Shaneh2-445/+407
* Support little-endian systems * Improve error reporting * Implement some new features in the protocol Change-Id: I73e07a588c4a028fd0c22e1570adb7957ba2d52f Reviewed-on: https://code.wireshark.org/review/35467 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2020-01-09TCP: fix DESEGMENT_UNTIL_FIN handling in combination with OoO trackingPeter Wu1-2/+27
For dissectors that expect reassembly at FIN (for example, the WHOIS dissector), the expected end of the reassembly is not known until the FIN packet is received. We cannot rely on 'nxtseq' being valid, and certainly not use it to set the end of the reassembly using fragment_reset_tot_len. Since (1) OoO segments before FIN are already properly handled without extra care, and (2) OoO FIN is already broken, just disable OoO handling when DESEGMENT_UNTIL_FIN is requested. This ensures that reassembly at FIN is not skipped due to lack of data. Explicitly calculate 'nxtpdu' for the FIN case. Previously it happened to work because streams were often smaller than DESEGMENT_UNTIL_FIN (0x0ffffffe, 256MiB), but that was not obvious. Bug: 16289 Change-Id: I9b9468925d49765e21e58136c8a2366da082eeba Fixes: v2.9.0rc0-1097-gca42331437 ("tcp: add support for reassembling out-of-order segments") Reviewed-on: https://code.wireshark.org/review/35543 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09GSUP/SMS: also dissect ToN/NPI header in SM-RP-DA/OAVadim Yanitskiy1-4/+8
Unlike IMSI, both MSISDN and SMSC Address in SM-RP-OA/DA not only contain the BCD encoded digits, but also a little header with NPI (Numbering Plan Identification), ToN (Type of Number), and Extension fields. IE: SM-RP-DA (Destination Address) Information Element Identifier: SM-RP-DA (Destination Address) (65) Information Element Length: 8 Address Type: SMSC Address (3) 1... .... = Extension: No Extension .001 .... = Nature of number: International Number (0x1) .... 0001 = Number plan: ISDN/Telephony Numbering (Rec ITU-T E.164) (0x1) E.164 number (MSISDN): 447785016005 Country Code: United Kingdom of Great Britain and Northern Ireland (44) Let's dissect that header and following address bytes using the public API from MAP dissector - dissect_gsm_map_msisdn(). Change-Id: Idc8a098926d38770002ba689efcf2c794c6b18d9 Reviewed-on: https://code.wireshark.org/review/35664 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09DCERPC: display various driver version fields as hexGünther Deschner1-4/+4
Guenther Change-Id: I39eecf3e864df401dff9236d9614a5bd6ca68427 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35693 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: try to verify the PAC checksums and display the used keysStefan Metzmacher2-7/+239
This makes it much easier to analyze how PAC signing is supposed to work with trusted domains. Change-Id: I9993e5d92b7efee5aa91cd0e2005787f7d384444 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35704 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09BGP: Add EVPN Layer 2 Attributes Extended Community (RFC 8214)Jaap Keuter1-0/+76
Bug: 16287 Change-Id: Ic76972c2c99d0206c68703bee924c0e16ffdeae7 Reviewed-on: https://code.wireshark.org/review/35702 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: add a hint to the used decryption key into the proto treeStefan Metzmacher2-15/+33
This makes it much easier to understand which key is used were. Change-Id: I6f4bb1e46abb30212a87be2b574dc2679d8b7aed Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35695 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: re-add dissection of ntstatus (KERB_EXT_ERROR) in PA-PW-SALTStefan Metzmacher3-62/+188
We autodetect the length a 12 bytes and the 0 (4 bytes) and 1 (4 bytes) values after the 4 bytes NTSTATUS field. See [MS-KILE] 2.2.1 KERB-EXT-ERROR. Change-Id: I19345cb3f9c863e54a8f16002987912487f7d76a Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35694 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08Netlink: remove encoding copies and, by extension, nl_data copiesJaap Keuter7-177/+136
The underlying netlink dissector sets up a data structure to help maintain information about the netlink packet. This contains the encoding information as determined for this packet. Use this value in place of the copy that every netlink dissector makes in its private data structure. As a consequence the encoding field can be removed from these private data structures. Since the encoding field is now directly available from the data structure setup by the underlying netlink dissector, the private data structures also do not need to keep a pointer to this underlying netlink dissector data structure. This change replaces the use of the local copy of encoding with the original one. This change, by extension, also removes the encoding field and the pointer to the underlying netlink dissector data structure as these are no longer needed. The exception is the generic netlink dissector, which implements the dynamic netlink famiily subdissector table. Change-Id: Ida0065379c19ae68caf6d87860828b48766c1998 Reviewed-on: https://code.wireshark.org/review/35698 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08packet-smb2: add support for SMB2_FILE_NORMALIZED_NAME_INFOStefan Metzmacher1-0/+31
Change-Id: I58d9db510181c5872be14e9feb4f35c2e6e41a39 Reviewed-on: https://code.wireshark.org/review/35595 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-08packet-dcerpc-netlogon: relax the data model for netlogon_auth_keyStefan Metzmacher1-70/+34
This is a change into the correct direction and allows decryption even if DCERPC security context multiplexing is not used. The final design is added as comment, which would make it possible to do decryption in all cases allowed by the protocol. Change-Id: Ided40e0028967f2a047bf2722e627800ca77054d Reviewed-on: https://code.wireshark.org/review/35680 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08Netlink: stop hiding packet_netlink_data pointerJaap Keuter8-230/+244
The underlying netlink dissector sets up a data structure to help maintain information about this netlink packet. It gets passed through the familiy specific netlink dissectors private data structures to reappear when support funtions of the underlying netlink dissector are needed. In the mean time a copy of data (the value 'encoding' to be precise) in this structure is also maintained in these familiy specific netlink dissectors, adding to the confusion. This change is to make the underlying netlink dissector data structure a normal part of the function interfaces, so that it is present without being dependant on another private data structure. This change is a first step towards removing the unnessesary copy of the encoding value. Change-Id: I69e78a2b15e58e149e82e89c19e519ef041ee6b1 Reviewed-on: https://code.wireshark.org/review/35688 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07dcerpc-netlogon: fix compilation with older gcrypt versions.Dario Lombardo1-1/+9
GCRY_CIPHER_MODE_CFB8 has been introduced in gcrypt 1.8.0: https://abi-laboratory.pro/?view=changelog&l=libgcrypt&v=1.8.0 Add conditional compilation code for older versions. Change-Id: I756cc118fce261a6e1a580f4a6a244c8ff0b381f Reviewed-on: https://code.wireshark.org/review/35678 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-07BGP: update Well-known CommunitiesUli Heilmeier1-1/+10
Update the well-known communities as defined by https://www.iana.org/assignments/bgp-well-known-communities/bgp-well-known-communities.xhtml Communities for expired drafts has been ignored. Change-Id: I3dedea2bdaad8feda3c7f1d9886092d4c02d6f95 Reviewed-on: https://code.wireshark.org/review/35602 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07TFTP Header End FixRoman Koshelev1-2/+4
Change-Id: I70d66bb49384f2eac865a81ffc23b76362c37191 Reviewed-on: https://code.wireshark.org/review/35578 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07NL80211: Remove global variable m_pinfo from dissectorJaap Keuter1-29/+40
The Netlink 80211 dissector has a global variable to pass the pinfo pointer to dissection routines that need it. Replace this by properly passing it to the functions via a new private data structure, akin other netlink dissectors. Change-Id: Ie08e370b65f7068c01cc93100657e3b8baa5fd63 Reviewed-on: https://code.wireshark.org/review/35657 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-smb2: handle SMB2_CHANNEL_RDMA_V1_INVALIDATE for readStefan Metzmacher1-0/+1
Change-Id: I96045fb2b07d8bae26360558f34dd6de3442ecd0 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35594 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-smb-direct: move Flags into data_tree.Stefan Metzmacher1-1/+1
Change-Id: I919994c084d4f5702b0a6d504c8cd5a8b716498b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35596 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: implement NETLOGON_FLAG_AES decryptionStefan Metzmacher1-14/+159
Change-Id: I2ff05f528fe8c3ab6f5407c0289064b62f3f0202 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35593 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: remove STRONGKEY related processing from get_seal_key()Stefan Metzmacher1-24/+27
This won't be needed for NETLOGON_FLAG_AES. Change-Id: I668bca15ed13e5a2767fa3e39c5cad0d510a8f5d Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35592 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: split out prepare_decryption_cipher[_strong]()Stefan Metzmacher1-11/+56
Change-Id: Ie63c2d0311be058c5694245d8576ea75d7e6bc14 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35591 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: split out uncrypt_sequence_strong()Stefan Metzmacher1-2/+16
Change-Id: Ie58377b319632c74ad61c2df42e690466b5c5608 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35590 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: use the correct NETLOGON_FLAG_AES flagStefan Metzmacher1-8/+10
See [MS-NRPC] 3.1.4.2 Netlogon Negotiable Options, it's flag W: Supports Advanced Encryption Standard (AES) encryption (128 bit in 8-bit CFB mode) and SHA2 hashing ... Change-Id: I4b677e1ca1c3b3b9bc47ccc412380cc18659fd5d Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35589 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07packet-dcerpc-netlogon: fix the build with DEBUG_NETLOGONStefan Metzmacher1-2/+2
Change-Id: Iab70f2847343f934864cf205569fe64cf9e98d9b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35588 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07UDP: Add a filter for payload.Anders Broman1-3/+16
A filter for payload makes it easier to exoprt it. Change-Id: I0732c60c7fac37283fcbe6508d5e27bcd3c603fd Reviewed-on: https://code.wireshark.org/review/35519 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07NAS 5GS: add missing R15 bits in 5GS network feature support IEPascal Quantin1-1/+29
Bug: 16310 Change-Id: I52a3e8bbe6ae89c227cd0eee58bb46ba37eceeb6 Reviewed-on: https://code.wireshark.org/review/35676 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-06USB MSC: Dissect subclass and protocol codesTomasz Moń2-1/+64
Change-Id: I7a818a11352e437a9492f896557c3348abe33c95 Reviewed-on: https://code.wireshark.org/review/35668 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-06Get rid of %debug, so protobuf_lang.y can be processed by Berkeley YACC.Guy Harris3-6/+3
If somebody wants to debug the parser, they can add it if necessary in their version. Bug: 16306 Change-Id: I00e5924058d9401176e3fab40833932dc5757e6a Reviewed-on: https://code.wireshark.org/review/35665 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-06USB Audio: Fix Feature Unit Descriptor dissectionTomasz Moń1-12/+26
Properly calculate the number of logical channels in the cluster. Report expert info if number of channels does not turn into integer. Bug: 16305 Change-Id: I028f3f00912629351641ef9297864ea832629cf0 Reviewed-on: https://code.wireshark.org/review/35656 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-05IPv4: Fix incorrect expert info for IGMP TTLJoão Valverde1-4/+7
IGMP uses TTL = 1 for the network control block. The code assumes a certain registered multicast destination address always carries traffic for that protocol, which isn't true. For example mDNS usually uses a TTL of 255 but IGMP Membership reports use a TTL of 1 for the same destination address. The end result is that IGMP traffic to mDNS multicast destination shows a confusing and incorrect "TTL != 255 for the Local Network Control Block" expert info. Rename the "ttl" variable for clarity. Change-Id: I693306cd6531aa250a6f5884a6731a2ea254bf2a Reviewed-on: https://code.wireshark.org/review/35639 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-05SIP: authorization validation segfault on missing fieldserikdejong1-1/+2
Fix for segfaults caused by missing username and or realm fields when validating SIP authorization. Change-Id: Ia418f2a7f036ef706fcd6e4a766ea43098a6883d Reviewed-on: https://code.wireshark.org/review/35644 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-04IPv4: Fix indentation (use spaces)João Valverde1-3/+2
Change-Id: Ie89c3c958567182c1f5fe66cff23522e797a3e78 Reviewed-on: https://code.wireshark.org/review/35640 Reviewed-by: João Valverde <j@v6e.pt>
2020-01-04gtpv2: added IE Monitoring Event InformationJoakim Karlsson1-3/+73
Change-Id: Icf02c5715c2eda01fc86d5a71a209983b2f5df68 Reviewed-on: https://code.wireshark.org/review/35603 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-03WSUG: Add a Packet Lengths dialog section.Gerald Combs1-4/+4
Add a section for the Packet Lengths window. Use title case for the column headers. Fix a button name and other issues elsewhere. Change-Id: I339d56aa169158e0788acd02a897729205e9f50e Reviewed-on: https://code.wireshark.org/review/35615 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03packet-iec104: Use pinfo->match_uint instead of port number from configurationJiří Engelthaler1-14/+2
Dissector port number is used to determine the direction. It will not work with Decode As when port number from the configuration is used. It is better to use the actual dissector port from pinfo->match_uint. Change-Id: I156728a66ed0cf0fe536da8d9ae958c8c4e0b361 Reviewed-on: https://code.wireshark.org/review/35632 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-03GSM RLC/MAC: dissect Mobile Identity in Packet Paging RequestVadim Yanitskiy1-9/+18
Before this patch, Mobile Identity was displayed as an array: PACKET_PAGING_REQUEST (34) (downlink) 1000 10.. = MESSAGE_TYPE (DL): PACKET_PAGING_REQUEST (34) .... ..00 = PAGE_MODE: Normal Paging (0) 0... .... = Exist_PERSISTENCE_LEVEL: 0 .0.. .... = Exist_NLN: 0 ..1. .... = Repeated_Page_info Exist: 1 Repeated_Page_info ...1 .... = Repeated_Page_info: (Union) u.Page_req_RR .... 1... = Page_request_for_RR_conn: (Union) u.Mobile_Identity .... .100 0... .... = Length_of_Mobile_Identity_contents: 8 .001 0100 1... .... = Mobile_Identity_contents: 41 .001 0011 0... .... = Mobile_Identity_contents: 38 .001 0010 0... .... = Mobile_Identity_contents: 36 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .000 0000 0... .... = Mobile_Identity_contents: 0 .001 0010 0... .... = Mobile_Identity_contents: 36 .00. .... = CHANNEL_NEEDED: 0 ...0 .... = Exist_eMLPP_PRIORITY: 0 after this patch: u.Mobile_Identity .... .100 0... .... = Length_of_Mobile_Identity_contents: 8 0010 .... = Identity Digit 1: 2 .... 1... = Odd/even indication: Odd number of identity digits .... .001 = Mobile Identity Type: IMSI (1) IMSI: 262420000000042 [Association IMSI: 262420000000042] Mobile Country Code (MCC): Germany (262) Mobile Network Code (MNC): Vodafone GmbH (42) .00. .... = CHANNEL_NEEDED: 0 ...0 .... = Exist_eMLPP_PRIORITY: 0 Achieved by calling de_mid() on an octet-aligned buffer. Change-Id: Ia77e388f9ac18e4ecda27eeb3e04ce1bd978a3a5 Reviewed-on: https://code.wireshark.org/review/35625 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-02BER: fix ber.error.bits_unknown displayPascal Quantin1-10/+19
Before the changes done in v3.1.0rc0-431-gc2ac157ac0 and v3.1.0rc0-458-g37b91eedd6 the expert info was only displayed if at least 1 unknown bit was set to 1. Restore this behavior. Bug: 16301 Change-Id: I3bea0992d6727154ef07d40ac18a7b012d3c1da4 Reviewed-on: https://code.wireshark.org/review/35612 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-02BGP: Support for drafts Tunnel Encapsulation and Segment RoutingUli Heilmeier1-27/+551
Add support for BGP Tunnel Encapsulation Attribute (draft-ietf-idr-tunnel-encaps-15) and Advertising Segment Routing Policies in BGP (draft-ietf-idr-segment-routing-te-policy-08). Due to missing pcap file(s) most of the Segment List Sub-TLVs are still missing. Bug: 16294 Change-Id: I0d7524934d5c5f2458a3f9a68e1e49c95a030c32 Reviewed-on: https://code.wireshark.org/review/35587 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-31HTTP: Fix dissection of data following the HTTP Upgrade responsePeter Wu1-0/+7
When a HTTP response includes HTTP headers and a subset of data for the subdissector in the same frame, be sure to skip the HTTP headers for reassembly of the latter data. Otherwise the HTTP headers will be misinterpreted as the subprotocol (for example, WebSocket). Bug: 16274 Change-Id: Ida6f6f2f7d0c463be2d498bfde5e8a9cd11a4b25 Reviewed-on: https://code.wireshark.org/review/35536 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-12-31LPP: upgrade dissector to 37.355 v15.0.0Pascal Quantin5-6/+6
3GPP decided to transfer the specification from 36.355 to 37.355 now that it covers NR also. 37.355 v15.0.0 is equivalent to 36.355 v15.5.0. Change-Id: I63aba21f55861ffd8a5c0adbd307b0453482baaa Reviewed-on: https://code.wireshark.org/review/35613 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-30GSM A RR: Fix wrong description for Access Technologies Request presence fieldPau Espin Pedrol1-1/+1
Reference: 3GPP TS 44.018 version 13.3.2 Release 13, section 10.5.2.16 Change-Id: I813275d5fb3e87485b855770c97e566d6c2288ed Reviewed-on: https://code.wireshark.org/review/35605 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-30SIP: RFC8688 Rejected Status CodeUli Heilmeier1-0/+1
Add support for RFC8688 A Session Initiation Protocol (SIP) Response Code for Rejected Calls Change-Id: I8471e62f9a428c731100940301d70af66095606b Reviewed-on: https://code.wireshark.org/review/35601 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-30GSM A RR: Fix typos in PS IR fieldPau Espin Pedrol1-1/+1
Change-Id: I521633fe2533983e403eb694b544c377d4b3ae9f Reviewed-on: https://code.wireshark.org/review/35597 Reviewed-by: Vadim Yanitskiy <axilirator@gmail.com> Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-29netlink: changes to match Linux kernel v5.4 netlink interfaceJaap Keuter6-53/+192
Changes consist of: - Addition of new enum values - Header file references now point to kernel sources - Dissection of few more fields - Fixes to some dissections Change-Id: I4cda045153ab0971b0b09ce59a7363238fe627ee Reviewed-on: https://code.wireshark.org/review/35571 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-28netlink: update 802.11 related netlink messages Linux kernel v5.4Jaap Keuter1-0/+1294
Taking the Linux kernel v5.4 uapi/linux/nl80211.h file: - Sort the enums in the generation script according to the header file to make incremental maintenance easier. - Add listing of all additional enums found in the header file. - Update the generated netlink dissector code for 802.11. Change-Id: I9d2dc09d58d8f252d4746e662e4133d47a7525c5 Reviewed-on: https://code.wireshark.org/review/35570 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-27ieee802.11ax: Fix spelling mistakes in HE Capabilities Supported HE-MCS.Richard Sharpe1-6/+6
Change-Id: Ifcf041eb70bd68564d326b94868a45efab86a71f Reviewed-on: https://code.wireshark.org/review/35568 Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-26Find the line ending using tvb_find_line_end().Guy Harris3-16/+20
tvb_find_line_end(), unlike a tvb_find_guint8() looking for an LF, returns a length that *doesn't* include the line ending, *regardless* of whether the line ends with CR-LF or just LF, so the query string we extract is just the query, without any of the line ending. Update some comments while we're at it to note that the "next_offset" pointer argument to tvb_find_line_end() and tvb_find_line_end_unquoted() can be NULL, in which case the offset *past* the line ending isn't returned. (We pass tvb_find_line_end() NULL in the aforementioned call, because, in that particular case, we don't care about the next line.) Change-Id: I1c9746e32c61a79f8cb636d577a2e14a07ecab17 Reviewed-on: https://code.wireshark.org/review/35566 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-26Cleanly fetch the query string.Guy Harris1-1/+1
Use tvb_get_string_enc(), because it guarantees null termination, unlike tvb_memdup(), and use ENC_ASCII|ENC_NA as the encoding, to convert non-ASCII characters to Unicode REPLACEMENT CHARACTER (there is *no* standard for the encoding of WHOIS texts other than "ASCII"; we use ENC_ASCII|ENC_NA elsewhere). Bug: 16298 Change-Id: I6b7ff2a1af3997e8426ca07bea1ce68fe9cbc9c6 Reviewed-on: https://code.wireshark.org/review/35564 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-26SMB2: display oplock/lease break packets properlyVolodymyr Khomenko1-14/+74
Changed display of SMB2 oplock/lease break packets: using proper Notification/Acknowledgment/Response naming notation and explicitly indicate Oplock/Lease type of packets. According to [MS-SMB2] 2.2.23, 2.2.24 and 2.2.25 Bug: 16296 Change-Id: I04c8b34116aec850b917fd47f6333fb56a1ec934 Reviewed-on: https://code.wireshark.org/review/35560 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-25rtcp: Extend AVB RTCP (IEEE1733) to decode AS Timestamp and Sequence IdAlexander Meier1-4/+35
AS Timestamp and Sequence Id are not decoded in AVP RTCP (IEEE17333) packets. This adds a unsigned 32 bit field for AS Timestamp and a unsigned 64 bit field for Sequence Id to the rtcp dissector. Change-Id: I9f47001d60985b90d0f4a67ca1b1188ceba45923 Reviewed-on: https://code.wireshark.org/review/35537 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-20 12:02:58 +0000