aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-11-02cfdp: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I434fdecd028d63d12f3fc804342c9ca04c7fd106 Reviewed-on: https://code.wireshark.org/review/34907 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-02amp: Fix Dead StoreAlexis La Goutte1-16/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I199d9ebf9ff48f4268a4647bfdeafb784eb8e9a5 Reviewed-on: https://code.wireshark.org/review/34908 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-02ieee80211: Extended Key ID supportAlexander Wetzel2-6/+28
Support Extended Key ID for Individually Addressed Frames from IEEE 802.11 - 2016. Extended Key ID allows unicast (PTK) keys to also use key ID 1 and has an additional RSN attribute "KeyID" in EAPOL #3. Add the additional attribute KeyID to the RSN parser, stop assuming unicast keys are only using key ID 0 and add a test case to verify Extended Key ID parsing and decoding. Change-Id: I43005c74df561be5524fa3738149781f50dafa14 Reviewed-on: https://code.wireshark.org/review/34883 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-10-31RTCP:Improve dissection of Mission Critical Push To Talk (MCPTT)Anders Broman2-24/+282
Change-Id: I6e15cd8e56e4ad327aa925b6bcc7a1baf9bb756c Reviewed-on: https://code.wireshark.org/review/34895 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-30SDP: Handle MCPTT fmtp parameter.Anders Broman1-11/+14
Change-Id: I1f1a6ce84395e5d3922b4bcb08f0d7627bef603c Reviewed-on: https://code.wireshark.org/review/34891 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-30RTCP: Remove unused hf.Anders Broman1-13/+0
Change-Id: I25ec8af7e8b15326beacc2b14f919b7e44ed6728 Reviewed-on: https://code.wireshark.org/review/34890 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-30ITS: Fix dissection of ItsPduHeaderRediet2-12/+18
The offset logic was incorrect leading to systematic call of data_dissector for facilities. packet-its.c was generated using asn2wrs.py Change-Id: Id49b031d757f4b0fde9e789b98226efbf044d4da Reviewed-on: https://code.wireshark.org/review/34888 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-30RTCP:Improve dissection of Mission Critical Push To Talk (MCPTT)Anders Broman1-484/+632
TS 24.380 V16.3.0 Change-Id: Ib01cf18e4fa74b14bc0cd7367036d5107c1e7fa3 Reviewed-on: https://code.wireshark.org/review/34889 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-29Diameter: Update AVP and flag dissection.Anders Broman1-2/+93
Change-Id: I982f3ed12613b0dc6a4dfc1ffebebde5b0697c98 Reviewed-on: https://code.wireshark.org/review/34884 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-29lustre: fix rmfid dissectionNathaniel Clark1-18/+1
Initial member as count is only in ioctl call, not in the wire format. Change-Id: Ic44b7ccf6510df91e5df78587a84fc502bbd7623 Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us> Reviewed-on: https://code.wireshark.org/review/34880 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-29ZigBee: add new manufacturer codesChris Brandson2-0/+22
Change-Id: If0a481e4cfe7bd97684522b8ef7e72ea86684851 Reviewed-on: https://code.wireshark.org/review/34882 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-28wslua: Fix memleak of unregistered ProtoExpertStig Bjørlykke2-4/+20
If a ProtoExpert object was created, but not linked to a Proto, then the object and some fields (abbrev, text) would leak. This is a follow-up to g79fef2ae. Change-Id: Ic0b44e8b70895a19d9b52a0e44064a1e76a58fa0 Reviewed-on: https://code.wireshark.org/review/34876 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28NAS 5GS: fix dissection of routing indicatorPascal Quantin1-1/+1
Change-Id: I75c344394bf796c0d58cf24c758a6a54a585dc75 Reviewed-on: https://code.wireshark.org/review/34877 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-28RLC: Show reassembled data as a fieldDarien Spencer1-2/+11
Adding a field of "Reassembled RLC Data" like other reassembling dissectors have (such as TCP) Also cosmetic changes to the reassembled tree 'root' item Change-Id: I6642ea2ef79f3783f4bcd2d544c34f7b0c1e7ade Reviewed-on: https://code.wireshark.org/review/34814 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-28wslua: Fix memleak of unregistered ProtoField stringsStig Bjørlykke4-83/+100
If a ProtoField object was created, but not linked to a Proto, then the strings field and all elements (depending on type) would leak. This is a follow-up to g79fef2ae and fixes the real issue in g44870fb1. Change-Id: I01880a92bb20fae45f68c754b07daeb07630deec Reviewed-on: https://code.wireshark.org/review/34872 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28NAS 5GS: fix dissection of ngKSI in Registration Request messagePascal Quantin1-2/+2
Bug: 16163 Change-Id: I00e5aa1f6e543eaf06d4c4f0e98c94eba80f5f6d Reviewed-on: https://code.wireshark.org/review/34875 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-28NAS 5GS: fix dissection of PLMN in a few IEsPascal Quantin1-9/+9
The MNC is encoded in little endian format, not big endian. The IEs impacted are 5GS tracking area identity list, service area list and SOR transparent container. Bug: 16162 Change-Id: I05acc5fb7d1c4a84f53cc5b2a21ee12c4813593d Reviewed-on: https://code.wireshark.org/review/34874 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-28NAS 5GS: Rejected NSSAI. use correct offsets.Anders Broman1-6/+6
Change-Id: I30e1bda0d57dc7d5dfd5bf2036e6db6c9c211f3d Reviewed-on: https://code.wireshark.org/review/34871 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-27HomePlug AV: Fix dissection of MMTYPE and FMIJohn Serock1-3/+3
Get MMTYPE MSB from the three most significant bits, bits 5 through 7, instead of bits 1 and 2. Get FMI Fragment count from the four most significant bits instead of the four least significant bits. Get FMI Fragment index from the four least significant bits instead of the four most significant bits. Bug: 16158 Change-Id: Ib51789486be4562f76114081cbbf3aa22a41ff2e Reviewed-on: https://code.wireshark.org/review/34868 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-27Add more checks, fail for negative byte block lengths.Guy Harris1-19/+50
Have dissect_kafka_string_new() set a flag if the length was negative. If the length is negative, don't try to process what comes afterwards. Make the length argument to decompression routines unsigned, and do various checks. Don't try to decompress a zero-length block, and quit if the decompressed block is zero-length. Bug: 16082 Change-Id: I34c2ea99aa096b3f5724d9b113171b105bd6c60b Reviewed-on: https://code.wireshark.org/review/34867 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-27Fix val_to_str() call.Guy Harris1-1/+1
The format argument (third argument) is used with the numerical value passed to val_to_str(), so it should have a numerical format item, not a string format item. Bug: 16146 Change-Id: I91ae0edd7fe06fb95ae74697b06bd4f50b696f9f Reviewed-on: https://code.wireshark.org/review/34866 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-27[Automatic update for 2019-10-27]Gerald Combs1-4/+22
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic8bc6882d217da5f04e7e3ef1e58c3f16ca23fd3 Reviewed-on: https://code.wireshark.org/review/34861 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-26IPv6: New Hop by Hop Path MTU OptionBob Hinden1-0/+90
Add support to Wireshark for new hop-by-hop option defined in: https://tools.ietf.org/html/draft-ietf-6man-mtu-option-01 This Hop-by-Hop IPv6 option is designed to be used to record the minimum Path MTU along the forward path between a source host to a destination host. This collects a minimum recorded MTU along the path to the destination. The value can then be communicated back to the source using the return Path MTU field in the option. Change-Id: I5dfc1a70aedd347b128bc3c5cd96f9d5a0752e3b Reviewed-on: https://code.wireshark.org/review/34786 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2019-10-26synphasor: fix compilation with gcc-5/6.Dario Lombardo1-2/+2
They complain because of an uninitialized variable. ../epan/dissectors/packet-synphasor.c: In function ‘config_3_frame_fast’: ../epan/dissectors/packet-synphasor.c:782:7: error: ‘ai’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ai[i].conv = 1; ^ ../epan/dissectors/packet-synphasor.c:767:7: error: ‘pi’ may be used uninitialized in this function [-Werror=maybe-uninitialized] pi[i].unit = phasor_unit & 0x00000800 ? A : V; ^ Change-Id: I2013ca9ddff5551328d2b86decc5e52fe052b6d0 Reviewed-on: https://code.wireshark.org/review/34859 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-26nfs: fix guint64 format in proto_item_append_text.Dario Lombardo1-1/+1
../epan/dissectors/packet-nfs.c:7070:48: error: format specifies type 'long' but the argument has type 'guint64' (aka 'unsigned long long') [-Werror,-Wformat] proto_item_append_text(attr_tree, " = %ld", size); ~~~ ^~~~ %llu Change-Id: Iab7c6e026e9e5668e5d744eaedc67cd055f5e3cc Reviewed-on: https://code.wireshark.org/review/34860 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-26Add config 3 frame support synphasorDwayne Rich1-394/+1305
Config 3 frames are optional in the synchrophasor standard. Add support so that they get dissected correctly. Bug: 16140 Change-Id: I6e0f7f653b99a9fd817736d69687132ae9a8537d Reviewed-on: https://code.wireshark.org/review/34800 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-26NFS: add dissector for FATTR4_MDSTHRESHOLDJorge Mora1-0/+121
Add dissector for the MDS threshold attribute for the files layout type. For any other layout type just display the bitmap mask and the bitmap opaque data. Change-Id: I3325218eb0e8b29d20b1bb540148f3b18cd4ef8f Reviewed-on: https://code.wireshark.org/review/34845 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-26lustre: MDS opcode cleanupNathaniel Clark1-90/+398
Fill out MDS HSM opcode processing. Lustre 2.13/2.12.3 has added MDS_RMFID RPC. Reorder MDS opcodes to numeric order. Change-Id: I732b55f62195358b860ca7403f699fc4ff10faaf Signed-off-by: Nathaniel Clark <nathaniel.clark@misrule.us> Reviewed-on: https://code.wireshark.org/review/34826 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-25nas-5gs:Dissect 9.11.3.46 Rejected NSSAI.Anders Broman1-3/+47
Change-Id: Idc85a790b326e1087d10c3968eac84ff6d0382d4 Reviewed-on: https://code.wireshark.org/review/34857 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-25nas-5gs:Fix dissection of NAS key set identifierAnders Broman2-18/+40
Bug: 16155 Change-Id: Ife4048d140e2d30d1d26a680c548783a14447199 Reviewed-on: https://code.wireshark.org/review/34853 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-25snort: Show top-level config errors using popup windowMartin Mathieson2-0/+8
Not queueing up as most likely only one of these would pop up. Not trying to show every possible error - only really verifying that the binary and top-level config file are specified correctly. Change-Id: I2adf2557989bfc67874f5ac2648b1ba8d2a3eb25 Reviewed-on: https://code.wireshark.org/review/34851 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-10-25NFS: Fixing again stateid display of other_hashJorge Mora1-3/+3
Initially added feature to match linux kernel hash value of stateid to the wireshark in commit 05c47d755a82891fd73b2dfad7e128cd3c966ded change id I70c6d2b88822b6f735e8bc506a1bfcb421f6ddb9 [NFS] adding stateid hash based on stateid.other This has been broken by commit b913bcc13a9a6213902691a8d73bba1427ab407b change id I3bf7caefc3341887a4c9137500dfeac0115af8cf NFSv4: Fix for duplicate StateId hashes This patch fixes it to again calculate a crc32 hash to make it to the linux kernel output. Change-Id: Ibb29516de61bd9bdf2dd1164da4b14412aa7a71c Reviewed-on: https://code.wireshark.org/review/34842 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-24nas-5gs: NAS-5GS 5GS network feature support incorrectly dissectedAnders Broman1-25/+43
Bug: 16149 Bug: 16147 Change-Id: Ib09c8697f8f5d0751d49a872e9f7ceafc7b4f22b Reviewed-on: https://code.wireshark.org/review/34850 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-24lte-rrc: Register dissector for UEPagingCoverageInformation and -NBAnders Broman2-2/+4
Change-Id: I42cd7a917e3a79d61a6ae5dc80765814ad0650a7 Reviewed-on: https://code.wireshark.org/review/34849 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-23asn2wrs.py: fix parsing of integer unions with extensionPascal Quantin4-8/+8
When parsing the description ExpectedActivityPeriod ::= INTEGER (1..30|40|50|60|80|100|120|150|180|181,...) asn2wrs.py was generating some code where the has_extension flag was wrongly set to false, leading to a decoding error. Bug: 16145 Change-Id: I0d54994c0656f5b48f3dcd1864218c45a4ebc308 Reviewed-on: https://code.wireshark.org/review/34837 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-23NAS 5GS: small fixes for PDU session establishment request messagePascal Quantin1-7/+49
- add missing Always-on PDU session requested IE - decode SM PDU DN request container IE as UTF-8 string Change-Id: I841c509fadeb870014b85543fe25fdb7f2d11071 Reviewed-on: https://code.wireshark.org/review/34830 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-22SNMP: handle Net-SNMP Engine Id of 12 octetsJaap Keuter2-13/+23
The Net-SNMP code creates an Engine Id size based on the compilation size, either 8 or 12 octets long. The initial change added handling of the '4B/8B random, 4B epoch seconds' format. A different format seems more likely though, hence this change, implementing handling of the '4B random, 4B/8B epoch seconds' format instead. Bug: 16051 Change-Id: I8105b0ba69004f6c15e6b1926c677cb4c5b76f17 Reviewed-on: https://code.wireshark.org/review/34816 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-10-22Protobuf: for UDP frames, show top-level summary in columns.Martin Mathieson1-13/+64
Will show PB(<message_name>) in Protocol column, and details of top-level message elements in the Info column. Change-Id: Ia00fb90bb7ec990300a990555a0ab6fbddf01ef9 Reviewed-on: https://code.wireshark.org/review/34822 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Huang Qiangxiong <qiangxiong.huang@qq.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-21TVB(LZ77+Huffman): return proper value on error (CID1451652)Jaap Keuter1-1/+1
When preparing to decompress the encoded tree size is the minimum input size. When not met the return value (FALSE) would still indicate success, being value 0. This could lead to NULL pointer dereference later on. Change the return value to -1 to match the function return type. Change-Id: Ie81d98f55af33518a34bc0b79c29450064886bc3 Reviewed-on: https://code.wireshark.org/review/34818 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-19Netflow: Niagara Networks decode for SSL SHA-1 IPFIX IE.Volodymyr Veskera1-0/+13
Change-Id: I8ec149a218e0db42bdc06796b6c800bbe0f48d79 Reviewed-on: https://code.wireshark.org/review/34806 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-10-19RLC: mark depended framesDarien Spencer1-2/+5
Using mark_frame_as_depended_upon like other reassembling dissectors Change-Id: I2b1f476d9339d8277fb0d3420d94ec32d402c0ee Reviewed-on: https://code.wireshark.org/review/34807 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-19AgentX: Register dissector so find_dissector() can find itKen Aaker1-0/+3
Change-Id: Idfe4d7040dfdd7273b39f79ac4f5bdae2e8c990d Reviewed-on: https://code.wireshark.org/review/34810 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-18ieee1905: Move to the latest version of the Multi-AP spec.Richard Sharpe2-296/+3903
This handles the various Multi-AP additions and has been checked by the WFA. Change-Id: I56d32f3efec24923e1a710cb67c67f7e0b4630dc Reviewed-on: https://code.wireshark.org/review/34794 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2019-10-18NFS: add dissect_nfs4_bitmap functionJorge Mora1-519/+558
Add generic function to dissect the bitmap4 struct and optionally its corresponding opaque data. The behavior is customized by setting the nfs4_bitmap_info_t struct given as argument. The items are displayed when their corresponding hf_* labels are given (not set to NULL). The type argument if set to NFS4_BITMAP_MASK only the bitmap is dissected and displayed as a list of attribute names. Otherwise if set to NFS4_BITMAP_VALUES the bitmap is dissected including their respective values. The function dissect_nfs4_fattrs was modified to use dissect_nfs4_bitmap instead and all functionality which dissects the value of each attribute was moved to a separate function dissect_nfs4_fattr_value. All functionality from dissect_nfs4_fattrs is given in the new function dissect_nfs4_bitmap, but it also includes additional functionality: - Gracefully handle a bitmap attribute which does not have a dissector and a warning is displayed. - If there is a problem dissecting one of the bitmap attribute values then do not attempt to dissect any more values and a warning is given explaining why the values were not dissected. In this case at least the rest of the attributes names are displayed. - If any error is found dissecting the values then all bytes left undissected are just consumed so the rest of the NFS packet is correctly dissected. - Add subtree if the name is given, all bitmap data will be under this main tree. - Show mask label when the number of bitmap masks is 0 and the type is to display only the bitmap mask. Use function dissect_nfs4_bitmap instead to process the state protect bitmaps. Also, use correct labels "spo_must_enforce" and "spo_must_allow" instead of using the generic label "operation mask" for both bitmap masks. Finally, display the operation masks including the list of operation names in each mask. Use function dissect_nfs4_bitmap instead to process the hints mask in IO_ADVISE. Use function dissect_nfs4_bitmap instead to process the notify mask in GETDEVICEINFO. Bug: 16107 Change-Id: Ic470fd003bbc18feeadbd5d2cd0aa56329682bd6 Reviewed-on: https://code.wireshark.org/review/34714 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-18SRT: Fixed misnamed field srt.bufavailMaxim Sharabayko1-1/+1
Change-Id: I03d336100e91bdf35165b380a1220a2f4efc8484 Reviewed-on: https://code.wireshark.org/review/34804 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2019-10-18RRC: Add System Information Block type to info columnDarien Spencer6-217/+689
Add block type to information column and also add fences for blocks container messages (SysInfoUpdateRequest in NBAP, SysInfo-BCH in RRC) Change-Id: I2a49229f74438cadc67603b6209d4a8d72cfd017 Reviewed-on: https://code.wireshark.org/review/34785 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-18BTMesh: Add support for manufacturer-specific opcodesPedro Malagon1-3/+10
Access Layer: add support for manufacturer-specific opcodes (customizable) of 3-octets when bits 7 and 6 of the first opcode octet are set, as specified in Table 3.43: Opcode formats of document Mesh Profile v1.0.1, Bluetooth Specification Change-Id: I3edf8f86bf58d28f15cc2a8f72618cc577a75a44 Reviewed-on: https://code.wireshark.org/review/34787 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-18Kafka: Fix a length check.Gerald Combs1-1/+1
Skip past our chunk size before checking our available length. Bug: 16117 Change-Id: I39ddf1f6861de3b3adea59df2f30abfe3a4f7295 Reviewed-on: https://code.wireshark.org/review/34795 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-17Wi-Fi NAN: Fix rval_to_channel_set reading past end of op_class_ch...Connor Newton1-1/+3
Looks like I broke it by fixing it... Added the table terminator again. The real solution to this when there is time is to use the 802.11 dissector for operating classes, as this is a duplicate and not fantastically thought out implementation. Bug: 16123 Change-Id: Ide7071b71825b1595e14a474bcb0c57ee8eb0bf5 Reviewed-on: https://code.wireshark.org/review/34792 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-16wslua: Improve parameter check in ProtoField.new()Stig Bjørlykke1-10/+24
Improve paremeter check in ProtoField.new() when using ftypes.CHAR: - Check valid base types and give an error when not supported instead of terminate in a g_error() (base.DEC is not supported). - Give an error if used with base.UNIT_STRING instead of silently remove the flags. - Support base.RANGE_STRING instead of removing the flag. Support using base.NONE with a valuestring. Add ftypes.CHAR to the list of supported types. Change-Id: I0e3f9698074c807f5da0de23ccd1be7446271135 Reviewed-on: https://code.wireshark.org/review/34783 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 23:44:18 +0000