aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2015-12-07Spelling fixes for errors found by lintianBalint Reczey31-49/+49
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-07v5ua: The 'then' statement is equivalent to the 'else' statement found by ↵Alexis La Goutte1-58/+25
PVS Studio (V523) Change-Id: I0aa35944dbae45477a9db365f30cf24355f5328d Reviewed-on: https://code.wireshark.org/review/12454 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-07MIP6: Don't no need to have a another subtree (with wrong lenght for LLAAlexis La Goutte1-6/+3
Bug: 10627 Change-Id: Ia6940ef7624a92d453cada6693bcd7f4e145a5b6 Reviewed-on: https://code.wireshark.org/review/12453 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-06[Automatic update for 2015-12-06]Gerald Combs2-1/+71
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I70fd3f5a9f8f53ea6a086b521c8f05d33815516f Reviewed-on: https://code.wireshark.org/review/12450 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-06SCTP: It is odd that the body of dissect_heartbeat_ack_chunk' function is ↵Michael Tüxen1-3/+5
fully equivalent to the body of 'dissect_heartbeat_chunk' function found by PVS Studio (V524) This is just a cosmetic change, which makes sense. No funtional change. Change-Id: Id24d162379093207863608e70f405e66f789276c Reviewed-on: https://code.wireshark.org/review/12440 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Tüxen Reviewed-by: Michael Tüxen <tuexen@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2015-12-05Type cleanups.Guy Harris3-9/+10
dfilter_macro_apply_recurse() returns either NULL or a pointer to freshly-allocated memory, so it doesn't return a const pointer. dfilter_macro_apply() calls dfilter_macro_apply_recurse(), so it doesn't return a const pointer, either. In dfilter_compile(), have separate variables for the filter handed in and the macro-expanded filter, the former being const gchar * and the latter being gchar *. Change-Id: I191549bf0ff6c09c1278a98432a907c93d5e0e74 Reviewed-on: https://code.wireshark.org/review/12446 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Undoing base-64 encoding is not decryption.Guy Harris1-12/+12
For now, we don't change the name of the preference, but we *do* change the description of the preference and the name of the variable. Change-Id: I1f80b2e7187679dca787fda5f3d06e9d30536ddc Reviewed-on: https://code.wireshark.org/review/12444 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Revert "Build Flex-generated files with "warnings are errors"."Guy Harris5-34/+69
This reverts commit b56f53884be3bab935058b2bbbb4da0b8bbbe7f6. Sadly, we *do* get warnings at this point with older versions of Flex, such as the one on the 32-bit OS X buildbot. Change-Id: I9aec1a16e9f2e1bbcfaac3dffdabdd89af5815e3 Reviewed-on: https://code.wireshark.org/review/12443 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Fix for bug 11856:Andreas Urke1-1/+1
Correct parameter-name "opt-offset" to "offset" in macro "tvb_eui64_to_str" in epan/to_str.h such that offset is taken into account when converting eui64 to str. Bug: 11856 Change-Id: Id0b17c4b9186b4c41d6fe338ba7c017e88f63acf Reviewed-on: https://code.wireshark.org/review/12441 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-05Add missing table entry.Michael Tüxen1-0/+1
Add a missing table entry for Stream Reset Response parameters. Change-Id: I45172cace57cd3f628a94fd61c4cb37a6c2e17ed Reviewed-on: https://code.wireshark.org/review/12439 Reviewed-by: Michael Tüxen Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05RTPS: Minor improvementsJuanjo Martin1-49/+53
1) Fixed the guidPrefix deserialization (before it was showing counter and it should be instanceId). 2) The PID_PARTICIPANT_GUID was a total mess. Now it looks perfect. 3) Fixed some bounds in the proto_tree creations so instead of selecting the rest of the tvb, now they select what they have to. Did all of this keeping the dissection for version 1 untouched. Change-Id: I93df2a29e292655ceb3f8c1395f31d8e38106dee Reviewed-on: https://code.wireshark.org/review/12406 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05Build Flex-generated files with "warnings are errors".Guy Harris5-69/+34
We shouldn't be getting warnings at this point. Change-Id: I363a48546cb8d916425f42962ae1697d52ed9a29 Reviewed-on: https://code.wireshark.org/review/12436 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05packetbb: fix the display of IPv4 addressesLotte Steenbrink1-1/+2
IPv4 Addresses are currently displayed incorrectly in RFC5444 Addressblocks. For example, what should be `Address: 10.1.3.0` is incorrectly rendered as Address: 0.0.0.10 This commit fixes that. Bug: 11852 Change-Id: Id6dc954e9a06e79375058f6070fe8e0f64167d64 Reviewed-on: https://code.wireshark.org/review/12429 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05BGP: fix some issueMatt Texier1-5/+22
Fixing ESI Label extended community Fixing PMSI label field decoding on 20 bits Fixing inclusive multicast Ethernet tag route Fixing Ethernet segment route Bug: 11650 Change-Id: Ifadcc3099f681a5c9480d1ccdd50b29ef4c0069f Reviewed-on: https://code.wireshark.org/review/12430 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05ECMP: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-21/+18
Change-Id: Idd57cba39e82a2538bd8a8ceb2263ec23202c25a Reviewed-on: https://code.wireshark.org/review/12424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05Enhancements for EtherNet/IP and CIPD. Ulis3-62/+162
EtherNet/IP 1. EtherNet Link object parsed Physical Address attribute response incorrectly. 2. Display Unknown Commands as ENIP instead of just TCP data. CIP 1. For connected data, don't interpret it as a Message Router Request/Response format when the Forward Open connection was not directed to the Message Router. Previously, this data would be incorrectly shown as explicit CIP data. In many cases, this would show as malformed. This traffic will now just display as Data in the Wireshark tree, and "Implicit Data - Class (0x123)" in the Info column. Make this data filterable by "cip.conn_path_class == 0x123". 2. Fix parsing of Unconnected Send responses. Previously, for most cases, the response was not fully parsed, and would just show "Data", or it would parse the response as if the request class was the Connection Manager, which is incorrect. Now, also show the request path of the original embedded message in the tree. 3. Add some detailed error data for malformed Forward Close response. Change-Id: I1c98ce516373d8c0ed6e049e25342f726bc370ea Reviewed-on: https://code.wireshark.org/review/12339 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: D. Ulis <daulis0@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05ECMP: fix indentAlexis La Goutte1-185/+189
Change-Id: I80e664185a34feaebc05fc089c405e658e3b1e60 Reviewed-on: https://code.wireshark.org/review/12423 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-05Remove a remnant of the old removed support for Python dissectors.Guy Harris1-1/+1
Change-Id: Ib5dcfc3b6ed08310b5aa8ddc3e08a0951f24bbb4 Reviewed-on: https://code.wireshark.org/review/12434 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-05Use noyywrap rather than defining our own yywrap functions.Guy Harris6-59/+30
Tweak lemonflex-tail.inc to fix an issue this reveals. It appears that, at least on the buildbots, the Visual Studio compiler no longer issues warnings for the code generated with %option noyywrap. Change-Id: Id64d56f1ae8a79d0336488a4a50518da1f511497 Reviewed-on: https://code.wireshark.org/review/12433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-04Export prefs_register_module() and prefs_register_subtree() functionsPascal Quantin1-2/+2
Change-Id: I09796eadb5fb8b564adfab5060715571983b1bb3 Reviewed-on: https://code.wireshark.org/review/12428 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-04[packet-h] Add defines to make it possible to convert functions prefixedAndersBroman1-3/+6
with new_ to plain function names without changing all at the same time. Change-Id: I52682996704ff2472c9830bb62fda2a3cbef6589 Reviewed-on: https://code.wireshark.org/review/12401 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-04Adds wmem_list_find functionMatthieu Coudron2-0/+20
Change-Id: I72162210b830a57978e108032d75d8c54f17d16b Reviewed-on: https://code.wireshark.org/review/12387 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-03Make the gauntlet a bit clearer.Guy Harris1-3/+2
if(is a fixed-length TDS type) { XXX } else if(is a variable-length TDS type) { XXX } Change-Id: Icaa8047ad76abe8b955fb5a025a057ddf8757b1f Reviewed-on: https://code.wireshark.org/review/12415 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03TDS: Sanity check number of columns to prevent crash.Michael Mann1-0/+4
Bug: 11846 Change-Id: I6eac46dc397263fe005e803730c5d3084bfb7f74 Reviewed-on: https://code.wireshark.org/review/12391 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Fix address hashing broken in g4f39c60Evan Huus6-24/+24
We actually have to *use* the return value of the method, which the macro did for us. Change-Id: I240ca7e526a18054fe39c6c4ded902998dc2fef0 Reviewed-on: https://code.wireshark.org/review/12389 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-12-02L2TP: define the Cisco ACK control messageNicolas S. Dade1-2/+9
This is a common packet when sniffing Cisco routers performing L2TP with their proprietary AVPs. Change-Id: I8093f7e3ceb39c9af5b6292289c55f705b53dffb Reviewed-on: https://code.wireshark.org/review/12368 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-02OSTIP: fix typo found by PVS Studio (V519)Alexis La Goutte1-1/+1
The 'pinfo->clnp_dstref' variable is assigned values twice successively Change-Id: I02b8ae54728f88c2173b4522d436bd2f7b1b7bc0 Reviewed-on: https://code.wireshark.org/review/12365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02L2TP: fix typo: s/zero length bit/zero length body/Nicolas S. Dade1-4/+4
A "ZLB" message is a Zero Length Body message. See RFC 3931 Change-Id: I89d8f2328754e236f0704f851831fd8274f3b99e Reviewed-on: https://code.wireshark.org/review/12366 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02L2TP: show unsigned value of control connection idNicolas S. Dade1-1/+1
Everywhere else in the l2tp packet tree we show the control connection ID as an unsigned decimal. Change-Id: I189b9ce8c56b024a249d18fc62641c2f5283b0c1 Reviewed-on: https://code.wireshark.org/review/12367 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02[SUA] Change the dissector table sua.prop.tags to use ↵AndersBroman1-1/+1
DISSECTOR_TABLE_ALLOW_DUPLICATE Change-Id: Iaabd69e5779534c1cf73b2c1ab1b957bb30c44d3 Reviewed-on: https://code.wireshark.org/review/12373 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02PCP: Use GLib 2.32 < supported hash functionsRyan Doyle1-1/+1
GLib 2.32 is required for use of g_hash_table_contains function Change-Id: Ia2af2868ab1029d392d921d915b8898fb5ec81a4 Reviewed-on: https://code.wireshark.org/review/12361 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02PCP: Implement PMID to name mappingRyan Doyle1-22/+196
Tracks the interation between PMNS_NAMES and PMNS_IDS packets to build up a mapping from PMID to a text name and displays the name whenever the PMID is displayed. Change-Id: I665b293c32fee95b649fe6a6e26989db1eff38e0 Reviewed-on: https://code.wireshark.org/review/12303 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02btatt - make size 32-bit in get_value()Michael Mann1-2/+2
Bug: 11817 Change-Id: I118ff55f9a709167976a2522114d65ec03fc68c5 Reviewed-on: https://code.wireshark.org/review/12353 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02Only check for the last nibble being 0x0f.Guy Harris1-1/+8
That's what my_dgt_tbcd_unpack() did; do the same thing here. Change-Id: Ia68c6ba652c748bd2661fd6eda736e880f414dc5 Reviewed-on: https://code.wireshark.org/review/12359 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02Add a separate expert info for "not a valid digit".Guy Harris1-11/+5
That should be used in for errors in the BCD strings where only 0 through 9 ar valid. Fix comments to reflect that the two checks for '?' in the output of tvb_bcd_dig_to_wmem_packet_str() are doing different checks - one is checking for end-of-string padding, the other is checking for anything that's not a digit. Change-Id: I615587b34883ed5bfdc57827451c6e00e213fa5f Reviewed-on: https://code.wireshark.org/review/12358 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02"#if 0" out unused variables.Guy Harris1-0/+4
Change-Id: If6663c18a809b13faa14744c3b0ee625ef03ea03 Reviewed-on: https://code.wireshark.org/review/12357 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02Fix field long name.Guy Harris1-2/+12
(Copy-and-pasteo.) Add some comments while we're at it. Change-Id: If03a43203a2ee7fad54b76cbdaf9318768edc1b0 Reviewed-on: https://code.wireshark.org/review/12354 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-02eCMP Dissector - Extensible Control & Management ProtocolJames Lynch3-0/+3593
Developed by Emerson Industrial Automation (Control Techniques Division) eCMP is a protocol for setting up and controlling the devices in a factory automation system. eCMP has about 30 commands; most are embedded into TCP/IP messages, but cyclic data messages use the UDP protocol. Bug: 10562 Change-Id: I9a421f39dfbdbc9e28d8f7cba72c22e270064641 Reviewed-on: https://code.wireshark.org/review/3157 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-02[NBAP] Fix SIGSEGV in dissect_nbap_MACdPDU_SizeMichael Mann1-30/+31
Bug: 11815 Change-Id: I107cf90df87bdafa23bd4b81acbc25d98773b223 Reviewed-on: https://code.wireshark.org/review/12347 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-01[IPMI] packet-scope isn't valid for use in BASE_CUSTOM functions.Michael Mann1-1/+3
Bug: 11831 Change-Id: Ic4b963bf5a790c2f57b26a15f6226924f742fa55 Reviewed-on: https://code.wireshark.org/review/12340 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-01autotools: Fix g212f2f1João Valverde1-1/+1
Change-Id: If7185885faea2319fdce4d89a7a9bf40312bcfa6 Reviewed-on: https://code.wireshark.org/review/12346 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-01Bugfixes for EtherNet/IP and CIPD. Ulis4-31/+39
EtherNet/IP 1. Only decode 32-bit header if there is enough data. Previously, this would show malformed data, even for I/O packets that have no data, eg: heartbeat data. 2. Typos CIP 1. Many Time Sync attribute responses were flagged incorrectly as malformed. 2. Create service response highlighted the instance number incorrectly, and showed warnings. 3. Set Attribute List Request should exit early if it doesn't know about a particular attribute. 4. Incorrect format for Safety Network Segment: Router Format. 5. Typos Change-Id: I506dbb053c247bc8efcbde2cce6ab24d9550c897 Reviewed-on: https://code.wireshark.org/review/12321 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01stats_tree: re-indent else for avoid warning found by PVS Studio (V705)Alexis La Goutte1-7/+9
It is possible that 'else' block was forgotten or commented out, thus altering the program's operation logics Change-Id: Ie246592282bd0791021159f90b4b8aeb92cff86f Reviewed-on: https://code.wireshark.org/review/12333 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01Removed some remaining svn Id tagsStig Bjørlykke4-10/+3
Change-Id: I7ffbf59099132cde55995bde991d1c6a5dd224b0 Reviewed-on: https://code.wireshark.org/review/12330 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-01Art-Net: Fix ArtAddress dissectionRyan Mullen1-4/+111
Parse and display NetSwitch and SubSwitch fields, treating 0x00 and 0x7f as "special" values with meaning beyond what is usually offered by these fields. Change-Id: Idf94361793441f5f4b32c23e7f7f9250ed952a37 Reviewed-on: https://code.wireshark.org/review/12279 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01[NBAP] Prevent crash.Michael Mann1-32/+33
If no previous conversation exists, a memcpy will try to copy from NULL destination. Bug: 11835 Change-Id: I445480bb425834c5a918f1ffa148cb83d6c9750c Reviewed-on: https://code.wireshark.org/review/12326 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01[S7COMM] Prevent divide by zero.Michael Mann1-5/+7
Bug: 11823 Change-Id: I4437efb3dc9532e3d29aacd36736d6f7b3ed38a2 Reviewed-on: https://code.wireshark.org/review/12322 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-01autotools: Clean abi-check with maintainer-cleanJoão Valverde1-1/+8
Change-Id: Ia2ce54592485d2995bcfd56bd127a2fedb1a7d07 Reviewed-on: https://code.wireshark.org/review/12293 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-30mausb: The '&' operator is applied to bool type value found by PVS Studio (V564)Alexis La Goutte1-2/+2
You've probably forgotten to include parentheses or intended to use the '&&' operator Change-Id: Ie9c79729f2ec67aa9579dca40b2e904a9047218f Reviewed-on: https://code.wireshark.org/review/12313 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-30mausb: Fix A part of conditional expression is always true found by PVS ↵Alexis La Goutte1-1/+1
Studio (V560) !del is always true (else if before) Change-Id: I21e335eb3035ec17e990076a4895006d3138f16b Reviewed-on: https://code.wireshark.org/review/12312 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 01:56:19 +0000