aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2017-01-12uat: add a reset callback.Dario Lombardo49-33/+128
This function will free the resources allocated by the caller. Change-Id: Ib486c14e4fd3c321662fb71f7fd06733ce9a64a4 Reviewed-on: https://code.wireshark.org/review/19375 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-12X2AP: upgrade dissector to v13.6.0Pascal Quantin9-95/+189
Change-Id: Ie312d354cadadba693ea5320c5bbc0957bde6514 Reviewed-on: https://code.wireshark.org/review/19613 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-11S1AP: upgrade dissector to v13.5.0Pascal Quantin10-104/+112
Change-Id: Ic65ae88af37f0e82207c093827755f93934d9424 Reviewed-on: https://code.wireshark.org/review/19612 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-11packet-btatt.c: Use protocol information from dissector handle instead of ↵Michael Mann1-1/+37
pinfo data for attributes. Instead of using a dissector function placed in a dissector table, just use the protocol information registered with the dissector table to create the desired dissector tree. Change-Id: Ic32b15e3c05d73df6e8f69890c47172e991bda6f Reviewed-on: https://code.wireshark.org/review/19509 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-11OpenFlow (v4/1.3): rename dissect_openflow_payload_v4 to ↵Alexis La Goutte1-13/+16
dissect_openflow_message_v4 Like OpenFlow (v5/1.4) dissector and include dissect_openflow_header_v4 Ping-Bug: 13221 Change-Id: I123fad871bcb1c9d54946500505525d55a81f8f3 Reviewed-on: https://code.wireshark.org/review/19602 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-11iso14443: use proto_tree_add_checksum()Martin Kaiser1-50/+76
replace our own function for dissecting the CRC with the generic proto_tree_add_checksum() Change-Id: I569c877836a7b771b01a37b57b6c50fc0183e9a7 Reviewed-on: https://code.wireshark.org/review/19601 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-10Use tvb_new_subset_remaining() rather than tvb_new_subset_length_caplen().Guy Harris4-25/+25
Any call of the form tvb_new_subset_length_caplen(tvb, offset, -1, -1) should instead be tvb_new_subset_remaining(tvb, offset). Change-Id: I4bc95b028103ea4fc82453ef3460c147d7ccabd6 Reviewed-on: https://code.wireshark.org/review/19598 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-10Rename tvb_new_subset() to tvb_new_subset_length_caplen().Guy Harris164-453/+453
This emphasizes that there is no such thing as *the* routine to construct a subset tvbuff; you need to choose one of tvb_new_subset_remaining() (if you want a new tvbuff that contains everything past a certain point in an existing tvbuff), tvb_new_subset_length() (if you want a subset that contains everything past a certain point, for some number of bytes, in an existing tvbuff), and tvb_new_subset_length_caplen() (for all other cases). Many of the calls to tvb_new_subset_length_caplen() should really be calling one of the other routines; that's the next step. (This also makes it easier to find the calls that need fixing.) Change-Id: Ieb3d676d8cda535451c119487d7cd3b559221f2b Reviewed-on: https://code.wireshark.org/review/19597 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-10ieee80211: Add Extreme (Zebra) Vendor Specific TLVAlexis La Goutte3-0/+81
Only decode subtype 1 : AP Name with unknown data (7 bytes) Change-Id: I4fc0c6fff1a931075ab333a8527251f12acb2827 Reviewed-on: https://code.wireshark.org/review/19586 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-09Consistently use tvb_reported_length_remaining().Guy Harris1-10/+10
That's the amount of data left in the packet; perhaps not all of it was *captured*, and using tvb_reported_length_remaining() will throw an exception, but that's what *should* happen ("packet cut short" notification and all). Use tvb_new_subset_remaining() to get a tvbuff with everything after a certain point in the packet. Change-Id: I2512e58e23600f7e7bbce0126732b05997692a65 Reviewed-on: https://code.wireshark.org/review/19596 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-09Use tvb_new_subset_length(); no need to do its work ourselves.Guy Harris1-5/+1
Change-Id: I581e14af2981c723a81e9c0340de0229b832e51a Reviewed-on: https://code.wireshark.org/review/19595 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-09Restore FCoIB frame marker handling (CID 1397701)Jaap Keuter1-2/+8
It seems that somewhere in the last few years the changes for FCoIB have caused it to loose its frame marker processing. This change puts that back. Also there is an ambiguity in EOF handling, which is solved. Change-Id: Iefbb42726e4e5491a50d7ce96626c906fb5ea857 Reviewed-on: https://code.wireshark.org/review/19594 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-01-09802.11(ad): Add reserved field of Grant ACK frameAlexis La Goutte1-1/+8
Change-Id: I0bb982403fb7f36ad166234b16dbe8ad9b8b8eb8 Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19592 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-09802.11(ad): Remove comment about clang warning and set directly the valueAlexis La Goutte1-5/+5
Change-Id: Ie64608597c7d6a5b9a2fec9de8e8983233e0e10e Reviewed-on: https://code.wireshark.org/review/19591 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-09802.11(ad): Fix SSW Feedback dissection when Sector Sweep Direction = ResponderAlexis La Goutte1-1/+9
For the Sector Sweep Frame in which the Sector Sweep Direction = Responder, the format of the Sector Sweep Feedback Field should be the one in the standard (Figure 8-431d—SSW Feedback field format when not transmitted as part of an ISS) i.e. similar to the one in Sector Sweep Feedback Frame and Acknowledgement. Issue reported by Hany ASSASA bug: 13244 Change-Id: Ic8c6d83fc32d017fb73116a54759608498f99452 Reviewed-on: https://code.wireshark.org/review/19590 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-09802.11(ad) fix typo : ambiguous assignment (CID 1398212)Alexis La Goutte1-1/+0
Introducte in g62a54cb77 Ping-Bug: 13244 Bug: 13309 Change-Id: I2e3411cfd38685c08fd669fad1313663ba879936 Reviewed-on: https://code.wireshark.org/review/19589 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-09TLS(1.3): update PSK extension for draft -18Peter Wu2-87/+66
Removed ke_modes and auth_modes fields, add identity.obfuscated_ticket_age and binders fields. (Note that binders field is not dissected further at this moment due to the lack of a pcap for verification.) Ping-Bug: 12779 Change-Id: I9af7d93feb2352a494be2d5bda66d124267cf464 Reviewed-on: https://code.wireshark.org/review/19462 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-08[Automatic update for 2017-01-08]Gerald Combs2-24/+189
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I91668647c50e78b29bbb28f2348dc8e52c3a66c5 Reviewed-on: https://code.wireshark.org/review/19585 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-08Restore some MPLS registered dissectors.Michael Mann8-27/+26
Per https://ask.wireshark.org/questions/58532/missing-dissector-pw_eth_cw it appears some MPLS dissectors are still referenced by name and not just for the dissector table created in I1e0c3ae784b71c0145b1f1730a97feae8e9f488f. Change-Id: I27be132f56c879be16f78f76ac0e9688673a47c1 Reviewed-on: https://code.wireshark.org/review/19582 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-08Comments on the first nibble stuff.Guy Harris1-3/+42
If you don't have control words - and several MPLS pseudo-wire RFCs say "in these cases, a control word isn't necessary, and isn't useful, so you might want to leave it out" - the first nibble values of 0, 1, 4, and 6 could just be part of the packet header. Explain some other stuff as well. Change-Id: I2f1aae2ab8653bdd7f8b3b52ef450f6d43a1afcd Reviewed-on: https://code.wireshark.org/review/19583 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-07Add MUD-URL manufacturer usage description certificate extension.Eliot Lear10-0/+396
See draft-ietf-opsawg-mud for details. File changes include addition of new asn1 directory and associated files, as well as edits to various other files to support the change. Change-Id: Ib910980e1ddcafaa31aa07cf049562520b61a3aa Reviewed-on: https://code.wireshark.org/review/19505 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-07Refactor range preference.Michael Mann3-2/+413
Refactored so that all handling of ranges in struct preference can be internal to prefs.c Change-Id: I68577909f9c07b23a16ab3443a523355d4645314 Reviewed-on: https://code.wireshark.org/review/19577 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07DVB-S2 BB: Fix BB header CRC checksMustBeArt1-9/+4
Fix problem with baseband header CRC check that caused almost all baseband frames to show a spurious CRC error, introduced with proto_tree_add_checksum. Change-Id: I6b2f9680507eeb79e59b825f3ac9e4cee1033976 Reviewed-on: https://code.wireshark.org/review/19567 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-01-07Make column size sanity check more sensible.Noel Power1-1/+3
The existing sanity check on column_size makes incorrect assumptions about the size of the CTableColumn structure (which is an internal dissector structure that contains optional data). The sanity check test *always* fails. This change uses the minimum size of CTableColumn structure instead which should prevent excessive allocation during fuzz testing. Bug: 13299 Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/19566 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-07Add support for RROCE(v2) over IPv4 (without UDP).Jeff Morriss1-2/+6
This isn't standard but has been seen in the wild, see: https://ask.wireshark.org/questions/58521/cannot-decode-rocev2-traffic With this change users can Decode-As an IP Protocol as RROCE (by selecting Infiniband (IB) as the protocol). Change-Id: Iec865478d056f687f2f66124d6e936f67707d2c4 Reviewed-on: https://code.wireshark.org/review/19572 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-07packet-nvme: Dissect read/write cmd and SGLParav Pandit1-4/+268
1. Added support to dissect read and write commands. 2. Added support to dissect SGL fields addr, len, key. 3. Changed long reserved fields to decimal presentation. 4. Fixed typo for cqe reserved field. Change-Id: I63c674c68143c9c61610bada0410b49a134361d4 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19565 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07packet: fix memleak of "short_name" for heuristics dissectorsPeter Wu1-1/+3
Change-Id: I3b954e3623473899b6039f0ff572eb56defe14cc Fixes: v2.3.0rc0-1841-ga8b68205a4 ("packet: duplicate short_name to fix UAF in wslua") Reviewed-on: https://code.wireshark.org/review/19571 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07Convert range API to always use wmem memory.Michael Mann45-159/+153
This is mostly to address memory leaks in range preferences (the biggest user of range functionality) on shutdown. Now range preferences must use epan scoped memory when referencing internal preference structures to keep consistency. Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157 Reviewed-on: https://code.wireshark.org/review/19387 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): Enhance dissection of Beacon Interval Control (BIC)Alexis La Goutte1-28/+36
You can now use bitmap on 64bits (or 48bits) and also add a reserved field Ping-Bug: 13244 Change-Id: I2ec9412f6cfebd3a8ca5c082af5e8481e2646eaf Reviewed-on: https://code.wireshark.org/review/19561 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-06Convert some easily identifiable pinos.Michael Mann8-25/+25
grepping for "Decode As" comments reveals exactly was pinos were created for - distinguishing multiple dissection functions in a single dissection table. Change-Id: Iaa9294045e9d0633563e7d763cb585c0e6dc598f Reviewed-on: https://code.wireshark.org/review/19490 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06VLAN: Support IEEE 802.1Q-2005 and -2011 changesJohn A. Thacker1-20/+174
Supports the recommended meanings of the priority field as changed by 802.1Q-2005, and the change from the CFI to DEI in 802.1Q-2011. A preference is added to use the older (non-compatible) spec version. Note that 802.1Q-2011 is consistent with 802.1ad and ah, which got rolled up in 802.1Q, but ends up removing support for bridging Token Ring and FDDI over Ethernet. Bug: 13294 Change-Id: Ieeadb0f6dda2758750f9e6649f1390609d78c50e Reviewed-on: https://code.wireshark.org/review/19548 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): add reserved fields for Beam FormingAlexis La Goutte1-0/+14
Change-Id: I486c883b27059eb55e9fe11fcc372fc31c1e56ca Ping-Bug: 13244 Reviewed-on: https://code.wireshark.org/review/19560 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): align length of Beam FormingAlexis La Goutte1-10/+10
use UINT16 Change-Id: I7f7c4e847ed6ccb6ced446d493aa27f76cc8db61 Reviewed-on: https://code.wireshark.org/review/19559 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-06802.11(ad): fix typoAlexis La Goutte1-1/+1
Wrong field name for Dynamic Allocation Issue reported by Hany ASSASA Bug: 13244 Change-Id: Idec2cb48c5b3d22d75880325d2aec0083d89ca95 Reviewed-on: https://code.wireshark.org/review/19558 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-05Update the preference help text to indicate the correct default RROCE port.Jeff Morriss1-2/+2
I97b82fb53fd63d9107ee5d4c64b94840e743fc72 changed the default but not the help text. Change-Id: I05375c44c01703e36686d0a16a094cb8d6b3dcd2 Reviewed-on: https://code.wireshark.org/review/19557 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-05NAS EPS: NAS message container in Control Plane Service Request can be cipheredPascal Quantin1-2/+21
Change-Id: I026fc63e09c54807604c5d5a112c36dd41759c00 Reviewed-on: https://code.wireshark.org/review/19556 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-04QUIC: fix typo on ACK num revived field descriptionAlexis La Goutte1-1/+1
Found in https://ask.wireshark.org/questions/58396/some-question-about-quic-decode-result Change-Id: Ic7fc2c2318186eabb5047f816987d2553a6fd449 Reviewed-on: https://code.wireshark.org/review/19547 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04RTPS: Added dissection for Parametrized user dataJuanjo Martin1-1/+78
Before we were showing an expert warning saying that it was not supported. Now we show the parametrized data dissected in the form sequence of (id, length, value) Added also filters so it is possible to filter on the ids (useful in RTPS) Bug: 13278 Change-Id: I8569830305bc303febe6f3460221e7a52867a34d Reviewed-on: https://code.wireshark.org/review/19458 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04RRC: upgrade dissector to v13.5.0Pascal Quantin7-433/+436
Change-Id: I95323ed8aabff7a20442c848fa0dc39854297584 Reviewed-on: https://code.wireshark.org/review/19527 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04No reason not to use etype_vals for an Ethertype field.Guy Harris1-1/+1
Maybe there was an issue on Windows back in the old days, when 1) we didn't have a shared libwireshark library from which to import functions and data variables and thus you couldn't get variables such as etype_vals in a plugin and 2) the Infiniband dissector was a plugin, but neither of those are the case any more. Change-Id: Id8b82886317bd36a32ad1e1591673623696d4808 Reviewed-on: https://code.wireshark.org/review/19530 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-04Ensure that tcp.reassembled_in is added to the tree for first segment.Martin Mathieson1-1/+12
Bug: 3264 Change-Id: I9fa8cfaf1e21a8a984941ee40e2e404ae21e55c9 Reviewed-on: https://code.wireshark.org/review/19528 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-03infiniband: remove offset variable.Dario Lombardo1-9/+7
Change-Id: Ie86c2aece05ebbc35eb15a54d8c3f2c455ff53cf Reviewed-on: https://code.wireshark.org/review/19516 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-01-03infiniband: fix error for clobbered variable.Dario Lombardo1-1/+1
Given by gcc-4.9.2 on arm: epan/dissectors/packet-infiniband.c:2708:9: error: variable ‘offset’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] int offset = 0; ^ cc1: all warnings being treated as errors Change-Id: I12066031093c1fa638792ff8be8f3f5457e3feda Reviewed-on: https://code.wireshark.org/review/19515 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-03ISAKMP: add Reserved fieldsMirko Parthey1-17/+43
Add Reserved fields as defined by: * RFC 7296 for IKEv2 * RFC 2408 for IKEv1 * draft-ietf-ipsec-isakmp-mode-cfg-05 for the IKEv1 Attributes Payload Change-Id: I0c25de6e543aa5461650fb4cd2c103a6a3a8c392 Reviewed-on: https://code.wireshark.org/review/19480 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-01-02Use g_slist_find_custom instead of g_slist_nth when just looking for item in ↵Michael Mann5-46/+68
list. Change-Id: Ida3c5d5826f0ca01a25052a67f1460ff4686008f Reviewed-on: https://code.wireshark.org/review/19513 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-02ISAKMP: Fix size of ID in IKEv1 Attributes PayloadMirko Parthey1-1/+1
Fix the size of the Identifier field in the IKEv1 Attributes Payload. Reference: draft-ietf-ipsec-isakmp-mode-cfg-05, section 3.2 Change-Id: I30bfde9caa6750b342f7dfbad39e63341614a45b Reviewed-on: https://code.wireshark.org/review/19502 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-01-02ISAKMP: fix dissection of IKEv2 ID PayloadMirko Parthey1-16/+22
Fix dissection of the IKEv2 Identification Payload. Unlike IKEv1, it does not have Protocol and Port fields. References: * RFC 2407, section 4.6.2 * RFC 7296, section 3.5 Change-Id: I968e378abd49363785dd7308a4f27908c1c05a8a Reviewed-on: https://code.wireshark.org/review/19497 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-01-01Snort: without explicit disable, expand preference to switch offMartin Mathieson2-10/+16
Change-Id: I5fd3b0cc6f19c4c873aaaae8c9e257a8b53a8419 Reviewed-on: https://code.wireshark.org/review/19489 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-01-01[Automatic update for 2017-01-01]Gerald Combs2-13/+158
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I397e20ffbc5227cb22d838c9eec68fae0e216162 Reviewed-on: https://code.wireshark.org/review/19492 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-01OpenFlow (v4/1.3): Add complete dissection of error messagesAlexis La Goutte1-24/+52
Bug: 13221 Change-Id: Ide3e734fca280a294a993afade2503cd751d78a2 Reviewed-on: https://code.wireshark.org/review/19459 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>