aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2024-02-27prefs: Fix null defererences, remove obsolete functionHEADmasterJohn Thacker1-13/+10
Null dereference check to fix Coverity CIDs 1399640 and 1399641. Remove a function that has been unused for a decade.
2024-02-27MEGACO: Remove some long obsolete codeJohn Thacker1-38/+2
Remove some long obsolete code that dates back to before the binary H.248 protocol was separated into an ASN.1 dissector
2024-02-27MEGACO: Dissect statisticsDescriptor inside mediaDescriptorJohn Thacker1-0/+12
Versions 2 and 3 of MEGACO (H.248 text) added statisticsDescriptor to one of the options for a streamParm that can appear inside a mediaDescriptor. Dissect it. Part of #11080
2024-02-27gsup: Add PCO IEPau Espin Pedrol1-0/+20
This IE is present in the ePDG Tunnel Request/Result messages to forward protocol configs between the UE (IKEv2) and the PGW (GTPv2C), with ePDG in the middle. https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36023 https://gerrit.osmocom.org/c/libosmocore/+/36024
2024-02-27gsup: Add ePDG Tunnel Request/Error/Result messagesPau Espin Pedrol1-0/+7
These messages are used in the GSUP-based CEAI interface between strongswan IPsec and osmo-epdg, which acts basically as a forwarding protocol between IKEv2 on the UE side and GTPv2C S2b towards PGW + Diameter SWm towards AAA Server. Those fields are already present in libosmocore, GSUP reference implementation [1]. [1] https://gitea.osmocom.org/osmocom/libosmocore/src/branch/master/include/osmocom/gsm/gsup.h#L205
2024-02-27ENRP: Check for invalid parameter & error cause lengthsJohn Thacker1-1/+15
The value in the length field in ENRP parameters and error causes include the length and types, and must be at least 4. In particular, not erring on zero can cause an infinite loop. https://datatracker.ietf.org/doc/html/rfc5354 Fix #19674
2024-02-27Wifi(NAN): Minor fix for NAN dissectorJie Han1-24/+64
Fix typos and bugs in NAN dissector. Separate NDP and NDPE control field
2024-02-27ptp: Improve display of rateRatio allowing more decimals.Patrik Thunström1-1/+1
2024-02-27Protobuf: Add a UAT table to map URI -> message_typeMartin Mathieson4-7/+109
2024-02-27Update existing NAN attributes to NAN R4Jie Han1-45/+275
NAN Availability Attribute, Device Capability Attribute, Cipher Suite Info Attribute.
2024-02-27Remove PREF_DECODE_AS_UINTJohn Thacker2-106/+8
PREF_DECODE_AS_UINT has been unused since all auto port preferences were made ranges by 8604d03a98607bf8dc62e3ee152f8c8289c4052b Remove it. Ping #14319
2024-02-27Thrift: Align the endianness for doubleTriton Circonflexe1-1/+16
Compact protocol uses little endian doubles instead of big endian like compact. This issue is documented as an accident that became the de-facto standard. For consistency, the sub-tvbuff_t given to delegated sub-dissectors is aligned with binary protocol to allow a sub-dissector to work with both binary and compact.
2024-02-27Thrift: Fix recursion checkTriton Circonflexe1-16/+91
Previous recursion check only worked with generic dissector. The introduced changes cover the sub-dissectors as well. Remove the existing check as it counted basic types as well. Add a check at every place where a sub-tree is created: - containers (list, set, map) - structures
2024-02-26GSSAPI: Avoid dissecting checksum in signed-only KRB_TOKEN_CFX_WRAPJohn Thacker6-74/+103
In KRB_TOKEN_CFX_WRAP (RFC 4121), for signed-only Wrap tokens ("Wrap tokens without confidentiality"), the plaintext is followed by the checksum, unlike in other implementations where the all the GSSAPI bits, including the checksum, precede the plaintext. For those cases, the calling dissector cannot simply dissect the entire original tvb after the returned offset, as it's not all plaintext. Instead, place the plaintext without checksum subset in gssapi_decrypted_tvb and return it to the caller. In these cases, gssapi_data_encrypted will be set to FALSE, to allow dissectors that wish to distinguished signed-and-sealed from signed-only. For dissectors that do not care to distinguish the cases, this requires no change. Update the documentation in the GSSAPI header to describe this. Fix #9398.
2024-02-26hipercontracer: don't consume LDAP/SASL/KRB_TOKEN_CFX_WRAP messagesStefan Metzmacher1-1/+28
See the capture in #9398 for an example. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2024-02-26asterix: adjust to upstream changeZoran Bošnjak1-9/+9
Structure change in asterix-specs, revision 3ab3bb3. Rule type is generalized and it now also includes a default value.
2024-02-25Fix lots of spellingsMartin Mathieson162-264/+264
2024-02-25[Automatic update for 2024-02-25]Gerald Combs3-221/+282
Update manuf, services enterprise numbers, translations, and other items.
2024-02-25CSV Export: Last column no longer exported when hidden.Patrik Thunström1-8/+22
Prior to fix the last column no matter if hidden or not was always included when exporting packet dissections to CSV. Fixes #19666.
2024-02-24Qt: Only set Packet List style sheet when relevant prefs changeJohn Thacker2-1/+8
Add a colorsChanged signal/slot, more precise than the generic preferencesChanged signal, and only call it when one of the color related preferences have changed. Connect it to the packetList::colorsChanged() function, instead of calling that whenever preferencesChanged() is called. We could eventually move the signals and slots some of the other GUI widgets to this. Send that signal before handling preferences that change dissection and freeze the packet list, so that when we restore the column widths due to Qt bug 122109 it takes effect. The packet_list_hover_style preference affects colors, not the layout, despite its presence in the GUI layout module.
2024-02-24Qt: If no preferences have changed, don't signalJohn Thacker1-0/+6
Enforce the requirement, already mentioned in the headers, that preference and preference module effect flags must be nonzero so that the application knows that a preference has changed. (Lua, for example, needs this.) Use this and avoid sending the PreferencesChanged signal when preferences have not changed.
2024-02-23thrift: make some functions staticMartin Mathieson1-7/+7
2024-02-23RNSAP: Dissect IMSIJohn Thacker3-1/+22
2024-02-23SCCP: Use register_dissector_preferenceJohn Thacker1-2/+2
Switch SCCP's default payload preference from a string to validated dissector name preference, added in 2f1392169a2230d53b8e
2024-02-23dfilter: Add functions to override field baseJohn Thacker1-0/+94
Add field expression functions to convert unsigned integer and char fields to hex or decimal. (BASE_OCT is handled somewhat different currently now, presumably because it can't be used in filters, so leave that commented until it is handled as a display representation.) Currently string() always converts unsigned integers to their decimal representation so it is the same as dec(), but possibly in the future string() might use the native base. These can be used in columns thanks to the fix for #15990 Fix #5308
2024-02-23Look into some items where VALS doesn't fit in maskMartin Mathieson3-4/+6
2024-02-23DNSCrypt: Add support to parse DNSCrypt Initial DNS requesthidd3ncod3s Sec1-1/+117
2024-02-23extcap: Use extcap.cfg as extcap config file nameJohn Thacker2-3/+5
"extcap" by itself can be the name of a directory that stores extcap programs, especially if the default profile is being used. Add an extension to the default file name so it doesn't clash. Follow up to 4fb2ef8af871682905b29cc1f3dbbfaba41c9e38
2024-02-23ICMPv6: Add a recursion checkGerald Combs1-0/+9
Fix ``` wireshark/epan/dissectors/packet-icmpv6.c:1709:1: warning: function 'dissect_icmpv6_nd_opt' is within a recursive call chain [misc-no-recursion] 1709 | dissect_icmpv6_nd_opt(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree) | ^ wireshark/epan/dissectors/packet-icmpv6.c:1709:1: note: example recursive call chain, starting from function 'dissect_icmpv6_nd_opt' wireshark/epan/dissectors/packet-icmpv6.c:2247:30: note: Frame #1: function 'dissect_icmpv6_nd_opt' calls function 'dissect_icmpv6_nd_opt' here: 2247 | opt_offset = dissect_icmpv6_nd_opt(tvb, opt_offset, pinfo, icmp6opt_tree); | ^ wireshark/epan/dissectors/packet-icmpv6.c:2247:30: note: ... which was the starting point of the recursive call chain; there may be other cycles ```
2024-02-23DHCPv6: Add a recursion checkGerald Combs1-1/+12
Fix ``` wireshark/epan/dissectors/packet-dhcpv6.c:1846:1: warning: function 'dhcpv6_option' is within a recursive call chain [misc-no-recursion] 1846 | dhcpv6_option(tvbuff_t *tvb, packet_info *pinfo, proto_tree *bp_tree, | ^ wireshark/epan/dissectors/packet-dhcpv6.c:1846:1: note: example recursive call chain, starting from function 'dhcpv6_option' wireshark/epan/dissectors/packet-dhcpv6.c:2052:28: note: Frame #1: function 'dhcpv6_option' calls function 'dhcpv6_option' here: 2052 | temp_optlen += dhcpv6_option(tvb, pinfo, subtree, | ^ wireshark/epan/dissectors/packet-dhcpv6.c:2052:28: note: ... which was the starting point of the recursive call chain; there may be other cycles wireshark/epan/dissectors/packet-dhcpv6.c:2958:1: warning: function 'dissect_dhcpv6' is within a recursive call chain [misc-no-recursion] 2958 | dissect_dhcpv6(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, | ^ ```
2024-02-22SMB2: Add recursion checksGerald Combs1-1/+26
2024-02-23cose: Peek ahead for map principal value before dissecting map itemsBrian Sipos3-48/+96
This change updates references to obsoleted RFCs and I-Ds, provides human-readable interpretation of kid values, and fixes the text encoding type in proto_tree_add_cbor_tstr(). Fixes #19659
2024-02-22ptp: Corrected data type for cumulativeScaledRateOffset.Patrik Thunström1-5/+22
Aligning the data type with the 802.1AS specs the data type is now INT32 instead of UINT32. Also added a generated field where the scale and offset is removed to easier interpret the actual accumulated rate ratio.
2024-02-22Fix some spelling errorsMartin Mathieson10-41/+40
2024-02-22QUIC: Handle early 1-RTT data from serverJohn Thacker1-20/+54
For our test in check_dcid_on_coalesced_packet, check the *last* QUIC packet in the frame so far, not the first packet in the frame. Only create the quic_packet structure after checking for a coalesced packet, so that the last QUIC packet in the frame is the previous one, not the current one. What happens if 0-RTT packets are lost and resent? There's an alternative suggestion featuring checking if the ciphers are initialized on the first pass that might work too, but if we did that, what happens if the server Handshake is fragmented, reassembled, and the server sent some "0.5-RTT" data after the last fragment but then had to resend a different Handshake fragment later? We'd still get some 1-RTT data before the handshake was done. Fix #19665 while still not upsetting #19503.
2024-02-22OSITP: Pass ED-TPDU to subdissectorsJohn Thacker1-5/+26
Fix #7393
2024-02-22SNMP: Add support for RFC 5343Jaap Keuter2-2/+10
Add identification of the 'local engine' format.
2024-02-22feat(#19647): decode Datum enum and Ver fieldmarmonier_c1-2/+26
Use RFC 6225 (obsoletes RFC 3825)
2024-02-22feat(#19647): decode resolution fieldsmarmonier_c1-17/+69
2024-02-22feat(#19647): check longitude and latitude max valuemarmonier_c1-9/+19
2024-02-22fix(#19647): correction of fractional calculationsmarmonier_c1-33/+175
Altitude dissector added
2024-02-22AllJoyn: Add recursion checksGerald Combs1-6/+33
2024-02-216LoWPAN: Add recursion checksGerald Combs1-0/+15
2024-02-21GTP: Fix filtering of UL/DL itemsJohn Thacker1-5/+9
The uplink and downlink bit rate items, and the maximum SDU size, are contained in a single octet but added to the tree using proto_tree_add_uint_format[_value] after multiplying by various factors, so the values don't actually fit in a FT_UINT8. The fields need to be large enough to fit the largest value added after transformation. The filter engine won't allow filters for values outside the field range, e.g. $ ./run/dftest -s 'gtp.qos_max_sdu_size == 1500' Filter: gtp.qos_max_sdu_size == 1500 Error: "1500" too big for this field, maximum 255. gtp.qos_max_sdu_size == 1500 ^~~~ After: $ ./run/dftest -s 'gtp.qos_max_sdu_size == 1500' Filter: gtp.qos_max_sdu_size == 1500 Syntax tree: 0 TEST_ANY_EQ: 1 FIELD(gtp.qos_max_sdu_size <FT_UINT16>) 1 FVALUE(1500 <FT_UINT16>) Instructions: 0000 READ_TREE gtp.qos_max_sdu_size -> R0 0001 IF_FALSE_GOTO 3 0002 ANY_EQ R0 == 1500 0003 RETURN
2024-02-21LUA: Make it compile with LUA 5.4Anders Broman2-1/+9
2024-02-21LUA bitop: Convery our lua_bitop.c to work with 5.3 and 5.4Anders Broman1-8/+17
The code is written by Andrew Engelbrecht and found here: https://github.com/LuaJIT/LuaJIT/issues/384
2024-02-21TN5250: Add a recursion checkGerald Combs1-0/+8
2024-02-21Add Clang-Tidy suppressions to various dissectorsGerald Combs6-0/+28
Add NOLINTNEXTLINE suppressions for some existing recursion checks.
2024-02-21MONGO: Add a recursion checkGerald Combs1-0/+9
2024-02-21dfilter: Handle 64-bit extended value stringsJohn Thacker2-4/+16
Allow matching against 64-bit extended value strings the same way as other value strings. The IAX2 sample capture on the Wiki is a good test of this. Previously the matches operator would never match, and comparison operators we not allowed. Before: $ ./run/dftest -s 'iax2.voice.codec == "GSM compression"' Filter: iax2.voice.codec == "GSM compression" Error: "GSM compression" cannot be found among the possible values for iax2.voice.codec. iax2.voice.codec == "GSM compression" ^~~~~~~~~~~~~~~~~ After: $ ./run/dftest -s 'iax2.voice.codec == "GSM compression"' Filter: iax2.voice.codec == "GSM compression" Syntax tree: 0 TEST_ANY_EQ: 1 FIELD(iax2.voice.codec <FT_UINT64>) 1 FVALUE(2 <FT_UINT64>) Instructions: 0000 READ_TREE iax2.voice.codec -> R0 0001 IF_FALSE_GOTO 3 0002 ANY_EQ R0 == 2 0003 RETURN
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 14:40:39 +0000