aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2013-12-11- Make local functions static.Anders Broman23-10/+69
- Forward declaration of register functions. svn path=/trunk/; revision=53941
2013-12-11From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9550 :Pascal Quantin1-14/+21
GSM SMS UDH EMS control expects 4 octets instead of 3 with OPTIONAL 4th svn path=/trunk/; revision=53940
2013-12-11Remove _U_ from dissect_openwire_tcp()'s data parameter; technically it is ↵Chris Maynard1-1/+1
used since it is passed to tcp_dissect_pdus(), even though dissect_openwire() doesn't actually use it. svn path=/trunk/; revision=53939
2013-12-11Fix (-W)unused-const-variable error found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=53935
2013-12-11Fix an out of bounds access found by ASAN and reported by Alexis:Pascal Quantin1-1/+1
==21553==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7fffbc0b2a5e at pc 0x7fe8684147a3 bp 0x7fffbc0b2950 sp 0x7fffbc0b2948 READ of size 2 at 0x7fffbc0b2a5e thread T0 #0 0x7fe8684147a2 in dissect_schedule_message /home/alagoutte/wireshark-clang/epan/dissectors/packet-gsm_cbch.c:309 #1 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #2 0x7fe867eda42c in call_dissector_only /home/alagoutte/wireshark-clang/epan/packet.c:2139 #3 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #4 0x7fe867ed735b in dissector_try_uint_new /home/alagoutte/wireshark-clang/epan/packet.c:1030 #5 0x7fe868a3ebd4 in decode_udp_ports /home/alagoutte/wireshark-clang/epan/dissectors/packet-udp.c:411 #6 0x7fe868a41886 in dissect /home/alagoutte/wireshark-clang/epan/dissectors/packet-udp.c:747 #7 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #8 0x7fe867ed6d03 in dissector_try_uint_new /home/alagoutte/wireshark-clang/epan/packet.c:1030 #9 0x7fe8684eaa1f in dissect_ip /home/alagoutte/wireshark-clang/epan/dissectors/packet-ip.c:2401 #10 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #11 0x7fe867ed735b in dissector_try_uint_new /home/alagoutte/wireshark-clang/epan/packet.c:1030 #12 0x7fe868333e98 in dissect_ethertype /home/alagoutte/wireshark-clang/epan/dissectors/packet-ethertype.c:305 #13 0x7fe867ed707d in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:508 #14 0x7fe867eda42c in call_dissector_only /home/alagoutte/wireshark-clang/epan/packet.c:2139 #15 0x7fe8683328ad in dissect_eth_common /home/alagoutte/wireshark-clang/epan/dissectors/packet-eth.c:472 #16 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #17 0x7fe867ed735b in dissector_try_uint_new /home/alagoutte/wireshark-clang/epan/packet.c:1030 #18 0x7fe868382460 in dissect_frame /home/alagoutte/wireshark-clang/epan/dissectors/packet-frame.c:485 #19 0x7fe867ed70a9 in call_dissector_through_handle /home/alagoutte/wireshark-clang/epan/packet.c:512 #20 0x7fe867eda42c in call_dissector_only /home/alagoutte/wireshark-clang/epan/packet.c:2139 #21 0x7fe867ed5baf in call_dissector /home/alagoutte/wireshark-clang/epan/packet.c:2169 #22 0x7fe867eb6388 in epan_dissect_run_with_taps /home/alagoutte/wireshark-clang/epan/epan.c:329 #23 0x4a0ef9 in process_packet /home/alagoutte/wireshark-clang/tshark.c:3434 #24 0x49c985 in load_cap_file /home/alagoutte/wireshark-clang/tshark.c:3237 #25 0x7fe860e8ede4 in __libc_start_main /build/buildd/eglibc-2.17/csu/libc-start.c:260 #26 0x48586c in _start ??:? Address 0x7fffbc0b2a5e is located in stack of thread T0 at offset 126 in frame #0 0x7fe86841353f in dissect_cbch /home/alagoutte/wireshark-clang/epan/dissectors/packet-gsm_cbch.c:345 This frame has 2 object(s): [32, 80) 'new_slots.i' [128, 224) 'other_slots.i' <== Memory access at offset 126 underflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow ??:0 ?? svn path=/trunk/; revision=53934
2013-12-11Remove an unused variableMartin Mathieson1-2/+0
svn path=/trunk/; revision=53933
2013-12-11Convert to new-style dissector, change crcStatusValid to a gboolean, and ↵Martin Mathieson2-111/+141
rework DRX timers (again) svn path=/trunk/; revision=53932
2013-12-11#if 0 unused function.Anders Broman1-2/+2
svn path=/trunk/; revision=53931
2013-12-11- Forward declaration of register functions.Anders Broman14-14/+28
svn path=/trunk/; revision=53930
2013-12-10Pass the correct uuid when recursing (the other one is a temporary var that mayEvan Huus1-1/+1
not be initialized). Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9535 svn path=/trunk/; revision=53929
2013-12-10use large positve values for illegal DVB-SI string encodingsMartin Kaiser3-11/+12
interpret encoding fields as UINT32 so that the displayed value matches the actual bytes in the packet svn path=/trunk/; revision=53927
2013-12-10use the new SI string routines in DVB-CIMartin Kaiser1-126/+66
svn path=/trunk/; revision=53925
2013-12-10Reject the packet if data is NULL.Chris Maynard1-5/+10
svn path=/trunk/; revision=53924
2013-12-10Where appropriate, reject the packet entirely or at least protect against ↵Chris Maynard1-4/+13
data being NULL. svn path=/trunk/; revision=53923
2013-12-10Reject packets if data (and usb_trans_info) are NULL. Also, new-syle ↵Chris Maynard3-22/+38
dissectors return the number of bytes dissected, not TRUE/FALSE. svn path=/trunk/; revision=53922
2013-12-10Trival: spaces -> tab.Chris Maynard1-1/+1
svn path=/trunk/; revision=53921
2013-12-10Add a missing semicolon.Gerald Combs1-1/+1
svn path=/trunk/; revision=53919
2013-12-10- Forward declaration of register functions.Anders Broman58-7/+162
svn path=/trunk/; revision=53918
2013-12-10Remove _U_ from dissect_usb_com_bulk()'s data parameter; it is used.Chris Maynard1-1/+1
svn path=/trunk/; revision=53916
2013-12-10Reject the packet if data is NULL.Chris Maynard3-10/+25
svn path=/trunk/; revision=53914
2013-12-10Remove config.h includes from proto.h and tap.h.Gerald Combs2-10/+6
svn path=/trunk/; revision=53913
2013-12-10- Forward declaration of register functions.Anders Broman23-4/+60
svn path=/trunk/; revision=53911
2013-12-10Get the "Decode As" dialog working, albeit with a few warts. It differsGerald Combs7-259/+73
from the GTK flavor in two major ways: - The "Decode As" and "User Specified Decodes" dialog have been unified. - You can modify the decode as behavior at any time, not just when you have a packet selected. Revert part of 53498 so that we can move items marked /*** THE FOLLOWING SHOULD NOT BE USED BY ANY DISSECTORS!!! ***/ from epan/decode_as.h to ui/decode_as_utils.h. Move "save" code from decode_as_dlg.c to decode_as_utils.c as well. In packet-dcerpc.c don't register a table named "ethertype". We might want to add checks for duplicate table names. To do: - Add support for ranges? - Either add support for DCERPC or make DCERPC use a regular dissector table. - Fix string selectors (i.e. BER). svn path=/trunk/; revision=53910
2013-12-10Fix epan building with undefined HAVE_PLUGINSJakub Zawadzki3-0/+10
+ guard prototypes with HAVE_PLUGINS in .h files to get errors before linking. svn path=/trunk/; revision=53909
2013-12-10- Forward declaration of register functions.Anders Broman18-40/+92
svn path=/trunk/; revision=53908
2013-12-10Add uat preferences to SCTP (QT only).Irene Rüngeler1-1/+98
svn path=/trunk/; revision=53907
2013-12-10Use PT_TXTMOD_NONE for columns that should not be editable.Irene Rüngeler2-0/+4
svn path=/trunk/; revision=53906
2013-12-10In dissect_ldss_transfer(), reject the packet if data is NULL. Fix some typos.Chris Maynard1-7/+10
svn path=/trunk/; revision=53905
2013-12-10comment out unused functionsMartin Kaiser1-2/+4
fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9538 reported by Yaniv Kaul svn path=/trunk/; revision=53902
2013-12-10- Forward declaration of register functions.Anders Broman13-29/+63
svn path=/trunk/; revision=53901
2013-12-10Remove _U_ from dissect_wol's and dissect_wolheur's data argument; they both ↵Chris Maynard1-2/+2
pass it to dissect_wol_pdu, which doesn't actually use it, but technically they do. svn path=/trunk/; revision=53900
2013-12-10Reject the packet if data is NULL.Chris Maynard5-5/+30
svn path=/trunk/; revision=53899
2013-12-10Reject the packet if data is NULL.Chris Maynard2-4/+13
svn path=/trunk/; revision=53898
2013-12-10Remove _U_ from dissect_carp's data argument; it's passed to ↵Chris Maynard1-1/+1
test_carp_packet(), which doesn't actually use it, but dissect_carp technically does. svn path=/trunk/; revision=53897
2013-12-09Reject the packet if data is NULL. For now, leave the ↵Chris Maynard1-3/+6
DISSECTOR_ASSERT(rose_ctx_tmp) since get_rose_ctx() also checks the signature, which might be invalid even if data is not NULL. svn path=/trunk/; revision=53896
2013-12-09Reject the packet if data is NULL without doing anything else.Chris Maynard11-95/+80
Note: We *might* want to do _something_ but that _something_ should be well-defined and consistent across all dissectors. Previously, some dissectors called proto_tree_add_text() to add some error message text to the tree, while others called DISSECTOR_ASSERT(). svn path=/trunk/; revision=53895
2013-12-09Minor whitespace changes and to keep the GNU-syle indentation scheme consistent.Chris Maynard1-26/+24
svn path=/trunk/; revision=53894
2013-12-09Reject the packet if data is NULL.Chris Maynard7-23/+102
svn path=/trunk/; revision=53893
2013-12-09ignore empty textsMartin Kaiser1-5/+8
svn path=/trunk/; revision=53892
2013-12-09use the DVB-SI string hadling for the short event descriptorMartin Kaiser1-3/+14
svn path=/trunk/; revision=53891
2013-12-09add editor modelinesMartin Kaiser1-0/+13
svn path=/trunk/; revision=53890
2013-12-09Reject the packet if data is NULL.Chris Maynard2-2/+13
svn path=/trunk/; revision=53889
2013-12-09TABs -> spacesMartin Kaiser1-52/+65
add editor modelines svn path=/trunk/; revision=53888
2013-12-09From packet-ua, pass a pointer to direction rather than direction itself. ↵Chris Maynard2-5/+10
In packet-ua3g, reject the packet if data is NULL. svn path=/trunk/; revision=53887
2013-12-09From JakubMartin Kaiser2-0/+255
support DVB-SI character tables (EN 300 468) in a generic way From me move things to charsets.c/.h distinguish between single and multi byte encoding for some tables (so that the highlighted bytes match the displayed value) no character table byte -> length 0, use default table svn path=/trunk/; revision=53886
2013-12-09Fix warningsJakub Zawadzki6-12/+5
svn path=/trunk/; revision=53885
2013-12-09fix compilation without GNUTLS and libgcryptMartin Kaiser1-32/+42
move from_hex_char() and from_hex() outside ifdef gnutls add dummy ssl_generate_pre_master_secret() this should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9529 svn path=/trunk/; revision=53884
2013-12-09Reject the packet if data is NULL.Chris Maynard1-1/+6
svn path=/trunk/; revision=53883
2013-12-09Reject the packet if data is NULL.Chris Maynard1-1/+6
svn path=/trunk/; revision=53882
2013-12-09Add TLV 16 (Interface name)Jörg Mayer1-1/+7
svn path=/trunk/; revision=53881