aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-09-12E1AP: Add .h file needed for private IE dissection.Anders Broman6-21/+98
Change-Id: I04569b89a6fe55e4d988978bd8f1538bc62444e5 Reviewed-on: https://code.wireshark.org/review/34514 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-11Netflow: Niagara Networks decodes for RADIUS IPFIX information elements.Volodymyr Veskera1-0/+286
Change-Id: Idec2db02ca5cf08bf407a15b716e804947426a19 Reviewed-on: https://code.wireshark.org/review/34502 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-09-10DLT: Fix gint64 printf formatStig Bjørlykke1-1/+1
Use G_GINT64_FORMAT for gint64. Change-Id: I50e82a45d51b97f0e15d90082b71fd53e65d83a6 Reviewed-on: https://code.wireshark.org/review/34499 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10FC-dNS: add missing fields registrationPascal Quantin1-0/+4
Issue reported by Christian Svensson in https://www.wireshark.org/lists/wireshark-dev/201909/msg00016.html Change-Id: I362bb9ad861d5b87d3d21997621011654a8b86ef Reviewed-on: https://code.wireshark.org/review/34492 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-10DLT: Fix uint64 printf formatStig Bjørlykke1-2/+2
Use G_GUINT64_FORMAT for uint64. Change-Id: I3c86dad0f045092e4292899c473ff32bb1fe82a8 Reviewed-on: https://code.wireshark.org/review/34490 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10DLT: Adding support for the DLT protocolDr. Lars Völker2-0/+1373
The Diagnostic Log and Trace protocol (DLT) is a commonly used and standardized protocol in the automotive industry used to retrieve log data. This patch adds the protocol to Wireshark. Keep in mind that ports have to be configured before the dissector can be used. Change-Id: I24592705476fb0c3bb83a1cc10b3dae8867523f4 Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de> Reviewed-on: https://code.wireshark.org/review/34462 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10TDS: Improve handling of scale for TDS numeric and decimal fields.Craig Jackson1-12/+52
For numeric and decimal fields, we can use doubles to display many decimal and numeric fields exactly. It only starts to fall down when we get more than 15 decimal digits. Bug: 16041 Change-Id: Idae1790ade7106d7557739220756ef9e9281378c Reviewed-on: https://code.wireshark.org/review/34471 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10ieee80211: fix dissection of HE Phy Capabilities InformationAlexis La Goutte1-27/+9
Wrong bitmask and duplicate field for same byte Issue reported by Helge Mangus Keck Change-Id: Ibc5a914fc2ecc05b9b5f6d0025c52c80af23d9f4 Reviewed-on: https://code.wireshark.org/review/34483 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10DIS: Support for the EntityStateUpdate PDUJean-Philippe Lebel1-1/+131
Updated the DIS protocol dissector to support the EntityStateUpdate PDU. The EntityStateUpdatePDU is part of DIS 7 and was already "semi-handled" by the dissector. Change-Id: I3221520e0260dc836d373fa590b3941de45a2dcc Reviewed-on: https://code.wireshark.org/review/34463 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09rsl: Add support for non-standard RSL_MSG_TYPE_OSMO_ETWS_CMDHarald Welte1-1/+49
3GPP sadly has forgotten to specify how the ETWS Primary Notification is to be communicated over Abis to the BTS. Osmocom has introduced a non-standard RSL message type "RSL_MSG_TYPE_OSMO_ETWS_CMD" for this purpose to the OsmoBTS and OsmoBSC implementations. It contains a single Information Element which in turn contains the 56-byte primary notification of the Earthquake and Tsunami Warning system. This patch adds wireshark dissector support to it. Change-Id: Icce5b06bfd00c0a7ef0f21283cc57473fa34f034 Reviewed-on: https://code.wireshark.org/review/34464 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I013c1bdc943033550f497b1be0dfc7979ca49517 Reviewed-on: https://code.wireshark.org/review/34484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09nvme-tcp: Add C2H/H2C TermReq dissectionDmitry Radivonchik1-0/+165
Section 7.4.10.4 and 7.4.10.5 of the spec. Change-Id: I175f98ca8265eb369344d5dcaff7bdf0943372c3 Signed-off-by: Dmitry Radivonchik <mitya@oktetlabs.ru> Reviewed-on: https://code.wireshark.org/review/34470 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-5/+5
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d Reviewed-on: https://code.wireshark.org/review/34481 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08BACNET: Update vendor ID listJaap Keuter1-1/+80
Update build-in vendor ID list with last years additions. Change-Id: I1916e160f6bcea5e94ce203b50f4a27a6ca1d261 Reviewed-on: https://code.wireshark.org/review/34460 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-08QUIC: fix connection tracking with empty Initial SCIDPeter Wu1-16/+22
Fix linking of new Initial packets after a Retry packet in case the client Initial packet has an empty SCID. Update a comment to drop "Stateless" from "Stateless Retry" to match newer QUIC drafts. Tested with quic-go-b083fd6f0e36-d22-dsb.pcapng. Bug: 13881 Change-Id: Idc8b1ad6283ace95ae059a6ef6ee268c1ffb4097 Reviewed-on: https://code.wireshark.org/review/34469 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-05NAS 5GS: enhance dissection of QoS rules IEPascal Quantin1-18/+162
Change-Id: I96d416744401d259b9205f5e8daaffe58673633f Reviewed-on: https://code.wireshark.org/review/34451 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-05kafka: Cleanup to use "native" APIs.Michael Mann5-157/+172
Add "native" support for the "zig-zag" version of a varint in proto.[ch] and tvbuff.[ch]. Convert the use of varint in the KAFKA dissector to use the (new) "native" API. Ping-Bug: 15988 Change-Id: Ia83569203877df8c780f4f182916ed6327d0ec6c Reviewed-on: https://code.wireshark.org/review/34386 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Load environment vars to globals for efficency.Anders Broman7-21/+49
These environment variables are read very frequently, read them once to globals for performance improvment. Change-Id: I4f05a5edca85b370674cc5f85fce40bd1af695cb Reviewed-on: https://code.wireshark.org/review/34449 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03NAS 5GS: fix dissection of Session-AMBR/GFBR/MFBR unitPascal Quantin1-7/+6
Change-Id: Iccbc89a586abd33db0dd8c16974ad8d9b5bd21f9 Reviewed-on: https://code.wireshark.org/review/34443 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-03OSC: Set UDP heuristic default off as this is a niche protocol.Anders Broman1-1/+1
The heuristic is a bit expensive, set default off. Change-Id: Ib0cb863810a1cbcae2fef0b5a035c63682246a0f Reviewed-on: https://code.wireshark.org/review/34441 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03ETSI Card Application Toolkit Transport: Set heuristics default off.Anders Broman1-1/+1
RTP packets picked up by the dissector as it's a niche protocol set heuristics to default off. Change-Id: I33c6c3fc0f4a593cc4ed5866515cdcea669bee54 Reviewed-on: https://code.wireshark.org/review/34440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-02NAS 5GS: fix dissection of QoS flow description IEPascal Quantin1-39/+101
Do not reuse Session AMBR fields for MFBR and GFBR. Add averaging window and EPS bearer identity cases. Change-Id: I34fad0b5f38aa097bb968106de2bbb86278579b9 Reviewed-on: https://code.wireshark.org/review/34430 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-02NAS 5GS: display protocol identifier string in QoS Rule IEPascal Quantin1-2/+2
Change-Id: I9d5e1f099b9273b20bf335a5b29ef66cf112c928 Reviewed-on: https://code.wireshark.org/review/34429 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-02couchbase: update command identifiersSergey Avseyev1-0/+8
Change-Id: Ic6eb59a26dc0a9edd216a985bbf94d13b4bc5094 Reviewed-on: https://code.wireshark.org/review/34427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02TCP: Provide display filters for "raw" SEQ/ACK.Michael Mann2-3/+21
Add hf_ fields for "raw" Sequence and Acknowledgment numbers. They will only be visible when "Relative sequence numbers" preference is TRUE. Bug: 15913 Change-Id: Icfbdc435e82723d663dce36c3a5cc513c837bdaf Reviewed-on: https://code.wireshark.org/review/34421 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02IEEE802.11: Minor cleanupMichael Mann1-43/+42
1. he_mac_headers can be changed at runtime, so it is not "static" or "const" 2. Optimize out extended length calculation. Ping-Bug: 15866 Change-Id: Ibf8191a7043a22109ae8a3db481bfbbef583b110 Reviewed-on: https://code.wireshark.org/review/34424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-01SMTP: Consider bytes seen as "data" until a command is seenMichael Mann1-2/+3
Create a state for the start of an SMTP conversation. If bytes seen don't match a command and conversation is still in the "start" state, treat bytes as message data, not a command. Bug: 16026 Change-Id: I229b316a77819b07bf8cf93bed72570a947c6cf3 Reviewed-on: https://code.wireshark.org/review/34412 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01net_dm: Add dissector for drop monitor netlink packetsIdo Schimmel2-0/+502
The Linux kernel includes a module called drop monitor which - unsurprisingly - monitors packet drops. Once enabled, the module will periodically send netlink notifications to user space over generic netlink. Historically, these notifications only included the program counter where the drop occurred and the number of packets that were dropped in this location in the last interval. Patches in net-next (queued for Linux kernel 5.4) extend drop monitor with another mode of operation where the dropped packets themselves are sent to user space along with relevant metadata as netlink notifications. This allows users to perform a more detailed analysis of the dropped packets. This patch adds a dissector for these netlink packets. The dissector is expected to be invoked by the generic netlink dissector and during its hand off routine it adds an entry in the 'genl.family' dissector table. The various netlink attributes are dissected by calling dissect_netlink_attributes(), in a similar fashion to the rtnetlink dissector. The dropped packet itself is encoded in the netlink attribute 'NET_DM_ATTR_PAYLOAD' and dissected by invoking a dissector from the 'sll.ltype' dissector table based on the packet's protocol which is encoded in the 'NET_DM_ATTR_PROTO' attribute. Bug: 16018 Change-Id: I10bfa4b9c9d8f5e82769c250f929f74693142a23 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34351 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01IEEE 802.11: RSN Information tag, more fields optional.Michael Mann1-2/+8
IEEE 802.11-2016 Section 9.4.2.25 RSNE All information after Element ID, Length, and Version are optional; therefore the minimal IE length is 2. Bug: 15905 Change-Id: I231e31c6a0fe5a26d5dd7c1c36be4e9816a7bb50 Reviewed-on: https://code.wireshark.org/review/34411 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-30isakmp: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I318fec3f9cf8d86eaa4260f00e8747683a049e6e Reviewed-on: https://code.wireshark.org/review/34407 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30ieee1722: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ia056c5591369924f88762490b22e72e10f3bc392 Reviewed-on: https://code.wireshark.org/review/34406 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30NAS 5GS: update 5GSM capability IE dissectionPascal Quantin1-2/+8
Change-Id: I64b063aba78e64193fa5e8dc5e15955bd93093de Reviewed-on: https://code.wireshark.org/review/34409 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix PDU session identity dissectionPascal Quantin1-4/+4
Values 1 to 4 are allowed Change-Id: Ifa0bc9185af9a16c261d7cbd939a07f77f03b330 Reviewed-on: https://code.wireshark.org/review/34408 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: update 5GSM cause tablePascal Quantin1-4/+8
Change-Id: I88c9015e0ec31c6d04fe653aee1753d2a604976f Reviewed-on: https://code.wireshark.org/review/34405 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: small cleanupPascal Quantin1-8/+1
Remove a useless assignment and a few useless return. Change-Id: I38d868fe8cb81cd86683cf660a6a6699c1e8a54b Reviewed-on: https://code.wireshark.org/review/34403 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: fix dissection of 5GSM capability IEPascal Quantin1-4/+7
This IE has a variable length to allow future extension. Change-Id: I158ef8a8aa2f5cace992113a9efeb324beebe1aa Reviewed-on: https://code.wireshark.org/review/34402 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-30NAS 5GS: add dissection of Maximum number of supported packet filters IEPascal Quantin1-4/+23
Change-Id: I771cb6d2542a5069641fd5c57836e776802da199 Reviewed-on: https://code.wireshark.org/review/34401 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30ASTERIX: addition of CAT021 v0.23 and v0.26 decodingIvan Quach1-1/+323
Added ability to decode CAT021 version 0.23 and version 0.26 ASTERIX messages Change-Id: I242ae3055f0af805e3a9eb126494d545702f836f Reviewed-on: https://code.wireshark.org/review/34343 Reviewed-by: Ivan Quach <ivan.quach@aireon.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-30genl: Always call subdissectorIdo Schimmel2-9/+14
Commit 61c5e8e76d21 ("genl: make subdissectors responsible for header") changed the generic netlink dissector to only call a sub-dissector if there is a payload after the generic netlink header. However, there are commands in certain generic netlink families that do not have any payload. For example, 'NET_DM_CMD_START' in the 'NET_DM' family. This means that the command will not be dissected by the subdissector, as it will never be invoked. Change the generic netlink dissector to always call a subdissector, if it is present. Prevent the subdissectors from trying to dissect past the end of the packet by adding checks in the two existing subdissectors, for the 'nlctrl' and 'nl80211' families. Change-Id: I4d2f48531dee92b11dc45000081a8d2d3dd875c6 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34350 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-29mpeg(dsmcc): Fixed default switch conditionAnthony Crawford1-0/+2
A default condition was missing within the switch statement in dissect_dsmcc_un_session_resources Bug: 16025 Change-Id: I34a2c3715923ba80be456aa9b03f84f1dae58bd3 Reviewed-on: https://code.wireshark.org/review/34399 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-29Add proto_tree_add_item_ret_time_stringMichael Mann14-222/+236
A few dissectors need the functionality of adding a time field to a proto_tree while also needing the "time to string" value (typically to show on a tree above). The functionality to do "get value from tvb and convert to string" was being done in packet-ntp.c. Instead proto_tree_add_item_ret_time_string can be used with various encoding to get the necessary functionality with less code duplication. ENC_TIME_MIP6 was added as a result of the refactoring. ABSOLUTE_TIME_NTP_UTC was added as another potential "base" type for time fields. Change-Id: Ie460c33370b0af59ef60bdab893ce9d6eb23b94f Reviewed-on: https://code.wireshark.org/review/34390 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28DOCSIS: FDX: Added decoding for SW-RBABruno Verstuyft1-1/+97
Change-Id: Ic55c2393e20c69866a266a5a8213faa84e17fac1 Reviewed-on: https://code.wireshark.org/review/34389 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28eCPRI: Update value string.Anders Broman1-3/+19
Change-Id: I7e5f5fa00b168578e00191089b482082e290f2d0 Reviewed-on: https://code.wireshark.org/review/34388 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-28Use g_hash_table_replace() when key depends on dataTomasz Moń1-1/+1
Using g_hash_table_insert() in cases where the key is contained within value is error prone. Use g_hash_table_replace() to eliminate the risk of ending up with incoherent hash table state. Change-Id: I595457476a2682e927d2c56b2692404aef4dc43a Reviewed-on: https://code.wireshark.org/review/34385 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27Kafka: fixed OffsetForLeaderEpoch dissectionPiotr Smolinski1-132/+155
Bug: 16023 Change-Id: I78e1354ac5509707c818d7968c7067583fb469ba Reviewed-on: https://code.wireshark.org/review/34379 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-27kafka: remove unused hf/ei entries.Dario Lombardo1-15/+0
Change-Id: I98a3a1456fbfeb726a1a81a0b46714556fe951cd Reviewed-on: https://code.wireshark.org/review/34383 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27SMTP: Add support for multiline responsesMichael Mann1-22/+53
Commands with "-" at the end mean another line with the same command will follow. Group all of those lines in a single response tree and don't append the command value in the Info column for the additional lines. Bug: 15933 Change-Id: Icba167f2f1d22ebaf53a6844285ba83ed8a20106 Reviewed-on: https://code.wireshark.org/review/34381 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: workaround that pidl always emits dissect_deferred_pointers()Ralph Boehme1-2/+7
Commit f57cf9e56c90c0c0c724f415eff35821afaaf849 introduced a DISSECTOR_ASSERT() that revealed a deficiency in pidl: currently pidl unconditionally adds calls to dissect_deferred_pointers() which breaks dissecting any RPC function that has only scalar arguments: Warn Dissector bug, protocol RPCMDSSVC, in packet 51: epan/dissectors/packet-dcerpc.c:2940: failed assertion "list_ndr_pointer_list" Bug: 16022 Change-Id: I9d3522a3e17ef79b9a8a5acb018104ab398a512a Reviewed-on: https://code.wireshark.org/review/34364 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27DCERPC: update mdssvc DCERPC dissector from upstream SambaRalph Boehme2-99/+278
Change-Id: I13871e093b294a1865be6c47cb86275165002855 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-on: https://code.wireshark.org/review/34365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26coap: Distinguish observe option for request and responseStig Bjørlykke3-11/+24
The observe option has different values for request and response. For request it identifies register or deregister, and for response it is a sequence number for reordering detection. RFC 7641 chapter 2. Change-Id: I09515864997a32f7259e344532ea770b74030b04 Reviewed-on: https://code.wireshark.org/review/34368 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>