aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2017-05-14ssl,dtls: fix message hash for extended_master_secretPeter Wu3-4/+49
The handshake_messages for extended master secret start at Client Hello and end at ClientKeyExchange. Previously all handshake messages in a record would be hashed, possibly covering those after CKE. Now it will hash each handshake message separately. For DTLS, the CH and HVR messages must also be ignored. Additionally, DTLS needs special treatment to merge multiple fragments. Bug: 13704 Change-Id: I0c8f19b4c352c0195848ded319b6991d76542720 Reviewed-on: https://code.wireshark.org/review/21625 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-05-14ieee802154: Refactor payload IE dissectionRémy Léone1-140/+203
- Create explicit display filter - Adding reference to the IEEE 802.15.4 standard - extract dissect_802154_enhanced_beacon_filter - Explicit case of header termination - Fix typo - Add some cast Change-Id: I21c5b9eb46c72a377f17113ae729c6aeb79e5d2b Reviewed-on: https://code.wireshark.org/review/21361 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14OpenFlow(v6): add Openflow bad action error message valueAlexis La Goutte1-0/+2
Ping-Bug: 13702 Change-Id: I3fa5e9f4d0736d62c922ab3994a0a57afda043a3 Reviewed-on: https://code.wireshark.org/review/21648 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14OpenFlow(v6): rename Meter Config to Meter DescAlexis La Goutte1-58/+58
Ping-Bug: 13702 Change-Id: I86ed023bcd4f0f9df79dc5c9bd4cfe566c04c804 Reviewed-on: https://code.wireshark.org/review/21647 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow(v6): Add OFPGC_INSERT_BUCKET/OFPGC_DELETE_BUCKETAlexis La Goutte1-0/+26
and add new field on groupmod with Bucket Ping-Bug: 13702 Change-Id: If5893d49d6cd7a8ab6b46f1fcfce4fbff4153d1f Reviewed-on: https://code.wireshark.org/review/21646 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14OpenFlow(v6): Add new OFPXMT typeAlexis La Goutte1-0/+6
Ping-Bug: 13702 Change-Id: If320fe6557a66cafaf95afeead4912f7476a70ad Reviewed-on: https://code.wireshark.org/review/21645 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14OpenFlow(v6): Enhance OFPITAlexis La Goutte1-1/+3
OFPIT_METER is now deprecated and there is a new OFPIT_STAT_TRIGGER Ping-Bug: 13702 Change-Id: I76b8ab8a86ee59e443fbeac81c45b982bac1b3a2 Reviewed-on: https://code.wireshark.org/review/21644 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow(v6): Add new OFPAT MeterAlexis La Goutte1-0/+43
no try on real pcap... Ping-Bug: 13702 Change-Id: I828ae5599704c9bc514b8968d1a15c9a446555d6 Reviewed-on: https://code.wireshark.org/review/21643 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow(v6): Add new OFPAT Copy FieldAlexis La Goutte1-0/+69
no try on real pcap... Ping-Bug: 13702 Change-Id: Ia6b048cc8b37bb1697e7378bbcd098a19bff99e3 Reviewed-on: https://code.wireshark.org/review/21642 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow: Add support of openflow 1.5 (v6)Alexis La Goutte4-0/+9925
Copy from dissector 1.4 (v5) Bug: 13702 Change-Id: I2ae5b620e6ff1626c69f8fac6184244399e297de Reviewed-on: https://code.wireshark.org/review/21641 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14reload-framing: fix typo (serie -> series)Alexis La Goutte1-1/+1
Change-Id: I604b4e2e99753734d550b40d5fe013c89f2960fc Reviewed-on: https://code.wireshark.org/review/21652 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14MQ: fix typo (Comit -> Commit)Alexis La Goutte1-1/+1
Change-Id: I36f772f7b7cf0d8e9d3f287bc4bf9718180485d8 Reviewed-on: https://code.wireshark.org/review/21651 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14It's now RFC 6940.Guy Harris1-0/+2
Change-Id: I2818d5c0c7e33e53cac2d3f3adb1bfd44f43d756 Reviewed-on: https://code.wireshark.org/review/21655 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-14Provide some URLs for the document in question.Guy Harris1-1/+8
Change-Id: Ief48dbc07add739ed7274947640cc9e68552242e Reviewed-on: https://code.wireshark.org/review/21654 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-14smb: don't use tvb_get_* on proto_tree_add_uintAlexis La Goutte1-6/+6
Change-Id: I38db11b444a1d4b5be7980c262e9f84ae48c7427 Reviewed-on: https://code.wireshark.org/review/21649 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-14ansi_map : fix typo (dont't -> don't)Alexis La Goutte1-1/+1
Change-Id: Iffeec2c2f24dad263d328186767a758558a56351 Reviewed-on: https://code.wireshark.org/review/21653 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-14GSM RLC/MAC: fix another global-buffer-overflow error reported by ASANPascal Quantin1-1/+4
Same root cause as gf751918 Bug: 13708 Change-Id: I9d1089c3a632ca82370d14beb06ebcd554901415 Reviewed-on: https://code.wireshark.org/review/21639 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow(v5): fix field typoAlexis La Goutte1-2/+2
Change-Id: I101f760a64e4beec73483eeda93068798b140d69 Reviewed-on: https://code.wireshark.org/review/21640 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14nge: fix conflict for hf fieldAlexis La Goutte1-1/+1
'nge.unknown' exists multiple times with NOT compatible types: FT_UINT32 and FT_BYTES Change-Id: I757e6b4107e4d8103950603d4441248b931bbb15 Reviewed-on: https://code.wireshark.org/review/21638 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-14Initial OBD-II PIDs dissector.Jakub Zawadzki5-0/+1569
Change-Id: I0974f13a032a908bcc27f583c3e059f57959881f Reviewed-on: https://code.wireshark.org/review/21552 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2017-05-14[Automatic update for 2017-05-14]Gerald Combs2-8/+238
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia7833dc62cb4f4687da664b66eba6c5f31437f9a Reviewed-on: https://code.wireshark.org/review/21630 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-05-14Add unit_name_string_get_double to handle float/double fieldsMichael Mann3-4/+13
Bug: 13705 Change-Id: I6bd006f216440d071e5c1eeb6b1f996b4a364c62 Reviewed-on: https://code.wireshark.org/review/21629 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-13IEEE80211-radio: Fix divide by zeroBjörn Ruytenberg1-1/+1
Perform sanity check on parsed data rate. Data rate of zero results in a division by zero in calculate_llac_duration. Do not use data rate if zero. Bug: 13706 Change-Id: I7883e1052a0965f7927d3a478c0aa992693f7fe1 Reviewed-on: https://code.wireshark.org/review/21626 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-13gsm_osmux: Support multiple OSmux frames per packetPau Espin Pedrol1-45/+92
Also split and show all AMR payloads Change-Id: I5bde4e87dc51fd4a996a14117813ea89d7005d38 Reviewed-on: https://code.wireshark.org/review/21600 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-05-13gif: simplify the dissection codeMartin Kaiser1-56/+57
Increment offset as we go through the file. Add a function to dissect a sequence of data blocks. Call this function for extension blocks and images. Change-Id: If156cb9cd4fe4ba6fdd3780c93087f2dd2ae8bf5 Reviewed-on: https://code.wireshark.org/review/21547 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-13Kafka: add LZ4 decompressionPascal Quantin1-1/+211
Change-Id: Idf2f63782c8751778ad88f46a7f65fe7d5d49f3b Reviewed-on: https://code.wireshark.org/review/21577 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12AIM: allow multiple TCP ports to be configuredMartin Mathieson1-2/+5
Change-Id: I4a74120ad1424f2b5aab0a4ef734ff52e5ac1a14 Reviewed-on: https://code.wireshark.org/review/21586 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-05-12Thread CoAP: fix 2 potential infinite loopsPascal Quantin1-2/+2
Bug: 13693 Change-Id: Ie47ca69a9941dbc273bb8f18e300773092a2fc96 Reviewed-on: https://code.wireshark.org/review/21620 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-12packet-acn.c: Various cleanupNick1-57/+65
1. Fix some typos (in hf_ field names and value_string values) 2. Fix an off-by-on error in blob calculation 3. Bugfix a few field lengths 4. Bugfix offset handling when adding ACN address Change-Id: Id9e3d205b848ce3767b27ef1fcf02f7faae0be15 Reviewed-on: https://code.wireshark.org/review/20953 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-12BT L2CAP: avoid a division by 0Pascal Quantin1-2/+3
Bug: 13701 Change-Id: Ie433ecd932dcfc40fa6d3fdc3fa00139c64584a2 Reviewed-on: https://code.wireshark.org/review/21618 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-12UMTS Iub: Resolve U-RNTI for C-RNTIS. Shapira10-122/+465
This commit includes logic used to store pairs of C-RNTIs and U-RNTIs based on allocations in RRC and logic to retrive those when encountering C-RNTIs in the MAC header for DCCH over FACH/RACH. Change-Id: I629ab061b7a73416e5730a980480b81a1aaade11 Reviewed-on: https://code.wireshark.org/review/21607 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-12gif: make data block an FT_UINT_BYTES entryMartin Kaiser1-7/+8
The length byte is now highlighted along with the actual data. Change-Id: I93ce25ad2cd7c790cc23668d354e32c4f5e195c6 Reviewed-on: https://code.wireshark.org/review/21610 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12smb: fix some indent typo (use tabs)Alexis La Goutte1-9/+9
Change-Id: I54b301cb224a2ff15d5a7a453ecf6f29b798f366 Reviewed-on: https://code.wireshark.org/review/21615 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-12Adds aggregate detection, calculation of frame start and end time, and IFSSimon Barber1-22/+342
Change-Id: I3a9cddd9c6e47a5c5c48e2e02a32a71413bcf799 Reviewed-on: https://code.wireshark.org/review/13590 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12Fix header field info checks for FT_UINT_BYTES.Martin Kaiser1-0/+1
It should be allowed to have an FT_UINT_BYTES hf entry with BASE_NONE|BASE_ALLOW_ZERO. At the moment, this triggers an assert: Err Field 'Data block' (image-gif.data_block) is an FT_UINT_BYTES but is being displayed as (Bit count: 2048) instead of BASE_NONE For FT_UINT_BYTES entries, we should make the same checks as for FT_BYTES. Don't fall through to the default case. Change-Id: I986a9b779d130919d17595f08b3b63306b3956f2 Reviewed-on: https://code.wireshark.org/review/21606 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-12gsm_osmux: Add RTP Marker fieldPau Espin Pedrol2-2/+21
GSM Osmux recently got support to bring RTP Marker (M) bit. It should be mostly backwards compatible as the first bit was reserved and not used before for the FieldType. Support was added in libosmo-netif commit e98afe5808176efb60298a2f764e8e11efaf580b This bit is documented in the protocol documentation recently available: http://ftp.osmocom.org/docs/latest/osmux-reference.pdf Change-Id: Ia0508971519b3df9499d963404bb8a0e3c4b9c33 Reviewed-on: https://code.wireshark.org/review/21599 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-11dns: improve loop detection in label decompressionPeter Wu1-9/+7
Previously the number of allowed pointers within a message is equal to the data in a tvb (16575 in one example). This is still expensive, so implement an alternative detection mechanism that looks for a direct self-loop and limits the total pointers to about 256. Bug: 13633 Change-Id: I803873e24ab170c7ef0b881d3bdc9dfd4014de97 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1206 Reviewed-on: https://code.wireshark.org/review/21507 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-05-11Another shadowing fix for abort().Guy Harris1-4/+4
Change-Id: I991bd24ab8b64bdfeae275941d79b716da3309f9 Reviewed-on: https://code.wireshark.org/review/21592 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-11Squelch warning from some compilers.Guy Harris1-4/+4
Change-Id: Iacd5832e3b63fa24907423d2b7df40e81fafb0de Reviewed-on: https://code.wireshark.org/review/21591 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-11EPL: Dissect read/write multiple parameter SDOsChristoph Schlosser1-9/+444
The dissector only dissected Write Multiple Parameter by Index requests correctly. Now it is possible to dissect the response to the request and Read Multiple Parameter by Index request and responses. Bug: 13677 Change-Id: I13aae241690cd3ac9dfbe8129ef56d0fc9016301 Reviewed-on: https://code.wireshark.org/review/21034 Reviewed-by: Christoph Schlosser <christoph@schlosser.xyz> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-11GSM RLC/MAC: fix global-buffer-overflow error reported by ASANPascal Quantin1-1/+4
After a M_NEXT_EXIST(), you should always have another variable (like M_UINT, M_TYPE, ...) and not immediately end the structure with CSN_DESCR_END. Note that this is a workaround as the current description does not allow a proper parsing anyway (as the structure is reentrant). But at least it solves the buffer overflow. Bug: 13692 Change-Id: I8e607aadcced2d8cc636dc10f9690c5c679ad581 Reviewed-on: https://code.wireshark.org/review/21585 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-10This is specified in section 8 of the DIX v2.0 Ethernet spec.Guy Harris1-1/+9
Note that, and give a URL for the spec. Change-Id: I60953ddf2e7934ac273ba808ae4aa662f562917e Reviewed-on: https://code.wireshark.org/review/21583 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09nge: add modelines infoAlexis La Goutte1-0/+13
Change-Id: Ib75f637c36be575a85e75fee6282d1a16455bfd6 Reviewed-on: https://code.wireshark.org/review/21572 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Charlie Lenahan <clenahan@sonicbison.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-09nge: fix no previous prototype for ‘proto_register_nge/handoff_nge’ ↵Alexis La Goutte1-0/+3
[-Wmissing-prototypes] Change-Id: I2e7cecad96390f709c6a135b6059c01712971dfe Reviewed-on: https://code.wireshark.org/review/21571 Reviewed-by: Charlie Lenahan <clenahan@sonicbison.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-09You can't have a field be both integer and string.Guy Harris1-6/+1
For an inter-frame gap that couldn't be determined, just add it with proto_tree_add_uint_format_value() and "Cannot be determined" as the way the value is displayed. (But why add it *at all* if it couldn't be determined?) Change-Id: I491f9a6fe430141a15568e9a7dec3253a1c78cf5 Reviewed-on: https://code.wireshark.org/review/21582 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09Give fields better names than ".bitN".Guy Harris1-587/+559
".bitN" names 1) don't indicate what the bit actually *means* and 2) run the risk of collisions if the bit in question has a different meaning in different bitsets. Combine the "receive case" and "transmit case" bitsets in some cases where the only difference between the two sets is that some bits are present only in one set, but if a bit is present in both sets, it has the same meaning. Change-Id: Ie1cb9d076e431b30b64ef05acab39efe38193d33 Reviewed-on: https://code.wireshark.org/review/21581 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09De-capitalize "error" - it's not capitalized in other field names.Guy Harris1-1/+1
Change-Id: I6f5aaaba47ab8d36124aa10c63ceec7cf1f70867 Reviewed-on: https://code.wireshark.org/review/21580 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09Fix various field names and types.Guy Harris1-78/+30
Make some names used for multiple fields more stylistically consistent. If a bitfield has more than one bit, it's not Boolean - the extra bits mean it has more values than "true" or "false". If a bitfield has only one bit, and indicates that something is true/false, or enabled/disabled, or present/absent, or on/off, or something else obviously Boolean, it's Boolean. Change-Id: I89d5e214eb5c4e7f72eb59a78757f0f49fec3dbf Reviewed-on: https://code.wireshark.org/review/21579 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-09ua3g: fix conflicting entry in its value_stringAlexis La Goutte1-2/+2
Field 'Audio Env.' (ua3g.ip.set_param_req.parameter.audio_env) has a conflicting entry in its value_string: 2 is at indices 2 (Open Space) and 3 (Meeting Room)) Field 'Audio Env.' (ua3g.ip.set_param_req.parameter.audio_env) has a conflicting entry in its value_string: 2 is at indices 2 (Open Space) and 4 (Noisy)) Field 'Audio Env.' (ua3g.ip.set_param_req.parameter.audio_env) has a conflicting entry in its value_string: 2 is at indices 3 (Meeting Room) and 4 (Noisy)) Change-Id: I495f183dd52e59ec64e6eea0df15a5b243d8b87c Reviewed-on: https://code.wireshark.org/review/21568 Reviewed-by: Nicolas BERTIN <nicolas.bertin@al-enterprise.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-09Don't have epan_dissect_init() return anything.Michael Mann2-5/+4
It manipulates the epan_dissect_t structure passed into it and then returns that. Callers can (and have been) just using the passed in epan_dissect_t structure anyway. Change-Id: Ia19d360a7347ff473654eeb553756f59a38f95bd Reviewed-on: https://code.wireshark.org/review/21570 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 20:25:26 +0000