aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2012-08-10Use val_to_str_const() where appropriate;Bill Meier195-1751/+2429
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-08-10Add a missing NULL check pointed out by Jakub.Gerald Combs1-1/+1
svn path=/trunk/; revision=44437
2012-08-10Bug fixes and general cleanup;Bill Meier1-460/+464
- untermintated range-string array can/will cause crash (e.g. 'tshark -G values'); - remove all 'if (tree)': calling col_...() and sub-dissectors under 'if (tree)' not OK; - simplify code for heuristic test; - find_dissector() calls need to be done only once (not on each prefs callback); - do some whitespace/indentation changes. svn path=/trunk/; revision=44436
2012-08-10Make the corresponding packet_info available to each tree item. ThisGerald Combs7-31/+38
lets us pass a NULL pinfo to expert_add_info_format() and expert_add_undecoded_item(), which makes it possible to use those routines deep in the bowels of many dissectors. As a proof of concept remove the recent pinfo additions to packet-afp.c. This should also make it easier to fix bug 3884. svn path=/trunk/; revision=44435
2012-08-10Fix missing dissection of HSDSCH-Paging-System-InformationFDD (bug ↵Pascal Quantin1-20/+24
introduced in r44037) and HSDSCH-MACdPDUSizeFormat (bug introduced in r44423). While we are at it, fix a few typo errors. svn path=/trunk/; revision=44434
2012-08-10Subdissectors & etc shouldn't be under 'if (tree)';Bill Meier1-53/+51
Use val_to_str_const() as appropriate. svn path=/trunk/; revision=44429
2012-08-10General cleanup:Bill Meier1-1100/+1109
- Add svn:keywords and svn:eol-style properties; - col_...() and expert...() shouldn't be done under 'if (tree)'; - #if 0 an unused value-string; - Use val_to_str_const as appropriate; - Do some reformatting (whitespace changes). svn path=/trunk/; revision=44426
2012-08-10Try to make the buildbot happy.Anders Broman1-36/+28
svn path=/trunk/; revision=44425
2012-08-10From Jacob Nordgren and Rishie Sharma:Anders Broman5-980/+1421
RLC: changed so reassembly fail flag is set per channel instead of globally. RLC: added reset channel function Added support for reconfigurin HSDSCH flows, and E-DCH flows (just needs to figure out when it should become active for 'overloaded' ports), also changed slightly how ehs headers are configured in nbap. Removed extra (debugging) port in nbap This is the last patch set for a while. svn path=/trunk/; revision=44423
2012-08-10From Stephen Donnelly via ↵Jeff Morriss1-2/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7563 : Remove another invalid array write. svn path=/trunk/; revision=44419
2012-08-10From Jacob Nordgren and Rishie Sharma:Anders Broman1-39/+47
RLC: fixed weird dereferencing of things that were not pointers svn path=/trunk/; revision=44418
2012-08-10Looks like some packets in the sample trace have type 0,Jörg Mayer1-3/+18
so add Unknown_0 to the mix svn path=/trunk/; revision=44416
2012-08-10The packet id seems to be only 16 bits. The "extra" 4 bitsJörg Mayer1-17/+27
may be a subtype or additional information for the type. svn path=/trunk/; revision=44415
2012-08-10General cleanup:Bill Meier1-128/+128
- remove 'if (tree)' * col_...() shouldn't be called under 'if (tree)'; * new-style dissector should alwyas return same 'bytes dissected' (independent of 'if (tree)'); - create/use extended value string; - Use consistent indentation; svn path=/trunk/; revision=44414
2012-08-10convert some simple uses to use ephemeral memoryMichael Mann15-79/+34
svn path=/trunk/; revision=44413
2012-08-10Beginnings of a Skype dissector. Requires "decode as".Jörg Mayer3-0/+354
svn path=/trunk/; revision=44412
2012-08-10If not configured to call MAC for MAC-is PDUs, don't (avoidingMartin Mathieson1-2/+17
assertion). Do show extent of MAC-is PDU. Didn't it used to show the MAC-is SDUs inside too? svn path=/trunk/; revision=44411
2012-08-09Try to fix a compiler warning.Gerald Combs1-3/+3
svn path=/trunk/; revision=44408
2012-08-09Don't leak memory when loading UATs. Also reformat a bit.Jeff Morriss1-13/+23
svn path=/trunk/; revision=44407
2012-08-09Add a check for the number of nodes. Fixes a DoS in bug 7573 reported byGerald Combs1-2/+10
Ben Schmidt. svn path=/trunk/; revision=44403
2012-08-09Use wording that's more in line with other expert messages.Gerald Combs1-1/+1
svn path=/trunk/; revision=44402
2012-08-09Iterate over the emem_tree_*32_array key data instead of usingGerald Combs1-140/+67
recursion. I've only done minimal testing but it seems to work OK. svn path=/trunk/; revision=44401
2012-08-09call mpeg_pmt dissector directly for CI+ tune_broadcast_req apduMartin Kaiser1-18/+15
svn path=/trunk/; revision=44400
2012-08-09Not usre if this makes sense. At least the compiler doesn't complainMichael Tüxen1-14/+14
anymore. svn path=/trunk/; revision=44399
2012-08-09Don't define HAVE_UMTS_KASUMI to anything unless we actually have it.Jeff Morriss2-9/+12
Use #ifdef HAVE_UMTS_KASUMI instead of #if HAVE_UMTS_KASUMI Put $Id$ tag in kasumi.h svn path=/trunk/; revision=44398
2012-08-09Fix a couple of typos.Anders Broman1-4/+4
svn path=/trunk/; revision=44395
2012-08-09Small fixes:Pascal Quantin2-97/+100
- put back return NULL in line 947 that got removed in r44384: it is mandatory to avoid accessing non initialized variables. Change rlc_channel_assign a bit to fix what was the root cause of this removal (I guess) - put back add_channel_info in dissect_rlc_am (removed by error?) - fix some typo errors - fix indentation a bit svn path=/trunk/; revision=44393
2012-08-09Put #if HAVE_UMTS_KASUMI around a statics that won't be used unless itMartin Mathieson1-1/+4
is defined. svn path=/trunk/; revision=44390
2012-08-09Mark parameters as unused when we don't have kasumi.Anders Broman1-3/+4
Cast the result of strlen to int. svn path=/trunk/; revision=44388
2012-08-09Add Custom.common to dist.Anders Broman1-0/+1
svn path=/trunk/; revision=44387
2012-08-09General cleanup:Bill Meier1-213/+216
- remove 'if (tree)' around calls to col_...() fcns and to sub-dissectors; - call proto_get_id_by_filter_name() in proto_reg-handoff...() (not init routine); - do some whitespace and formatting changes. svn path=/trunk/; revision=44385
2012-08-09From Jacob Nordgren and Rishie Sharma:Anders Broman6-1915/+2217
FP: fixed so hsdsch type 1 also uses communication context id Added experimental conditional decryption support. svn path=/trunk/; revision=44384
2012-08-09From David Drysdale via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7551Alexis La Goutte1-4/+78
Add dissection of sub-options in DNS OPT RRs (RFC 2671) From me * use/prefer proto_tree_add_item * Remove dns_optcode_description function (Use value_string...) svn path=/trunk/; revision=44383
2012-08-09Use g_slice allocation for 'reassembled_table' keys (instead of se allocation).Bill Meier1-10/+10
Not strictly required, but IMO a bit cleaner (if maybe a bit less efficient). svn path=/trunk/; revision=44382
2012-08-09Make emem_tree_*32_array functions non-destructive. The following ↵Michael Mann1-9/+111
dissectors/files have affectively been bugfixed by the change: packet-classicstun.c packet-reload-framing.c (probably) packet-reload.c packet-sccp.c packet-sua.c packet-tcp.c packet-xmcp.c \epan\gcp.c The following files unnecessarily recreate keys because of the previously destructive nature of emem_tree_*32_array functions: packet-btl2cap.c packet-nfs.c packet-rpc.c packet-scsi-osd.c packet-stun.c (per Bug 7569) These could be cleaned up, but it's not like the key recreation is burning CPU cycles. svn path=/trunk/; revision=44380
2012-08-09From Stephen Donnelly: a better fix for the fuzz failure reported inJeff Morriss1-29/+29
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7563 : Previous patch solved the reported problem. This patch should cover input validation for the VC Id and Link Rate fields properly. Note link_rate==0 (unknown) is supported, as some hardware/firmware may not set this field, but vc_size==0 is defined invalid. From me: also initialize m_sdh_line_rate when the input is garbage. svn path=/trunk/; revision=44377
2012-08-09Bugfix 7608 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7608)Michael Mann1-4/+4
svn path=/trunk/; revision=44376
2012-08-09From Jacob Nordgren and Rishie Sharma:Anders Broman2-37/+29
FP: fixed exotic bug where fakes counter was sometimes not reset, RRC: fixed bug where num_chans_per_flow was not properly cleared svn path=/trunk/; revision=44375
2012-08-09 registered init routine action need be done just once in ↵Bill Meier1-8/+5
proto_reg_handoff...(); localize handle to proto_reg_handoff(); svn path=/trunk/; revision=44373
2012-08-09registered init routine actions need be done just once in ↵Bill Meier1-11/+6
proto_reg_handoff...(); localize two handles to proto_reg_handoff(); svn path=/trunk/; revision=44372
2012-08-09From Jakub Zawadzki: Fix for memory leak in reassemble.cBill Meier1-13/+33
Bug #4141 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4141#c10 svn path=/trunk/; revision=44371
2012-08-09Bugfix capture column preferencesMichael Mann1-13/+6
svn path=/trunk/; revision=44370
2012-08-09se_tree_lookup32_array() can destroy its key. Make sure we refresh itGerald Combs1-0/+6
before passing it to se_tree_insert32_array(). Fixes bug 7569 reported by Laurent Butti. svn path=/trunk/; revision=44366
2012-08-08Remove set-but-not-used variable.Jeff Morriss1-2/+0
svn path=/trunk/; revision=44365
2012-08-08Complete compiler warnings from r44348Michael Mann1-22/+1
svn path=/trunk/; revision=44364
2012-08-08Get it compiling on Mac OS X.Michael Tüxen1-2/+4
svn path=/trunk/; revision=44363
2012-08-08Compiler error fixes resulting from r44348Michael Mann2-109/+116
svn path=/trunk/; revision=44359
2012-08-08Various small changes:Pascal Quantin2-253/+238
- add a missing test on null pointer - always initialize rrc_nas_sys_info_gsm_map_type with a value from its associated enum - fix some typo errors - remove some useless directives from conformance file - detabify files (ASN.1 generated dissectors are indented with spaces) svn path=/trunk/; revision=44358
2012-08-08From Jacob Nordgren and Rishie Sharma:Anders Broman5-182/+583
- FP: added header CRC validation, added crc11.c and crc11.h in wsutil/ for EDCH 11 bit CRC, fixed bug in RRC, And also smaller bugfixes in umts_fp and rrc. svn path=/trunk/; revision=44349
2012-08-08Have (almost) all preferences use the generic preferences API (per ↵Michael Mann3-1186/+1187
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7402). This cleaned up a lot of hardcoded code and allows breaking up the prefs structure (or at least prevent it from growing too large) if desired. Bugfixed problems mentioned in http://www.wireshark.org/lists/wireshark-dev/201208/msg00001.html Column preferences now support default '#' character svn path=/trunk/; revision=44348
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-29 07:17:30 +0000