aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2015-04-23Use VALS_EXT_PTR to satisfy checkAPIs.Jeff Morriss1-1/+1
Change-Id: Ic7a7cfb97be5c3fbca5944328d04d505b54242ad Reviewed-on: https://code.wireshark.org/review/8176 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-04-23LPP: fix a typo in the protocol abbreviationPascal Quantin2-3/+3
Bug: 11141 Change-Id: I2bd00a84dd59bbcfc67bf6b8286cb49fd9ff01f9 Reviewed-on: https://code.wireshark.org/review/8175 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-23Add C15 Call History Protocol dissection (C15ch) dissectorMichael Mann4-0/+12304
Bug: 11063 Change-Id: I3daa9e6a75e52df1587678bd78f42e4e46fe4509 Reviewed-on: https://code.wireshark.org/review/7557 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-23Added syntax id 0x82 for NCK data accessThomas Wiens1-0/+184
Change-Id: Iaff4551f87fa8d74a09a99c3c772c8abbdf60198 Reviewed-on: https://code.wireshark.org/review/8168 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-23idl2wrs: don't use -1 for the protocol-item length.Jeff Morriss5-5/+5
It doesn't work any more for empty (length==0) PDUs. Similar to bug 10646/Ifb96768969a43c59367b73e7bb940ceeb02cf6b0 (for RPC). Untested as I'm not set up to build IDL dissectors now. Bug: 11134 Change-Id: I77aacc2590acbacbe02edb1768e754f92f87bc23 Reviewed-on: https://code.wireshark.org/review/8163 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-04-23Added decoding of BSEND/BRECV communicationThomas Wiens1-0/+53
Change-Id: Ie02f809e69cf9e7980d90ab02a2d4f34a465e0cd Reviewed-on: https://code.wireshark.org/review/8170 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-23Added display and filteroptions for byte- and bitaddressThomas Wiens1-1/+21
Change-Id: I48f39c148006e25fa98b75656cbb11496bce9d25 Reviewed-on: https://code.wireshark.org/review/8169 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-22Added transport size double-integerThomas Wiens1-0/+2
Change-Id: I3b5452ef8cfd4fac414b2c5bdd7926ea679b8029 Reviewed-on: https://code.wireshark.org/review/8167 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-22Convert proto_tree_add_boolean to ↵Michael Mann22-1114/+813
proto_tree_add_bitmask_[value|value_with_flags|list] Part 2 of a few Change-Id: Ic1f1aafe2ed02dce95b15c03a91cbd68807a5cf4 Reviewed-on: https://code.wireshark.org/review/8165 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-22Fix length calculation of IKEv2 REDIRECT notify with nonce dataTobias Brunner1-1/+1
Change-Id: Ia20569e89c3ae1d9ccdec73cc25c622e64117536 Reviewed-on: https://code.wireshark.org/review/8166 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-22Add VALS_EXT_PTR to decorate pointers to value_string_ext's in hfinfo.Jeff Morriss1-0/+3
This allows checkAPIs to continue checking the 'convert' field for correctness when dissectors use value_string_ext_new() to build their value_string_ext's (without resorting to tricks like getting the address of the dereferenced pointer). This will be used to resolve the checkAPIs failure in patch set 3 of Ia5c96b1f6f1fe3a9521b3d70142889e3881fae5e . Change-Id: I700d86b9076f077706d34000f5a6aa5c96351f69 Reviewed-on: https://code.wireshark.org/review/8162 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-22Add special handling of the (derived) AppId AVP type so that we can maintainJeff Morriss1-5/+33
one (and only one) Application ID list. This means we don't have to list all the Application IDs several times in the XML file. Collapse those lists into one (much more complete, now) list while also fixing URIs for several of the specifications (and making it clear for others that we don't have access to the specification--by declaring their URI to be "none"). Add a bunch more entries to the list of application IDs. Change-Id: Ia5c96b1f6f1fe3a9521b3d70142889e3881fae5e Reviewed-on: https://code.wireshark.org/review/8147 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-21Allow the definition of AVPs within vendor IDs.Jeff Morriss1-9/+16
This allows for a more natural organization of AVP definitions: they can now be grouped by application (including the base application) or vendor ID. This means we can stop using the "workaround" (for those vendors who define AVPs but don't have their own application ID) of finding some random application ID to put in a vendor-specific xml file just to satisfy the parser. Rework a couple of Vendor-specific xml files as an example. Note: this does mean that vendor IDs can no longer be defined inside of the base or other application. If that's a problem the parser could be made (through some duplication of code) to understand the old format too. Change-Id: I5119f0dc7f8e3bbf59e2207046a8bb0f42ab0ca1 Reviewed-on: https://code.wireshark.org/review/8141 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-04-21reassembly: address a 15-year old XXX commentEvan Huus1-2/+4
Question: "what if we didn't capture the entire fragment due to a too-short snapshot length?" Answer: An assertion fails and we leak a bunch of memory. Don't do that. Bug: 11129 Change-Id: I0adfb217f0e66ae8f5f6255a4caf7ff940826b59 Reviewed-on: https://code.wireshark.org/review/8128 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-04-20Don't use FT_STRINGZ for something that's not a string.Guy Harris1-1/+1
Change-Id: Idd2f0ab5237ab2596557214fe9853e7b2259a34d Reviewed-on: https://code.wireshark.org/review/8146 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-20Have a common routine to convert FILETIME to nstime_t.Guy Harris1-37/+1
We had several copies of that code; put it into a filetime_to_nstime() routine in wsutil, and call that common routine instead. Change-Id: I1eb5579c36c129ff8d23f9212285ab3f63be0f43 Reviewed-on: https://code.wireshark.org/review/8142 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-20OpenSafety: Fix Dead Store (Dead assignement/Dead increment) warning found ↵Alexis La Goutte1-4/+1
by Clang Change-Id: Iccd80450835946abbe68d66fb4ccbc1c799e6065 Reviewed-on: https://code.wireshark.org/review/8137 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-20sv: remove #if0'd codeEvan Huus1-98/+6
we can always get it back from git if we want Change-Id: I61911628541cf4ed4be20e736e41fbaa58978d75 Reviewed-on: https://code.wireshark.org/review/8124 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-20Make offset unsigned int. anilkumar9111-1/+1
Change-Id: Ieb7f8a7735b8dd73f180a385294c3b8ca7ceaefb Reviewed-on: https://code.wireshark.org/review/8060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-20The previous change doesn't work; do it right.Guy Harris1-1/+18
The correct bit has to be set in the value passed in; create a proto_tree_add_boolean64() that takes a 64-bit argument and use that. Change-Id: I28eaab38308baa908bdc1b043b2f0b87a17afe0d Reviewed-on: https://code.wireshark.org/review/8131 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-20replace some deprecated tvb_length callsEvan Huus7-11/+11
Change-Id: I18152e75aec2eedccad4d393c1b4b493cd7b406d Reviewed-on: https://code.wireshark.org/review/8125 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-20Make sure we handle Booleans even with the upper 32 bits set.Guy Harris1-1/+1
Just pass 1 or 0 to proto_tree_add_boolean() depending on whether the 64-bit value is non-zero or zero. Change-Id: I5b55c9aff4e559fb8e62bd96ae2b0b34e45189fa Reviewed-on: https://code.wireshark.org/review/8129 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-19Don't use proto_tree_add_uint() to add FT_BOOLEAN values.Guy Harris1-3/+31
In proto_item_add_bitmask_tree(), if use_value is true, base the routine we use to add the item to the tree on the type of the field being added. Also, use DISSECTOR_ASSERT_NOT_REACHED(), not g_assert_not_reached(), to catch types that aren't integral or Boolean. Change-Id: I6ff9867bddcae16ddf8b689b48fdc93c6f949105 Reviewed-on: https://code.wireshark.org/review/8127 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-19zbee: add support to ZigBee power configuration clusterJulien STAUB3-9/+463
Implemented full power configuration cluster according to 07-5123-04 ZigBee cluster library Change-Id: Ic9cb9894c2153ce53e2a2762967dbdc6a4a060c2 Reviewed-on: https://code.wireshark.org/review/8032 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Julien STAUB <atsju2@yahoo.fr> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-19rtcp.psfb.fmt DissectorTable does not work in Lua pluginPeng Li1-2/+12
Change-Id: I4e26ee5e4d9c1556d62ce01720e40848047c23e0 Reviewed-on: https://code.wireshark.org/review/8119 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-19[Automatic update for 2015-04-19]Gerald Combs2-5/+115
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Id9886f878c4d7422b779f1361fd9f7fcfb315982 Reviewed-on: https://code.wireshark.org/review/8120 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-19Ixiatrailer: Requires at least 15 bytes so change test in heuristic.Martin Mathieson1-2/+2
Change-Id: I00415fc77d2493eccdb3f0511f0a49d670e26d9d Reviewed-on: https://code.wireshark.org/review/8118 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-19openSAFETY: Implementing a tap interfaceRoland Knall2-356/+612
Implementing a tap interface as well as a packet structure which contains all necessary information from a single openSAFETY frame. This structure is located in a separate packet-opensafety.h so that plugins and other programs, which want to utilize the tap interface, may benefit from the same defines The 40bit calculation was implemented in a wrong fashion, so that it never calculated the correct UDID Change-Id: I62895f91d0a255a5489b9bf397a40d824a27383f Reviewed-on: https://code.wireshark.org/review/7275 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-19Bluetooth: OBEX: Dissect HeaderIDMichal Labedzki1-2/+74
HeaderID is bitfield in real. There is information about length-information in value part. Change-Id: Ib861f658c7b56e16df8a6514de69215138a1740d Reviewed-on: https://code.wireshark.org/review/8039 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-04-18Convert proto_tree_add_boolean to ↵Michael Mann17-1980/+789
proto_tree_add_bitmask_[value|value_with_flags|list] Part 1 of a few Change-Id: I413f23dfa92da5488ca8a7f62ca0738b25004635 Reviewed-on: https://code.wireshark.org/review/8117 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-18Bluetooth: OBEX: Add DecodeAs for profile-based Application ParametersMichal Labedzki1-54/+165
Application Parameters are defined in profile specification. If there is not enough infgormation to recognize profile user must have ability to do that manually. Also add expert info that packet is manually "Decoded As". Change-Id: I8a735d46d365d712995cd8cc00b2f46849c8afb4 Reviewed-on: https://code.wireshark.org/review/8044 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-04-18ZigBee: commissioning dissectionAlexis La Goutte1-11/+14
Miscellaneous corrections in ZigBee Green Power commissioning cluster dissection. Change-Id: I6aaf5f2c1ad5c70d1961709c0e94ab5c5af81ec7 Reviewed-on: https://code.wireshark.org/review/8094 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18GIOP: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+0
Change-Id: I5cd8fe72e6288578d4fa316096dfa606bf3e7aea Reviewed-on: https://code.wireshark.org/review/8116 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18GIAS: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I430e044d838b0d81bda15d3f8012b81f7247080e Reviewed-on: https://code.wireshark.org/review/8115 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18Bluetooth: OBEX: Fix Dead Store (Dead assignement/Dead increment) warning ↵Alexis La Goutte1-6/+6
found by Clang Change-Id: I5c260b6af14786119a324c3fed98178ddad01c6d Reviewed-on: https://code.wireshark.org/review/8114 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18Bluetooth: HFP: Fix Dead Store (Dead assignement/Dead increment) warning ↵Alexis La Goutte1-1/+1
found by Clang Change-Id: I1509a9ee9b136c15b5da8ff88fa6eadab3dd7f99 Reviewed-on: https://code.wireshark.org/review/8113 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18802.11 fix unchecked return value (CID 1293628)Alexis La Goutte1-1/+3
following ge243b0041 check the last add_tagged_field for avoid a Coverity warning (Yes the code is already safe..) Ping-Bug: 11110 Change-Id: Iaceb8cf9c91de426bc5e5408b4271091cab57862 Reviewed-on: https://code.wireshark.org/review/8084 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-18proto(.h): fix '@return' command used in a comment that is attached to a ↵Alexis La Goutte1-1/+1
function returning void [-Wdocumentation] Change-Id: Ice88ddf2d35293f23be2d5a61a6ae77ed540f886 Reviewed-on: https://code.wireshark.org/review/8107 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-16Fix spelling error.Guy Harris1-2/+2
Also clean up alignment. Change-Id: Ib1efb5f642489ea2ddfe2d129c083eda72551bad Reviewed-on: https://code.wireshark.org/review/8100 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-16ZigBee: dissection of commissioning frameAlexis La Goutte1-2/+2
Fix miscelleanous errors in ZigBee Green Power Change-Id: Ie5d379228a755ea09821148dc508108c6293da81 Reviewed-on: https://code.wireshark.org/review/8095 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-04-16giop: replace glib with wmemEvan Huus1-5/+5
One structure and one hash table with very simple uses. Fixes a memory leak. Change-Id: I727b7d5b0b17c2fcfaaad57797d11090e392253b Ping-Bug: 11123 Reviewed-on: https://code.wireshark.org/review/8088 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-04-16giop: fix uninitialized use of request idEvan Huus2-4/+3
Move the req_id field to the "message-dependent data" section of the header struct, since in the spec I found it is not specified in the common GIOP header (even though it appears to be present in all message types). Regardless, this better reflects the fact that it is not initialized by the primary tvb_memcpy, only the independent fields are. Initialize it and use it rather than creating a local for no reason; fixes the possibility of using it uninitialized. Bug: 11123 Change-Id: I3bae1df5123fbb1f2b86f7c42cee392b5b045c4f Reviewed-on: https://code.wireshark.org/review/8087 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-04-16Remove deprecated tvb_lengt APIsAndersBroman13-42/+42
Change-Id: Ic3c364384dcc1d87089d646665f5900081de13df Reviewed-on: https://code.wireshark.org/review/8089 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-16Replace deprecated tvb_length APIsAndersBroman16-68/+68
Change-Id: Idfd3bed012e823de544fe4de483c8f095fc7c65d Reviewed-on: https://code.wireshark.org/review/8086 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-15Fix gsmtap signal and snr.Anton Thomasson1-6/+6
-Correct parsrsing to get correct value (corect position in header). -Rename hf_gsmtap_noise_dbm to hf_gsmtap_snr_db to reflect use and name in struct. -Change order of decalaration/use of signal and snr to reflect position in struct. -Change registered types to signed to reflect possible values and definition in struct. Change-Id: I748bd19757c0dd87fe4ad0969dfcc8427b908aa2 Reviewed-on: https://code.wireshark.org/review/8077 Reviewed-by: Sylvain Munaut <246tnt@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-15Replcae deprecated API tvb_length with tvb_reported_length or tvb_capturedAndersBroman17-93/+93
length. Change-Id: Id42f3409a32e202528d350f7afde7376e411fc51 Reviewed-on: https://code.wireshark.org/review/8076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-15Replcae deprecated API tvb_length with tvb_reported_length or tvb_capturedAndersBroman7-33/+33
length. Change-Id: Ia1235c49b28320b5651e284115639820f81cb747 Reviewed-on: https://code.wireshark.org/review/8074 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-15ZigBee: fix IS_ANALOG_SUBTYPE macroJulien STAUB1-1/+1
Modify IS_ANALOG_SUBTYPE macro according to 07-5123-04 zigbee cluster library specification. It wasn't filtering out the 8-bit enums ans 16 bit enum (digital types). Bug: 11120 Change-Id: I74f1c0e6671b33fa69e5045cfc283ada3a39d380 Reviewed-on: https://code.wireshark.org/review/8069 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-14openSAFETY: Replace deprecated APIRoland Knall1-3/+3
Replace deprecated API functions tvb_length and tvb_length_remaining Change-Id: Ibf4c7b12a1a6ea3b1a750dce7faf2f4933b4c470 Reviewed-on: https://code.wireshark.org/review/8063 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-14Bluetooth: OBEX: Update to PBAP 1.2, GOEP 2.1, CTN 1.0 and GPP 1.0Michal Labedzki1-193/+1174
Add a lot of fields. Change-Id: If12a30b1840c0dbe934bc6af264a068935912832 Reviewed-on: https://code.wireshark.org/review/8043 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>