aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2018-04-14x509ce: fix display of IPAddress when it is an IPv6 AddressAlexis La Goutte3-20/+44
According to RFC 5280 (Section 4.2.1.6. Subject Alternative Name), an iPAddress can be either four (IPv4) or sixteen octets (IPv6). Bug: 14603 Change-Id: I6894f78c8e3f2a1b10940379397c87bbf981d4d6 Reviewed-on: https://code.wireshark.org/review/26891 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-13PDCP NR: add expert info for unknown / missing UDP framing tagsPascal Quantin1-2/+21
Change-Id: I1b71d30e5e6d5a63e14fc6daf8e2cca2b9b6f7f6 Reviewed-on: https://code.wireshark.org/review/26915 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13RLC NR: add an expert info for unknown UDP framing tagsPascal Quantin1-2/+15
Change-Id: I8a103840b3c795ce76c8a1af04a5751d6901e62f Reviewed-on: https://code.wireshark.org/review/26914 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13MAC NR: add an expert info for unknown UDP framing tagsPascal Quantin1-1/+14
Change-Id: I03013e02856508179d1d75ece5d5c215b947eeb4 Reviewed-on: https://code.wireshark.org/review/26913 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13PDCP LTE: add expert info for unknown / missing UDP framing tagsPascal Quantin1-3/+23
Change-Id: Iafeb49b529da4f62149124193326a4ff6c3960b9 Reviewed-on: https://code.wireshark.org/review/26912 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13RLC LTE: add expert info for unknown / missing UDP framing tagsPascal Quantin1-2/+20
Change-Id: I252c63f7104ce92de5d72e5e3ea40e3e45d76add Reviewed-on: https://code.wireshark.org/review/26911 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13MAC LTE: add an expert info for unknown UDP framing tagsPascal Quantin3-16/+26
Change-Id: I505e1df17d468c84f363c3be0ac5e2c29c85ca23 Reviewed-on: https://code.wireshark.org/review/26910 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13UMTS RLC: add expert info for unknown / missing UDP framing tagsPascal Quantin1-2/+21
Change-Id: I29dbeaf0d90bab4c10b4674bfa983f7f5f26027b Reviewed-on: https://code.wireshark.org/review/26909 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13kafka: raise the required version to 1.5.0 for lz4_frame.Dario Lombardo1-3/+3
Change-Id: I25619260572163872915c56bcf242e8ff8190b47 Reviewed-on: https://code.wireshark.org/review/26890 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-04-13file-pcap: expert info if captured len > reported lenMartin Kaiser1-1/+20
Bring up an expert info if the file contains a record whose captured length is larger than the reported length. Abort the dissection in this case since we rely on those lengths to find the next record. Change-Id: If249d0fe670373417bbfef6759edc0b020a9f5cb Reviewed-on: https://code.wireshark.org/review/26885 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-13Fix the length of the payload of a private_1 or audio PES packet.Guy Harris2-21/+111
The length field's value doesn't include the length of the length field itself. Change-Id: Icd0cc2721a32212296929d248b9305b0f4a051e6 Reviewed-on: https://code.wireshark.org/review/26920 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-12RoHC: IP version is 1 byte onlyPascal Quantin3-5/+7
Change-Id: I533b9d3ef37af9aa13a20c9af82a8a75cd73e9ad Reviewed-on: https://code.wireshark.org/review/26895 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-12PDCP NR: add SN length to PDCP context for user plane PDUsPascal Quantin1-0/+5
Change-Id: I49d215e65e424e605179747d350d4f36ccbc0d92 Reviewed-on: https://code.wireshark.org/review/26894 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-12PDCP NR: rework UDP framing formatPascal Quantin2-40/+42
Change-Id: I6f4a17ed91d4cb6ea39b5938add6ee882b033687 Reviewed-on: https://code.wireshark.org/review/26893 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-12Update a comment.Guy Harris1-18/+46
We don't just reassemble DOCSIS MAC frames, we reassemble other forms of higher-level packet atop an MPEG Transport Stream as well. Change-Id: If6e709a8d2d3e574fbaedb1fcac74797c5664aa5 Reviewed-on: https://code.wireshark.org/review/26905 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-12Need to flag a variable as volatile, due to the use of exceptions.Guy Harris1-3/+3
The exception mechanism is setjmp/longjmp-based, so we need to mark offset as volatile, otherwise the longjmp might not restore its value. Change-Id: Ib63070bbbbe1f16a93cb58aa7ee5ef2a5488df8a Reviewed-on: https://code.wireshark.org/review/26901 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-12If a subdissector throws an exception, catch it and continue.Guy Harris1-1/+30
That way, some exception thrown higher in the protocol stack doesn't stop us from dissecting the next TSP. Change-Id: Ib756e5d62806caf0edd4e4ded18bb94000653d39 Reviewed-on: https://code.wireshark.org/review/26897 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-11kafka: check lz4 version in a single point.Dario Lombardo1-4/+5
This allows a better check of the required version. Change-Id: I6c4aab67c73434aff4ad744caa2d0add9ec6225c Reviewed-on: https://code.wireshark.org/review/26889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11Netlink: Add rtnetlink attribute dissectingFilip Sohajek1-23/+396
This patch adds dissecting of several attributes in RTM_NEWLINK and RTM_NEWADDR. Change-Id: Iab476e7439a9bcbc25e70cded67bc371788baec4 Reviewed-on: https://code.wireshark.org/review/26830 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11LPP: fix a typo in ASN.1 filePascal Quantin1-1/+1
Change-Id: Id3189b5617aff853d85029624d7e160d48dd1f36 Reviewed-on: https://code.wireshark.org/review/26896 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-11PFCP: Added dissection of IEs 127-131Matej Tkac1-12/+79
According to 3GPP TS 29.244 v15.1.0 Change-Id: Idcaad3eccf0bd5c9cc57eca5038313fd14916963 Reviewed-on: https://code.wireshark.org/review/26859 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11user_encap: Avoid a hash lookup to get dissector nameStig Bjørlykke1-4/+4
The dissector handle is already known so it's no need to fetch this again using find_dissector(). Change-Id: Id48066ab881f2b80ec9e3a6e86bc1e41f32cd1ec Reviewed-on: https://code.wireshark.org/review/26873 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-04-11ZigBee: MGMT Unsolicited Enh NWKUpdate dissectorDana Sy3-0/+44
Added a dissector for the mgmt_nwk_unsolicited_enhanced_update_notify from the R22 spec (clusterID = 0x003b) Change-Id: I5d60ef0a762f932a7f814743d1c219428c8f9e73 Reviewed-on: https://code.wireshark.org/review/26865 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11zbee zcl: fill constant ett arrays at declaration timeMartin Kaiser1-106/+85
This dissector defines a bunch of ett arrays, most of which contain a constant list of ett entries. Fill those arrays directly when they're declared, this is what the vast majority of other dissectors do. Fix some whitspace things while at it. Change-Id: Iae85e2449024ef04b2a44bd847c45515f8efc903 Reviewed-on: https://code.wireshark.org/review/26869 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11zbee_zcl: (trivial) clean up decode_color_xy()Martin Kaiser1-2/+1
remove unnecessary return statement remove a wrong comment Change-Id: I40afd8144178a2cccba67289d5a3120dd5719ad0 Reviewed-on: https://code.wireshark.org/review/26868 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11pfcp: correction of lengthJoakim Karlsson1-2/+2
flags are uint8 but the whole list was set as uint16 Change-Id: I8726fe533253fd1339351f581e7a2fe01c0edce2 Reviewed-on: https://code.wireshark.org/review/26849 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Matej Tkac <matej.tkac.mt@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-11NBSS: take into account snaplen when creating the TVB subsetPascal Quantin1-4/+1
Otherwise you can trigger an exception interrupting the packet dissection when the snaplen defined is shorter than the payload length Bug: 14598 Change-Id: Ibeb6482495ed67c7669574bdcd7c429523318428 Reviewed-on: https://code.wireshark.org/review/26858 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-11Zigbee: Decode the ZCL extension field sets in the scenes cluster.Paul Zander2-6/+286
Change-Id: Ida564e8c292819508fd2dd0fb5b650e95356459a Reviewed-on: https://code.wireshark.org/review/26852 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-10Rename the last argument to tvb_new_subset_length().Guy Harris2-7/+7
In tvb_new_subset_length_caplen(), the captured length argument is backing_length and the reported length argument is reported_length. The length argument to tvb_new_subset_length() is a reported length, not a captured length, so call it reported_length, not backing_length. Change-Id: Ibfb30e15bdd885d3c0fd66e2b4b07c4a45327f14 Reviewed-on: https://code.wireshark.org/review/26863 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10"#if 0" out some currently-unused value_strings.Guy Harris1-0/+2
Change-Id: I1535b8ec430bbf119c6cc58464da820603454265 Reviewed-on: https://code.wireshark.org/review/26862 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Add, and use, "fetch signed value" for lengths < 40 bits.Guy Harris27-139/+266
Add 8-bit, 16-bit, 24-bit, and 32-bit "fetch signed value" routines, and use them rather than casting the result of the 8/16/24/32-bit "fetch unsigned value" routines to a signed type (which, BTW, isn't sufficient for 24-bit values, so this appears to fix a bug in epan/dissectors/packet-zbee-zcl.c). Use numbers rather than sizeof()s in various tvb_get_ routines. Change-Id: I0e48a57fac9f70fe42de815c3fa915f1592548bd Reviewed-on: https://code.wireshark.org/review/26844 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10NR (5G) PDCPMartin Mathieson5-1/+1786
Tested with some hand-generated PDUs. Change-Id: Ic603d0ca4578d23121e438ac2458be34e63492d2 Reviewed-on: https://code.wireshark.org/review/26755 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-04-10gsm_ipa: remove unnecessary if (tree) checksMartin Kaiser1-29/+21
Change-Id: I4d6bd9d296fcbd35551e3da9d60e20848865330b Reviewed-on: https://code.wireshark.org/review/26846 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-04-10RRC: upgrade dissector to v15.2.0Pascal Quantin8-3278/+4392
Change-Id: I874466e05bbc1ff11c286078b482de2f27eccf8b Reviewed-on: https://code.wireshark.org/review/26851 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-10Replace lbmpdm_fetch_uintN_encoded() with tvb_get_guintN().Guy Harris1-65/+20
They do the same thing. Change-Id: I0ff800efca9e6812ae416677023c955869bbc0cc Reviewed-on: https://code.wireshark.org/review/26850 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10PFCP: Added dissection of new IEs 123-126Matej Tkac1-23/+174
In accordance with the latest spec - 3GPP TS 29.244 v15.1.0 Change-Id: I1267590dc25ec946f4a33b5813b1a00deff357c1 Reviewed-on: https://code.wireshark.org/review/26826 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10The message length is unsigned, not signed; treat it as such.Guy Harris1-3/+3
Add explicit checks for values that don't fit in a gint, rather than relying on testing for < 1 catching that case. Change-Id: I4181087e3499537da88117b710d56c6b5fe9ceaa Reviewed-on: https://code.wireshark.org/review/26843 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Get rid of get_opaque_length() and unneeded length arguments.Guy Harris1-62/+36
In most calls to get_opaque_length(), the length is a constant, so just directly fetch the length value. In the calls in dissect_nodeid_list() and dissect_kindid_list(), the length is an argument to the routine making the call, and *those* arguments are, for each of the routines, the same constant for all calls to the routine in question, so just directly fetch the length value in those routines. This lets us avoid checks for a valid length-of-length, so we don't need to have the length-of-length be a signed value with -1 meaning "invalid". That's good, because nothing was actually *checking* for an invalid length-of-length. Change-Id: I58264c133977266f3214d6e4ca361f71ecc0b69a Reviewed-on: https://code.wireshark.org/review/26842 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Nb is an unsigned value; treat it as such.Guy Harris1-3/+2
Use proto_tree_add_item_ret_uint() to get its value, while we're at it. Change-Id: I734da5f588d9a89e810490d657c09b9ad2ff08dd Reviewed-on: https://code.wireshark.org/review/26841 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10Revert "Don't use static GMutexes."Anders Broman1-21/+7
This reverts commit ba3f29b62fcb362b5385b7e35691f0c466d811fd. Our minimum Glib level now supports this. Change-Id: I55a783b7aaa1ebfce8f2870d0c24768029ced39e Reviewed-on: https://code.wireshark.org/review/26838 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10MySQL: Add initial support for command 30 (binlog dump gtid)Daniël van Eeden1-1/+7
Change-Id: I1442e401e4b5dbd07ae16bd21944bfb10f54cf53 Reviewed-on: https://code.wireshark.org/review/26833 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09user_encap: Copy all user_encap_t valuesStig Bjørlykke1-1/+7
Copy all values for user_encap_t in user_copy_cb() when duplicating an entry in the DLT User table. Change-Id: Ic695a6213e12d42b62c2a0614c7f598e57833cdf Reviewed-on: https://code.wireshark.org/review/26827 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09ieee80211: fixes min and max power values in item text (they are signed).Adrian Granados1-2/+2
This change further extends the fix for bug 14593 by making sure the values min, max values shown in the item's info text match the item's children values. Change-Id: Ibac39e1f21a892a02753c3cf1604ed3b14eadc52 Reviewed-on: https://code.wireshark.org/review/26832 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-09gsm_ipa: Make sure the Osmo Extended IPA stream ID type is printedHarald Welte1-6/+6
Currently, each tree item of the IPA sub-tree will only list the IPA stream identifier. However, for the osmocom-specific sub-streams, this is always "OSMO EXT", which is not very informative. Make sure the tree item states something like "OSMO EXT GSUP" or "OSMO EXT MGCP" to indicate the actual payload type based on the osmocom sub-type. Change-Id: Ic1536574c8679de778d5b3cfc680b85284d1b503 Reviewed-on: https://code.wireshark.org/review/26795 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-04-09iso14443: make the payload dissector configurableMartin Kaiser2-2/+13
Add an iso14443.subdissector table where other protocols can register themselves for iso14443's payload. Register iso7816 dissector in this table. Change-Id: Idb17ae014449443448ec4c64017531bc69d806b3 Reviewed-on: https://code.wireshark.org/review/26821 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09iso14443: decode the bitrates in the attrib messageMartin Kaiser1-0/+28
Change-Id: I10bd77d72984fcf045a3c80e900c034393b444ae Reviewed-on: https://code.wireshark.org/review/26822 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-08Mark some fields as being in units of dBm.Guy Harris1-9/+9
Fix some formats to print unsigned values with %u while we're at it. Change-Id: If4a8793c77d4fbff0dd19f17e31cd18107db02ba Reviewed-on: https://code.wireshark.org/review/26810 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08No need to display *signed* power values in hex.Guy Harris1-2/+2
Change-Id: I8356dc3c2667a7bd55d3bb75b88f7ed758cecb72 Reviewed-on: https://code.wireshark.org/review/26807 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08Max and min transmit power, in the Power Capabilities IE, are signed.Guy Harris1-2/+2
To quote IEEE Std 802.11-2016, section 9.4.2.15 "Power Capability element": The Minimum Transmit Power Capability field is set to the nominal minimum transmit power with which the STA is capable of transmitting in the current channel, with a tolerance B1 5 dB. The field is coded as a signed integer in units of decibels relative to 1 mW. Further interpretation of this field is defined in 11.8.4. The Maximum Transmit Power Capability field is set to the nominal maximum transmit power with which the STA is capable of transmitting in the current channel, with a tolerance B1 5 dB. The field is coded as a signed integer in units of decibels relative to 1 mW. Further interpretation of this field is defined in 11.8.4. Bug: 14593 Change-Id: Ibc4e4a11d71ac1894d03d33f5762a7b0d1d70085 Reviewed-on: https://code.wireshark.org/review/26804 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-08mqtt: Add option to uncompress message when decodingStig Bjørlykke1-4/+30
Add support for uncompressing message data before dissecting based on topic. Bug: 14591 Change-Id: Ibaead205a4df791d8e903935dfd29b9b8c13ddc5 Reviewed-on: https://code.wireshark.org/review/26794 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com> Tested-by: Petri Dish Buildbot
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-20 07:47:00 +0000