Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I34d6fc5a59af7cfd39a1181e71788dfee617cc22
Reviewed-on: https://code.wireshark.org/review/15497
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
|
|
it is possible to have multiple reason on same tag
display the handshake failure reason (from crypto_handshake.h)
Change-Id: Ib388d3849292de00fa3d569936a20433bd2a0e89
Reviewed-on: https://code.wireshark.org/review/15479
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
|
|
Change coming with draft-02
Change-Id: I361ebcf1cdcbe8da30f1bf3e6ec0ae72f4756be2
Reviewed-on: https://code.wireshark.org/review/15476
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
|
|
Also update comment about RFC7830
Issue reported by Alex Mayrhofer
Ping-bug:11759
Change-Id: I4e70a32ddca6de43cb97f921b027e167170bf16d
Reviewed-on: https://code.wireshark.org/review/15017
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
|
|
From draft-drao-bgp-l3vpn-virtual-network-overlays
Change-Id: I0a0137b6a8b8fbb4b4efd6f5e08eba5ed6d7a9d6
Reviewed-on: https://code.wireshark.org/review/15477
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I289898207ae5c5b38e4567399b7e0f3b0b48aa9b
Reviewed-on: https://code.wireshark.org/review/15495
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: I59acb37250f6248e985482e4b972250e295fd638
Reviewed-on: https://code.wireshark.org/review/15469
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
If a standard setup response arrives without data, don't call a subdissector.
This can happen if a control endpoint STALLs.
This patch prevents the STALL response from appearing as a malformed packet.
Change-Id: I6f0e82487fae964e93a4291ccb3badbe652f7499
Reviewed-on: https://code.wireshark.org/review/15379
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: I640fd7c96c421bb7862021405cdb7a2c255ced21
Reviewed-on: https://code.wireshark.org/review/15473
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
apply a mask to get the lower 32 bit of a guint64
(there's no need for a right shift)
Change-Id: Ibcf685f6e58a5c5c4b96289d0c08e83d019301e7
Reviewed-on: https://code.wireshark.org/review/15489
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
apply a mask to get the lower 32 bit of a guint64
(there's no need for a right shift)
Change-Id: Ifa8281a64bb327bd9b8591cc2e54ee35ab15ae11
Reviewed-on: https://code.wireshark.org/review/15491
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
apply a mask to get the lower 32 bit of a guint64
(there's no need for a right shift)
Change-Id: Ia8c963dc0dd88f56c4ccaf0c37a1bd3d51d65d27
Reviewed-on: https://code.wireshark.org/review/15490
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
... only if we haven't figured it out yet
Do some other minor cleanup while at it.
Change-Id: I75d10b66a529c2043f17fced3e65f57ada993442
Reviewed-on: https://code.wireshark.org/review/15488
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
Change-Id: I57bdc87b062c8199bb174f94d301cc96f493da2a
Reviewed-on: https://code.wireshark.org/review/15487
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
There's no need to build a string by reading byte-by-byte.
Change-Id: I23223ec1188acbd2591817d66cc8f15d4eb25427
Reviewed-on: https://code.wireshark.org/review/15486
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
Use an offset variable, increment it as we walk through the packet. Use
tvb_reported_length_remaining() to see if we have more data.
Change-Id: I7048316ee418ff3e79e391295a29d9b221079847
Reviewed-on: https://code.wireshark.org/review/15485
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
which were copied from doc/packet-PROTOABBREV.c (or its predecessor)
Change-Id: I8f81d45cf7e9ad00378c965af663df8b64a9b591
Reviewed-on: https://code.wireshark.org/review/15484
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
As we know the field's length, we can skip to the next field even if the
length is invalid. There's no need to abort the dissection in this case.
Change-Id: I855427ca07f38c3041018a2d7ed9dbc15f1e9bd7
Reviewed-on: https://code.wireshark.org/review/15483
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
We either have a string or an integer. Use tvb_get_string_enc() to get
the string.
Change-Id: I84a83aed5eba57817e53bb194a8e01c273abf57a
Reviewed-on: https://code.wireshark.org/review/15482
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
The result of shifting a 32bit value by 32 bits is undefined.
Avoid all of the shift operations. Use the appropriate functions to get
the value from the tvb.
It seems that a manolito integer can be up to 5 octets. Use data types
large enough to store the possible values.
Change-Id: Icc1b538dbd7cdb27700140e9e5b81458b1047537
Reviewed-on: https://code.wireshark.org/review/15481
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
- Deal with short EnblocCallMessage coming from 7936
- SubscriptionStatReqMessage is shorter than previously known
- Use buttonType enum in FeatureStatV2Message and FeatureStatMessage
Change-Id: I0c4db5a0199ebb95bf807c858971d763faeef016
Reviewed-on: https://code.wireshark.org/review/15427
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Added dissectors for OPA Fabric Executive (FE) Header, OPA Snoop and
Capture (SnC) MetaData Header, OPA 9B Packets, and OPA MAD Packets.
Bug: 12114
Change-Id: I6acd3c9e266e4b638167abbdd275ec7c1d472b4f
Reviewed-on: https://code.wireshark.org/review/13473
Reviewed-by: Adam Goldman <adam.goldman@intel.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I6a8ea98cf0f4a2172e73fc4dcad67f2dbf8d5be3
Reviewed-on: https://code.wireshark.org/review/15471
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
The number of bytes allocated is small enough not to matter.
Change-Id: I44c2103a87bd41f21e61d0f27648266fdc2be557
Reviewed-on: https://code.wireshark.org/review/15470
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: Iee33c59d5b032f3c99ba16338195c050e8078329
Reviewed-on: https://code.wireshark.org/review/15472
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Add dissection of Diversification nonce (if QUIC Version >= 33)
Bug:11494
Change-Id: I448921db30174e47c30b3f60656ec3494f079c23
Reviewed-on: https://code.wireshark.org/review/15465
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I9a33c37658b48cf47d4f054658ac42fab99d7a43
Reviewed-on: https://code.wireshark.org/review/15466
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
type.
Change-Id: I7af0d89441b9ab87e9ed8dd0d52ca7f6ad82b896
Reviewed-on: https://code.wireshark.org/review/15458
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: Ifaf96e8482316720bddc5bab3aab3d0a677fe5fb
Reviewed-on: https://code.wireshark.org/review/15464
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Issue reported by boaz
Bug:12441
Change-Id: I1feb82615db65b0806c56425dd9f3cffdde463b4
Reviewed-on: https://code.wireshark.org/review/15461
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: I78253c35c84fed2e3f2775aa96798e29ae3b7bc3
Reviewed-on: https://code.wireshark.org/review/15460
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Iaa516108996e5087042c49ca3e076a6cc6b59eea
Reviewed-on: https://code.wireshark.org/review/15440
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
calls.
Change-Id: I23a013519f4a7f2c0a81f84a40045dd13c8b67f7
Reviewed-on: https://code.wireshark.org/review/15457
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Check the current length before adding the digit and not after
While we are at it, also switch to strbuf wmem buffer instead
Bug: 12442
Change-Id: If3e80e8446f527fe8fb013fbd57828f5572ca5ee
Reviewed-on: https://code.wireshark.org/review/15441
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
This allows for better expandability of future options
(and not having to add more boolean parameters or remove
obsolete ones)
Change-Id: I761bcfdbffe5b15c71dcd2a500e467b0f2c7a2fa
Reviewed-on: https://code.wireshark.org/review/15450
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: Ib43401fdd92e119d69c9c7b9dee365ea21658d2d
Reviewed-on: https://code.wireshark.org/review/15437
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Ping-Bug:11494
Change-Id: I3f0999049cd47f70154fdfbd3ca618c413dbea87
Reviewed-on: https://code.wireshark.org/review/15439
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
We don't only try and dissector only handshake
Change-Id: I92576cb7a6d8d3390d4a95d8e81db06d8698a77c
Reviewed-on: https://code.wireshark.org/review/15438
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
[-Wmissing-prototypes]
Fix also indent typo (replace tabs by spaces)
Change-Id: Ibb124c4fc7f175f0dd77331a25df30974bf71ec6
Reviewed-on: https://code.wireshark.org/review/15431
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I877a3018c81dc557453bf1e423c84578da47d74b
Reviewed-on: https://code.wireshark.org/review/15429
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
Wiretap support had already been added for old type variants COLOR_HASH_ETH and
COLOR_HASH_POS, dissect them like the other variants.
Change-Id: I60b83c50a258a27c31a498382c276bc4f4a34cbb
Reviewed-on: https://code.wireshark.org/review/15397
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I6c95e78d1248f8d604903952914d6cfc11432db6
Reviewed-on: https://code.wireshark.org/review/15420
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Ping-Bug:11494
Change-Id: I51f19c2e09f9503fa8a6a34933048bce3fef2803
Reviewed-on: https://code.wireshark.org/review/15419
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
we expect to find packet-tcp.h in the same directory as our dissector
Change-Id: I1bf027afbf810708e9f1428442d41b79708738cd
Reviewed-on: https://code.wireshark.org/review/15426
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
ccm_data can't possibly be NULL at this point
Change-Id: I30dcf902573a54e7efed864339f05e98bb666b20
Reviewed-on: https://code.wireshark.org/review/15425
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
|
|
Fixed warnings about Dead store / Dead assignment found by clang
analyzer.
Fixed encoding to be compatible to hf-type.
Change-Id: Iba93abe21f87029d53cd1db111b372cd4bd76229
Reviewed-on: https://code.wireshark.org/review/15418
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
From Guy via
https://www.wireshark.org/lists/wireshark-dev/201605/msg00027.html
Change-Id: I7884cecb6cd87f474ecc3f84253797fe57f62487
Reviewed-on: https://code.wireshark.org/review/15421
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
checkAPIs complains that the system member of the kingfisher_packet_t
structure shadows a system variable.
Althoguh this is a false positive, rename the variable to keep
checkAPIs happy.
Change-Id: Ia356dea5abb3ed93d10c5057f55786e2f28cec11
Reviewed-on: https://code.wireshark.org/review/15414
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
|
|
Change-Id: I3c5895d2e0671cdcd8063aa27356d49aa2bdbfa7
Signed-off-by: Tom Haynes <loghyr@primarydata.com>
Reviewed-on: https://code.wireshark.org/review/15416
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Trond Myklebust <trondmy@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Was fixed to pass. Let's keep it that way.
Change-Id: I49b532b6f1df2430b3912f8f1e9d518caff17d2c
Reviewed-on: https://code.wireshark.org/review/15413
Reviewed-by: Michael Mann <mmann78@netscape.net>
|