aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2016-05-13Have wmem conform to checkAPIs.plMichael Mann7-19/+20
Yes, the rename of structure members is a bit hacky. Yes, catering to Windows since "GLib's v*printf routines are surprisingly slow on Windows". But it does pass checkAPIs.pl Change-Id: I5b1552472c83aa2e159f17b5b7eb70b37d03eff9 Reviewed-on: https://code.wireshark.org/review/15404 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-13BACAPP: event-time-stamps decode fixLori Tribble1-1/+7
event-time-stamps decode when array-index is 0. Bug: 12422 Change-Id: I9f1f90e269352a49a8fc8a2ba2f64211f3cf7961 Reviewed-on: https://code.wireshark.org/review/15409 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-13jxta: there's no need to call proto_tree_set_visible() when calling ↵Jeff Morriss1-3/+0
append_text() It only needs to be called if you're calling proto_tree_append_string(). Change-Id: Ia00c3cb0077469ef6c2eadf98d02569af399fa7d Reviewed-on: https://code.wireshark.org/review/15411 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-13Add filterable fields for each ISUP number.Jeff Morriss6-712/+299
Make a common number dissection function to do this without cut-n-pasting code a whole bunch of times. Clean up the number dissection code while we're there: - Don't throw an exception when we found too many digits. Report it (expert info) and move on. - Avoid a useless (text) subtree: use the hf for the number as the root of the tree. This means using proto_tree_append_string() which adds some complication but it's worth it to avoid a hidden item (which was the old solution if we passed the number to the E.164 dissector). Bug: 12334 Change-Id: I465cab91b216b734f5763a4e56faa8e06b0731a2 Reviewed-on: https://code.wireshark.org/review/14924 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-12packet-nfs: add decoding and displaying of exclusive create attributesTigran Mkrtchyan1-0/+1
NFSv4.1 defines FATTR4_SUPPATTR_EXCLCREAT attribute which tells the client a bitmap of attributes which can be set during exclusive create. Wireshark did show that FATTR4_SUPPATTR_EXCLCREAT is provided, but doesn't show supported attributes. Bug: 12435 Change-Id: I29fc6beb2e75e9c78d68b1ca73a714bab2ad10a2 Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de> Reviewed-on: https://code.wireshark.org/review/15401 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-12BACAPP: Added dissection for NotificationParameterLori Tribble1-0/+36
Case 19 - change-of-reliability and related enums Bug: 11734 Change-Id: Ie40acc9d157adcf4d69b9cc57c6419daf8f6263d Reviewed-on: https://code.wireshark.org/review/15350 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-12ERF: In packet-eth register ERF_TYPE_ETH variants.Anthony Coddington1-0/+5
Register for: ERF_TYPE_COLOR_ETH ERF_TYPE_DSM_COLOR_ETH ERF_TYPE_COLOR_HASH_ETH Change-Id: I5877ca5721abaa269f937cca0414df4f6b1a5eef Reviewed-on: https://code.wireshark.org/review/15398 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11Run checkAPIs in epan/ .Jeff Morriss1-11/+8
It runs cleanly (no errors anyway) now. Change-Id: I1dca3a3f854c4f2feebcf4193e3c5d444a01e06b Reviewed-on: https://code.wireshark.org/review/15378 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11QUIC: for QUIC < 33, display CID flag with 2 bitsAlexis La Goutte1-1/+20
Change-Id: I943a40b7a942a6175d9b92cbb6060de34060459d Reviewed-on: https://code.wireshark.org/review/15269 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11QUIC: Add conversation support for store the versionAlexis La Goutte1-10/+33
Change-Id: Id9e2cc4a8b94ed91e35a6ab7610ab37ab2c41340 Reviewed-on: https://code.wireshark.org/review/15268 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11QUIC: fix dissection when num_timestamp = 0 and also reason phrase length ↵Alexis La Goutte1-18/+20
use little endian Change-Id: Id0158463b437face3412ec416f28d95b63ae4a07 Reviewed-on: https://code.wireshark.org/review/15302 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11ERF: Fix Ethernet FCS detection and remove preferenceAnthony Coddington2-8/+8
Use eth_maybefcs instead of eth_withoutfcs. ERF_TYPE_ETH records almost always have FCS, but using maybe means the "Assume packets have FCS" is respected. Mark the erf_ethfcs preference as obsolete. It was being ignored. This was broken by Change 3670 which changed the ERF dissector to use a dissector table. Change-Id: I45cffdaed3890f8a0f505b2011be8c5204d9b2a6 Reviewed-on: https://code.wireshark.org/review/15360 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11automake/nmake: don't run checkAPIs on lex and yacc files.Jeff Morriss2-4/+1
The lex files use malloc and friends which is prohibited; don't check them (until checkAPIs becomes smart enough to realize this is OK). This mirrors what is done in cmake. Change-Id: Ie80ea7a9b7c0e25c70c8edf3671e80a493ea1b2f Reviewed-on: https://code.wireshark.org/review/15377 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11TShark: Add a "-E bom=" option.Gerald Combs1-0/+21
Add an option to print the UTF-8 BOM. Change-Id: I3d30c67852b9b89d1548b0f957d97fd8e8741049 Reviewed-on: https://code.wireshark.org/review/15318 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-05-11Run checkAPIs in epan/ftypes/ .Jeff Morriss1-9/+8
Michael cleaned up the strcpy()'s which were preventing it from running without errors. Change-Id: I3f02150a9b1fbefddb67c0cb90fc2c58766d7d2a Reviewed-on: https://code.wireshark.org/review/15375 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11s7comm: block/file up-/download redesignThomas Wiens1-235/+1210
Redesigned the block/file up- and download, using new informations from PI-Services. Changed the block-info items, as it's in general a string, which can be further dissected if it's a PLC program block. Other types of Siemens automation hardware may use this as a simple filename for filetransfer. Changed the display-style for block name/number in info-column, to be more compact. Change-Id: Ie7c3a285d25897f8516ed8827041a5dbdf80679e Reviewed-on: https://code.wireshark.org/review/15275 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11Create IEC401 source TCP port preference.Jaap Keuter1-7/+27
In order to decode IEC401 over TCP/IP it's not always the case that the source port is the default 2404. Makeing this port a preference addresses the decoding issue and src/dst determination. Bug: 12407 Change-Id: Ifaee829e014a5e0ce449d047d9e0e44c470cd2f5 Ping-Bug: 10933 Reviewed-on: https://code.wireshark.org/review/15321 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-05-11Fix warnings for good ISUP messagesRustam Safargalin1-1/+1
Bug: 12423 Change-Id: Ie4bd0507677850317fda69b991d167948b241397 Reviewed-on: https://code.wireshark.org/review/15356 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11Decode the first 6 bytes of Unknown1 as Timestamp: Two recorded BeaconsJoerg Mayer1-3/+10
had the identical difference in the timestamp and unknown1 value, and the difference was almost identical to the beacon interval (102398 vs 102400us). Change-Id: Ic3fe8c1b52f3e9852ffdeae0fda79c5cb2e1482b Reviewed-on: https://code.wireshark.org/review/15368 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-05-11MRCPv2: do not update info column under tree checkPascal Quantin1-146/+146
Bug: 12426 Change-Id: I1921e6d409af3290862f41f07e95c2c5036bee80 Reviewed-on: https://code.wireshark.org/review/15364 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-11correctly decode EA Data Length in CIFSChristian Ambach1-1/+1
This field is little endian, not big. The SMB2 dissector already does it right. Change-Id: I859f581424be861fdcc1a586d085ba3bfe70a2f0 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-on: https://code.wireshark.org/review/15365 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-11Revert "Simplify val_to_str[_ext] implementation."Guy Harris1-2/+18
This reverts commit 1d0a97493280fd79d00e85a0971b3842d7f00e5e. This appears to be causing a crash - and the code in val_to_str() isn't just a copy of the code in val_to_str_wmem(), as it doesn't do a wmem allocation if try_val_to_str(), which *doesn't* use wmem, succeeds. Change-Id: I40e9e8b4ed0a1c66e20ab4bd827ac51c3fac85ff Reviewed-on: https://code.wireshark.org/review/15351 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-11Simplify val_to_str[_ext] implementation.Michael Mann1-18/+2
All val_to_str API use wmem, so just call the wmem function version passing packet_scope instead of copying it. Change-Id: Ib58b6b702fbaf5a81cc445bd01ef1a523774be6e Reviewed-on: https://code.wireshark.org/review/15348 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-11Remove strcpy from wmem_strbuf.cMichael Mann1-1/+1
This removes all strcpy calls from Wireshark provided code (only ones remaining are in lemon.c) Change-Id: I7a467fc3e10cc94c97196ecea3277a5375bc14b7 Reviewed-on: https://code.wireshark.org/review/15347 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10Give FvalueToStringRepr a length parameter.Michael Mann13-55/+55
This allows the conversion of a few straggler strcpy calls in ftype library. Also provides a more accurate size value instead of the many hard coded values the ftypes were using. Change-Id: Ia6273980432e16ad3a6233816a6054d9fed5d2a4 Reviewed-on: https://code.wireshark.org/review/15344 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10Have fvalue_to_string_repr always return an (wmem) allocated buffer.Michael Mann7-44/+47
Previous patches converted all fvalue_to_string_repr calls to expect an allocated buffer (and not a passed in one). Now changing signature to force an allocated buffer. Added wmem in case that can be taken advantage of within epan (and since the function signature was changing anyway). Change-Id: Ica1ac4a9a182ce0e73303856329e198d9d525b7b Reviewed-on: https://code.wireshark.org/review/15343 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10rawshark: Get "field string values" from existing functionality.Michael Mann2-0/+9
rawshark shouldn't be converting FT_ and BASE_ values into strings on its own, there's a function for that. Change-Id: Ib4ce1651ee130a03644b5de3ab471333444e19a9 Reviewed-on: https://code.wireshark.org/review/15341 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10enttec: CID 1355670 (same code for different branches)Martin Kaiser1-5/+2
else if and else branch do exactly the same thing - remove the else if Change-Id: If6017f2fdb960b5533d02f1f863070de95babdf5 Reviewed-on: https://code.wireshark.org/review/15339 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10Dynamically allocate the string for representing FT_IEEE_11073_[S]FLOAT.Michael Mann1-31/+22
Most uses of fvalue_to_string_repr() don't provide a buffer to write to, so memory is allocated dynamically inside the function. Trying to move to where ALL cases don't provide a buffer to simplify fvalue_to_string_repr handling and the underlying functionality of the ftypes. Change-Id: Iac03e4eb63b5e38311a6472fbe488009ed55206c Reviewed-on: https://code.wireshark.org/review/15331 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-10enttec: uups, I forgot some if (tree) checksMartin Kaiser1-10/+6
Change-Id: Id092b91408cdac9e490cb060a3d95e4a1d78e4e6 Reviewed-on: https://code.wireshark.org/review/15338 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-05-10enttec: remove some unnecessary if (tree) checksMartin Kaiser1-27/+23
Change-Id: Id108b0bacac377ad1f3fe7e999fb4d772bb69789 Reviewed-on: https://code.wireshark.org/review/15337 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-05-10iso14443 ats: show explicitly if TA(1), TB(1) and TC(1) are transmittedMartin Kaiser1-0/+21
Change-Id: I3f6e2bb73da901de0c6127564612fba86d49ddb4 Reviewed-on: https://code.wireshark.org/review/15335 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-05-10Sanity check eapol_len in AirPDcapDecryptWPABroadcastKeyMichael Mann1-1/+3
Bug: 12175 Change-Id: Iaf977ba48f8668bf8095800a115ff9a3472dd893 Reviewed-on: https://code.wireshark.org/review/15326 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Peter Wu <peter@lekensteyn.nl>
2016-05-10BGP-LS: fix Prefix-SID parsing, add SR-Capabilities and SR-AlgorithmFrancesco Fondelli1-3/+124
dissection. - 20 *rightmost* bits of the 'SID/Label' field represent a MPLS label (Adjacency-SID already fixed). - Add support for SR-Capabilities (TLV 1034) and SR-Algorithm (TLV 1035) dissection (draft-gredler-idr-bgp-ls-segment-routing-ext-01). Change-Id: Ib02137f1c41c4a201afee5d61cf2b6bf88d59991 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/15306 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-10cmake: fix build without LuaPeter Wu1-1/+8
Fixes this error: Objects of target "wslua" referenced but no such target exists. Change-Id: I1168dbff538fb62f614073c28aaba6e6666f499b Reviewed-on: https://code.wireshark.org/review/15329 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Léo Gaspard Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-09CID 1215245, 1215247: NULL check for the param of proto_get_id()Martin Kaiser1-1/+1
Change-Id: Ie1bcbffdc0040bf25e32c763185befb0231f4173 Reviewed-on: https://code.wireshark.org/review/15320 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-09Give the time_[m]secs_to routines names that begin with "[un]signed_".Guy Harris18-55/+55
Indicate whether they take a signed time delta or an unsigned time delta. Export unsigned_time_secs_to_str() while we're at it. Change-Id: I0fbe87f1825efa886364caa61a3358b79d285947 Reviewed-on: https://code.wireshark.org/review/15324 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-09Handle -2^31 as a negative time-in-seconds.Guy Harris1-46/+25
Its absolute value *is* expressible as an unsigned 32-bit value, so have time_secs_to_str_buf(), for negative values, just put a - at the front of the string and then pass the absolute value to time_secs_to_str_buf_unsigned(). Change-Id: I87252fe541d9aac4902f81493c9f032ec3ed1500 Reviewed-on: https://code.wireshark.org/review/15323 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-09Shuffle some routines to put absolute-time and relative-time code together.Guy Harris2-212/+224
Put the routines that handle absolute time ("relative to the Epoch") together and the routines that handle relative time together. Change-Id: I15256921091ab67a1d92026385bf1b27aa52b404 Reviewed-on: https://code.wireshark.org/review/15316 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-09format DIS header timestamp as mm:ss.nnnnnnalpartis1-1/+16
Older versions of this dissector displayed the header timestamp formatted to show minutes, seconds, and milliseconds past the hour (the DIS spec actually defines the timestamp in terms of microseconds). This commit fulfills a feature request to return to that format. Bug: 12402 Change-Id: Ide4adf8f80306f2458e48e8b2f78c911782669e5 Reviewed-on: https://code.wireshark.org/review/15276 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-09LAPDm: reset the last N(S) variable only during first passPascal Quantin1-1/+1
Change-Id: If496ca47f6e8b093511ee9a9a6834a49ef3553fa Reviewed-on: https://code.wireshark.org/review/15308 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-09LPADm: fixes for reassemblyPascal Quantin1-29/+54
- do not packets in error in reassembly table - filter retransmissions based on N(S) value See https://www.wireshark.org/lists/wireshark-users/201605/msg00000.html Change-Id: I0c2ab36acd5927529d40f8fa7fd2eed17a6fc486 Reviewed-on: https://code.wireshark.org/review/15281 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-09TShark: Convert TTY output.Gerald Combs1-1/+48
If we detect that we're writing to a TTY and that it doesn't support UTF-8, convert our output to the current code page on UNIX/Linux or to UTF-16LE on Windows. This helps to ensure that we don't fill users' screens with mojibake, along with scrubbing invalid output. Add a note about our output behavior to the TShark man page. Add a note about the glyphs we should and shouldn't be using to utf8_entities.h. Bug: 12393 Change-Id: I52b6dd240173b80ffb6d35b5950a46a565c97ce8 Reviewed-on: https://code.wireshark.org/review/15277 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-08Get rid of extra blank line.Guy Harris1-1/+0
Change-Id: Ibe35ee1dd8dcea5641e8cb8104c1fbf33966eca4 Reviewed-on: https://code.wireshark.org/review/15299 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-08Remove the MIBenum stuff from the WAP code.Guy Harris11-388/+471
MIBenum values are from an IANA registry, not a WAP specification; add <epan/iana_charsets.h> to declare the MIBenum -> Wireshark encoding mapper routine and the value_string_ext for MIBenum values, and epan/iana_charsets.c to define them. Change-Id: I6d9c82cd011bd5211c688322e6423de38e161f41 Reviewed-on: https://code.wireshark.org/review/15298 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-08GSM A RR: fix dissection of GPRS Cell Options IEPascal Quantin1-45/+52
As seen in the capture given in https://www.wireshark.org/lists/wireshark-users/201605/msg00007.html The extension length is not always equal to ll the options defined for a given release Change-Id: I68ba57dd384122eed1f1ff36cc8acc7ef029fcd0 Reviewed-on: https://code.wireshark.org/review/15290 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-08LAPSat: fix reported length for tvb subsetPascal Quantin1-1/+1
It seems like LAPSat can have have padding bytes as seen in the capture found here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9005 Change-Id: Ia2c7230c4c9fdae0bbe456585ab164f04eda0eb8 Reviewed-on: https://code.wireshark.org/review/15293 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-05-08Show MIBenum values for character sets as decimal.Guy Harris5-7/+7
http://www.iana.org/assignments/character-sets/character-sets.xhtml is the official IANA registry for character sets, including MIBenum values, and it shows MIBenum values in decimal, not hex, so show them in decimal, not hex. Change-Id: Id00a0d351a1f758401232aba621cc60aeccf360a Reviewed-on: https://code.wireshark.org/review/15292 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-08Handle the encoding when displaying the string table.Guy Harris5-39/+191
Don't just treate the strings as piles of ASCII characters. Add a proto_tree_add_item_ret_string_and_length() routine to help do this. Clean up some of the documentation of the proto_tree_add_item_ret routines while we're at it. Change-Id: Ib4c52bd8a8331eac97312583326f5be9175889d9 Reviewed-on: https://code.wireshark.org/review/15291 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-08The tabulation is specified by the stuff at the end.Guy Harris1-2/+0
I'm not sure what "4-space tabulation means", but: if it's "a tab character means 4 spaces", that's just *wrong* in a UN*X environment (Apple's mistaken use of "tab is 4 spaces" as the default in Xcode nonwithstanding - Xcode is just *wrong* there); if it's "use 4-space *indentation*", then the code should be reformatted and the editor hints updated. Change-Id: Ie8249b483fe9d6fcd8db29b72167eb854eec863e Reviewed-on: https://code.wireshark.org/review/15288 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 11:14:27 +0000