aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2014-06-18Fix compilation warningYan Burman1-2/+2
Change-Id: Ia7922415d8b22ba0c5a04ad6940c7e10bc205d57 Reviewed-on: https://code.wireshark.org/review/2371 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-18PDCP LTE: do not try to decipher PDCP control messages (like ROHC feedback)Pascal Quantin1-3/+6
Change-Id: I4a1596fd45bbc78ed8e90accf69ac048e7053161 Reviewed-on: https://code.wireshark.org/review/2366 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Replace glib memory with wmem memoryEvan Huus1-66/+25
Fixes potential memory leaks. Bug:8102 Change-Id: I88f9a74e3f782232d2da0bc7d83727dc3253f376 Reviewed-on: https://code.wireshark.org/review/2364 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Convert the obvious emem to wmem in lua code.Evan Huus4-8/+15
Bug:9927 Change-Id: Ibf0dd45d3b54e489b70a4fde193b825ec703379e Reviewed-on: https://code.wireshark.org/review/2349 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18TCP: do desegmentation sanity checks for all sub dissectors typesPascal Quantin1-23/+14
Change-Id: I02fe9827d8c1618f7dc6696e7d8667681a48d4a9 Reviewed-on: https://code.wireshark.org/review/2355 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Optimize tvbparse character set checking.Jakub Zawadzki1-61/+29
This patch makes tvbparse_[not_]chars() to generate array of characters which is accepted, later this array is checked in cond_chars_common(). This results in nice speedup of XML dissector (~33% for my file). Change-Id: I62a5585f8bccaaea1a0c49fc70c7552531493442 Reviewed-on: https://code.wireshark.org/review/2356 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17check for correct ftypeMartin Kaiser1-2/+4
Change-Id: I2274b97c74a845e6514e8acff136e55f721f11a8 Reviewed-on: https://code.wireshark.org/review/2354 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-17make dissect_ipmi_cmd() staticMartin Kaiser1-1/+2
Change-Id: Ie494a52fa73f7b91bc65da1bc36516f799ef4967 Reviewed-on: https://code.wireshark.org/review/2353 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-06-17Update a comment about how to better identify retransmissionsJoerg Mayer1-0/+2
Change-Id: Iec83f7e713a3077f1f4569aa86a55a69684b3097 Reviewed-on: https://code.wireshark.org/review/2351 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-17Set the rlc len field before we try to use it in an expert info.Evan Huus1-1/+1
Bug:9795 Change-Id: I740a9fe36278995cf6e590206f600c037789f0eb Reviewed-on: https://code.wireshark.org/review/2344 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17Initialize smb ioctl_function struct memberEvan Huus1-1/+2
Bug:10020 Change-Id: I415a29dd36697887cb06485d6ed3a2b799a93464 Reviewed-on: https://code.wireshark.org/review/2342 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17Initialize rq_hdr.sessionEvan Huus1-0/+2
Bug:10168 Change-Id: Ida4d82d102421152785ce680aa47bcb5cf8692f6 Reviewed-on: https://code.wireshark.org/review/2334 Reviewed-by: Dmitry Bazhenov <dima_b@pigeonpoint.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17ip version and header-length are not full byte values. Show theJoerg Mayer1-5/+4
bit decoding for these values. Change-Id: I7ab6c4badf5b66d6f434a47523e2b35730ecb65d Reviewed-on: https://code.wireshark.org/review/2338 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-17fix underflow in BER constrained bitstringsEvan Huus1-1/+1
this can happen and cause invalid memory accesses with incorrectly-large padding values Bug:10187 Change-Id: Ib9b2a2fa10766efb4d95d588f57354a56373c626 Reviewed-on: https://code.wireshark.org/review/2325 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17lua_pushstring takes a copy of its argumentEvan Huus1-2/+4
free the value we pass it, fixing a memory leak Change-Id: I446cb85d82a0697c24035461ad03450855b68884 Reviewed-on: https://code.wireshark.org/review/2304 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17Return number of bytes dissected in dissector:callStig Bjørlykke1-2/+4
This does not work for old-style dissectors as they always return the number of bytes in incoming buffer and not the number of bytes dissected. This is noted in the documentation. Change-Id: I5b236a73952cac3efc830e40276283bed9af1f87 Reviewed-on: https://code.wireshark.org/review/2237 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17Add dissect_nt_64bit_time_ex for retrieving the created proto_itemHannes Mezger2-5/+18
Using dissect_nt_64bit_time it is not possible to access the created proto_item afterwards, hence the new function. Change-Id: I39aca92536a53841045c30b601b6ec1a7d8bfb4e Reviewed-on: https://code.wireshark.org/review/2160 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17isakmp: add support for IKEv1 AES decryptionAlex Badea1-0/+15
Select an appropriate gcrypt cipher based on ISAKMP encryption ID and key length attribute. Fixes bug 10128. Bug:10128 Change-Id: Ie74fc51eb9bfe6d68340056d3ef2ef28c7677fb8 Signed-off-by: Alex Badea <abadea@ixiacom.com> Reviewed-on: https://code.wireshark.org/review/2296 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-17isakmp: allow IKEv1 decryption with non-PSK authenticationAlex Badea1-1/+0
There is a check that disables decryption for non-PSK authentication. It has been around ever since its introduction in commit acfe071e (svn r17229). As suggested in bug 7951, remove this check to allow decryption for e.g. certificates authentication. Bug: 7951 Change-Id: I5e98407d0f8dbabac2cdaf632cf0af403192872b Signed-off-by: Alex Badea <abadea@ixiacom.com> Reviewed-on: https://code.wireshark.org/review/2297 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17Add support for WRITE_LONG16 & REPORT_REFERRALS to scsi dissectorAnish Bhatt3-31/+136
Picking up leftover work on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8843 Change-Id: Ie3df55ae3309cf68f64b2aa184fb2904d1200cb5 Signed-off-by: Anish Bhatt <anish@chelsio.com> Reviewed-on: https://code.wireshark.org/review/2239 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17Fix copy/paste errors in value_string.Jakub Zawadzki4-4/+4
Also make repetition_coding_indications[] standard terminated. Change-Id: Ice20e1f27f5ab4d111f893608a230b83899efc9f Reviewed-on: https://code.wireshark.org/review/2288 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-17Convert tcap dissector to wmemEvan Huus1-14/+14
As far as I can tell these calls were just missed in the first initial pass, they're not in a weird scope. Close review from somebody else please to verify that! Change-Id: Ic3188879124dcb8fdf42e79d200d4f244200aa7b Reviewed-on: https://code.wireshark.org/review/2266 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16Add a FIXME referring to bug 4096Joerg Mayer1-1/+3
Change-Id: I4263d791e7bc7dc410d2735e94bc765aee2d84bc Reviewed-on: https://code.wireshark.org/review/2287 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-16More Python-bindings removal.Jeff Morriss2-27/+0
Change-Id: I4d82175781e65c73179f4c8e737a7900cb050bce Reviewed-on: https://code.wireshark.org/review/2283 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-06-16Add a cast to satisfy the buildbots.Jeff Morriss1-1/+1
Change-Id: I1c128db8a8b0cbbef01a26f7b3a50ed2b59af229 Reviewed-on: https://code.wireshark.org/review/2279 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-06-16fix format string typosEvan Huus1-3/+3
Change-Id: I470463ecfdd2d8facef93e09d6265a9d7ed868c8 Reviewed-on: https://code.wireshark.org/review/2274 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Fix copy/paste errors in stun attributes value_string[] array.Jakub Zawadzki1-3/+3
Found thanks to warning: ** (process:20239): WARNING **: Extended value string 'attributes' forced to fall back to linear search: entry 53, value 32858 [0x805a] < previous entry, value 32861 [0x805d] Change-Id: I12396380b42bbcb90dd139775c4b8d0bfdc79972 Reviewed-on: https://code.wireshark.org/review/2273 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16kill one last python remnantEvan Huus1-2/+0
Change-Id: I21ec54e59acc799ccb0799f06e95713a60f8e86d Reviewed-on: https://code.wireshark.org/review/2272 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16kill unmaintained python bindingsEvan Huus15-1323/+11
Change-Id: I1fa4f0d76b6b29d2935723b83b5ea7165039c807 Reviewed-on: https://code.wireshark.org/review/2258 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Have ipmi "dissectors" register through the build process instead of "manually"Michael Mann14-70/+45
Change-Id: I6d6d32e8a1bc21dee9bf52b502e1a02e9511ecb2 Reviewed-on: https://code.wireshark.org/review/2253 Reviewed-by: Dmitry Bazhenov <dima_b@pigeonpoint.com> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16packet-ipdc.c: proto_tree_add_text -> something filterable.Michael Mann1-48/+81
This appears to be a TLV architecture, not sure if the T and L should be broken up and filtered separately. Right now, just filtering on value. Change-Id: Ic5853d2216b6b5f845587e4b789435bed5fe60ff Reviewed-on: https://code.wireshark.org/review/2252 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16Register P_Mul as new-style dissectorStig Bjørlykke1-2/+4
Change-Id: Ic1f85475223d5ba36d9aa4ae617d6db450940fae Reviewed-on: https://code.wireshark.org/review/2268 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-06-16Register DMP as new-style dissectorStig Bjørlykke1-4/+7
Change-Id: I0491c9c5e817e31011e64aebc9010437581ba718 Reviewed-on: https://code.wireshark.org/review/2269 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-06-16Do not handle P_Mul packet as ASCII string when calculating checksum.Stig Bjørlykke1-1/+1
This bug was introduced when rewriting tvb_get_string() to handle encoding (and thus handling ASCII string different). Change-Id: Ic107d7b9e2f63aea33fdf55b9c20c22202f7b458 Reviewed-on: https://code.wireshark.org/review/2270 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> (cherry picked from commit fb0266fb244bf444a2801ee7ffc983f5a58621de) Reviewed-on: https://code.wireshark.org/review/2267
2014-06-16remove more unused codeEvan Huus2-83/+1
Change-Id: I7275aafe7d7216b85bbb34ba959b74358d102a91 Reviewed-on: https://code.wireshark.org/review/2255 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Convert more time_to_str functions to wmemEvan Huus7-34/+60
Change-Id: Ibaae0e79935dc62f12f713f2df5b57d0f3f799b9 Reviewed-on: https://code.wireshark.org/review/2254 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Add a preference to use Japanese ISUP TTC version with 13 bit CIC.AndersBroman1-2/+23
Change-Id: I98cb9f803378d69048ef94b7e3ad7d35b393733a Reviewed-on: https://code.wireshark.org/review/2260 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16Convert a bunch of time_to_str functions to wmemEvan Huus44-181/+222
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983 Reviewed-on: https://code.wireshark.org/review/2245 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16isakmp: support decryption for SHA-2 hash algorithmsAlex Badea1-0/+9
Simply map ISAKMP hash IDs for sha256, sha384 and sha512 to gcrypt MDs. Fixes bug 10181. Change-Id: I9c8265bf3c5c8f8d2fd6d251cc0f267964e3be8e Signed-off-by: Alex Badea <abadea@ixiacom.com> Reviewed-on: https://code.wireshark.org/review/2250 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-16glusterfs: correctly decode GFIDs that are passed in a dictNiels de Vos1-11/+13
When a dict structure is passed by GlusterFS, the values are not encoded normally. We now assume that the GFID in the dict is in network-order, but this will be incorrect for Big Endian systems. The majority of Gluster deployments are on Little Endian, and the GFID is displayed correctly for this case. I am sorry for the few users on Big Endian Gluster environments, they will see some GFIDs in Wireshark that don't exist on the Gluster volume. With this change, it is also made possible to filter on the GFID that is contained inside of the dict. Change-Id: I62a265eca34df23a507403397012cf652d43ca54 Reported-by: Vikhyat Umrao <vumrao@redhat.com> Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: https://code.wireshark.org/review/1856 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16Remove emem in SNMP UAT, use glib insteadEvan Huus1-116/+141
Change-Id: Ieea8c09d6a82285b0ba20f669c35394fbf195f50 Reviewed-on: https://code.wireshark.org/review/2241 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Remove last caller of se_strdup_printfEvan Huus2-23/+0
Also remove that function as it is now unused. Fix what appeared to be a memory leak in the manual address resolution dialog while in the neighbourhood. Change-Id: I75128ab0f95e5a7673f92bfeea45191f00581c25 Reviewed-on: https://code.wireshark.org/review/2244 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16Remove emem from ssl utils, use glib instead.Evan Huus1-14/+18
No exceptions can be thrown when loading a key from a file, so it's safe. Change-Id: I14ee8569bb516fcb45b72f07f76d28ef4b32065c Reviewed-on: https://code.wireshark.org/review/2243 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16Remove now-unused functions.Evan Huus4-42/+1
Change-Id: Iecf230d493b31ecab25b33c67323987459b23bd7 Reviewed-on: https://code.wireshark.org/review/2242 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16STUN: Add support of MS-TURNBWMAlexis La Goutte1-1/+179
Traversal using Relay NAT (TURN) Bandwidth Management Extensions http://msdn.microsoft.com/en-us/library/ff595670.aspx Change-Id: I58c7b758ae96226a45095243939b2ad2b4a91d4d Reviewed-on: https://code.wireshark.org/review/1973 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16Fix SDP dissector crash during fuzz testingYan Burman1-0/+3
Change-Id: Ic133dd9440feb61964d197fa0aaacd86241f229d Signed-off-by: Yan Burman <yanb@mellanox.com> Reviewed-on: https://code.wireshark.org/review/2248 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16iSCSI: Register iscsi dissector, so it can be used by iSERYan Burman1-0/+1
Change-Id: I78e487c14859b82d7e1d79f99a92c759c73fbda2 Signed-off-by: Yan Burman <yanb@mellanox.com> Reviewed-on: https://code.wireshark.org/review/2246 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-16Register BER dissector as new.Stig Bjørlykke1-5/+8
This makes it possible to dissect part of a package as ASN.1. Change-Id: I53dd6bc916fa0d2c932d77fef437c2094fdd29ed Reviewed-on: https://code.wireshark.org/review/2238 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Use tfs_f1_3_override_state to avoid unused variable errorStig Bjørlykke1-2/+2
Change-Id: I211f1bd2dcf61f27034e1e42e00ab3c1dc0c4c89 Reviewed-on: https://code.wireshark.org/review/2236 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-16Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+0
Change-Id: I17b5f3af2c4822805705fae9fdbb0375ba04acdd Reviewed-on: https://code.wireshark.org/review/2225 Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 06:57:31 +0000