aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2013-11-06Remove pinfo->private_data from DCERPC dissectors and instead have ↵Michael Mann82-28191/+27457
dcerpc_info* infomation be passed in as a function parameter. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) All "generated" source was manually modified (with the power of search/replace), but I believe the "source input" files have been adjusted (checked into revs 53098 and 53099) to reflect the necessary changes (with possible whitespace formatting differences). The Microsoft compiler doesn't flag "unused function parameters", so I apologize in advance if I may have missed a few. The "dcerpc_info* di" parameter is used in almost every function. svn path=/trunk/; revision=53100
2013-11-06Remove pinfo->private_data from DCERPC dissectors. Bug 9387 ↵Michael Mann4-96/+92
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) This is the "Wireshark DCERPC" input file changes necessary to support removing pinfo->private_data from the DCERPC dissectors in favor of passing it through function parameters. I didn't regenerate the dissector source, so this is just a "good faith" effort to mimic the manual changes. svn path=/trunk/; revision=53099
2013-11-06Remove pinfo->private_data from DCERPC dissectors. Bug 9387 ↵Michael Mann15-222/+180
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) This is the PIDL input file changes necessary to support removing pinfo->private_data from the DCERPC dissectors in favor of passing it through function parameters. I didn't regenerate the dissector source, so this is just a "good faith" effort to mimic the manual changes. svn path=/trunk/; revision=53098
2013-11-05Add missing cast.Evan Huus1-1/+1
svn path=/trunk/; revision=53096
2013-11-05Remove DISSECTOR_ASSERT since private_data isn't being used anymore to ↵Michael Mann1-2/+0
transport tcp_info data. svn path=/trunk/; revision=53093
2013-11-05From Zoltán Lajos Kis:Anders Broman1-0/+20
display present bit for vlan oxm field https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53092
2013-11-05From Zoltán Lajos Kis:Anders Broman1-16/+31
use tcp_dissect_pdus to properly dissect messages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53091
2013-11-05In an effort to reduce the use of pinfo->private_data (and some true global ↵Michael Mann12-359/+357
variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is. svn path=/trunk/; revision=53090
2013-11-05Replace pinfo->layer_names as a string with pinfo->layers as a wmem_list ofEvan Huus11-49/+68
protocol IDs. This is substantially more efficient, which means we can build it all the time rather than only if tree (in my benchmarks the extra time taken is not large enough to be statistically significant even over tens of thousands of packets). This fixes what was probably a bug in btobex that relied on layer_names for non-tree dissection. It also enables a much simpler fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9303 svn path=/trunk/; revision=53089
2013-11-05Expose wmem_list_remove_frame to make it efficient to do pop operations asEvan Huus2-0/+10
wmem_list_remove_frame(wmem_list_tail()) svn path=/trunk/; revision=53088
2013-11-05From Michael Labedzki, call data dissector instead if handle is NULL.Evan Huus1-2/+8
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9379 svn path=/trunk/; revision=53087
2013-11-05From J. Bruce Fields via ↵Alexis La Goutte1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9383 Incorrect FATTR4_SECURITY_LABEL value We got this constant wrong. See http://tools.ietf.org/html/draft-ietf-nfsv4-minorversion2-dot-x-19 and http://marc.info/?l=linux-nfs&m=138359828516861&w=2 svn path=/trunk/; revision=53086
2013-11-05Change "4 space tabs" indentation to use "4 spaces";Bill Meier1-402/+402
Clean up alignment of various structs & etc. svn path=/trunk/; revision=53085
2013-11-04Declare many value_string_arrays not used elsewhere as static;Bill Meier2-12/+14
IOW: Explicitly declare as global only those value_string_arrays used elsewhere. svn path=/trunk/; revision=53084
2013-11-04'#if 0' numerous unused value string arrays.Bill Meier1-0/+152
svn path=/trunk/; revision=53082
2013-11-04From Zoltán Lajos Kis:Anders Broman1-361/+264
tidying some stuff. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53079
2013-11-04From robionekenobi: Enhancement of the packet-mq dissector (WMQ 7.1-7.5)Bill Meier4-333/+531
Add more detail for SPI Open LPOO Structure Add more int_to_vals for INQ_Q_MGR reply Add more display detail for encoding value Some fix and display correction Note: The patch used was the *original* patch submitted (plus some fixes by me). That is: (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=11962) plus my fixes See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9367 and comments for details. From me: - Fix bug which resulted in a macro expansion fail on GCC - Fix a -Wshadow error in packet-mq-pcf.c svn path=/trunk/; revision=53078
2013-11-04Don't show the channel information twice in the protocol root proto_itemMartin Mathieson1-12/+2
svn path=/trunk/; revision=53077
2013-11-04Effectively remove the tree memory pool and port some of its behaviour to theEvan Huus3-31/+19
pinfo memory pool, they have exactly the same scope. Simplification and minor performance win (one GHashTable we longer have to create/destroy on every packet). svn path=/trunk/; revision=53076
2013-11-04Revert r53073, by now the vast majority of dissector do declare theJörg Mayer1-0/+9
registration functions and if we want to standardize it makes more sense to fix the remaining ones. svn path=/trunk/; revision=53075
2013-11-04From Peter Wu via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9373Alexis La Goutte1-0/+269
ieee80211: Decode Radio Measurements (Action Frames) The length of the fixed fields are dependent on the radio measurement action. Before this patch, fields following the action code were ignored, leading to wrong decoding results. This patch adds recognition for the Radio Measurement action management frames as specified in IEEE Std 802.11-2012. From me: * Rename some hf (Add ff_ in name) * Link Margin and Transmit Power are signed * Use always proto_tree_add_item (replace proto_tree_add_text) svn path=/trunk/; revision=53074
2013-11-03Remove forward declarations of registration functions.Jörg Mayer1-9/+0
svn path=/trunk/; revision=53073
2013-11-03Please checkAPIs.pl scriptPascal Quantin1-2/+2
svn path=/trunk/; revision=53072
2013-11-03Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9031 :Pascal Quantin1-5/+6
SIP contact-param parsing fails in case the last parameter includes a quoted string svn path=/trunk/; revision=53071
2013-11-03Try to clarify the documentation for tvb_length_remaining() and ↵Chris Maynard1-3/+4
tvb_reported_length_remaining() based on Jörg's recommendation from bug 9263. svn path=/trunk/; revision=53070
2013-11-03NULL terminate a value_strAnders Broman1-1/+2
svn path=/trunk/; revision=53069
2013-11-03From Zoltán Lajos Kis:Anders Broman1-21/+1130
dissect the rest of the messages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53068
2013-11-03Sync remaining patches with latest SAMBA PIDL source per ↵Michael Mann2-280/+513
http://www.wireshark.org/lists/wireshark-dev/201310/msg00217.html 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0016-Regenerate-the-dnserver.patch are now integrated, but modified to compile on Windows. I suspect the PIDL generators may need to be updated to support this, otherwise regeneration will break the build on Windows again. svn path=/trunk/; revision=53067
2013-11-03Bluetooth: AVDTP: Add support for Content Protection type SCMS-T (and some ↵Michael Mann6-118/+532
minor cleanup). Bug 7893 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893) From Michal Labedzki svn path=/trunk/; revision=53065
2013-11-03Fix what appears to be an off-by-one error in the IMAP dissector, causingEvan Huus1-1/+1
valgrind errors with the capture from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9263 svn path=/trunk/; revision=53062
2013-11-03Have rose_ctx_t passed into subdissectors instead of using pinfo->private_data.Michael Mann6-45/+44
svn path=/trunk/; revision=53061
2013-11-03Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=53058
2013-11-03Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=53057
2013-11-03Make Mac OS X buildbot happy (Missing _U_)Alexis La Goutte1-1/+1
svn path=/trunk/; revision=53056
2013-11-03Have asn1_ctx_t passed into the "h245.gef.name" and "h245.gef.content" ↵Michael Mann6-82/+76
subdissectors instead of using pinfo->private_data. svn path=/trunk/; revision=53055
2013-11-02Partially revert r53052 because hf_ fields aren't defined (or used)Michael Mann1-1/+8
svn path=/trunk/; revision=53054
2013-11-02Replace glib with wmem when constructing dynamic RADIUS fields. Fixes the memoryEvan Huus1-29/+25
leaks reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9370 svn path=/trunk/; revision=53053
2013-11-02Bluetooth: minor improvements. Bug 7893 ↵Michael Mann2-9/+44
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893) 1. AVDTP: Fix double decoded stream 2. AVDTP: Use items for logical block objects 3. HCI_USB use handoffed dissector handles instead of find_dissector() From Michal Labedzki svn path=/trunk/; revision=53052
2013-11-02Bluetooth: Use dissector data instead of pinfo->private_data. Bug 7893 ↵Michael Mann27-365/+347
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893) From Michal Labedzki svn path=/trunk/; revision=53051
2013-11-02Require dissector_try_string to pass a data parameter to its subdissectors. ↵Michael Mann33-132/+67
There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. svn path=/trunk/; revision=53049
2013-11-02Fix build (missing some _U_)Alexis La Goutte2-2/+2
svn path=/trunk/; revision=53048
2013-11-02Fix warning found by fix-encodings-arg toolAlexis La Goutte1-66/+66
svn path=/trunk/; revision=53047
2013-11-02Make checkAPIs Happy (Missing const for value_string)Alexis La Goutte1-3/+3
svn path=/trunk/; revision=53046
2013-11-02Prep a few more dissectors to receive their string data through dissector data.Michael Mann5-28/+46
svn path=/trunk/; revision=53045
2013-11-02get tcpinfo from dissector data, not pinfo->private_dataMichael Mann1-2/+2
svn path=/trunk/; revision=53044
2013-11-02From Zoltán Lajos Kis:Anders Broman1-143/+3092
dissect multipart request and reply messages https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53043
2013-11-02Allow json dissector to receive a string through dissector data and give ↵Michael Mann2-10/+18
dissector data priority over pinfo->private_data (to discourage it's use) svn path=/trunk/; revision=53042
2013-11-02Allow text-data dissector to receive a string through dissector data and ↵Michael Mann1-7/+15
give dissector data priority over pinfo->private_data (to discourage it's use) svn path=/trunk/; revision=53041
2013-11-02Remove rpc_defrag.hMichael Mann5-49/+9
Move the #defines to packet-rpc.h and pull the functions into packet-rpc.c since they aren't used by any dissectors. svn path=/trunk/; revision=53040
2013-11-02Mark unused arguments.Guy Harris2-2/+2
svn path=/trunk/; revision=53038