aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2014-10-10GTPv2: Presence-Reporting-Area-Elements-List do full dissection of ECGIAndersBroman1-47/+72
and TAI. Change-Id: I95d9ebf1d6f4eabe30b557fdc937d56006f8b123 Reviewed-on: https://code.wireshark.org/review/4593 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-10Fix some more int-to-enum conversion complaint.Guy Harris1-4/+10
While we're at it, log a message if a Lua file format module lacks a read or a seek-read routine, rather than completely silently ignoring that module if it claims a file. Change-Id: I9778f7835922439e2d3708614689280ef7b61d33 Reviewed-on: https://code.wireshark.org/review/4590 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-10CMake: Bundle our libraries.Gerald Combs1-0/+6
Change-Id: I5df4d794602f7e53c2f4f496597f8eaf7c7b6eaa Reviewed-on: https://code.wireshark.org/review/4588 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-10Add back a value_string conversion lost in g58cc452.Gerald Combs1-1/+1
I don't have a capture to check but this appears to be correct. Change-Id: I93405d1e3ec4aac3761d06e257db3ec2e32b2fc2 Reviewed-on: https://code.wireshark.org/review/4587 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-09Use an enum for the open-routine return value, as per Evan Huus's suggestion.Guy Harris1-6/+6
Clean up some things we ran across while making those changes. Change-Id: Ic0d8943d36e6e120d7af0a6148fad98015d1e83e Reviewed-on: https://code.wireshark.org/review/4581 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-09Kerberos: fix decryption of DCERPC with Kerberos encryptionPascal Quantin1-11/+12
Bug: 10538 Change-Id: I4e6feaf218da7f977f6c63d8bc204635f387672c Reviewed-on: https://code.wireshark.org/review/4566 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-09Kerberos: remove debug logs when loading a keytabPascal Quantin1-8/+3
Bug: 10543 Change-Id: I9ea20cd4d046cc072c21fd3f87f6d6be40b08b27 Reviewed-on: https://code.wireshark.org/review/4567 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-09GTPv2: fix an infinite loopPascal Quantin1-1/+1
Bug: 10548 Change-Id: I916e15cecf0ec9dc607362b902709567d69243df Reviewed-on: https://code.wireshark.org/review/4578 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-09Eliminate proto_tree_add_text from packet-lmp.cMichael Mann1-301/+251
Also "refactored" a few fields into proto_tree_add_bitmask calls. Change-Id: I3a222b38e1992943d6ee4bd300026bc28c5bbb78 Reviewed-on: https://code.wireshark.org/review/4575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-09Add Dissection of MA packets over UDPSean O. Stalley1-3/+14
Change-Id: Ic6e1cbb623f3e84b73ce7e4608f291baadc77bf6 Reviewed-on: https://code.wireshark.org/review/4576 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-09Eliminate proto_tree_add_text from packet-nbns.cMichael Mann3-238/+261
Some other cleanup while in the neighborhood. Not sure the all the proto_tree_add_expert calls are needed after each field (having implicit bounds error thrown should be sufficient), but left them in there. Change-Id: I3ca75ec9f51ccbed6b6ca792789daa8e7cebf34a Reviewed-on: https://code.wireshark.org/review/4574 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-09[BACnet][trivial] change strings as per Bug 9640Anish Bhatt1-2/+2
Change-Id: I542b5a96bcff6c779359b80ddce513524852272c Reviewed-on: https://code.wireshark.org/review/4572 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-09Lua: Improved TreeItem:add documentation.Stig Bjørlykke1-9/+13
The protofield is optional and can not be replaced with 'nil' as with the other fields for this function. Change-Id: I2b1dd7f290264394b400cea2110b65b657c71456 Reviewed-on: https://code.wireshark.org/review/4549 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-08Make sure we don't dereference a null pointer.Gerald Combs1-7/+21
Change-Id: I033c60cdc5b78f4db31903277c659661e0dc5123 Reviewed-on: https://code.wireshark.org/review/4561 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-08Fix a comment.Guy Harris1-1/+1
Change-Id: I0ebaa1b99bc9c7e51be10f3f8825280782f26190 Reviewed-on: https://code.wireshark.org/review/4560 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-08ANSI 683: Removed unused assignments.Stig Bjørlykke1-19/+0
Change-Id: I952ce5329f69fa947e39b020a70a06f2bbf8a014 Reviewed-on: https://code.wireshark.org/review/4558 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-08"long" does not necessary mean "64-bit". Use G_GINT64_MODIFIER.Guy Harris1-1/+1
Change-Id: I2521bf368ea30ac691af50c760a63b81efedeeae Reviewed-on: https://code.wireshark.org/review/4559 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-08DCERPC (DRSUAPI) Fix typo found on idl fileAlexis La Goutte2-9/+1
Change-Id: I79ad05122ae48de671c9c919bab6b3e8d94a50de Reviewed-on: https://code.wireshark.org/review/4554 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-08SIP Enhance dissecion of PATHJohan Wahl1-1/+51
Change-Id: I0508a886fb664f36b51464a9dfd6936092e197f8 Reviewed-on: https://code.wireshark.org/review/4543 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-08elmi: Fix bug in message type codingAnish Bhatt1-1/+1
Bug: 10531 Change-Id: Ide6237afb71c79243347dedd1c744b3e97ff612e Reviewed-on: https://code.wireshark.org/review/4542 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-08Remove #pragma warning (MSVC) for PIDL generate dissectorAlexis La Goutte18-122/+3
Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c Reviewed-on: https://code.wireshark.org/review/4479 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-08DCERPC DFS: Remove from Dirty PIDL listAlexis La Goutte2-3/+3
Change-Id: I87bd196d1c4ba14d9af6d174754b37d2b4d772c8 Reviewed-on: https://code.wireshark.org/review/4527 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-08[bacnet] update vendors list, fix whitespace issues, all generated via scriptAnish Bhatt1-23/+24
Change-Id: Ieb4b169dfcf5e89b7b2a2cb90b6572a3d973d744 Reviewed-on: https://code.wireshark.org/review/4519 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-08Add support for LISP over TCP control messagesLorand Jakab3-0/+417
draft-kouvelas-lisp-rloc-membership-00 specifies 9 new LISP control message types using TCP transport instead of UDP (which is used by all existing messages). These new messages are related to each other and are used to exchange RLOC membership information between a tunnel router and a map server. Bug: 10494 Change-Id: I129f0d6344693092bd5d0efb06b025e89fd26bf2 Signed-off-by: Lorand Jakab <ljakab@ac.upc.edu> Reviewed-on: https://code.wireshark.org/review/4253 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-07No need for WTAP_ERR_CANT_READ.Guy Harris1-6/+3
Unlike the standard I/O routines, the code we introduced that supports fast random seeking on gzipped files will always supply some specific error code for read errors, so we don't need WTAP_ERR_CANT_READ. Add WTAP_ERR_CANT_WRITE for writing, as we're still using the standard I/O routines for that. Set errno to WTAP_ERR_CANT_WRITE before calling fwrite() in wtap_dump_file_write(), so that it's used if fwrite() fails without setting errno. Change-Id: I6bf066a6838284a532737aa65fd0c9bb3639ad63 Reviewed-on: https://code.wireshark.org/review/4540 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-07ANSI683: Fix mobile country code baseEvan Huus1-1/+1
Fixes error: Field 'Mobile country code (MCC_T)' (ansi_683.mcc_t) is an integral value (FT_UINT16) but is being displayed as BASE_NONE Change-Id: I2d87075b0c982bcaf0e855653d49eb891e83b70d Reviewed-on: https://code.wireshark.org/review/4536 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-07GSM (bssmap): Fix Dead Store (Dead assignement/Dead increment) warning found ↵Alexis La Goutte1-2/+0
by Clang Change-Id: I9fadd0edc26e5525cfdd15fc62062f19fef16d10 Reviewed-on: https://code.wireshark.org/review/4526 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-07Overhaul the filterability of packet-ansi_683.cMichael Mann5-2307/+1068
It's (ab)use of proto_tree_add_text was "hidden" behind a single FT_NONE hf item, that effectively had the same behavior of proto_tree_add_text, but wouldn't show up in checkAPIs.pl. Replaced the (over 200+) proto_tree_add_none_format calls with proto_tree_add_text and then ran convert_proto_tree_add_text.pl on the dissector. That started the cleanup, and I did more while in the neighborhood. Change-Id: I89e09cf23e8998bcc9197f9a4043e1fc2850fc8c Reviewed-on: https://code.wireshark.org/review/4521 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-07[iSCSI] Fix incorrect heuristic.Anish Bhatt1-3/+5
The only valid check for Expected Data Transfer Length is : R and W MUST NOT both be 0 when the Expected Data Transfer Length and/or Bidirectional Read Expected Data Transfer Length are not 0 Bug #10469 Change-Id: I5503a5ad524c4e237b143696fc8eda895bcb9172 Reviewed-on: https://code.wireshark.org/review/4514 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-07ASN1: Added support for using #.REGISTER_NEWStig Bjørlykke5-50/+92
This will register BER PDU-dissectors as "new". Return number of bytes dissected from dissector_try_* functions. Return number of bytes dissected in DissectorTable:try() This will make it possible to get dissected length when using dissector_try_*() and dissected ASN.1 length in Lua when using DissectorTable:try() (as we already have for Dissector:call). Change-Id: Iee17a68dc214fa0fb50b25fc927026ad7c1cbce4 Reviewed-on: https://code.wireshark.org/review/4531 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-07Add proper decoding for type field in OBEX headersMichał Orynicz1-1/+12
Change type field type from byte sequence to string. Change-Id: I3e2ac6fbb5ce7187ba1183d63236e9a2bcd824ee Reviewed-on: https://code.wireshark.org/review/4417 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-07Revert "ASN1: Added support for using #.REGISTER_NEW"Gerald Combs5-92/+50
This temporarily reverts commit acc09c2aa248d892ee6b894b43c79cb060131b11. Change-Id: I7a55c8c2da3f65e914b90648ee92c84efd57f1a0 Reviewed-on: https://code.wireshark.org/review/4525 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-07ASN1: Added support for using #.REGISTER_NEWStig Bjørlykke5-50/+92
This will register BER PDU-dissectors as "new". Return number of bytes dissected from dissector_try_* functions. Return number of bytes dissected in DissectorTable:try() This will make it possible to get dissected length when using dissector_try_*() and dissected ASN.1 length in Lua when using DissectorTable:try() (as we already have for Dissector:call). Change-Id: I8802a812bd484c1e8794c618b87e676003aea94a Reviewed-on: https://code.wireshark.org/review/4493 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-10-07Dissect an SVHDX Open Device Context that appears as an Extra Create ParameterRichard Sharpe1-3/+153
in a CREATE request. This helps understand HyperV over SMB 3.x stuff. Bug: 10527 Change-Id: I1e206ed38e12fed419b1ac4a0793b91f9308f364 Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-on: https://code.wireshark.org/review/4477 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-07- Handle strings that have an opening but no closing quoteMartin Kaiser1-6/+11
fixes the endless loop reported in Bug: 10521 - Fix a typo. Change-Id: I17b4a15e780d1d6122841a308348518063f82a59 Reviewed-on: https://code.wireshark.org/review/4467 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-07[bacnet] update vendor listAnish Bhatt1-0/+80
Change-Id: I6b7bd3b3a110b8d393cd849c12890fff17446e54 Reviewed-on: https://code.wireshark.org/review/4515 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-07PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang ↵Alexis La Goutte6-8/+8
Analyzer packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized] Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f Reviewed-on: https://code.wireshark.org/review/4478 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-07idl2wrs (DCERPC DRSUAPI): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte2-4/+12
warning found by Clang Add a check if the struct is not empty budb and butc are also regenerate but no change Change-Id: I0d8cfc827f5451f1cdbd924628a263af9d483a7b Reviewed-on: https://code.wireshark.org/review/4473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-06Revert "Qt: Try to fix a Visual C++ encoding warning."Gerald Combs2-2/+2
Revert gafa8c02 since it didn't work on Windows. Use a pragma to squelch Visual C++ instead. Qt's rich text renderer doesn't handle "&apos;". Replace it with "&#x27;". Remove a QDebug include. Change-Id: I0e6308efda74a4bc0e67ce841a50a0a9b68f4a8b Reviewed-on: https://code.wireshark.org/review/4511 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-06Qt: Packet list column sorting.Gerald Combs1-0/+8
Sorting behavior should be identical to GTK+. Pass the correct position to beginInsertRows. Add a list of to-do items to packet_list.cpp. Change-Id: Ie6ab4b9f2d780a2af430d0f90529edca5485dada Reviewed-on: https://code.wireshark.org/review/4481 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-06Convert "4 space tabs" to spaces; Adjust editor modelines.Bill Meier3-1174/+1174
Change-Id: I8d61d959c79e6aa9875c58680c54a331d18079cc Reviewed-on: https://code.wireshark.org/review/4504 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust indentation to match editor modelines; Do other minor whitespace changes.Bill Meier36-4407/+4413
Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353 Reviewed-on: https://code.wireshark.org/review/4502 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-rpcap.c: Don't use mixed space/tab indentation;Bill Meier1-124/+124
Change-Id: I21409a02fabc28951d9c15be7a160295f5fb35ca Reviewed-on: https://code.wireshark.org/review/4501 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust editor modelines to match actual format of the file; Adjust some ↵Bill Meier2-76/+74
whiotespace. Change-Id: If930f2c266b61c9348063eab0189af2582b0a331 Reviewed-on: https://code.wireshark.org/review/4500 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Convert (what appear to be) "4 space tabs"; Adjust editor-modelines; Do some ↵Bill Meier3-3497/+3505
minor reformatting. Change-Id: Ie078c826ed38a0d682f61fb3e95450b47a9d2c31 Reviewed-on: https://code.wireshark.org/review/4499 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-g723.c: Remove some boilerplate comments.Bill Meier1-17/+1
Change-Id: Ib322b33c304674835170e1ae2006aabf0f44fd9d Reviewed-on: https://code.wireshark.org/review/4498 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-hclnfsd.c: Reformat hf[] entries; Adjust some whitespace.Bill Meier1-98/+122
Change-Id: I84368080d12cb5001dd7847add0ec96608080604 Reviewed-on: https://code.wireshark.org/review/4497 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-q931.c: Reformat hf[] entries; Convert apparent "4-space tabs" to ↵Bill Meier1-2721/+3057
spaces. Adjust editor modelines. Change-Id: Iaeb321f0facfc6b3176677779e6cdf5c92226dec Reviewed-on: https://code.wireshark.org/review/4496 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Dissect 3GPP AVP Presence-Reporting-Area-Elements-List.AndersBroman1-19/+46
Change-Id: Ic7b99d41a275fb6f50758ea87763844f24be537c Reviewed-on: https://code.wireshark.org/review/4495 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-06tcp: default no-subdissector-on-error to TRUEEvan Huus1-1/+1
Dissectors that need this set break badly when it isn't. Dissectors which don't need this set will still generally be understandable without it, since e.g. retransmissions will link to the original packet at the TCP layer, and presumably the subdissector payload is exactly the same in that case. Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603 Ping-Bug: 10525 Ping-Bug: 10289 Reviewed-on: https://code.wireshark.org/review/4487 Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 04:59:56 +0000