aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2014-09-29Remove duplicate packet-dcerpc-mapi.c.Guy Harris1-4/+1
Change-Id: If2ffd01c29777840db8e305bee9565efaa58d253 Reviewed-on: https://code.wireshark.org/review/4362 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-29PIDL (DCERPC mapi): enhance dissectorAlexis La Goutte4-937/+431
Correctly regenerate mapi dissector (launch via make in pidl/mapi folder) * Fix -Wunused-variable (fix in request/response.cnf files) * Fix trailing whitespace Not yet ready to remove from DIRTY list (there is always some warning about unused tree) Change-Id: I9759202e320e90f0cb91db5c7dd9650ff62bbadd Reviewed-on: https://code.wireshark.org/review/4347 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29PIDL (DCERPC mdssvc): enhance dissectorAlexis La Goutte4-21/+7
* Fix -Wunused-function (Add functions to mdssvc.cnf with NOEMIT) * Remove dissector DCERPC mdssvc from DIRTY list Change-Id: Ic097b0067a44fcfd9298ace1abeb7ca8f0daf00b Reviewed-on: https://code.wireshark.org/review/4346 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29Remove proto_tree_add_text_valist from dissectors.Michael Mann4-254/+135
The only remaining call to proto_tree_add_text_valist is in expert.c. Suggestions welcome on how to make it "private" enough so dissectors can't use it. Change-Id: I1b70789bd01a857c3ac06d198667aeb59c4d1be9 Reviewed-on: https://code.wireshark.org/review/4333 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29Fix lua bindings to handle timestamp precision changesEvan Huus2-2/+11
The recent wiretap changes broke the generation of init.lua among other things, though it did coincidentally fix one of the "yuck" comments in the generator regex. (Note that this is entirely untested, because out-of-tree init.lua is and always has been broken, but it should work) Change-Id: Id0c27b31c596613997de4ba2f6088eb9d6c8fc53 Reviewed-on: https://code.wireshark.org/review/4361 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-29mrcpv2: don't use an uninitialized buffer as a stringEvan Huus1-4/+2
I have no idea what the original intent was with this magical otherwise-totally-unused buffer, but it clearly serves no purpose now. Stop reading garbage from it, and just read the data in the packet which is what the field name suggests. Bug: 10510 Change-Id: I05d0b98c04e59ea70247811168c4c8a64861f43d Reviewed-on: https://code.wireshark.org/review/4352 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-28PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte2-8/+0
Change-Id: Ibae478771b30d6e9ae07315985f1e71bc6b65423 Reviewed-on: https://code.wireshark.org/review/4350 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28Stanag 4607: rename protocol abbreviation from 4607 to s4607 to avoid any ↵Pascal Quantin1-108/+108
collision with a frame number Bug: 10509 Change-Id: I6b97c979ed05378a7d3495fe455bc36b82b19cc9 Reviewed-on: https://code.wireshark.org/review/4338 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-28Make the time stamp resolution per-packet.Guy Harris7-139/+227
Pcap-ng files don't have a per-file time stamp resolution, they have a per-interface time stamp resolution. Add new time stamp resolution types of "unknown" and "per-packet", add the time stamp resolution to struct wtap_pkthdr, have the libwiretap core initialize it to the per-file time stamp resolution, and have pcap-ng do the same thing with the resolution that it does with the packet encapsulation. Get rid of the TS_PREC_AUTO_XXX values; just have TS_PREC_AUTO, which means "use the packet's resolution to determine how many significant digits to display". Rename all the WTAP_FILE_TSPREC_XXX values to WTAP_TSPREC_XXX, as they're also used for per-packet values. Change-Id: If9fd8f799b19836a5104aaa0870a951498886c69 Reviewed-on: https://code.wireshark.org/review/4349 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-28packet-netflow.c: Do various fixes and changesBill Meier1-992/+696
- Allow integer & float fields to have "reduced size encoding"; Fixes Bug #8846; - Add a missing cflow field-type; - Update the names of a few cflow field-types; - Replace all-but-one use of proto_tree_add_text(); - Fix encoding-args as appropriate; - Remove some obsolete comments; - Adust whitespace/indentation/formatting. Change-Id: I4271e3692288cef3ea0f1aa5eb44f5a0b05c29da Reviewed-on: https://code.wireshark.org/review/4348 Petri-Dish: Bill Meier <wmeier@newsguy.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-28PIDL (DCERPC lsa): enhance dissectorAlexis La Goutte4-69/+15
* Fix -Wunused-function (Add functions to lsa.cnf with NOEMIT) * Remove also some MANUAL function (no unused too..) * Remove dissector DCERPC lsa from DIRTY list Change-Id: I7b7f924f244757207f378b8650b8dd30e739da08 Reviewed-on: https://code.wireshark.org/review/4325 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC eventlog): enhance dissectorAlexis La Goutte4-21/+4
* Fix -Wunused-function (Add functions to eventlog.cnf with NOEMIT) * Remove dissector DCERPC eventlog from DIRTY list Change-Id: I29710ce4f548a6e4d9bf1dd6e652acf1eeaddf2c Reviewed-on: https://code.wireshark.org/review/4324 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC dnsserver): enhance dissectorAlexis La Goutte4-28/+7
* Fix -Wunused-function (Add functions to dnsserver.cnf with NOEMIT) * Remove dissector DCERPC dnsserver from DIRTY list Change-Id: Id1d4f43784bfbf417156353fd3254375365c35c8 Reviewed-on: https://code.wireshark.org/review/4323 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL (DCERPC winreg): enhance dissectorAlexis La Goutte4-24/+12
* Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector) * Fix indent (use tabs) * Remove DCERPC winreg dissector from DIRTY list Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7 Reviewed-on: https://code.wireshark.org/review/4322 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL: fix -Wmissing-prototypeAlexis La Goutte19-1042/+1556
Change-Id: I4cae47450e8026b10bd373828f235184560e0a99 Reviewed-on: https://code.wireshark.org/review/4308 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28[Automatic manuf, services and enterprise-numbers update for 2014-09-28]Gerald Combs2-4/+189
Change-Id: I7604c01a061f4832e53aa88903a53c1d6a50e4dc Reviewed-on: https://code.wireshark.org/review/4339 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-09-28New dissector for KNXnetIP protocolalage3-0/+1801
Bug:10403 Change-Id: I8c733ce69e6d44d1bff0ebbe72995f06212d9d93 Reviewed-on: https://code.wireshark.org/review/3828 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-27PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte13-30/+29
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-27Make get_column_longest_string() static.Guy Harris2-15/+13
It's not used outside epan/column.c, so don't export it. Change-Id: I38e084946d92f3c31b06fc4fc1991c88e652f58a Reviewed-on: https://code.wireshark.org/review/4334 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-27Get rid of g_hash_table_lookup asserts when loading an external host filePascal Quantin1-21/+24
Only parse the host file syntax without trying to store the names in the hash tables (it will be done later in host_name_lookup_init()) Change-Id: I2b8c7b29220e6413c1b5c0a0fa238ecb5388c962 Reviewed-on: https://code.wireshark.org/review/4309 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-27Eliminate proto_tree_add_text from some dissectors.Michael Mann18-761/+901
Some other related cleanup. Change-Id: I45f54032aa8318858f4ee784945b6f2ed163b6ea Reviewed-on: https://code.wireshark.org/review/4328 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27Added support ofSimon Zhong1-71/+550
- "PCEP Extensions for Stateful PCE" (draft-ietf-pce-stateful-pce-09) - "PCEP Extensions for PCE-initiated LSP Setup in a Stateful PCE Model" (draft-ietf-pce-pce-initiated-lsp-01) - "Optimizations of Label Switched Path State Synchronization Procedures for a Stateful PCE" (draft-ietf-pce-stateful-sync-optimizations-01) checkAPIs.pl executed, got "deprecated APIs tvb_length" warning, but I didn't modify them because I saw reverse operations. Fuzz test executed, no error. Can't submit pcap file because is captured during internal test. Change-Id: I063a7f6bda57543017b546506f9f89eda387daf6 Reviewed-on: https://code.wireshark.org/review/4275 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27Regenerate PIDL dissectors with our current PIDL.Guy Harris14-5636/+5636
Change-Id: I63a1874d157c55df6c3c3f69c68098528adbb384 Reviewed-on: https://code.wireshark.org/review/4330 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-27"declare" apparently isn't a valid keyword; use typedef instead.Guy Harris2-3/+3
These changes came from the versions of those files at the tip of the Samba trunk, and fix the failures to compile with pidl. Change-Id: Ifc3276d4bc2ff1cfdb19819811f5b8d1b91961b5 Reviewed-on: https://code.wireshark.org/review/4329 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Note that errors are generated for dnsserver.idl and eventlog.idl.Guy Harris1-2/+6
Also fix a typo. Change-Id: Id0713fbb722e88a911cae4ef4371b528fe73e048 Reviewed-on: https://code.wireshark.org/review/4321 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-26Modbus: Add value 90 (0x5A) used by Unity (Schneider)Alexis La Goutte2-0/+2
Change-Id: I205f77bccb8ca042da1a699d49844e305612aac2 Reviewed-on: https://code.wireshark.org/review/4307 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-26Modbus: fix indent and add modelines infoAlexis La Goutte2-96/+127
Change-Id: Idfcdaa13c24791cf2b765b02d8235e9b3a9cd775 Reviewed-on: https://code.wireshark.org/review/4306 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-26Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: Ia0f29a491af920415d6e56f30ef436544f7d5ddf Reviewed-on: https://code.wireshark.org/review/4303 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-26Added basic decoding of new IEsAndersBroman1-2/+50
Change-Id: I7982fe6ccee806b574f780cc2e96d7139a6a74c5 Reviewed-on: https://code.wireshark.org/review/4305 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-26Add basic dissection for new IEsAndersBroman1-9/+171
Change-Id: Ie9fc9ac4672a80c82c3b09188752c928b1e7d6c1 Reviewed-on: https://code.wireshark.org/review/4302 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-26ANSI IS-637 A: remove a useless variablePascal Quantin1-5/+2
Change-Id: I50077329d6e78ca39312e72eb04b7a5db85b977b Reviewed-on: https://code.wireshark.org/review/4301 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-26GTP: display SAC as BASE_HEX_DECPascal Quantin1-1/+1
Bug: 10490 Change-Id: I0afe1f2ff51f2452830bfc57210dc3a298b68cbf Reviewed-on: https://code.wireshark.org/review/4290 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-26CFM: display MEP ID in decimal in OAM Y.1731 Synthetic Loss Message and ↵Pascal Quantin1-8/+8
Reply PDU Bug: 10500 Change-Id: I70dab8fb86965fedbe8739e265db81fe310518cf Reviewed-on: https://code.wireshark.org/review/4289 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-25openSAFETY: Heuristic marks packet as truncatedRoland Knall1-2/+5
- There are cases, where the heuristic detection tries to access bytes, after a correct openSAFETY frame has been detected, leading to "Packet truncated" messages in the correct and complete detected packet Change-Id: Ie389edf82144283ad2c15f0bf975066de01e3409 Reviewed-on: https://code.wireshark.org/review/4237 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-25ANSI IS-637 A: get rid of tvb_length() deprecated APIPascal Quantin1-2/+2
Change-Id: I40de03605c051024c604679a1e141afa841a77e9 Reviewed-on: https://code.wireshark.org/review/4287 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-25ANSI IS-637-A: fix dissection of fragmented Unicode SMSPascal Quantin1-1/+15
The computation of the number of characters available was wrong when the User Data Header is present Change-Id: I2809c1460316530654a997b26cfc33c60a32fd6f Reviewed-on: https://code.wireshark.org/review/4284 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-25Freeze Info column while dissecting RRC transparent containerMartin Mathieson1-49/+53
Change-Id: I30900fd6a73ca38736b3f28eb416820f74003768 Reviewed-on: https://code.wireshark.org/review/4285 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-09-25Add comments about new IEsAndersBroman1-0/+18
Change-Id: Ibc035872ff6406830a06bcfd365047a6d8c2478f Reviewed-on: https://code.wireshark.org/review/4283 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-25reassembly: fix when fragment cut off by snapshotEvan Huus2-3/+11
Also add an assertion to tvb_generic_clone_offset_len so that it throws an error *before* allocating memory, as otherwise that memory is leaked. Bug: 10474 Change-Id: I5036cefac16841914a59670c64979cf599bf7969 Reviewed-on: https://code.wireshark.org/review/4234 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-25The length of the pktap header isn't fixed, it's a field in the header.Guy Harris1-1/+1
Don't assume that, once we've dissected the fields in the header we know about and skipped past them, that the payload follows immediately afterwards; use the header length from the header to find the payload. Bug: 10502 Change-Id: I645fe652240e0068d99cf00d19e3705615857d5b Reviewed-on: https://code.wireshark.org/review/4280 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-24Added a new DSR dissectorGilles Roudiere3-0/+778
Added a new dissector for the Dynamic Source Routing (DSR) protocol (RFC 4728) It should correctly dissect all DSR packets, including the "Flow State Extension" DSR packets. See Bug #10499 for capture file Change-Id: Ie33a1a2fe095cab19d5abfbfa8e1c79fec664a35 Reviewed-on: https://code.wireshark.org/review/4251 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-24Qt: Fix preference bugs.Gerald Combs1-10/+3
Make sure we set the "resolved" member of the column fmt_data struct. Emitting WiresharkApplication::AppSignals from a modal dialog can cause event loop problems on OS X. Queue them up in PreferencesDialog and emit them after closing. Change-Id: I2de77778a0448db3b87d402e431b8e5f325cbbda Reviewed-on: https://code.wireshark.org/review/4274 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-09-24Allow the HandoverPreparationInfoPDU dissector to be looked up by name and ↵Martin Mathieson1-3/+27
called. Change-Id: I9c22b74d5c3329b6c7d74547d26e940c84ffc66c Reviewed-on: https://code.wireshark.org/review/4247 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-23Add decoding of part of access network identifier optionAndersBroman1-2/+226
fixes Bug 10492. Change-Id: Ib01f457b74825e6c2a7aa1dc1d0f43ff4b104dea Reviewed-on: https://code.wireshark.org/review/4267 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-22packet-openflow_v1.c: Rename "Padding" fields & filter-names to be ↵Bill Meier1-36/+19
consistent with those in packet-openflow_v5.c Change-Id: Idd78b49cad86db6f63b4f14edbf4d954120665e3 Also: remove some commented-out "Padding" hf[] entries. Reviewed-on: https://code.wireshark.org/review/4257 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-22packet-openflow_v1.c: Fix a bug in dissection of openflow_features_reply_v1Bill Meier1-0/+9
Fixes Bug #10493 Change-Id: Ia330a7b087ea184865fc437d77ee6ca57b1f2e44 Reviewed-on: https://code.wireshark.org/review/4256 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-22Bluetooth: Handle LE ACL sessionMichal Labedzki1-5/+56
Low Energy use LE Meta event for creating connection so add session when it occur. Change-Id: I6fad42651a3dc6a45cfb1cf679660de5955e76b0 Reviewed-on: https://code.wireshark.org/review/4168 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-09-22Try to fix some buildbot warningsMichal Labedzki8-91/+66
Most interesting are: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations] warning: ISO C forbids zero-size array [-Wpedantic] warning: ISO C90 doesn't support unnamed structs/unions [-Wpedantic] warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual warning: initializer element is not computable at load time [enabled by default] Change-Id: I5573c6bdca856a304877d9bef643f8c0fa93cdaf Reviewed-on: https://code.wireshark.org/review/3174 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-09-22 packet-infiniband: added support for RoCE-v2 (RRocE)Wasim Abu Moch1-15/+66
Added support for the new Routable RDMA over Converged Ethernet. (NEW PATCH) Change-Id: I857a27c4f29cc78fcea8efa113e3c7e968eb041b Reviewed-on: https://code.wireshark.org/review/4156 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-22dcerpc: correctly initialize certain struct fieldsEvan Huus1-5/+1
Bug: 10482 Change-Id: I4d39d6a79d4ab89685a17a0c622c6181e4fada3d Reviewed-on: https://code.wireshark.org/review/4233 Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 02:59:56 +0000