aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1454-1457/+1457
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-25Don't format printable non-ASCII Unicode characters as escape sequences.Guy Harris2-155/+590
Note that even strings fetched with ENC_ASCII may contain them - bytes with the 8th bit set get mapped to REPLACEMENT CHARACTER. This means we can format STR_UNICODE fields with format_text(); do so. Bug: 1372 Change-Id: Ia32c3a92d220ac5174ecd25f33e2d1f85cfb8cb8 Reviewed-on: https://code.wireshark.org/review/34080 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-25USBLL: Verify DATA packets CRC-16Tomasz Moń3-1/+29
Ping-Bug: 15908 Change-Id: Idda280545665184aca40c694ea6d639c9317307a Reviewed-on: https://code.wireshark.org/review/34016 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-25USBLL: Initial USB 2.0 Link Layer dissectorTomasz Moń2-0/+358
Dissect raw USB Packets. The actual USB packets to transaction conversion (which is needed to pass the data to existing USB URB dissector) is not implemented yet. Ping-Bug: 15908 Change-Id: Ia75d58882d770fdd8650622d318241743069ad8f Reviewed-on: https://code.wireshark.org/review/34006 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24Use tvb_get_raw_bytes_as_string() to fetch the verb and reply code.Guy Harris1-3/+3
Change-Id: I615feb257274fdc44b8791078c0da512a4a7bd88 Reviewed-on: https://code.wireshark.org/review/34076 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Use g_ascii_isalpha(), not is_rfc2234_alpha().Guy Harris1-22/+3
Use GLib's locale-independent "is this alphabetic?" routine, rather than rolling our own. Change-Id: I841de09d534867ec7510bd680fd97387719b2850 Reviewed-on: https://code.wireshark.org/review/34075 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Use tvb_get_raw_bytes_as_string() to fetch the reply code.Guy Harris1-1/+1
Change-Id: Ida31fd962a6c2c792f19ac438697948c155e3f45 Reviewed-on: https://code.wireshark.org/review/34074 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Handle multiple PDUs per TCP segment and reassembly of multi-segment PDUs.Guy Harris1-114/+167
Use tcp_dissect_pdus(). Put the packet length and packet type into the protocol tree as items. Pass to routines dissecting various packet types an offset to the data past the packet type indication. While we're at it: Clear the Info column, so it doesn't contain TCP-level stuff. Use the new tvb_get_raw_bytes_as_string() to get the first 4 bytes of the payload as a string. Fix the capitalization of some field names. Change-Id: I3d5b8f4b4115d7b3675fbebc68a5e67976aba27b Reviewed-on: https://code.wireshark.org/review/34073 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Add a routine to fetch raw bytes into a fixed-length buffer as a string.Guy Harris2-0/+40
That's what the remaining calls to tvb_get_nstringz() and tvb_get_nstringz0() are being used to do, even though those routines were not intended for that purpose - the calls are extracting from a text protcool, meaning that the strings are *not* null-terminate in the packet. Strings - even null-terminated ones - should, in almost all cases, be extracted by tvb_get_string_enc() or routines that call it, so that an encoding is specified. In the few cases where we're fetching strings only to be compared to ASCII constants, or to parse as numbers, we can get away with this. Change-Id: I29f0532902c4ade2207de7f06db69c32eafd4132 Reviewed-on: https://code.wireshark.org/review/34072 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Clean up handling of group lists.Guy Harris1-26/+18
Use a wmem_strbuf_t for the group list, so it expands as necessary, rather than a static string buffer. Pass it to dissect_group() through dissect_rpc_list(). For each group, get the group name from the call to dissect_rpc_string(), and append it to the wmem_strbuf_t. Change-Id: I65b36a9b6d34dd1e88babd005fc60ab46331b382 Reviewed-on: https://code.wireshark.org/review/34069 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24f5ethtrailer: type-version subdissector tableJason Cohen1-26/+12
Add a subdissector table to the noise provider. This allows for extendability via a plugin to support new versions or message types of trailer noise. The original f5ethtrailer was distrubuted as a plugin. Since including it as part of libwireshark it has been impossible to add support for changes in the data this dissector decodes once Wireshark is released without patching and compiling on your own (or possibly building a git dev branch). This provides a mechanisim to add additional support to the dissector via plugin without needing to rebuild Wireshark. Change-Id: I1912ab497e0cfd34dcd92a893b819333665e23cd Reviewed-on: https://code.wireshark.org/review/34063 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24f5ethtrailer - Collapsible-Header trailer headerJason Cohen1-41/+66
Brings some less needed info from the trailer header into a tree collapsible tree. This save several lines in the packet decode tree. Bug: 15880 Change-Id: I7a3330a0a870e1e10f115e26ad7923b46de41f2e Reviewed-on: https://code.wireshark.org/review/34060 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-24Suqlech a -Wpointer-sign warning.Guy Harris1-1/+1
Change-Id: I193ff3b2faf37930128bdc02b4da36e32e306b4a Reviewed-on: https://code.wireshark.org/review/34067 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24Insert REPLACEMENT CHARACTER for various UTF-16 errors.Guy Harris1-20/+19
Change-Id: I2f62a409548b2c743864ca8da5733f7a73872b3c Reviewed-on: https://code.wireshark.org/review/34066 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-24E1AP: upgrade dissector to v15.4.0Pascal Quantin9-130/+511
Change-Id: Ic9a19804b5e46ca63f3d1256e13173a92fc39f9b Reviewed-on: https://code.wireshark.org/review/34065 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-22iso7816: link a transaction to a payload dissectorMartin Kaiser1-7/+14
When an iso7816 request is forwarded to a payload dissector, store its handle in the transaction info. Call the new helper function to get the selected payload dissector's handle. Use the stored dissector handle to pass the response to the same payload dissector that handled the request. Change-Id: Idc6f7fbee978c095719aea937ab3179eac17f2a7 Reviewed-on: https://code.wireshark.org/review/33934 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-22wslua: pinfo: make p2p_dir accessible to lua dissectorsMartin Kaiser2-0/+9
Some dissectors populate pinfo->p2p_dir with a packet's direction (incoming / outgoing). Make this info available to lua dissectors. Add a simple test for Pinfo's new p2p_dir attribute to the wslua test suite. It checks that p2p_dir is unknown for dhcp packets. (The dhcp dissector does not set p2p_dir). Change-Id: I8cc39a11cff840d10ef7fa94d30cbac8bf9b533f Reviewed-on: https://code.wireshark.org/review/33935 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-22helper function to get a payload dissector table's current handleMartin Kaiser2-0/+15
Add a simple helper function to get the dissector handle that's currently selected in a given payload dissector table. We have similar functions already for string and uint dissector tables. Change-Id: Ia1092fe2b8d038bae2b26db99fd08cd9d6979fcd Reviewed-on: https://code.wireshark.org/review/33933 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-21Extend epan library plugins with a tap registration callbackJoão Valverde2-0/+11
tap_register_plugin() is not sufficient for an extension language implementation because the epan plugin is initialized before proto_init(), therefore before dissectors have registered taps. Change-Id: Ief213f85ff4f7182f9af985e5f45476355cc2b86 Reviewed-on: https://code.wireshark.org/review/34048 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-07-21Lua: remove lua_data_handlePeter Wu3-7/+2
Use call_data_dissector directly for the same effect as lua_data_handle. Remove the special case where DissectorTable.get_dissector() returns the data dissector for an unsupported type. The documentation says that nil is returned if the handle is not found, that seems more appropriate. Change-Id: I128ef90b79bda925a4329202a0b9956e1cf16200 Reviewed-on: https://code.wireshark.org/review/34032 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-07-21Remove ABI compliance checker code.João Valverde1-48/+2
It's broken, unmaintained, poorly implemented and obsoleted by saner debug-info methods. Note: To do the compliance check properly would require much more extensive work to clearly define public and private interfaces (without manual bookeeping of files or symbols either, of course, because who would want that...). Change-Id: Ib801f3c152ca2369f95ca1f4af4d37cd8cc7c47a Reviewed-on: https://code.wireshark.org/review/33928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2019-07-21IEEE80211: handle symbol proprietary tag seperatelyJaap Keuter4-7/+103
The contents of the Symbol Proprietary TLV was assumbed to be the same as the Vendor Specific TLV. This proved not to be the case, at least for Zebra Extreme networks nodes. This change implements the dissection of the format as defined in the bug. Bug: 15909 Change-Id: I4c14dde386d33302d187680f9f09f8b5bb1ef213 Reviewed-on: https://code.wireshark.org/review/34023 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-20epan,packaging: convert http URLs to httpsPeter Wu6-13/+12
Ensure that public text in error messages and dialogs point to https. Ensure that the generated PDML files include scripts over https. Change-Id: I75d42704c2bbb33b05492261b3e1d45dc6e301f9 Reviewed-on: https://code.wireshark.org/review/34027 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-20Fix -Wpointer-sign warning.Guy Harris1-1/+9
Change-Id: I8e74e90f1383f01633343cd6e72ac2193bfb3e04 Reviewed-on: https://code.wireshark.org/review/34029 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-20smtp: add credentials to the tap.Dario Lombardo1-2/+31
Change-Id: I85afccd7e05efd9d293d6b8c1b5702faf8d34b14 Reviewed-on: https://code.wireshark.org/review/33764 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19Clean up the handling of the "friendly name".Guy Harris1-77/+51
Fetch it by adding it with proto_tree_add_item_ret_display_string(), and then use the resulting displayable string to append to columns and protocol tree items. Given that the string in question is ISO 8859-1, according to the KNXnet/IP spec, and that it must therefore be converted to UTF-8, that's the right thing to do. Use wmem string buffers to hold the strings to append - using a fixed-length buffer isn't a good idea when you are dealing with UTF-8 strings, as you might cut a UTF-8 sequence short in the middle. Don't consruct strings that we never use. While we're at it, give a URL to find KNX specifications. Change-Id: Ibec4f6c83a62e141bd8ce0e5dfd7dd45ff627fe4 Reviewed-on: https://code.wireshark.org/review/34024 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19Use proto_tree_add_item_ret_display_string() to add string items.Guy Harris1-4/+2
It does all the work done by the calls it replaces, *and* it takes an encoding argument, so the string data is converted, if necessary, to UTF-8. (Not necessary in this case, at least as I read the protocol spec, but it's the right thing to do in any case.) Plus, as we're using proto_tree_add_item_ret_display_string(), the string we're displaying will be in a displayable format. Change-Id: I7f5e46dcdbb8f3d3749ef539a31f6208371b72cd Reviewed-on: https://code.wireshark.org/review/34022 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19Provide only one data rate per user for VHT frames.Guy Harris1-8/+0
Don't provide an extra not-per-user data rate equal to the data rate for the highest user number; that makes no sense. Bug: 15928 Change-Id: Ie6bf5853d630bbf33afd423dc7a8eca26abdf83a Reviewed-on: https://code.wireshark.org/review/34018 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19XnAP: upgrade dissector to v15.4.0Pascal Quantin15-273/+921
Change-Id: Ia26593e7895709671a7a9d4a51bb6788e4059c94 Reviewed-on: https://code.wireshark.org/review/34015 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19pop3: add credentials to tap.Dario Lombardo1-33/+74
Change-Id: I0779a4c11451ee63be8d10ee78a7f920f519f77a Reviewed-on: https://code.wireshark.org/review/33799 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19imap: add credentials to tap.Dario Lombardo1-0/+13
Change-Id: I6858e66dcda643a97e9f1b29b62edc5ceb8af064 Reviewed-on: https://code.wireshark.org/review/33765 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19imap: dissect username and password from LOGIN command.Dario Lombardo1-0/+26
Change-Id: I84ff13cdda7af60bb6ce588b7ec3bccb1911ee97 Reviewed-on: https://code.wireshark.org/review/33756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19NGAP: upgrade dissector to v15.6.0Pascal Quantin9-575/+888
Change-Id: Iac53380ba1a6ba105103db7104d44688bbbe383d Reviewed-on: https://code.wireshark.org/review/34014 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19dhcp: fix memleak on exceptions in dissect_dhcpopt_avaya_ip_telephonePeter Wu1-5/+3
Do not use g_malloc, it leaks when accessing the tvb throws an error. Change-Id: I5c6515da2184e2bea496d352461784cf845c3e18 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15673 Fixes: v3.1.0rc0-136-gc28d8f937a ("packet-dhcp.c: Fix modification of a const char* string") Reviewed-on: https://code.wireshark.org/review/33999 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-19CoAP: add frame support for CoAP over TCP, TLS, WebSockets (RFC 8323)Peter Wu1-29/+136
Support is limited to message framing. Bug: 15910 Change-Id: Ia27c0b8428842618af00720441a9ef9cf163fecb Reviewed-on: https://code.wireshark.org/review/34001 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-18CoAP: add CoAP Signalling Codes (RFC 8323)Peter Wu1-15/+23
Update names and RFC references based on the IANA registry at https://www.iana.org/assignments/core-parameters/core-parameters.xhtml Bug: 15910 Change-Id: I56a4cc3c23fee321b09547254a33f6a76d46cc9d Reviewed-on: https://code.wireshark.org/review/34002 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-18ZigBee: Add Address fieldsKenneth Soerensen1-1/+25
Change-Id: I8b2f2b682f46b85230649e852f3fa70af6d237ef Reviewed-on: https://code.wireshark.org/review/33992 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-18ZigBee: Correct namingKenneth Soerensen1-3/+3
Change-Id: Ide220a1899bba6327dc7fbfcc3ac9ac0113b929f Reviewed-on: https://code.wireshark.org/review/33991 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-18QUIC: fix out-of-bounds write due to missing CID length checkPeter Wu1-7/+11
The length was previously increased to max 255, but v1 limits it. Be sure to check the bounds before doing anything. Bug: 15919 Change-Id: I2ed8469d882d5ac2dc4c21e3f5486534e4bf32e6 Fixes: v3.1.0rc0-1289-g3967f60e45 ("QUIC: update for new Connection ID Lengths (draft -22)") Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15936 Reviewed-on: https://code.wireshark.org/review/34000 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-17tvbuff_lz*: fix typo in commentAurelien Aptel3-9/+9
Change-Id: Id2b36454e678151ea5948f8e068ef400dd562188 Reviewed-on: https://code.wireshark.org/review/33985 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Couchbase: Fix dissector for dcp prepareTrond Norbye1-2/+1
The timeout value was removed from the DCP PREPARE message as it was never used (and will never occur in a released version of Couchbase) Change-Id: I95f5bb3a0878237bf0339da48476fda437740c25 Reviewed-on: https://code.wireshark.org/review/33984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Jim Walker <jim@couchbase.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-07-17BGP: Update description for IE Flag (EVPN IGMP)Uli Heilmeier1-2/+2
Ping-Bug: 15911 Change-Id: I2607eb96e8a217451a493a301dc06b56a4db3081 Reviewed-on: https://code.wireshark.org/review/33966 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-17ceph: remove unnecessary ifdef G_STATIC_ASSERT checkPeter Wu1-2/+0
Supported since GLib 2.20, we require at least 2.32. Change-Id: I0bdeaaaf11dad5352aa2f6e4dc9e23be9dc93e3a Reviewed-on: https://code.wireshark.org/review/33977 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-25/+15
Use tvb_get_string_enc() to fetch strings. That way, all strings are fetched using an encoding value, to properly map to UTF-8. While we're at it, add the RFC for the final version of the protocol. Change-Id: If103d9464a313bd61948b931291a3763ea85d01b Reviewed-on: https://code.wireshark.org/review/33981 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-4/+10
Use tvb_get_string_enc() routines to fetch them; all strings must have an encoding value, to properly map to UTF-8. While we're at it, fix heuristic test to make sure we have a full TALI header in the *captured* data. Change-Id: Ia572707f8d7da89d3fe31e839e1cbe4dc5e23c43 Reviewed-on: https://code.wireshark.org/review/33980 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Ask in a comment about DNS-style domain names.Guy Harris1-0/+8
Change-Id: Idcf5ed5db1d04f48849e458d85c3a04e6d1d8d43 Reviewed-on: https://code.wireshark.org/review/33979 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Don't just grab raw string data with tvb_memcpy().Guy Harris1-23/+23
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and are formatted for display. Change-Id: I4acd9ed7cfad3342be84a4773187dd531949f47b Reviewed-on: https://code.wireshark.org/review/33974 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Clean up handling of the command parameter.Guy Harris1-36/+35
It's an unsigned int, as per the protocol spec. Treat it as such. (Add a URL for the protocol spec while we're at it.) Convert it from a string of ASCII hex digits to a number using ws_hexstrtou32(); that routine does the appropriate checks. Clean up blank lines while we're at it - add some and remove some. Change-Id: I2c0832c4a57c121e2e64de49a8678b747025f35e Reviewed-on: https://code.wireshark.org/review/33972 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16X2AP: upgrade dissector to v15.6.0Pascal Quantin9-526/+839
Change-Id: Iffa23a10350ad8ef765401b50373a7d6aaf5d2bf Reviewed-on: https://code.wireshark.org/review/33971 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-16tvb_lz77huff: reduce stack memory usageAurelien Aptel1-15/+19
clang errs about the stack frame size being too big. * use indexes instead of pointers * use guint8 instead of gboolean (== int) * remplace hard coded 512 with #define Change-Id: Idae70677f20e88ac8bba93899573e0137b9a3d7e Fixes: 0db39ae59a ("smb2: add support for decompression") Reviewed-on: https://code.wireshark.org/review/33965 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 15:02:32 +0000