Age | Commit message (Collapse) | Author | Files | Lines |
|
Closes #18517
Solution by Zhao Ziqing
|
|
|
|
See Core_v5.3, Vol 6, Part B, Section 4.6.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
The dissection also includes adding control procedure sequence validation.
See Core_v5.3, Vol 6, Part B, Section 2.4.2.36-39 and Section 5.1.19-22.
Core_v5.3 was released in 2021.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
This will add expert info if the packet is being sent when
it is not allowed to be sent
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
This will add expert info if the packet is being sent when
it is not allowed to be sent
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
The LL_REJECT_EXT_IND is an allowed response to the LL_POWER_CONTROL_REQ,
see Core_v5.3, Vol 6, Part B, Section 5.1.17.
Performs control procedure validation one a LL_POWER_CHANGE_IND is sent
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
In Core_v5.3, Vol 6, Part B, Section 5.1.15 describes that this
is allowed.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
In Core_v5.3, Vol 6, Part B, Section 5.1.12 describes that this
is allowed.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
Core spec 5.2, Vol 6, Part B, Section 5.3 describes how the link layer should
resolve the scenario where a collision occurs where both link layers initiate
incompabile control procedures.
This commit adds expect information for the case where these conflicts are not
handled according to spec.
Example of an invalid scenario:
M->S: LL_PHY_REQ
S->M: LL_PHY_REQ
S->M: LL_PHY_RSP
M->S: LL_PHY_UPDATE_IND
The correct sequence for this scenario is:
M->S: LL_PHY_REQ
S->M: LL_PHY_REQ
S->M: LL_PHY_RSP
M->S: LL_REJECT_EXT_IND
M->S: LL_PHY_UPDATE_IND
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
By defining control_proc_add_frame(), control_proc_add_last_frame(), and
control_proc_add_frame_with_instant() a lot of duplicate code can be removed.
This commit makes the checks for the CIS establishment procedure follow the spec.
Previously the dissector had two bugs:
- It allowed both master and slave to initiate this procedure
- The procedure was marked as complete once the LL_CIS_RSP was received.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
Moves the check of starting a control procedure before the previous was complete inside
the function control_proc_start(). This check should be beformed before starting any
control procedure. Therefore it is better to simply move it inside the funciton to remove
code duplication.
Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
|
|
|
|
|
|
Adds APIs for parsing different kinds of integer from a lua ByteArray:
-16, 32 and 64 bit
-singed or unsigned
-encoded little endian or big endian
|
|
|
|
Treat a `FT_CHAR` field like a `FT_UINT*` field, the same as Wireshark's
`proto_tree_add_item()` does.
Closes #18353
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
This reverts commit ee509cc3f25eacecd60a73da135a2065c34a77d8.
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Applies to IM2R0 only.
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
|
|
Change-Id: Ie52ffaffd72fb1aa273ea0d3ce9ff6754e3dbd56
|
|
|
|
No one is using this so I'd like to explore other
options first to handle constants in arithmetic
expressions that lack type information.
Reverts 3ddb017a88797f520cda45961819c7084a0a5b29.
|
|
We want at least one letter. Because protocol names can contain
dots and hyphens testing for !isdigit is not enough to make it
dissimilar to decimal numeric expressions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- Show which options are referenced by entries in entry overview.
- Show IPv6 address in option overview too (before IPv4 only).
- Only register ports of endpoint referenced by SOME/IP services.
Endpoint Options referenced by Service 0xfffe (non SOME/IP) are not
automatically registered to be SOME/IP anymore [improvement].
|
|
|
|
Close #18759
|
|
Calculating ipei_digits happened using signed int arithmetic due to type
promotion rules. Explicitely casting the static number to guint64
ensures usage of unsigned 64bit arithmetics.
|
|
The extended location information type field is a four bit value. This
was handled correctly while displaying, but not by interpreting the
value. Hence the according MASK and SHIFT values have been updated.
|
|
Add a recursion check.
Fixes #18770.
|
|
Replace use of composite tvb with creation of one tvb.
|
|
|
|
When procssing BATCH statements, Wireshark did not properly handled keys with length < 0 , which actually means that no value
is sent on the wire..
This fixes it (and as a results, parses properly some result packets it failed to parse properly before).
Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
|
|
When procssing results, Wireshark did not properly handled keys with length -1, which actually means NULL.
This fixes it (and as a results, parses properly some result packets it failed to parse properly before).
Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
|