aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2019-09-21Qt, docs, ieee1905: fix some spelling errorsPeter Wu1-1/+1
The spelling error for "Desription" in the context menu was very obvious. The others were found by scanning the output of: grep -Po '<source>\K.*(?=</source>)' wireshark_en.ts Change-Id: I4b95236c82f76828a115d59d7c8e0b853eae1d26 Reviewed-on: https://code.wireshark.org/review/34582 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-19ieee80211: Fix nameclash in RM ReportAleksej Matis1-2/+2
RM Report channel number and duration share the same abbreviation. Rename duration to wlan.measure.re[qp].duration. Change-Id: I0a24ffb69e1b0f1c81626ccaeaa7ce1675158465 Reviewed-on: https://code.wireshark.org/review/34562 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-18dot11crypt: Fix crash on failure finding GTK in decrypted frameMikael Kanstrup2-7/+7
If GTK cannot be found inside a successfully decrypted wireless frame the dot11crypt engine returns incorrect decrypted data length of 0 bytes. As the IEEE802.11 dissector does not check the length of the decrypted frame the number of bytes allocated and copied to wmem ends up being a negative number (i.e. a huge unsigned number). This results in a SIGSEGV crash while copying data. Fix this both by returning a correct length from dot11crypt engine and add extra an protection to the IEEE802.11 dissector if the length for any (other) reason still would end up being a negative number. Bug: 16058 Change-Id: I9d0d1cf50498dece2e008222eebbb3edc8f10159 Reviewed-on: https://code.wireshark.org/review/34558 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-17RRC: Reconstruct MCC-MNC pairs in PLMN-IdentityWithOptionalMCC elementDarien Spencer3-46/+150
In this patch when a 'PLMN-IdentityWithOptionalMCC' field is found where MCC is missing but a MCC was seen previously in the packet, the last MCC will be used for E.212 dissection. Change-Id: I6bda9540f63acc693751606c1f99d6aa9539bd98 Reviewed-on: https://code.wireshark.org/review/33925 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16Couchbase: Handle extras in mutation responsesMatt Carabine1-7/+29
Previously extras in any mutation (e.g. ADD, SET) response would be marked as illegal, as these used to return no extras. More recently, extras can be returned in mutations if the connection has negotiated the MUTATION_SEQNO feature. The extras can contain the mutation's sequence number and the vBucket UUID. This commit adds a new field (couchbase.extras.mutation_seqno) to achieve this, as the existing field couchbase.extras.seqno is used for a different purpose and is only a UINT32, whereas a UINT64 is returned as part of the extras; the existing couchbase.extras.vbucket_uuid is used for the vBucket UUID. Change-Id: If8a5148f2115fce7a777b96ad22ba92d95c9ff71 Reviewed-on: https://code.wireshark.org/review/34540 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16pfcp: update of UP Function Features IEJoakim Karlsson1-3/+53
Added missed bits Updated Release digits Change-Id: I04eae315165137c8b04ed1c4d2e31fa1e3e57e91 Reviewed-on: https://code.wireshark.org/review/34541 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16ieee80211: the last bit of QoS INFO is now More Data AckAlexis La Goutte1-4/+4
Issue reported by Helge Mangus Keck Change-Id: Ic13dfd41b836b272d8c6f3e5b107b7c499470904 Reviewed-on: https://code.wireshark.org/review/34537 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16ieee80211: Add missing value string for HE Phy CapabilitesAlexis La Goutte1-8/+36
From 802.11ax Draft 4.1 Issue reported by Helge Mangus Keck Change-Id: I3c87acf1589285a6c4986f75422b9c938afb9292 Reviewed-on: https://code.wireshark.org/review/34536 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-16QUIC: Update to draft-23Alexis La Goutte3-17/+26
- Update initial salt (kept support of draft-22 and 21) - update URL - Remove INVALID_MIGRATION error code - Rename TP (disable_migration -> disable_active_migration) Bug: 13881 Change-Id: If3d3dc1930a9e16f13a931518efad38773e5ace3 Reviewed-on: https://code.wireshark.org/review/34517 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-15Add support for "custom" DNS servers to be used in address resolutionMichael Mann3-1/+143
Use the C-ARES ares_set_servers() API to set a list of DNS servers to use. The list of DNS servers is controlled through a UAT. There is also a boolean preference to determine if the custom list should be used. The boolean preference was added to arbitrate between the "default" list of servers that C-ARES creates during initialization and using the "custom" list (which may be empty and we don't want the "default" list to be overwritten) Bug: 15960 Change-Id: I4ba071777f6bb9bc2fef313b7618908d805c0690 Reviewed-on: https://code.wireshark.org/review/34419 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-15BACnet: Added missing decoding event-notification access-event (13)Dirk Römmen1-3/+64
- Improved decoding of trendlog type "any-value" - Added enumeration strings for odd/even month Change-Id: I96c775e07dabe48b31e81eec28d9ea31f78e4b75 Reviewed-on: https://code.wireshark.org/review/34521 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-15Add new filters for Ethernet src and dst OUI's as well as their resolved OUI'sMichael Mann1-116/+141
Bug: 15393 Change-Id: I931813ce3492557a5673e6bbd0269d34c0d550b2 Reviewed-on: https://code.wireshark.org/review/31416 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-14BACnet: Wrong dissection device identifierDirk Römmen1-61/+62
- Implemented labeling of decoding BACnet object identifier so that difference between device and other object id's are shown in the decoding tree. Bug: 16008 Change-Id: I145e26803e1b6c70c2980858c1b946a285382726 Reviewed-on: https://code.wireshark.org/review/34340 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-09-14802.11 radiotap: Fix wrong data structure in the dissector for HE TRIGGER framesSébastien Deronne1-1/+1
(patch from Getachew Redieteab) Change-Id: I180b20b513e901c2c157da9a2318a90c91fd040b Reviewed-on: https://code.wireshark.org/review/34505 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-14SNMP: handle Net-SNMP Engine Id of 12 octetsJaap Keuter2-12/+12
The Net-SNMP code creates an Engine Id size based on the compilation size, either 8 or 12 octets long. Current implementation handles 32 bit compilation of Net-SNMP (resulting in 8 octets), this change adds handling of 64 bit compilation of Net-SNMP (resulting in 12 octets). Bug: 16051 Change-Id: I256f9a7ad2fd219492e4ebc413ef24cd2c210e0b Reviewed-on: https://code.wireshark.org/review/34520 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-13ieee80211: remove no needed nbytes on display filterAlexis La Goutte1-54/+54
Change-Id: If1081708cf9dae4e50c35bf949a0dd37ce64c4c7 Reviewed-on: https://code.wireshark.org/review/34516 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-13ieee80211: Update b78 and b79 of HE PHY Capabilities InformationAlexis La Goutte1-11/+25
it is now Nominal Packet Padding fix also some variable name (missing he_phy_cap) From 802.11ax (Draft 4.1) Issue reported by Helge Mangus Keck Change-Id: Iba1d5524383222582060e259b9977b06938d96d6 Reviewed-on: https://code.wireshark.org/review/34515 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-13gsm_a_rr: Support for APDU ID ETWSHarald Welte1-4/+22
According to 3GPP TS 44.018 V15.3.0 APDU ID 1 is ETWS. Change-Id: I6dceeb45c82f4f5c75fc46fea85d22ec9c4855e6 Note: ETWS is the Earthquake and Tsunami Warning System. Reviewed-on: https://code.wireshark.org/review/34465 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-13ISAKMP: Added support for Notify AUTH_LIFETIME PayloadMichail Koreshkov1-0/+22
As specified in RFC4478 Change-Id: Ic15d1f553bd9c2a25a91a6d329fe9eb0daf35a3b Reviewed-on: https://code.wireshark.org/review/34498 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-13ieee80211: Update last bit (47,46,47) of HE MAC Capabilities InformationAlexis La Goutte1-5/+20
From 802.11ax (Draft 4.1) Issue reported by Helge Mangus Keck Change-Id: Ibc20c4c8139c88c84c6f08dbe8d0fc4c277ed85d Reviewed-on: https://code.wireshark.org/review/34487 Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-12E1AP: Add .h file needed for private IE dissection.Anders Broman6-21/+98
Change-Id: I04569b89a6fe55e4d988978bd8f1538bc62444e5 Reviewed-on: https://code.wireshark.org/review/34514 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-11Netflow: Niagara Networks decodes for RADIUS IPFIX information elements.Volodymyr Veskera1-0/+286
Change-Id: Idec2db02ca5cf08bf407a15b716e804947426a19 Reviewed-on: https://code.wireshark.org/review/34502 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-09-10DLT: Fix gint64 printf formatStig Bjørlykke1-1/+1
Use G_GINT64_FORMAT for gint64. Change-Id: I50e82a45d51b97f0e15d90082b71fd53e65d83a6 Reviewed-on: https://code.wireshark.org/review/34499 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10FC-dNS: add missing fields registrationPascal Quantin1-0/+4
Issue reported by Christian Svensson in https://www.wireshark.org/lists/wireshark-dev/201909/msg00016.html Change-Id: I362bb9ad861d5b87d3d21997621011654a8b86ef Reviewed-on: https://code.wireshark.org/review/34492 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-10DLT: Fix uint64 printf formatStig Bjørlykke1-2/+2
Use G_GUINT64_FORMAT for uint64. Change-Id: I3c86dad0f045092e4292899c473ff32bb1fe82a8 Reviewed-on: https://code.wireshark.org/review/34490 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10DLT: Adding support for the DLT protocolDr. Lars Völker2-0/+1373
The Diagnostic Log and Trace protocol (DLT) is a commonly used and standardized protocol in the automotive industry used to retrieve log data. This patch adds the protocol to Wireshark. Keep in mind that ports have to be configured before the dissector can be used. Change-Id: I24592705476fb0c3bb83a1cc10b3dae8867523f4 Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de> Reviewed-on: https://code.wireshark.org/review/34462 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10TDS: Improve handling of scale for TDS numeric and decimal fields.Craig Jackson1-12/+52
For numeric and decimal fields, we can use doubles to display many decimal and numeric fields exactly. It only starts to fall down when we get more than 15 decimal digits. Bug: 16041 Change-Id: Idae1790ade7106d7557739220756ef9e9281378c Reviewed-on: https://code.wireshark.org/review/34471 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10ieee80211: fix dissection of HE Phy Capabilities InformationAlexis La Goutte1-27/+9
Wrong bitmask and duplicate field for same byte Issue reported by Helge Mangus Keck Change-Id: Ibc5a914fc2ecc05b9b5f6d0025c52c80af23d9f4 Reviewed-on: https://code.wireshark.org/review/34483 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10DIS: Support for the EntityStateUpdate PDUJean-Philippe Lebel1-1/+131
Updated the DIS protocol dissector to support the EntityStateUpdate PDU. The EntityStateUpdatePDU is part of DIS 7 and was already "semi-handled" by the dissector. Change-Id: I3221520e0260dc836d373fa590b3941de45a2dcc Reviewed-on: https://code.wireshark.org/review/34463 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09rsl: Add support for non-standard RSL_MSG_TYPE_OSMO_ETWS_CMDHarald Welte1-1/+49
3GPP sadly has forgotten to specify how the ETWS Primary Notification is to be communicated over Abis to the BTS. Osmocom has introduced a non-standard RSL message type "RSL_MSG_TYPE_OSMO_ETWS_CMD" for this purpose to the OsmoBTS and OsmoBSC implementations. It contains a single Information Element which in turn contains the 56-byte primary notification of the Earthquake and Tsunami Warning system. This patch adds wireshark dissector support to it. Change-Id: Icce5b06bfd00c0a7ef0f21283cc57473fa34f034 Reviewed-on: https://code.wireshark.org/review/34464 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I013c1bdc943033550f497b1be0dfc7979ca49517 Reviewed-on: https://code.wireshark.org/review/34484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09nvme-tcp: Add C2H/H2C TermReq dissectionDmitry Radivonchik1-0/+165
Section 7.4.10.4 and 7.4.10.5 of the spec. Change-Id: I175f98ca8265eb369344d5dcaff7bdf0943372c3 Signed-off-by: Dmitry Radivonchik <mitya@oktetlabs.ru> Reviewed-on: https://code.wireshark.org/review/34470 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-5/+5
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d Reviewed-on: https://code.wireshark.org/review/34481 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08BACNET: Update vendor ID listJaap Keuter1-1/+80
Update build-in vendor ID list with last years additions. Change-Id: I1916e160f6bcea5e94ce203b50f4a27a6ca1d261 Reviewed-on: https://code.wireshark.org/review/34460 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-08QUIC: fix connection tracking with empty Initial SCIDPeter Wu1-16/+22
Fix linking of new Initial packets after a Retry packet in case the client Initial packet has an empty SCID. Update a comment to drop "Stateless" from "Stateless Retry" to match newer QUIC drafts. Tested with quic-go-b083fd6f0e36-d22-dsb.pcapng. Bug: 13881 Change-Id: Idc8b1ad6283ace95ae059a6ef6ee268c1ffb4097 Reviewed-on: https://code.wireshark.org/review/34469 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-05NAS 5GS: enhance dissection of QoS rules IEPascal Quantin1-18/+162
Change-Id: I96d416744401d259b9205f5e8daaffe58673633f Reviewed-on: https://code.wireshark.org/review/34451 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-05kafka: Cleanup to use "native" APIs.Michael Mann5-157/+172
Add "native" support for the "zig-zag" version of a varint in proto.[ch] and tvbuff.[ch]. Convert the use of varint in the KAFKA dissector to use the (new) "native" API. Ping-Bug: 15988 Change-Id: Ia83569203877df8c780f4f182916ed6327d0ec6c Reviewed-on: https://code.wireshark.org/review/34386 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Load environment vars to globals for efficency.Anders Broman7-21/+49
These environment variables are read very frequently, read them once to globals for performance improvment. Change-Id: I4f05a5edca85b370674cc5f85fce40bd1af695cb Reviewed-on: https://code.wireshark.org/review/34449 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03NAS 5GS: fix dissection of Session-AMBR/GFBR/MFBR unitPascal Quantin1-7/+6
Change-Id: Iccbc89a586abd33db0dd8c16974ad8d9b5bd21f9 Reviewed-on: https://code.wireshark.org/review/34443 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-03OSC: Set UDP heuristic default off as this is a niche protocol.Anders Broman1-1/+1
The heuristic is a bit expensive, set default off. Change-Id: Ib0cb863810a1cbcae2fef0b5a035c63682246a0f Reviewed-on: https://code.wireshark.org/review/34441 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03ETSI Card Application Toolkit Transport: Set heuristics default off.Anders Broman1-1/+1
RTP packets picked up by the dissector as it's a niche protocol set heuristics to default off. Change-Id: I33c6c3fc0f4a593cc4ed5866515cdcea669bee54 Reviewed-on: https://code.wireshark.org/review/34440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-02NAS 5GS: fix dissection of QoS flow description IEPascal Quantin1-39/+101
Do not reuse Session AMBR fields for MFBR and GFBR. Add averaging window and EPS bearer identity cases. Change-Id: I34fad0b5f38aa097bb968106de2bbb86278579b9 Reviewed-on: https://code.wireshark.org/review/34430 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-02NAS 5GS: display protocol identifier string in QoS Rule IEPascal Quantin1-2/+2
Change-Id: I9d5e1f099b9273b20bf335a5b29ef66cf112c928 Reviewed-on: https://code.wireshark.org/review/34429 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-02couchbase: update command identifiersSergey Avseyev1-0/+8
Change-Id: Ic6eb59a26dc0a9edd216a985bbf94d13b4bc5094 Reviewed-on: https://code.wireshark.org/review/34427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02TCP: Provide display filters for "raw" SEQ/ACK.Michael Mann2-3/+21
Add hf_ fields for "raw" Sequence and Acknowledgment numbers. They will only be visible when "Relative sequence numbers" preference is TRUE. Bug: 15913 Change-Id: Icfbdc435e82723d663dce36c3a5cc513c837bdaf Reviewed-on: https://code.wireshark.org/review/34421 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02IEEE802.11: Minor cleanupMichael Mann1-43/+42
1. he_mac_headers can be changed at runtime, so it is not "static" or "const" 2. Optimize out extended length calculation. Ping-Bug: 15866 Change-Id: Ibf8191a7043a22109ae8a3db481bfbbef583b110 Reviewed-on: https://code.wireshark.org/review/34424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-01SMTP: Consider bytes seen as "data" until a command is seenMichael Mann1-2/+3
Create a state for the start of an SMTP conversation. If bytes seen don't match a command and conversation is still in the "start" state, treat bytes as message data, not a command. Bug: 16026 Change-Id: I229b316a77819b07bf8cf93bed72570a947c6cf3 Reviewed-on: https://code.wireshark.org/review/34412 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01net_dm: Add dissector for drop monitor netlink packetsIdo Schimmel2-0/+502
The Linux kernel includes a module called drop monitor which - unsurprisingly - monitors packet drops. Once enabled, the module will periodically send netlink notifications to user space over generic netlink. Historically, these notifications only included the program counter where the drop occurred and the number of packets that were dropped in this location in the last interval. Patches in net-next (queued for Linux kernel 5.4) extend drop monitor with another mode of operation where the dropped packets themselves are sent to user space along with relevant metadata as netlink notifications. This allows users to perform a more detailed analysis of the dropped packets. This patch adds a dissector for these netlink packets. The dissector is expected to be invoked by the generic netlink dissector and during its hand off routine it adds an entry in the 'genl.family' dissector table. The various netlink attributes are dissected by calling dissect_netlink_attributes(), in a similar fashion to the rtnetlink dissector. The dropped packet itself is encoded in the netlink attribute 'NET_DM_ATTR_PAYLOAD' and dissected by invoking a dissector from the 'sll.ltype' dissector table based on the packet's protocol which is encoded in the 'NET_DM_ATTR_PROTO' attribute. Bug: 16018 Change-Id: I10bfa4b9c9d8f5e82769c250f929f74693142a23 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34351 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01IEEE 802.11: RSN Information tag, more fields optional.Michael Mann1-2/+8
IEEE 802.11-2016 Section 9.4.2.25 RSNE All information after Element ID, Length, and Version are optional; therefore the minimal IE length is 2. Bug: 15905 Change-Id: I231e31c6a0fe5a26d5dd7c1c36be4e9816a7bb50 Reviewed-on: https://code.wireshark.org/review/34411 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-30isakmp: Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I318fec3f9cf8d86eaa4260f00e8747683a049e6e Reviewed-on: https://code.wireshark.org/review/34407 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-13 11:13:30 +0000