aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2015-01-11Rename the FT_BYTES separator types to SEP_ from BASE_.Guy Harris17-51/+51
There's no requirement for "display" field values to have names beginning with BASE_; use SEP_, to indicate that they're separators. (And, yes, we should introduce SEP_NONE, with a value of 0, and use it.) While we're at it, fix BASE_SEMICOLON - the separator is a colon, not a semicolon - and document SEP_SPACE in doc/README.dissector. Change-Id: I856aafda2c60b8320dffe287f0deb06a9604a2bf Reviewed-on: https://code.wireshark.org/review/6486 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-10Netflow: do transport resolution on ports (if know they are UDP or TCP)Martin Mathieson1-1/+31
Change-Id: I8fc3675f03b7eaec6a9385638197067981762a70 Reviewed-on: https://code.wireshark.org/review/6474 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-10Remove ep_ allocated memory from get_conversation_filter and just return a ↵Michael Mann2-10/+10
g_alloced string. Change-Id: Ie7f6b2c5479fec1a44afb5e446ef6abf304113af Reviewed-on: https://code.wireshark.org/review/6480 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Add BASE_SPACE for FT_BYTESMichael Mann3-45/+34
It's just like BASE_DOT, BASE_DASH and BASE_SEMICOLON, only its a space between bytes. Since this seems pretty specific to FT_BYTES, perhaps there is a better was to represent the functionality (like FT_BOOLEAN uses numeric values for number of bits)? Change-Id: I1a8f1ab263ece2736a8012b66fdd6a9105db7282 Reviewed-on: https://code.wireshark.org/review/6451 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Add preference to display spaces between bytes for FT_BYTES fields.Michael Mann4-14/+30
I think this can make fields more readable (for a small amount of bytes). Converted DeviceNet dissector to use proto_tree_add_item for some FT_BYTES field as tvb_bytes_to_str_punct was used to create this effect "manually". Change-Id: I59e2acf9b00a4eb1279e6c2b2b7bd8ecef20db9b Reviewed-on: https://code.wireshark.org/review/6304 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Sort the value_string_exts at dissector registration time.Guy Harris1-18/+5
You *CANNOT* defer it until dissection time, otherwise "tshark -G values" will fail. Change-Id: I4edf9abda271baaf916f020a211b9add5543ecc7 Reviewed-on: https://code.wireshark.org/review/6481 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-10Squelch a compiler warning.Guy Harris1-4/+2
The clang I'm using warns about a non-constant format string in val_to_str_ext() calls; get rid of the unknown_format variable and, instead, make two different proto_item_append_text() calls with different format arguments in the val_to_str_ext()-call arguments. Change-Id: Id668efe666634798c278958bd7e6d790ec476539 Reviewed-on: https://code.wireshark.org/review/6479 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-10packet-mq: sort some value_string_ext in dissectorRobert Grange1-38/+54
Some value_string_ext are sorted only in the dissector, and only once. Adapted as said in comments. Added test for sort in dissect_mq_spx Change-Id: If72159fe96ab28a3ed540778d67996e152b4f110 Reviewed-on: https://code.wireshark.org/review/6444 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-10MQ: ensure that at least 4 bytes were captured before doing heuristic checksPascal Quantin1-1/+1
Otherwise it could trigger an exception Change-Id: I280e3c5d9e5554e4be49035c03e0170ae4495e6e Reviewed-on: https://code.wireshark.org/review/6463 Reviewed-by: Robert Grange <robionekenobi@bluewin.ch> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-10UTS: fix Copy-paste error (CID 11158603)Alexis La Goutte1-1/+1
Change-Id: Ibabb8ab3ccb0543856c84822542baa1ac0139f7e Reviewed-on: https://code.wireshark.org/review/6472 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10ISMACRYP: fix Copy-paste error (CID 11158602)Alexis La Goutte1-1/+1
Change-Id: I4978627115f46a8aa90ccf67f7c008cdf9986da6 Reviewed-on: https://code.wireshark.org/review/6471 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10CTDB: fix Copy-paste error (CID 11158596)Alexis La Goutte1-1/+1
Change-Id: Ieaa70505f4b880569be6126166a71f32d84f79a8 Reviewed-on: https://code.wireshark.org/review/6470 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10NLM: fix Copy-paste error (CID 11158588)Alexis La Goutte1-3/+1
Change-Id: I0d2736f3e00c62bb908e346a641d0ddc8b171fd2 Reviewed-on: https://code.wireshark.org/review/6469 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10to_str (epan): fix parameter 'scope' not found in the function declaration ↵Alexis La Goutte2-3/+3
[-Wdocumentation] Change-Id: Ie414d28415b71a79780d37fae454b90a7a610e1c Reviewed-on: https://code.wireshark.org/review/6475 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Bluetooth: A2DP: APT-X: Unhardcode stream configurationMichal Labedzki4-43/+130
Change-Id: I16cfb4d014020a7fb2c67fef3128021c9901719a Reviewed-on: https://code.wireshark.org/review/6442 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: HCI: Detect Vendor by "Read Local Version Information"Michal Labedzki5-13/+202
There is information about manufacturer of Bluetooth chip. Also try to detect if that "permament" info is not changed, if so informs user about this rare event (probably there is an issue) Change-Id: I1fa748a67ad7943e61d4445d240f0578b94560fc Reviewed-on: https://code.wireshark.org/review/6408 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: SMP: Add missing opcode for "Identity Address Information"Michal Labedzki4-12/+34
Also fix tvb_length, tvb_length_remaining warnings. Bug: 10299 Change-Id: Ib8b55ea9f2220394a5896d13e5cc4e2cefff1e13 Reviewed-on: https://code.wireshark.org/review/6407 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: Add HCI Vendor Broadcom dissectorMichal Labedzki7-58/+1490
Since those command/events are vendor specific and proprietary not all commands/events are implemented. All implemented commands can be found in Open Source implementations for Broadcom chip. If you found more, please let me know. Change-Id: Ie68d3737c88a8cef39260a9d93192cfc81871d6c Reviewed-on: https://code.wireshark.org/review/6406 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: ATT: Dissect opcode with more precisionMichal Labedzki1-5/+33
Change-Id: Iddc1a6d899b10b0d5c25723a71da7dcd11c6dfad Reviewed-on: https://code.wireshark.org/review/6405 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10USB: Fix Conversation/Endpoint filtersMichal Labedzki4-18/+52
There were not fields for that, so simple add them. Change-Id: I489bae24ac96ea0baf395add731f4d62ccf19352 Reviewed-on: https://code.wireshark.org/review/6401 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10IS-IS: Incorrect decoding of IPv4 Interface/Neighbor Address sub-TLVs in ↵Alexis La Goutte1-5/+5
Extended IS Reachability TLV Correct 4-byte IPv4 address is incorrectly detected as wrong 6-byte IPv4 address and cannot be decoded (IPv4 Interface Address (sub-TLV type 6) and IPv4 Neighbor Address (sub-TLV type 8) of Extended IS Reachability TLV (TLV type 22) of IS-IS. Wrong offset for some Sub-TLV Issue found by Alexander Okonnikov Bug: 10837 Change-Id: I81d083722da72115e1905237352650d380e9d0ac Reviewed-on: https://code.wireshark.org/review/6453 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Remove/replace ep_strsplit()Evan Huus5-95/+19
Change-Id: I4a803d83844d937804849b2ad3b067381c9b96d0 Reviewed-on: https://code.wireshark.org/review/6448 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-09Fix airpdcap debugging code.Gerald Combs1-6/+8
Change-Id: Ied1094dd3c6ad176fea830c0857ba43e09d3cb10 Reviewed-on: https://code.wireshark.org/review/6457 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-09Netflow: Fix some duplicate label namesMartin Mathieson1-9/+8
Change-Id: I077bdd6394898a445c00a1e7aec1c4c11b3e9ec2 Reviewed-on: https://code.wireshark.org/review/6450 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-09Some typos fixed.Dario Lombardo5-9/+9
Change-Id: I65df0c40d771c4854b73fd5c35d1af600f15f324 Reviewed-on: https://code.wireshark.org/review/6445 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-09Convert EUI64 address APIs to use wmem.Michael Mann10-72/+51
Change-Id: I57d2e435ac72ea07ec9a567e0b1ce4410966e3d2 Reviewed-on: https://code.wireshark.org/review/6419 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-09Bluetooth: AVDTP: Fix other-side ReconfigureMichal Labedzki1-39/+63
It is used to properly configure internal SEP data using to properly decode music stream. Change-Id: If8a15267ce072eaedfac947d7558be2d3e796483 Reviewed-on: https://code.wireshark.org/review/6404 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-09Bluetooth: AVDTP/VDP: Add link to first and last packet in the streamMichal Labedzki2-9/+121
Useful for analyzing stream issues. Change-Id: I1c9f43807dc3abc050cf17c971fbd270b812faa5 Reviewed-on: https://code.wireshark.org/review/6402 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-09Bluetooth: BTLE RF: Remove tree and reduce indentation levelMichal Labedzki1-74/+84
Useless check for tree avoid setting Bluetooth addresses. Change-Id: If38465679370c5ea74f6d916e409e337d60cf7db Reviewed-on: https://code.wireshark.org/review/6403 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-09Have ipxnet addresses use wmem scoped memory.Michael Mann6-14/+16
Change-Id: I1d8eed2ceacccce2768590f0689cd2c83a5e56e9 Reviewed-on: https://code.wireshark.org/review/6418 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-09disperse atalk-utils.[ch]Michael Mann11-122/+45
The functionality was suiting for address_to_str.c and the #defines belong in packet-atalk.h. Kept the address structure with the "address string conversion", but that can probably be better cleaned up when the address to str as a whole is cleaned up. Would also consider making AT_ATALK an FT_ type as well. Change-Id: Ia534096c707e6fb94acdfee0d332beda6571c371 Reviewed-on: https://code.wireshark.org/review/6417 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-09Some more random removal of ep_ memory.Michael Mann4-12/+11
Change-Id: I6eccd20280e907bd9e6a5fcf873ccf80afddecac Reviewed-on: https://code.wireshark.org/review/6416 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-09Remove proto_tree_add_ax25Michael Mann4-56/+11
There isn't a legitimate use for the API, all cases can be covered with proto_tree_add_item. As a bonus, a few more tvb_get_ptr calls can be removed. Change-Id: I3bb86ba8f05ef3363407bcfe9b059ee27ebc135d Reviewed-on: https://code.wireshark.org/review/6429 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-09convert variables that were static just because of SET_ADDRESS macro to use ↵Michael Mann8-49/+40
the proper pinfo->pool instead. Change-Id: I914918d9629f654ead497dddac0f412b690e4409 Reviewed-on: https://code.wireshark.org/review/6430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-08Use G_GINT64_CONSTANT() for 64-bit constants.Guy Harris1-59/+59
Change-Id: I2b4f24c0e68f8d1edb53981b2ada7db6cd0eff72 Reviewed-on: https://code.wireshark.org/review/6433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-08To register an SCTP port, register in "sctp.port", not "udp.port".Guy Harris1-4/+4
Change-Id: I8f013b2895e42919ea0d97cdc35414ea3f5aec9b Reviewed-on: https://code.wireshark.org/review/6422 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-08MQ: fix crash at startupPascal Quantin1-3/+3
the array given to qsort algorithm must be alterable Change-Id: I811cade161b7635e9bc9e070c1ec37d2cce50d1f Reviewed-on: https://code.wireshark.org/review/6420 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-08Netflow: add (hidden) root filters for each vendor with supported 'pie' entriesMartin Mathieson1-1/+69
Change-Id: I2bdca4c092c247ab253d6ceb3770ac7ea935cdad Reviewed-on: https://code.wireshark.org/review/6414 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-08Bluetooth: Update to latest Assigned Numbers (up to 4.2)Michal Labedzki7-45/+1109
Also start decoding next two profile attribute groups in SDP (MPS and CTN) and add new two fields in EIR/AD. Change-Id: I4dc13df2b3b13e8c2a2a5c4af2cabae9ee83d539 Reviewed-on: https://code.wireshark.org/review/6409 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-08mka: Minor cleanupBill Meier1-44/+33
Remove unneeded/unused code; Remove 'dead initializers'; tvb_captured_length() ==> tvb_reported_length(); Reformat a few long lines. Change-Id: I4a09bf330e939613ea8a47e69d4fc7b21dd496e8 Reviewed-on: https://code.wireshark.org/review/6413 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-08zbee-zcl-misc: Minor changesBill Meier1-49/+49
tvb_captured_length() --> tvb_reported_length(); whitespace changes. Change-Id: Id9c302d84f28ec23e554445777c7685c8d09918c Reviewed-on: https://code.wireshark.org/review/6412 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-08Bluetooth: AVDTP: Present bitfields for codec ad true/falseMichal Labedzki1-4/+4
Previously they are present as hex value. Change-Id: Ia30ba4da02e6bd4b0d68987506245e0534feadb6 Reviewed-on: https://code.wireshark.org/review/6400 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-08Eliminate proto_tree_add_text from some dissectors.Michael Mann12-247/+330
Change-Id: Ief4c377d56748e1a8ed0ef7fe5ba03b9be00cd8d Reviewed-on: https://code.wireshark.org/review/6267 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-08Add quotation marks in Conversations/Endpoints when address is stringMichal Labedzki1-0/+22
Change-Id: I39d49542cd563db1f6d3423b4e382a9a5e1c801b Reviewed-on: https://code.wireshark.org/review/6398 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-08BTSDP: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I48ddaa9ffe8f81094d63dd886dd15bb63888cbd7 Reviewed-on: https://code.wireshark.org/review/6396 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-08BATADV: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-6/+0
Change-Id: I3c33511389aa2f4b3eed73f1c712561b20e18bf7 Reviewed-on: https://code.wireshark.org/review/6395 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-08Small parenthesis fixDario Lombardo1-1/+1
Change-Id: I6bab238a37f7309daece7a7bfc062da41819d9ff Reviewed-on: https://code.wireshark.org/review/6394 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-08ieee80211: initialize bssid for data framesEvan Huus1-3/+7
Hypothentical fix for https://bugs.launchpad.net/ubuntu/+source/wireshark/+bug/1407662 which I haven't actually tried. Change-Id: Ib6d30873be7676eef756731a56a1d21a41c2c16c Reviewed-on: https://code.wireshark.org/review/6330 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-08packet-mq: Add New Def, Reformat Lines, re-order val_str defRobert Grange4-399/+628
Add missing definition, add new definition, Reformat some lines Re-order the value_string used with ext_value_string definition so they are in asc ASCII order as the ext_value_string is now sorted before first use renamed own tvb_get... funct to new tvb_get_guintxx funct and deleted own tvb_get... funct use ptvcursor_ funct instead of own macro to increment offset removed <epan/tvbuff.h> in *.c files correct [-Wunused-const-variable] Change-Id: Iaee26289e098cde0e5787ca1c98de64b6b733fa2 Reviewed-on: https://code.wireshark.org/review/6079 Reviewed-by: Robert Grange <robionekenobi@bluewin.ch> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-08use the http server port as index for the ws.port dissector tableMartin Kaiser1-5/+19
pinfo->match_uint is not set if websocket is called because of a previous http Upgrade: header and http is running on a non-standard port Bug: 10805 Change-Id: Ib0d35d29fe947cfb7b21107e734c64debbb91048 Reviewed-on: https://code.wireshark.org/review/6353 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 08:25:02 +0000